From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 19 22:31:04 2016 Received: (at submit) by debbugs.gnu.org; 20 Dec 2016 03:31:04 +0000 Received: from localhost ([127.0.0.1]:48176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJB8q-0005WT-By for submit@debbugs.gnu.org; Mon, 19 Dec 2016 22:31:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJB8o-0005Vy-Dp for submit@debbugs.gnu.org; Mon, 19 Dec 2016 22:31:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJB8i-0002qS-8C for submit@debbugs.gnu.org; Mon, 19 Dec 2016 22:30:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cJB8i-0002qO-4L for submit@debbugs.gnu.org; Mon, 19 Dec 2016 22:30:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59060) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJB8g-0005i6-R2 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2016 22:30:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJB8d-0002pN-MI for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2016 22:30:54 -0500 Received: from mail-ua0-x232.google.com ([2607:f8b0:400c:c08::232]:33078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJB8d-0002pE-Gz for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2016 22:30:51 -0500 Received: by mail-ua0-x232.google.com with SMTP id b56so5284268uaa.0 for ; Mon, 19 Dec 2016 19:30:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=XpxBpeq5gszixxq8n8T+mNc4pmDbAwGK7RtFpWXTX1g=; b=Q/YTidwnmEvlKv5/HjlKqXJ9/qGs9weBLDstjf/2uQOvODrXGfsYgHmYCHSdKen8/u VW9XnissQHvl0mOerRIpjuQRU+lWNsnCKHTkzgTGdRPIopWkasJQUNp89WU8s+8x7fHk 4fxBuztbZgWvRDIrpY3nbP60fspxROXZCoCzpZ1e3E0beWPNGjLiWrRf/82Tr5SLkgM5 K2XIZ+G6h/ip7pNI+ty3ZTUd6GsBN+HryXUKLguIRmbyXPQCgU042KOIWKXZoM57zk2+ a8IG9tKYwKwZfkCcmg9SWzEMeQfxNY1V3haDU55M5gyB9kHtwopMpoFI3X+xoHcoMNL+ WbFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=XpxBpeq5gszixxq8n8T+mNc4pmDbAwGK7RtFpWXTX1g=; b=WMRWWMMHWwg2O9EnXQiFKrgl9FlehqyG4wHDk3YCOVvNlwpHbWfg/0n3weYD17AtQz nGv6Q3Hlzdw6iGjVXWY880CITOLJivpYwE0V4p9cMK5HEYSkD0IQd6YwXtM9sDwBoVTm k/XePo0m5I3/coPsnmfk5UhVyOCXwWy/PcFocb4gPPKekYKtVu4VTzuZzZSmV1uDUC0n vJwN623jfqLrztI6VQh7JxK2aOZHS3dfFTrkiETurB4u6+TTIl1yFXc+fLWIRJk7QYcl psRBKEGKi1TWl/UA3EtIt+4HevUvnwHubSHaehMcVE8wQ0fn9a3anbGtiemOU7Hu0kYr BMlA== X-Gm-Message-State: AIkVDXLqclHaPsJIMFXfHf4PqNV/hWA+nZues0YEvDGiDTzfRnlVnncBWh3c0w/ZykcTAA== X-Received: by 10.176.74.18 with SMTP id q18mr9959902uae.119.1482204647998; Mon, 19 Dec 2016 19:30:47 -0800 (PST) Received: from caral ([201.240.146.85]) by smtp.gmail.com with ESMTPSA id 42sm5438608uah.2.2016.12.19.19.30.46 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Dec 2016 19:30:46 -0800 (PST) From: sunshavi@fastmail.fm To: bug-gnu-emacs@gnu.org Subject: 26.0.50; sql-postgres not working on master Date: Mon, 19 Dec 2016 22:30:25 -0500 Message-ID: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi. This is working on 25.1 but not on master compiled toda. I tried it with with 'emacs -Q' Regards In GNU Emacs 26.0.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars) of 2016-12-19 built on caral System Description: Arch Linux Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. process-lines: psql exited with status 2 Quit Configured using: 'configure '--program-transform-name=s/^ctags$/ctags.emacs/' --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=lucid --mandir=/usr/share/man --pdfdir=/usr/share/doc/emacs --with-sound --without-gconf --with-xft --without-xwidgets --with-gameuser=:games 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 LIBSYSTEMD Important settings: value of $LC_COLLATE: C value of $LANG: C locale-coding-system: nil Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils sql easymenu view thingatpt comint ansi-color ring cl-loaddefs pcase cl-lib term/xterm xterm time-date disp-table mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 107196 6967) (symbols 48 20913 1) (miscs 40 33 121) (strings 32 20197 3828) (string-bytes 1 673838) (vectors 16 12775) (vector-slots 8 412029 5278) (floats 8 187 568) (intervals 56 226 66) (buffers 976 11)) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 11:49:45 2016 Received: (at control) by debbugs.gnu.org; 21 Dec 2016 16:49:45 +0000 Received: from localhost ([127.0.0.1]:50430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJk5I-0007IG-PJ for submit@debbugs.gnu.org; Wed, 21 Dec 2016 11:49:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJk5H-0007I2-00 for control@debbugs.gnu.org; Wed, 21 Dec 2016 11:49:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJk5B-00018Z-5q for control@debbugs.gnu.org; Wed, 21 Dec 2016 11:49:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJk5B-00018V-39 for control@debbugs.gnu.org; Wed, 21 Dec 2016 11:49:37 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cJk5A-0004ef-JT for control@debbugs.gnu.org; Wed, 21 Dec 2016 11:49:36 -0500 Subject: control message for bug 24655 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 21 Dec 2016 11:49:36 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) block 24655 by 25236 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 30 13:18:04 2016 Received: (at 25236) by debbugs.gnu.org; 30 Dec 2016 18:18:04 +0000 Received: from localhost ([127.0.0.1]:60590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN1ki-0006in-H9 for submit@debbugs.gnu.org; Fri, 30 Dec 2016 13:18:04 -0500 Received: from mail-lf0-f52.google.com ([209.85.215.52]:34477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cN1kf-0006hs-VM for 25236@debbugs.gnu.org; Fri, 30 Dec 2016 13:18:02 -0500 Received: by mail-lf0-f52.google.com with SMTP id y21so240533732lfa.1 for <25236@debbugs.gnu.org>; Fri, 30 Dec 2016 10:18:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=bZiwUiw4lgL9Qac0zm4u/K6GG/zXpslKSyqc/cz0He8=; b=LV4/alIAxuHZKFjEHX93OO0QGw/9RqHaQGClPc5hJAH3PjXDt/9uxXx/YGOJ5ikHJj lEbFm7jbIHdywNHaVQRxtzptbI+exNHc2NNGHVp8Ov7zjfTIwik2/3sCTCRg7JGU+ZGY t7H+X2CdqeiqBFUAqfazpOpthvX6tLFxN1oLB//hlyYHmr75vmmsaKl76TREsi7tSmIL OgfNKElpPnEqiGu6h2UtB4XWPgPHOudkxhu2uklLKbJhpUUs30E4gUNXfCa0XcW0uz0u uZ+jidfkZl0OaRQrfKqVewp/EqW3sZFafAq475P+X7Dn+Ar90fEf5NW8VC+3tCWRF0qW KV6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=bZiwUiw4lgL9Qac0zm4u/K6GG/zXpslKSyqc/cz0He8=; b=Cr7fVjstnxdWVzJF0FUBe5HHWRmXADZ6rC55As4MzgO/T/kp9XMchumcTNny+quNOE WcbQiTxqHPBV1GEKzNDh6r7X7Qf6hdXU9nbmBtmdBocVuqPdHpsdw51eJEZHhX2Ji38c Oj5WyIkuXt8xKa5gsA6wQOt07qWL6DqqeDw9a/s/MXrTLOBv3vSeOAuLaCXNiWy7y1Y1 twEAgErl1OSuHCHPdQwAXFWKh/pM0t6p5WyIXj100cr2NYCcq1nJ4/oiQGLJGivJVT/d yFL2y00XnOSIyK4JwZc865+jOCJkFo+O56CCeqtvwnKYLJV40WYnLgA6rHMAVQ4isgMF T9EA== X-Gm-Message-State: AIkVDXKb/eoCJs91xeinwNeTGpLgP6wJjWcrnKnQuY0DfXT/MhTBwlKaM+MqhS+02h/XIg== X-Received: by 10.25.213.7 with SMTP id m7mr9515689lfg.36.1483121875913; Fri, 30 Dec 2016 10:17:55 -0800 (PST) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id f42sm13918505lji.2.2016.12.30.10.17.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 30 Dec 2016 10:17:55 -0800 (PST) Date: Fri, 30 Dec 2016 19:17:53 +0100 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master To: sunshavi@fastmail.fm, Michael Mauger Message-Id: <1483121873.22754.0@smtp.gmail.com> In-Reply-To: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> X-Mailer: geary/0.11.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25236 Cc: 25236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) This bug seems to be caused by a change I made in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24646, making `sql-postgres` able to complete the database name by looking at the result of `psql -ltX`. psql exits with status code 2 if the connection to the server went bad, for instance if permissions are missing [1]. I think we can fix this by being more lax in `sql-postgres-list-databases`, and just don't provide any completions should the command fail. Then we'd also need to change the value of the `REQUIRE-MATCH` parameter to `completing-read` on line 2966, since requiring a match when there are no completions would make it impossible to continue. What do you think, Michael? -- Simen [1] https://www.postgresql.org/docs/current/static/app-psql.html#AEN98634 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 03 22:20:13 2017 Received: (at 25236) by debbugs.gnu.org; 4 Jan 2017 03:20:13 +0000 Received: from localhost ([127.0.0.1]:40702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOc7Z-0002dA-0x for submit@debbugs.gnu.org; Tue, 03 Jan 2017 22:20:13 -0500 Received: from sonic324.consmr.mail.ne1.yahoo.com ([66.163.187.252]:34430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOc7W-0002cv-TS for 25236@debbugs.gnu.org; Tue, 03 Jan 2017 22:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1483500004; bh=1dFLHrFBb1UR9CWhCnkb7HAxf7wLv4so5muEVdTCODg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=YIKdA1GKzYVBsOgHI8o7X756c1+5MtCqOuIg8z8hnD7mZ6RLzdSIknNSwyshbjMUXDSJjdPZa6nGSpL7vgJidqTy/4iYzvswa/4rq1JzKHLNV8LNO1gZgP9S5XQjGQ/JLCaiUI9oQi/T3yISD7wXHnOGsNWsYKuuw6RfQrtjDfjcgaS87aZLlz81RAlQbPtmi3sMckOO9+nzirZaoctaue9BCu0lQ3Qk+6BLYlDzsAvjHPxbSo5xaTP3HBt1dIW42QNtXBGCsOnopK06jhk1svQaXOps8zbKzDiCSdo0pccLvksDJdpDj7M95MfVBPXbxFvTxaSXGimQRPnQTqJ3Yw== X-YMail-OSG: BFmJ4DIVM1kQfP4geVV36YLxWeYSmiXwwagZ9N1..hXprmgTwnnxC1GQaFxFsaP sAf3MFdKHOmxafk7QzsC8uHijsnFL.m0JU_4nNw210p8zH_5X_.yMNAmyuntKr3hGOcYz3GwK3xz ktD9KX2B2w5sZkSVSDZZeZh.kk0bfnLdE2Y29O8rKTRbZTVDmg783S8K5SAtPmdBDqxZvIagTv6a ahNJsqtXf_RVJ123qZrxEB7JoxLAM8R84eexO9kb9TSNbLXpPq8bB.gXBg7N1SsHiTTM9uh85DuZ vjDqEKx1FTuN7hV7CpEXL3jd5yGIecE3XWbRDnhpM7MWipkw_vMDkFFqgFEnPJDR8eE9Lk2_pmGR fVjkIsYYTO6qfsB857q7z_UZATPUk8PWeuTP8DABlq4U5Bf0vwFavvIY5U2CWq6OUwA1n30RypP7 iUe62_v4lZM9d51FKbw4gb_LBNwiLJHuZEOfu8O5SQwJ7xlds0hg68UPMlpojUZedlfGD4JwEySQ U4VHBddy6BAXLg2f.r7Y0r7ELwLEDZPL6WB1XAwcNd0UyL1WJjFYAE9QLanFVFbPvfzl5XTN4Fop dAjFND4Z.Exw- Received: from sonic.gate.mail.ne1.yahoo.com by sonic324.consmr.mail.ne1.yahoo.com with HTTP; Wed, 4 Jan 2017 03:20:04 +0000 Date: Wed, 4 Jan 2017 03:16:00 +0000 (UTC) From: Michael Mauger To: =?UTF-8?Q?Simen_Heggest=C3=B8yl?= , "sunshavi@fastmail.fm" Message-ID: <1397003198.5767161.1483499760212@mail.yahoo.com> In-Reply-To: <1483121873.22754.0@smtp.gmail.com> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Length: 1187 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25236 Cc: "25236@debbugs.gnu.org" <25236@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Michael Mauger Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Friday, December 30, 2016 1:17 PM, Simen Heggest=C3=B8yl wrote: > >This bug seems to be caused by a change I made in >https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24646, making >`sql-postgres` able to complete the database name by looking at the >result of `psql -ltX`. > >psql exits with status code 2 if the connection to the server went >bad, for instance if permissions are missing [1]. > >I think we can fix this by being more lax in >`sql-postgres-list-databases`, and just don't provide any completions >should the command fail. Then we'd also need to change the value of >the `REQUIRE-MATCH` parameter to `completing-read` on line 2966, since >requiring a match when there are no completions would make it >impossible to continue. > >What do you think, Michael? > >-- Simen > >[1]=20 >https://www.postgresql.org/docs/current/static/app-psql.html#AEN98634 > Just got back after the holiday. Makes sense that could be a problem. I'm g= etting ready to push a change related to completing-read so let me take a l= ook. Thanks for staying on top of this... --=20 MICHAEL MAUGER // FSF Member // GNU Emacs sql-mode maintainer // GNU Linux,= GNU Emacs From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 12:02:05 2017 Received: (at 25236) by debbugs.gnu.org; 18 Feb 2017 17:02:05 +0000 Received: from localhost ([127.0.0.1]:45225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf8Ob-0001Gh-4b for submit@debbugs.gnu.org; Sat, 18 Feb 2017 12:02:05 -0500 Received: from mail-lf0-f41.google.com ([209.85.215.41]:36659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cf8OZ-0001G6-Ca for 25236@debbugs.gnu.org; Sat, 18 Feb 2017 12:02:03 -0500 Received: by mail-lf0-f41.google.com with SMTP id z134so34124791lff.3 for <25236@debbugs.gnu.org>; Sat, 18 Feb 2017 09:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=xRkEXbpK1HVrCv5m9huZ0u/w7jQnqvpPp5LdQMoXfQI=; b=kH4Hg5ZknqqTqEA93V7WSgkk2hH/m9sH3QmZ8yL0foskmHrzTgkwMclx6egCrV9XKo Ah+DZ8KNslq6ggipalcptcq51YXUusHHfeizCkcpFNLXP8Q51vsvtYRCPko1k9STEEag umILTNzrkjnqyFDTfmJoBxsF9Cufq0dL6WaujOsZTzZnhtpFwbfEVqRJX4PkhUdbPASp cRK5DhHmTyCM7LgvL5dQQyunWSc8lD6tUI5vRXfsQOOSSB9z3JEmWusCtMobjdwlyX9x kTeAdbe9RdiLIxYCyBvVuBc9Biz+Wv2A+ADz+uaChytv1KHfOBSzkxKVt0E/WeREq0xw mgpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=xRkEXbpK1HVrCv5m9huZ0u/w7jQnqvpPp5LdQMoXfQI=; b=t4Bg0aVshupSHCbT8jgiV6qUaPiWAxUyPc+82nIShHbHb2BYdptNAc8GC9ua0GxkC1 C8YAoIELofQZ2WxT83s0XGNn7dP89IhUvhbKhf4I7yg664KLp8BanvbV9LIrvNISUhiP 3kIs2wToVu34/bqM90/Zvf3uH0a2cU4YQegKEfSmQtJKgqNbCw1P9HCEjAUnWcDlNThj xaRdFuRI7IAgH2WuuCRusjEUEyF/CbaVJpOiiiq7sbWtDH3W/fcOrqMHQANZ0oLs+Akx NZjhFLHrZVDLldS7xuE7/O0QZXcNxccsXjc2d7qyFC9O1YaSBq2roY5iHgsFdDak/AHU iScg== X-Gm-Message-State: AMke39lk3TTUJs+aIiL+Zvs9qSoDiMA3LpfPd6nhLE0HBX9ItUQ0ZXk2A9LZ1DL833qR/g== X-Received: by 10.25.199.14 with SMTP id x14mr3234905lff.13.1487437317421; Sat, 18 Feb 2017 09:01:57 -0800 (PST) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id e23sm3646818lji.29.2017.02.18.09.01.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 18 Feb 2017 09:01:56 -0800 (PST) Date: Sat, 18 Feb 2017 18:01:55 +0100 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master To: Michael Mauger Message-Id: <1487437315.31870.0@smtp.gmail.com> In-Reply-To: <1397003198.5767161.1483499760212@mail.yahoo.com> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> X-Mailer: geary/0.11.3 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-eP+PXK3nq7kqlavqWb3y" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25236 Cc: "25236@debbugs.gnu.org" <25236@debbugs.gnu.org>, "sunshavi@fastmail.fm" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-eP+PXK3nq7kqlavqWb3y Content-Type: text/plain; charset=utf-8; format=flowed On Wed, Jan 4, 2017 at 4:16 AM, Michael Mauger wrote: > Just got back after the holiday. Makes sense that could be a problem. > I'm getting ready to push a change related to completing-read so let > me take a look. > > Thanks for staying on top of this... I think the attached patch fixes half of the problem. Then we need to do something about the `completing-read' to make it possible to still select a database when `sql-postgres-list-databases' returns nil. -- Simen --=-eP+PXK3nq7kqlavqWb3y Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Handle-non-zero-exit-status-from-psql-more-gracefull.patch >From 100fc2038511a10edbda1fbf0c877bef33efbe4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Sat, 18 Feb 2017 17:50:16 +0100 Subject: [PATCH] Handle non-zero exit status from psql more gracefully * lisp/progmodes/sql.el (sql-postgres-list-databases): Handle non-zero exit statuses from `psql -ltX' more gracefully by returning nil. * test/lisp/progmodes/sql-tests.el (sql-tests-postgres-list-databases-error): New test. --- lisp/progmodes/sql.el | 7 ++++--- test/lisp/progmodes/sql-tests.el | 10 ++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index 8868343129..4a936a6b45 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -1087,9 +1087,10 @@ sql-postgres-list-databases "Return a list of available PostgreSQL databases." (when (executable-find sql-postgres-program) (let ((res '())) - (dolist (row (process-lines sql-postgres-program "-ltX")) - (when (string-match "^ \\([[:alnum:]-_]+\\) +|.*" row) - (push (match-string 1 row) res))) + (ignore-errors + (dolist (row (process-lines sql-postgres-program "-ltX")) + (when (string-match "^ \\([[:alnum:]-_]+\\) +|.*" row) + (push (match-string 1 row) res)))) (nreverse res)))) ;; Customization for Interbase diff --git a/test/lisp/progmodes/sql-tests.el b/test/lisp/progmodes/sql-tests.el index 27a72aa2c2..f75005f737 100644 --- a/test/lisp/progmodes/sql-tests.el +++ b/test/lisp/progmodes/sql-tests.el @@ -43,5 +43,15 @@ (should (equal (sql-postgres-list-databases) '("db-name-1" "db_name_2"))))) +(ert-deftest sql-tests-postgres-list-databases-error () + "Test that nil is returned when `psql -ltX' fails." + (cl-letf + (((symbol-function 'executable-find) + (lambda (_command) t)) + ((symbol-function 'process-lines) + (lambda (_program &rest _args) + (error)))) + (should-not (sql-postgres-list-databases)))) + (provide 'sql-tests) ;;; sql-tests.el ends here -- 2.11.0 --=-eP+PXK3nq7kqlavqWb3y-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 16:05:13 2017 Received: (at submit) by debbugs.gnu.org; 4 May 2017 20:05:13 +0000 Received: from localhost ([127.0.0.1]:54880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Mzx-0003yz-DG for submit@debbugs.gnu.org; Thu, 04 May 2017 16:05:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Msi-0003lh-Qx for submit@debbugs.gnu.org; Thu, 04 May 2017 15:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6Msc-0005vg-Tn for submit@debbugs.gnu.org; Thu, 04 May 2017 15:57:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=BAYES_50, FREEMAIL_FROM, URI_HEX autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34269) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d6Msc-0005vW-Qn for submit@debbugs.gnu.org; Thu, 04 May 2017 15:57:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6Msb-0002mu-J4 for Bug-gnu-emacs@gnu.org; Thu, 04 May 2017 15:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d6MsY-0005sO-F6 for Bug-gnu-emacs@gnu.org; Thu, 04 May 2017 15:57:37 -0400 Received: from mwork.nabble.com ([162.253.133.43]:53961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d6MsY-0005ro-8f for Bug-gnu-emacs@gnu.org; Thu, 04 May 2017 15:57:34 -0400 Received: from static.162.253.133.85.macminivault.com (unknown [162.253.133.85]) by mwork.nabble.com (Postfix) with ESMTP id BBEC73F038983 for ; Thu, 4 May 2017 12:57:32 -0700 (MST) Date: Thu, 4 May 2017 12:57:32 -0700 (MST) From: erreina To: Bug-gnu-emacs@gnu.org Message-ID: <1493927852761-426363.post@n8.nabble.com> In-Reply-To: <1487437315.31870.0@smtp.gmail.com> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1487437315.31870.0@smtp.gmail.com> Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Mac OS X [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 04 May 2017 16:05:12 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hi, any further progress on this? The database name completion is awesome...but the require match on the database name make it impossible to continue when working on a remote database server. Best, Ernesto -- View this message in context: http://emacs.1067599.n8.nabble.com/bug-25236-26-0-50-sql-postgres-not-working-on-master-tp416235p426363.html Sent from the Emacs - Bugs mailing list archive at Nabble.com. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 12:26:34 2017 Received: (at 25236) by debbugs.gnu.org; 29 Jul 2017 16:26:34 +0000 Received: from localhost ([127.0.0.1]:33275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbUZV-0004i2-Rw for submit@debbugs.gnu.org; Sat, 29 Jul 2017 12:26:34 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbUZT-0004ho-UF for 25236@debbugs.gnu.org; Sat, 29 Jul 2017 12:26:32 -0400 Received: by mail-lf0-f44.google.com with SMTP id g25so97015822lfh.1 for <25236@debbugs.gnu.org>; Sat, 29 Jul 2017 09:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=MR7S9eHRflnlWIEIcIJ6ZHyHIwGU3jB0z15ImnoJtRA=; b=WO8luTU8OuhHNEG4+uBcLLc0FdLmgoxg8W4KlMDyJkPK8S4rA+fVth0y4BQHc3SPqk o55xt9Jbd45nUsjTCR/QbYgvWUxw65lyj0VYnujgNJi17VBJbCZE83PbHjesquk4fi5x yjk8/khQaPvs8Ivm9jFKseVV681VF8t8MG0m6AkWT+rqWIENI7sAWhf08B01HhiMwWi/ 4J+MQVsWeLZ1Lz8Rb9Q8MYcZDSiWm2kt58gDN0huGQ2WItASzR2zWLfFoCwIUJJCofkN hSKYJ2L4Z0SKPnPFa3Ybessjl0P18fXHwMme44tkNQusNB+wJBRNjPNPfZmKZAbF5K+U BaNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=MR7S9eHRflnlWIEIcIJ6ZHyHIwGU3jB0z15ImnoJtRA=; b=t38HwqypaRC1ov5YZJsRR07oaZBBfI3m+JcDz3nBkLe1NNDX5TkPTGgIf2hIuFRfi3 yC65sGhTb6PahbfAlRJcqwR86ZkzHIdkOD6HWAhxe9VSwwR6FlZNYX1L3DTaFv03fqzP hYaKvayvrrw2C9P5KNJdn0AQEnhnb7rW5R1UgjrrLdO/Y3kM8ouq0Mv0s8vrMXuEP+9J 28HN1Vbo6EAlXakL9aRf0nARyWOUYQ0mFiGobbhel398fKjPHk8EOIfK9zj3yeMWRTXH RnX37lh/NNU37y2aqmLnck4STjYif7cZUJ1pdrWjahXPimLMTR1xTEAjG0f5H/vx7Yr8 l1gg== X-Gm-Message-State: AIVw110nD4K2migWBTTYNnGzv+0S6VhqGuvE85RnjrtK71p6cGGgMpG3 7ThpZx/dYaucKQ== X-Received: by 10.25.15.74 with SMTP id e71mr888801lfi.13.1501345586016; Sat, 29 Jul 2017 09:26:26 -0700 (PDT) Received: from [192.168.100.10] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id h22sm1170106ljb.41.2017.07.29.09.26.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Jul 2017 09:26:24 -0700 (PDT) Date: Sat, 29 Jul 2017 18:26:22 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master To: Michael Mauger Message-Id: <1501345582.29622.0@smtp.gmail.com> In-Reply-To: <1397003198.5767161.1483499760212@mail.yahoo.com> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> X-Mailer: geary/0.11.3 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-Bu0Z26b11s9E7j9epyRo" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25236 Cc: "25236@debbugs.gnu.org" <25236@debbugs.gnu.org>, "sunshavi@fastmail.fm" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-Bu0Z26b11s9E7j9epyRo Content-Type: text/plain; charset=utf-8; format=flowed On Wed, Jan 4, 2017 at 4:16 AM, Michael Mauger wrote: > I'm getting ready to push a change related to completing-read so let > me take a look. Hi Michael, any progress on this? Otherwise, does the attached patch look OK to install? I think it should fix the described problem. -- Simen --=-Bu0Z26b11s9E7j9epyRo Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Handle-non-zero-exit-status-from-psql-more-gracefull.patch >From 6a203bdf63bda37a28d5f4ae51386f552e337895 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Sat, 29 Jul 2017 18:20:43 +0200 Subject: [PATCH] Handle non-zero exit status from psql more gracefully * lisp/progmodes/sql.el (sql-postgres-list-databases): Handle non-zero exit statuses from `psql -ltX' more gracefully by returning nil. (sql-get-login-ext): Don't require a database name match. * test/lisp/progmodes/sql-tests.el (sql-tests-postgres-list-databases-error): New test. --- lisp/progmodes/sql.el | 9 +++++---- test/lisp/progmodes/sql-tests.el | 10 ++++++++++ 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index 68ca37207e..05370ba0aa 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -1090,9 +1090,10 @@ sql-postgres-list-databases "Return a list of available PostgreSQL databases." (when (executable-find sql-postgres-program) (let ((res '())) - (dolist (row (process-lines sql-postgres-program "-ltX")) - (when (string-match "^ \\([[:alnum:]-_]+\\) +|.*" row) - (push (match-string 1 row) res))) + (ignore-errors + (dolist (row (process-lines sql-postgres-program "-ltX")) + (when (string-match "^ \\([[:alnum:]-_]+\\) +|.*" row) + (push (match-string 1 row) res)))) (nreverse res)))) ;; Customization for Interbase @@ -2971,7 +2972,7 @@ sql-get-login-ext (expand-file-name file-name)))) ((plist-member plist :completion) - (completing-read prompt-def (plist-get plist :completion) nil t + (completing-read prompt-def (plist-get plist :completion) nil nil last-value history-var default)) ((plist-get plist :number) diff --git a/test/lisp/progmodes/sql-tests.el b/test/lisp/progmodes/sql-tests.el index 27a72aa2c2..f75005f737 100644 --- a/test/lisp/progmodes/sql-tests.el +++ b/test/lisp/progmodes/sql-tests.el @@ -43,5 +43,15 @@ (should (equal (sql-postgres-list-databases) '("db-name-1" "db_name_2"))))) +(ert-deftest sql-tests-postgres-list-databases-error () + "Test that nil is returned when `psql -ltX' fails." + (cl-letf + (((symbol-function 'executable-find) + (lambda (_command) t)) + ((symbol-function 'process-lines) + (lambda (_program &rest _args) + (error)))) + (should-not (sql-postgres-list-databases)))) + (provide 'sql-tests) ;;; sql-tests.el ends here -- 2.13.2 --=-Bu0Z26b11s9E7j9epyRo-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 14:49:31 2017 Received: (at 25236) by debbugs.gnu.org; 29 Jul 2017 18:49:31 +0000 Received: from localhost ([127.0.0.1]:33346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbWnq-000884-Va for submit@debbugs.gnu.org; Sat, 29 Jul 2017 14:49:31 -0400 Received: from mail-ua0-f194.google.com ([209.85.217.194]:34340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbVLW-0005sn-CJ for 25236@debbugs.gnu.org; Sat, 29 Jul 2017 13:16:10 -0400 Received: by mail-ua0-f194.google.com with SMTP id k43so17401734uaf.1 for <25236@debbugs.gnu.org>; Sat, 29 Jul 2017 10:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:organization:references:date :message-id:mime-version; bh=nbshVr7wZNTi+Mp8hfxh7EVXcTyIhDXv2IQ36qY7gbg=; b=HVjkyprmwZpsdnb/Zvar3Js9Yq88kllxqfPWAeG9AUL4bMQO9w0lB+gUXrHDUVM80V iHFLiMbt1KMR8grafA2ML74L+SawC4W00i20JrKcMmp73euRZo1sFMZHQvoKIdwegK+I DU5rDCR+f6SniD64IL4Gioqcy2NJFVh8N6amzxwo2CB3vBNG2GfmRvrwrR3y/+DUwxKC Etr/hgwMYor7ZZJkE+DcbMib7632Q+khYJVZ6qN0ORLgg94ACjN+Rt6j8p0/cS+YpubN pOys9TqGHUKb0YoyUWJU0LM7Pf3imXHQO4Nk9ligZrM6pfF9IoxlcSx3y0WWfrGIiyhI 6Z1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:organization :references:date:message-id:mime-version; bh=nbshVr7wZNTi+Mp8hfxh7EVXcTyIhDXv2IQ36qY7gbg=; b=fgYcgIY031374zoXheKGTgsVH9ke9jB4l1zFjQ8AF9rXY4Jy1Q+wLihWaTtAK/osOm qyN6WtdUGjWaWc8O47qjuT6ZywnUDNwlzeSAJC0iXHM2mGpKmhFo3rm39331VjUzaYI9 pJ271eE3QK903QHfJtn9MsOeleXz4CH5bFGCdNdbooWcy8TMss06/paLJWA8Z+dZUWDF lZN3Zub/qQ5xsZRqEHGW2RuMaOnMHcDivpCXzeU2NpjGQB7Jqv8t/o4c2p+gWFE0s9Al /1VCOlPkiz1NMvaHM1LQOfl1nnOI3h454S9i5DPC3fvlbTVt2ltXx+5Mz+ZruR2w1q47 ZToQ== X-Gm-Message-State: AIVw112UAVTKD2BTo8daBYvLR+PxAEqj4Q8elglkHeihxIL+opf2DNK4 t+aijfKPagJoq055 X-Received: by 10.176.82.110 with SMTP id j43mr6621637uaa.112.1501348564537; Sat, 29 Jul 2017 10:16:04 -0700 (PDT) Received: from chulpaca.n800.arm.processor.fastmail.fm ([190.234.106.33]) by smtp.gmail.com with ESMTPSA id 33sm5586084uaf.20.2017.07.29.10.16.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Jul 2017 10:16:03 -0700 (PDT) From: =?utf-8?Q?andr=C3=A9s_ram=C3=ADrez?= To: Simen =?utf-8?Q?Heggest=C3=B8yl?= Subject: new mail address (was: bug#25236: 26.0.50; sql-postgres not working on master) In-Reply-To: <1501345582.29622.0@smtp.gmail.com> Organization: bien.comun.org References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1501345582.29622.0@smtp.gmail.com> X-Attribution: INKA Date: Sat, 29 Jul 2017 11:15:51 -0600 Message-ID: <871sozqi48.fsf@chulpaca> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 4.0 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Simen, Michael. My fastmail account is going to be closed on 2 days. On the future send me a copy to this mail address (gmail). AR [...] Content analysis details: (4.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [190.234.106.33 listed in zen.spamhaus.org] 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.217.194 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.217.194 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rrandresf[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.217.194 listed in wl.mailspike.net] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 25236 X-Mailman-Approved-At: Sat, 29 Jul 2017 14:49:28 -0400 Cc: Michael Mauger , "25236@debbugs.gnu.org" <25236@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 4.0 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Simen, Michael. My fastmail account is going to be closed on 2 days. On the future send me a copy to this mail address (gmail). AR [...] Content analysis details: (4.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [209.85.217.194 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.217.194 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [190.234.106.33 listed in zen.spamhaus.org] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.217.194 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rrandresf[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Hi Simen, Michael. My fastmail account is going to be closed on 2 days. On the future send me a copy to this mail address (gmail). AR From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 06 21:12:57 2017 Received: (at 25236) by debbugs.gnu.org; 7 Aug 2017 01:12:57 +0000 Received: from localhost ([127.0.0.1]:45094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deWbI-0007fE-Sg for submit@debbugs.gnu.org; Sun, 06 Aug 2017 21:12:57 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:21383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deWQg-0007Qh-Ga for 25236@debbugs.gnu.org; Sun, 06 Aug 2017 21:01:59 -0400 Date: Sun, 06 Aug 2017 21:01:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1502067715; bh=ctsa3Gm0DfNQ2YyN+WNzrX7BLaMwzxwTq+A2HNiu00g=; h=To:From:Cc:Reply-To:Subject:In-Reply-To:References:Feedback-ID: From; b=lve0eGfE8TGaSni1RTYWcbR/K8OLtXDVLzwPW6aRKj1/RE/TOw4duVhxoN9tcSuqD 6m8fdbMGwMyFYscC+CTGg/S0djlktGGVgRdS0XNNBsUxdktakjPqBnhj+OoFUgTfnm EHRhQ4k6onL1HVQkzpi9ya4Dmh/iwzY2wxc7yltA= To: =?UTF-8?Q?Simen_Heggest=C3=B8yl?= From: Michael Mauger Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master Message-ID: In-Reply-To: <1501345582.29622.0@smtp.gmail.com> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1501345582.29622.0@smtp.gmail.com> Feedback-ID: b6CpL0MxcIA6fpHRkn3ZHzWS0Hoqxbtv_SrHfEzC9D85cLvnRsVk4rKaAOJUw48iy20W0W1VX4whjBYFluIX0w==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_f1f2c6b7f9332b641e2c716b1c822a33" X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE, MISSING_DATE autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25236 X-Mailman-Approved-At: Sun, 06 Aug 2017 21:12:55 -0400 Cc: Michael Mauger , "25236@debbugs.gnu.org" <25236@debbugs.gnu.org>, "sunshavi@fastmail.fm" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Michael Mauger Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --b1_f1f2c6b7f9332b641e2c716b1c822a33 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 U29ycnkgZm9yIHRoZSBkZWxheTsgQUREIGtlZXBzIGluIGEgcGVycGV0dWFsIHN0YXRlIG9mOiAi d2hhdCB3YXMgaXQgdGhhdCBJIHdhcyBkb2luZy4uLj8iCkkgaGFkIG1hZGUgdGhlIGNoYW5nZXMg bG9jYWxseSBhIHdoaWxlIGFnbywgYnV0IGhlZG4ndCBwdXNoZWQgdGhlbSB0byB0aGUgcmVwb3Jz aXR5LiBUaGV5IGFyZSB0aGVyZSBub3cuIExldCBtZSBrbm93IGlmIHlvdSBoYXZlIGFueSBpc3N1 ZXMuCkFnYWluLCBzb3JyeSBmb3IgdGhlIGRlbGF5LgoKLS0KTUlDSEFFTCBNQVVHRVIgLy8gRlNG IGFuZCBFRkYgbWVtYmVyIC8vIEdOVSBFbWFjcyBzcWwuZWwgbWFpbnRhaW5lcgoKPiAtLS0tLS0t LSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tLS0tCj4gU3ViamVjdDogUmU6IGJ1ZyMyNTIzNjogMjYu MC41MDsgc3FsLXBvc3RncmVzIG5vdCB3b3JraW5nIG9uIG1hc3Rlcgo+IExvY2FsIFRpbWU6IEp1 bHkgMjksIDIwMTcgMTI6MjYgUE0KPiBVVEMgVGltZTogSnVseSAyOSwgMjAxNyA0OjI2IFBNCj4g RnJvbTogc2ltZW5oZWdAZ21haWwuY29tCj4gVG86IE1pY2hhZWwgTWF1Z2VyIDxtaWNoYWVsQG1h dWdlci5jb20+Cj4gc3Vuc2hhdmlAZmFzdG1haWwuZm0gPHN1bnNoYXZpQGZhc3RtYWlsLmZtPiwg MjUyMzZAZGViYnVncy5nbnUub3JnIDwyNTIzNkBkZWJidWdzLmdudS5vcmc+Cj4gT24gV2VkLCBK YW4gNCwgMjAxNyBhdCA0OjE2IEFNLCBNaWNoYWVsIE1hdWdlciA8bWljaGFlbEBtYXVnZXIuY29t Pgo+IHdyb3RlOgo+PiBJIm0gZ2V0dGluZyByZWFkeSB0byBwdXNoIGEgY2hhbmdlIHJlbGF0ZWQg dG8gY29tcGxldGluZy1yZWFkIHNvIGxldAo+PiBtZSB0YWtlIGEgbG9vay4KPiBIaSBNaWNoYWVs LCBhbnkgcHJvZ3Jlc3Mgb24gdGhpcz8gT3RoZXJ3aXNlLCBkb2VzIHRoZSBhdHRhY2hlZCBwYXRj aAo+IGxvb2sgT0sgdG8gaW5zdGFsbD8gSSB0aGluayBpdCBzaG91bGQgZml4IHRoZSBkZXNjcmli ZWQgcHJvYmxlbS4KPiAtLSBTaW1lbg== --b1_f1f2c6b7f9332b641e2c716b1c822a33 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdj5Tb3JyeSBmb3IgdGhlIGRlbGF5OyBBREQga2VlcHMgaW4gYSBwZXJwZXR1YWwgc3RhdGUg b2Y6ICJ3aGF0IHdhcyBpdCB0aGF0IEkgd2FzIGRvaW5nLi4uPyI8YnI+PC9kaXY+PGRpdj48YnI+ PC9kaXY+PGRpdj5JIGhhZCBtYWRlIHRoZSBjaGFuZ2VzIGxvY2FsbHkgYSB3aGlsZSBhZ28sIGJ1 dCBoZWRuJ3QgcHVzaGVkIHRoZW0gdG8gdGhlIHJlcG9yc2l0eS4gVGhleSBhcmUgdGhlcmUgbm93 LiBMZXQgbWUga25vdyBpZiB5b3UgaGF2ZSBhbnkgaXNzdWVzLjxicj48L2Rpdj48ZGl2Pjxicj48 L2Rpdj48ZGl2PkFnYWluLCBzb3JyeSBmb3IgdGhlIGRlbGF5Ljxicj48L2Rpdj48ZGl2IGNsYXNz PSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jayAiPjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2ln bmF0dXJlX2Jsb2NrLXVzZXIgIj48ZGl2Pi0tIDxicj48L2Rpdj48ZGl2Pk1JQ0hBRUwgTUFVR0VS IC8vIEZTRiBhbmQgRUZGIG1lbWJlciAvLyBHTlUgRW1hY3Mgc3FsLmVsIG1haW50YWluZXI8YnI+ PC9kaXY+PGRpdj48YnI+PC9kaXY+PC9kaXY+PGRpdiBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1 cmVfYmxvY2stcHJvdG9uIHByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLWVtcHR5Ij48YnI+PC9k aXY+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGJsb2NrcXVvdGUgY2xhc3M9InByb3Rvbm1haWxfcXVv dGUiIHR5cGU9ImNpdGUiPjxkaXY+LS0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tLTxi cj48L2Rpdj48ZGl2PlN1YmplY3Q6IFJlOiBidWcjMjUyMzY6IDI2LjAuNTA7IHNxbC1wb3N0Z3Jl cyBub3Qgd29ya2luZyBvbiBtYXN0ZXI8YnI+PC9kaXY+PGRpdj5Mb2NhbCBUaW1lOiBKdWx5IDI5 LCAyMDE3IDEyOjI2IFBNPGJyPjwvZGl2PjxkaXY+VVRDIFRpbWU6IEp1bHkgMjksIDIwMTcgNDoy NiBQTTxicj48L2Rpdj48ZGl2PkZyb206IHNpbWVuaGVnQGdtYWlsLmNvbTxicj48L2Rpdj48ZGl2 PlRvOiBNaWNoYWVsIE1hdWdlciAmbHQ7bWljaGFlbEBtYXVnZXIuY29tJmd0Ozxicj48L2Rpdj48 ZGl2PnN1bnNoYXZpQGZhc3RtYWlsLmZtICZsdDtzdW5zaGF2aUBmYXN0bWFpbC5mbSZndDssIDI1 MjM2QGRlYmJ1Z3MuZ251Lm9yZyAmbHQ7MjUyMzZAZGViYnVncy5nbnUub3JnJmd0Ozxicj48L2Rp dj48ZGl2Pjxicj48L2Rpdj48ZGl2Pk9uIFdlZCwgSmFuIDQsIDIwMTcgYXQgNDoxNiBBTSwgTWlj aGFlbCBNYXVnZXIgJmx0O21pY2hhZWxAbWF1Z2VyLmNvbSZndDsgPGJyPjwvZGl2PjxkaXY+d3Jv dGU6PGJyPjwvZGl2PjxkaXY+Jmd0OyBJIm0gZ2V0dGluZyByZWFkeSB0byBwdXNoIGEgY2hhbmdl IHJlbGF0ZWQgdG8gY29tcGxldGluZy1yZWFkIHNvIGxldCA8YnI+PC9kaXY+PGRpdj4mZ3Q7IG1l IHRha2UgYSBsb29rLjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PkhpIE1pY2hhZWwsIGFu eSBwcm9ncmVzcyBvbiB0aGlzPyBPdGhlcndpc2UsIGRvZXMgdGhlIGF0dGFjaGVkIHBhdGNoPGJy PjwvZGl2PjxkaXY+bG9vayBPSyB0byBpbnN0YWxsPyBJIHRoaW5rIGl0IHNob3VsZCBmaXggdGhl IGRlc2NyaWJlZCBwcm9ibGVtLjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2Pi0tIFNpbWVu PGJyPjwvZGl2PjwvYmxvY2txdW90ZT48ZGl2Pjxicj48L2Rpdj4= --b1_f1f2c6b7f9332b641e2c716b1c822a33-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 10 17:26:24 2017 Received: (at 25236) by debbugs.gnu.org; 10 Aug 2017 21:26:24 +0000 Received: from localhost ([127.0.0.1]:54803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfuyG-0004ND-BY for submit@debbugs.gnu.org; Thu, 10 Aug 2017 17:26:24 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:37067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfuyE-0004N0-2m for 25236@debbugs.gnu.org; Thu, 10 Aug 2017 17:26:22 -0400 Received: by mail-qk0-f177.google.com with SMTP id z18so11441660qka.4 for <25236@debbugs.gnu.org>; Thu, 10 Aug 2017 14:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=r9K1eWKd3os2rbxee3nQo62MM8Www86aL/sIDyOCFjs=; b=CB+UmcH7BhpmN7FR4oOMh5Gwdy623Fzze1EB0tmD5k/NtScKNK9NYPTQWPHekTXGaD hdcDUDtDl4nhdINGcKgs7NVsc5IxiDBi/fqgrH1U59fbYiF+13i0XmtnvtLDQZNYHYiT vEOHUtmfZydgLsF7B0wyiMq4tZBijyhb1grIDeBZ2hU3JIKR5MpW+tTbr/+5ftPursix JWl7fKSFWIsBHEyc2D/XGBViKYKbKfigCTdn80bl8fyS4MOlRNzZPdc+/P3+pW3p+i0Y sEzDyOl2OrKXzlNsSPd1Sgcskz5sC92zLFZg7AmggXfNnaBlFwAPLEqmvLcZUBWvXmJo Q51w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=r9K1eWKd3os2rbxee3nQo62MM8Www86aL/sIDyOCFjs=; b=nS36OeBrvIScDv1HwrPQrtKJp1/Ydv1YPAgLEN+9Kp3KwFz5ccE2UJXkbLKGnXI6iT rXJo0MUad+HgwABhLTTzekGNm0enoh/xNwZeb3r14UOP8YhgUhfmlb4H3jUg0LK/nbVC Si7R/QP9UsDsLhy7S81hHRWPJwLWLM8yfRLCRMv4GoZPSeAq9m1AfPUEYenMLqyOWrXV pPddsHqbZ2lU7Y4yQNVZaCguDzeArAurGlny6vvnta2oDkQnYRYe9cnjlgNPgpT+DTcF 0G6lCy8hkoVi2UxuZ9Kj+5nj0riEurSx/xuW/JYpcLK4sR5pwr9DQQjPZVhd9/qeNR+7 HeMg== X-Gm-Message-State: AHYfb5hZpTMzxv7GSs2WjepredoFxORF7+6dMKM2q8lNNLPt5GFYp5Br ufKo4IWonliuAA== X-Received: by 10.55.212.129 with SMTP id s1mr5636272qks.41.1502400376374; Thu, 10 Aug 2017 14:26:16 -0700 (PDT) Received: from [192.168.2.165] (216-164-224-125.c3-0.tlg-cbr3.atw-tlg.pa.cable.rcn.com. [216.164.224.125]) by smtp.gmail.com with ESMTPSA id 22sm4526228qto.36.2017.08.10.14.26.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Aug 2017 14:26:15 -0700 (PDT) Date: Thu, 10 Aug 2017 23:26:13 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master To: Michael Mauger Message-Id: <1502400373.1756.3@smtp.gmail.com> In-Reply-To: References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1501345582.29622.0@smtp.gmail.com> X-Mailer: geary/0.11.3 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-lsA/bBhhXnkXMmmbNvis" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25236 Cc: Michael Mauger , =?iso-8859-1?q?andr=E9s_ram=EDrez?= , "25236@debbugs.gnu.org" <25236@debbugs.gnu.org>, "sunshavi@fastmail.fm" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-lsA/bBhhXnkXMmmbNvis Content-Type: text/plain; charset=utf-8; format=flowed Thanks Michael. There's still a problem when psql exists with a non-zero exit status. I think the attached patch is needed in addition. -- Simen --=-lsA/bBhhXnkXMmmbNvis Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Handle-non-zero-exit-status-from-psql-more-gracefull.patch >From a12099e443e9ab1a26715daafca6abb6c99f29ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Wed, 9 Aug 2017 15:34:34 +0200 Subject: [PATCH] Handle non-zero exit status from psql more gracefully * lisp/progmodes/sql.el (sql-postgres-list-databases): Handle non-zero exit statuses from `psql -ltX' more gracefully by returning nil. * test/lisp/progmodes/sql-tests.el (sql-tests-postgres-list-databases-error): New test. --- lisp/progmodes/sql.el | 7 ++++--- test/lisp/progmodes/sql-tests.el | 10 ++++++++++ 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el index b176e52950..48e21605a3 100644 --- a/lisp/progmodes/sql.el +++ b/lisp/progmodes/sql.el @@ -1095,9 +1095,10 @@ sql-postgres-list-databases "Return a list of available PostgreSQL databases." (when (executable-find sql-postgres-program) (let ((res '())) - (dolist (row (process-lines sql-postgres-program "-ltX")) - (when (string-match "^ \\([[:alnum:]-_]+\\) +|.*" row) - (push (match-string 1 row) res))) + (ignore-errors + (dolist (row (process-lines sql-postgres-program "-ltX")) + (when (string-match "^ \\([[:alnum:]-_]+\\) +|.*" row) + (push (match-string 1 row) res)))) (nreverse res)))) ;; Customization for Interbase diff --git a/test/lisp/progmodes/sql-tests.el b/test/lisp/progmodes/sql-tests.el index 27a72aa2c2..f75005f737 100644 --- a/test/lisp/progmodes/sql-tests.el +++ b/test/lisp/progmodes/sql-tests.el @@ -43,5 +43,15 @@ (should (equal (sql-postgres-list-databases) '("db-name-1" "db_name_2"))))) +(ert-deftest sql-tests-postgres-list-databases-error () + "Test that nil is returned when `psql -ltX' fails." + (cl-letf + (((symbol-function 'executable-find) + (lambda (_command) t)) + ((symbol-function 'process-lines) + (lambda (_program &rest _args) + (error)))) + (should-not (sql-postgres-list-databases)))) + (provide 'sql-tests) ;;; sql-tests.el ends here -- 2.13.2 --=-lsA/bBhhXnkXMmmbNvis-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 02 09:10:02 2017 Received: (at 25236) by debbugs.gnu.org; 2 Sep 2017 13:10:03 +0000 Received: from localhost ([127.0.0.1]:41841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do8BV-0002OV-2w for submit@debbugs.gnu.org; Sat, 02 Sep 2017 09:10:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1do8BS-0002Nz-R0 for 25236@debbugs.gnu.org; Sat, 02 Sep 2017 09:10:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1do8BI-0005Qo-U1 for 25236@debbugs.gnu.org; Sat, 02 Sep 2017 09:09:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1do8BC-0005Mb-Q3; Sat, 02 Sep 2017 09:09:42 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1do8BB-0004MT-8Y; Sat, 02 Sep 2017 09:09:42 -0400 Date: Sat, 02 Sep 2017 16:09:27 +0300 Message-Id: <83inh1z1q0.fsf@gnu.org> From: Eli Zaretskii To: Simen =?utf-8?Q?Heggest=C3=B8yl?= In-reply-to: <1502400373.1756.3@smtp.gmail.com> (message from Simen =?utf-8?Q?Heggest=C3=B8yl?= on Thu, 10 Aug 2017 23:26:13 +0200) Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1501345582.29622.0@smtp.gmail.com> <1502400373.1756.3@smtp.gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25236 Cc: michael@mauger.com, sunshavi@fastmail.fm, rrandresf@gmail.com, mmauger@protonmail.com, 25236@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Thu, 10 Aug 2017 23:26:13 +0200 > From: Simen Heggestøyl > Cc: Michael Mauger , > andrés ramírez , > "25236@debbugs.gnu.org" <25236@debbugs.gnu.org>, > "sunshavi@fastmail.fm" > > Thanks Michael. There's still a problem when psql exists with a > non-zero exit status. I think the attached patch is needed in > addition. Michael, any reasons not to push this patch? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 04 20:18:48 2017 Received: (at 25236) by debbugs.gnu.org; 5 Sep 2017 00:18:48 +0000 Received: from localhost ([127.0.0.1]:49657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dp1Zn-0001BS-SH for submit@debbugs.gnu.org; Mon, 04 Sep 2017 20:18:48 -0400 Received: from mail2.protonmail.ch ([185.70.40.22]:31038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dp1Zl-0001BH-4X for 25236@debbugs.gnu.org; Mon, 04 Sep 2017 20:18:46 -0400 Date: Mon, 04 Sep 2017 20:18:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=default; t=1504570719; bh=hqEi4s5mBLYnpdxTT78kTnBQkvC9vyX1SiDYmku/iv4=; h=To:From:Cc:Reply-To:Subject:In-Reply-To:References:Feedback-ID: From; b=wudLBqEloYEcQW+vSBSpf+nZGncWfMineORZPkIU2p7c3uR2m1Aj8HHq223v6N5gR /nLo+0d5tSOORewhRdGNUJjyGWXV58u8X6Xu5ryVKBXbhllH+CVXDEOE7Jbzw/yLw6 qdeKC3595AidBY+w3UQbvhLDDyc0dNUmNZjCojRk= To: Eli Zaretskii From: Michael Mauger Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master Message-ID: In-Reply-To: <83inh1z1q0.fsf@gnu.org> References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1501345582.29622.0@smtp.gmail.com> <1502400373.1756.3@smtp.gmail.com> <83inh1z1q0.fsf@gnu.org> Feedback-ID: b6CpL0MxcIA6fpHRkn3ZHzWS0Hoqxbtv_SrHfEzC9D85cLvnRsVk4rKaAOJUw48iy20W0W1VX4whjBYFluIX0w==:Ext:ProtonMail MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_be985217f2a769124347bfc8ca1f7644" X-Spam-Status: No, score=0.3 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, HTML_MESSAGE, MISSING_DATE autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail.protonmail.ch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25236 Cc: "michael@mauger.com" , "rrandresf@gmail.com" , "sunshavi@fastmail.fm" , =?UTF-8?Q?Simen_Heggest=C3=B8yl?= , "25236@debbugs.gnu.org" <25236@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Michael Mauger Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --b1_be985217f2a769124347bfc8ca1f7644 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 Tm8uIEdvIGFoZWFkIGFuZCBwdXNoIGl0LgoKLS0KTUlDSEFFTEBNQVVHRVIuQ09NIC8vIEZTRiBh bmQgRUZGIG1lbWJlciAvLyBHTlUgRW1hY3Mgc3FsLmVsIG1haW50YWluZXIKCj4gLS0tLS0tLS0g T3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tLQo+IFN1YmplY3Q6IFJlOiBidWcjMjUyMzY6IDI2LjAu NTA7IHNxbC1wb3N0Z3JlcyBub3Qgd29ya2luZyBvbiBtYXN0ZXIKPiBMb2NhbCBUaW1lOiBTZXB0 ZW1iZXIgMiwgMjAxNyA5OjA5IEFNCj4gVVRDIFRpbWU6IFNlcHRlbWJlciAyLCAyMDE3IDE6MDkg UE0KPiBGcm9tOiBlbGl6QGdudS5vcmcKPiBUbzogU2ltZW4gSGVnZ2VzdMO4eWwgPHNpbWVuaGVn QGdtYWlsLmNvbT4KPiBtbWF1Z2VyQHByb3Rvbm1haWwuY29tLCBtaWNoYWVsQG1hdWdlci5jb20s IHJyYW5kcmVzZkBnbWFpbC5jb20sIDI1MjM2QGRlYmJ1Z3MuZ251Lm9yZywgc3Vuc2hhdmlAZmFz dG1haWwuZm0KPgo+PiBEYXRlOiBUaHUsIDEwIEF1ZyAyMDE3IDIzOjI2OjEzICswMjAwCj4+IEZy b206IFNpbWVuIEhlZ2dlc3TDuHlsIDxzaW1lbmhlZ0BnbWFpbC5jb20+Cj4+IENjOiBNaWNoYWVs IE1hdWdlciA8bWljaGFlbEBtYXVnZXIuY29tPiwKPj4gYW5kcsOpcyByYW3DrXJleiA8cnJhbmRy ZXNmQGdtYWlsLmNvbT4sCj4+ICIyNTIzNkBkZWJidWdzLmdudS5vcmciIDwyNTIzNkBkZWJidWdz LmdudS5vcmc+LAo+PiAic3Vuc2hhdmlAZmFzdG1haWwuZm0iIDxzdW5zaGF2aUBmYXN0bWFpbC5m bT4KPj4KPj4gVGhhbmtzIE1pY2hhZWwuIFRoZXJlInMgc3RpbGwgYSBwcm9ibGVtIHdoZW4gcHNx bCBleGlzdHMgd2l0aCBhCj4+IG5vbi16ZXJvIGV4aXQgc3RhdHVzLiBJIHRoaW5rIHRoZSBhdHRh Y2hlZCBwYXRjaCBpcyBuZWVkZWQgaW4KPj4gYWRkaXRpb24uCj4KPiBNaWNoYWVsLCBhbnkgcmVh c29ucyBub3QgdG8gcHVzaCB0aGlzIHBhdGNoPw== --b1_be985217f2a769124347bfc8ca1f7644 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: base64 PGRpdj5Oby4gR28gYWhlYWQgYW5kIHB1c2ggaXQuPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2Pjxk aXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrICI+PGRpdiBjbGFzcz0icHJvdG9u bWFpbF9zaWduYXR1cmVfYmxvY2stdXNlciAiPjxkaXY+LS0gPGJyPjwvZGl2PjxkaXY+TUlDSEFF TEBNQVVHRVIuQ09NIC8vIEZTRiBhbmQgRUZGIG1lbWJlciAvLyBHTlUgRW1hY3Mgc3FsLmVsIG1h aW50YWluZXI8YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PC9kaXY+PGRpdiBjbGFzcz0icHJvdG9u bWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIHByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLWVt cHR5Ij48YnI+PC9kaXY+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGJsb2NrcXVvdGUgY2xhc3M9InBy b3Rvbm1haWxfcXVvdGUiIHR5cGU9ImNpdGUiPjxkaXY+LS0tLS0tLS0gT3JpZ2luYWwgTWVzc2Fn ZSAtLS0tLS0tLTxicj48L2Rpdj48ZGl2PlN1YmplY3Q6IFJlOiBidWcjMjUyMzY6IDI2LjAuNTA7 IHNxbC1wb3N0Z3JlcyBub3Qgd29ya2luZyBvbiBtYXN0ZXI8YnI+PC9kaXY+PGRpdj5Mb2NhbCBU aW1lOiBTZXB0ZW1iZXIgMiwgMjAxNyA5OjA5IEFNPGJyPjwvZGl2PjxkaXY+VVRDIFRpbWU6IFNl cHRlbWJlciAyLCAyMDE3IDE6MDkgUE08YnI+PC9kaXY+PGRpdj5Gcm9tOiBlbGl6QGdudS5vcmc8 YnI+PC9kaXY+PGRpdj5UbzogU2ltZW4gSGVnZ2VzdMO4eWwgJmx0O3NpbWVuaGVnQGdtYWlsLmNv bSZndDs8YnI+PC9kaXY+PGRpdj5tbWF1Z2VyQHByb3Rvbm1haWwuY29tLCBtaWNoYWVsQG1hdWdl ci5jb20sIHJyYW5kcmVzZkBnbWFpbC5jb20sIDI1MjM2QGRlYmJ1Z3MuZ251Lm9yZywgc3Vuc2hh dmlAZmFzdG1haWwuZm08YnI+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj4mZ3Q7IERhdGU6IFRo dSwgMTAgQXVnIDIwMTcgMjM6MjY6MTMgKzAyMDA8YnI+PC9kaXY+PGRpdj4mZ3Q7IEZyb206IFNp bWVuIEhlZ2dlc3TDuHlsICZsdDtzaW1lbmhlZ0BnbWFpbC5jb20mZ3Q7PGJyPjwvZGl2PjxkaXY+ Jmd0OyBDYzogTWljaGFlbCBNYXVnZXIgJmx0O21pY2hhZWxAbWF1Z2VyLmNvbSZndDssPGJyPjwv ZGl2PjxkaXY+Jmd0OyAgYW5kcsOpcyByYW3DrXJleiAmbHQ7cnJhbmRyZXNmQGdtYWlsLmNvbSZn dDssPGJyPjwvZGl2PjxkaXY+Jmd0OyAgIjI1MjM2QGRlYmJ1Z3MuZ251Lm9yZyIgJmx0OzI1MjM2 QGRlYmJ1Z3MuZ251Lm9yZyZndDssPGJyPjwvZGl2PjxkaXY+Jmd0OyAgInN1bnNoYXZpQGZhc3Rt YWlsLmZtIiAmbHQ7c3Vuc2hhdmlAZmFzdG1haWwuZm0mZ3Q7PGJyPjwvZGl2PjxkaXY+Jmd0OyA8 YnI+PC9kaXY+PGRpdj4mZ3Q7IFRoYW5rcyBNaWNoYWVsLiBUaGVyZSJzIHN0aWxsIGEgcHJvYmxl bSB3aGVuIHBzcWwgZXhpc3RzIHdpdGggYTxicj48L2Rpdj48ZGl2PiZndDsgbm9uLXplcm8gZXhp dCBzdGF0dXMuIEkgdGhpbmsgdGhlIGF0dGFjaGVkIHBhdGNoIGlzIG5lZWRlZCBpbjxicj48L2Rp dj48ZGl2PiZndDsgYWRkaXRpb24uPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+TWljaGFl bCwgYW55IHJlYXNvbnMgbm90IHRvIHB1c2ggdGhpcyBwYXRjaD88YnI+PC9kaXY+PC9ibG9ja3F1 b3RlPg== --b1_be985217f2a769124347bfc8ca1f7644-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 14:36:41 2017 Received: (at 25236-done) by debbugs.gnu.org; 5 Sep 2017 18:36:41 +0000 Received: from localhost ([127.0.0.1]:51764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpIiH-00031U-Gl for submit@debbugs.gnu.org; Tue, 05 Sep 2017 14:36:41 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:38240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpIiG-00031D-00 for 25236-done@debbugs.gnu.org; Tue, 05 Sep 2017 14:36:40 -0400 Received: by mail-lf0-f51.google.com with SMTP id q132so12737785lfe.5 for <25236-done@debbugs.gnu.org>; Tue, 05 Sep 2017 11:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=OWXjRgJB87PNyWJ7naNlP56Fdv/fYSt3o0N9fGFH5nc=; b=Ndq+PQ6oHoz5+HlJgnyev8YisygDin5oaeepfTTsrbDGF1FE/IQryc5aWgpUIRHqNx TfwFJyNLn1Hk+fWjlxBjg4JDTESW2vP3TGeRfw5jMO8v/wGkg2z8sCnktl1qce13Wx8t iZTwysNqzkGDoQJyL6xKqMuExmUyKotvZSH9uHWjXxFMJ46J13V1OCZ01CulByFcoM1H zDZsucfmUA/97UZIpq4d+NicIpk++Mr+9aCZjDMoBy3sq9ABRZYSChDMcJeNJika97f7 VBr8bR4IZyiKDfyCfc/PcFREzAkuKQHyOFib8LXf6OljPkuymEavtu6GppmmfVnv7ESU Jc+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=OWXjRgJB87PNyWJ7naNlP56Fdv/fYSt3o0N9fGFH5nc=; b=Dn09phCONm/BNIs/ILyXzvg+eEwJL5mo2c8HpdZ0QQ4tjV2dyIEQzwO9PtJuCpw6NO GaPWaLBbQ9ZdFkKb/t7xpXzMy/GwCzEa9YRwrd2eC8LX9lxUKZ0mYe+ibSb9ymFZWO56 W/mjsU4MBl7sA91NcXOB2D+ZqYce5xT+oe+7PjFo3HruWGnhXXVmYCRZLH1qnPywNTVr H9ELFXVAlBN63Pyy+aeDj0OvnmfVHSrIKapKVIp00g36vwz4LZtX8x7AIAZOCF7iJE+Z ZopV2162OWf0lu6y7XPqzeAha0v9ml6hTEkgvNYGvoebS4Pp1pxYaiUPLBx/A4irShnd Mj/Q== X-Gm-Message-State: AHPjjUh7hqcWYic2tErFxTkcA4+Z8a/axP3BYu21lUEVLqZwSf0zdSPv ISTXwh/orHCwPg== X-Google-Smtp-Source: ADKCNb4Dtlyhn5FtiV3MlQQR22mBXhmhuF9C+e0VzMso2ZkLhtsvGrGDk3v//Zmte5+nsd9X/h65Hw== X-Received: by 10.25.235.90 with SMTP id j87mr1768431lfh.249.1504636593994; Tue, 05 Sep 2017 11:36:33 -0700 (PDT) Received: from [192.168.100.3] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id q87sm226785lfg.35.2017.09.05.11.36.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Sep 2017 11:36:32 -0700 (PDT) Date: Tue, 05 Sep 2017 20:36:30 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#25236: 26.0.50; sql-postgres not working on master To: Michael Mauger Message-Id: <1504636590.1967.0@smtp.gmail.com> In-Reply-To: References: <87vauftgz2.fsf@caral.i-did-not-set--mail-host-address--so-tickle-me> <1483121873.22754.0@smtp.gmail.com> <1397003198.5767161.1483499760212@mail.yahoo.com> <1501345582.29622.0@smtp.gmail.com> <1502400373.1756.3@smtp.gmail.com> <83inh1z1q0.fsf@gnu.org> X-Mailer: geary/0.11.3 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25236-done Cc: "michael@mauger.com" , Eli Zaretskii , "rrandresf@gmail.com" , "sunshavi@fastmail.fm" , 25236-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Tue, Sep 5, 2017 at 2:18 AM, Michael Mauger wrote: > No. Go ahead and push it. Pushed! -- Simen From unknown Fri Jun 13 10:02:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator