From unknown Sun Aug 10 09:47:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25219 <25219@debbugs.gnu.org> To: bug#25219 <25219@debbugs.gnu.org> Subject: Status: 26.0.50; ispell failing Reply-To: bug#25219 <25219@debbugs.gnu.org> Date: Sun, 10 Aug 2025 16:47:12 +0000 retitle 25219 26.0.50; ispell failing reassign 25219 emacs submitter 25219 jpff severity 25219 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 17 15:28:53 2016 Received: (at submit) by debbugs.gnu.org; 17 Dec 2016 20:28:53 +0000 Received: from localhost ([127.0.0.1]:45206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cILbB-0006Og-4L for submit@debbugs.gnu.org; Sat, 17 Dec 2016 15:28:53 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIL8I-0005g8-Qu for submit@debbugs.gnu.org; Sat, 17 Dec 2016 14:59:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIL8C-0007xc-D4 for submit@debbugs.gnu.org; Sat, 17 Dec 2016 14:58:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48727) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cIL8C-0007xS-AQ for submit@debbugs.gnu.org; Sat, 17 Dec 2016 14:58:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIL8A-0006ML-Qu for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 14:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIL87-0007vf-OT for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 14:58:54 -0500 Received: from west.codemist.co.uk ([217.155.197.248]:59685 helo=codemist.co.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIL87-0007dJ-H2 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 14:58:51 -0500 Received: from jpff by codemist.co.uk with local (Exim 4.87) (envelope-from ) id 1cIL7U-0001Is-02 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2016 19:58:12 +0000 From: jpff To: bug-gnu-emacs@gnu.org Subject: 26.0.50; ispell failing Date: Sat, 17 Dec 2016 19:54:49 +0000 Message-ID: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 17 Dec 2016 15:28:51 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Load a text file (I used cvte but every file I have tried failed) run M-x ispell-buffer watch it fail on fist word not in dictionry I use ispell before sending mail (dyslexia and sspect keyboad) een this way fo a week or so In GNU Emacs 26.0.50.14 (x86_64-suse-linux-gnu, GTK+ Version 2.24.31) of 2016-12-17 built on birtwistle Repository revision: b03ce060cae90836b0627e283ea563abaf3f39e9 Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Starting new Ispell process /usr/bin/ispell with default dictionary... Spell-checking cv.tex using ispell with default dictionary...done ispell-process-line: Ispell misalignment: word ‘Claverton’ point 873; probably incompatible versions Making completion list... Configured using: 'configure --with-gnutls=no' Configured features: XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=local locale-coding-system: utf-8-unix Major mode: LaTeX Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils ispell tex-mode compile shell pcomplete comint ansi-color ring latexenc time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 110726 6329) (symbols 48 21197 0) (miscs 40 47 140) (strings 32 22429 4603) (string-bytes 1 707286) (vectors 16 15262) (vector-slots 8 462613 2777) (floats 8 186 84) (intervals 56 383 0) (buffers 976 13) (heap 1024 37577 1064)) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 06:51:49 2016 Received: (at 25219) by debbugs.gnu.org; 18 Dec 2016 11:51:49 +0000 Received: from localhost ([127.0.0.1]:45497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIa0K-00004r-Qc for submit@debbugs.gnu.org; Sun, 18 Dec 2016 06:51:48 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIa0I-0008WJ-TX for 25219@debbugs.gnu.org; Sun, 18 Dec 2016 06:51:47 -0500 Received: by mail-wm0-f43.google.com with SMTP id t79so77464832wmt.0 for <25219@debbugs.gnu.org>; Sun, 18 Dec 2016 03:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PsZtvMUHc7U8Gez8ohuusbz4jz3bGRXa8yy/4Tg/Wjs=; b=ZLulJWTKU6HFXUXlE8oojtFhcbAZ6tUVK5JIuysCBf4EwxGmMWhbsj1fLiR0Idoc8V +KINcD9hmDC4rtOvnvcMXi3mFdrF76VwwGt1qjStMC82MkjvvDiAC4S14A/4CaR8RQ+m fcHdwW8aWxc0nSHC6F8Opi5RYZP93DALXMt6wtGajeXfPNxLNaGqdZ4I0HCpW2+pVpWG O0HsDj8/qhtfrdD4ucVe4N7pImrIrhiGe9KWdKbK81KXGkJ5FJdZlZI0kUsKNx3TC3Kt 7fKbZiMt0SSWneyLguF6/utwH6VKANBsxu1oGj9mvJV4mD7SoixUoq+9eTg/Lf84rU4K oOGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=PsZtvMUHc7U8Gez8ohuusbz4jz3bGRXa8yy/4Tg/Wjs=; b=XJd4t5xja7n1NkSIIDKEHnMQHoel/XnBPoIX/Zog4XPGQeszdB5QxoraZmD77JPZd0 pDejMpU6jzdZz9C6huwF1y7BIVyVcb2vY1LJEsP7eqm2+RVEKX/km5rvHDb0jrhNLmDh A8Lhk23KQIC6bn2yg6cN+N7IJ0hCWUcr0Z7pIkGA9ziDSwxI0uVBuGniI2GyNc54ulrp a5L0/zEPnFEeVr7zfMyVcYfTwA8SWqkLOi47V1KN9Siv3N/InlKC4uMQ9FTXCkpd/pjp 1gb8eJrIIj04WEs8o/aeSCLWtTB8bApfwEjgEVl3FJ3kBbT+Bc58XgDMWnFBZRtVzroe /mwQ== X-Gm-Message-State: AIkVDXKJUrEVw1hsCPMhIwemjJuoWIW3rJN2gFtm1RZczwViZn6nnMRGv/CJJJTP2DveqQ== X-Received: by 10.28.214.84 with SMTP id n81mr8895799wmg.120.1482061898944; Sun, 18 Dec 2016 03:51:38 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-f570-80e4-3e8c-1ced.holly.idiocy.org. [2001:8b0:3f8:8129:f570:80e4:3e8c:1ced]) by smtp.gmail.com with ESMTPSA id e188sm12236147wma.21.2016.12.18.03.51.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 18 Dec 2016 03:51:38 -0800 (PST) From: Alan Third To: Reuben Thomas Subject: Re: bug#25219: 26.0.50; ispell failing References: Date: Sun, 18 Dec 2016 11:51:37 +0000 In-Reply-To: (jpff@birtwistle.i-did-not-set--mail-host-address--so-tickle-me's message of "Sat, 17 Dec 2016 19:54:49 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: jpff writes: > Load a text file (I used cvte but every file I have tried failed) > > run M-x ispell-buffer > > watch it fail on fist word not in dictionry > > I use ispell before sending mail (dyslexia and sspect keyboad) > > een this way fo a week or so [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [74.125.82.43 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.43 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.43 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (athird[at]googlemail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 1.1 TRACKER_ID BODY: Incorporates a tracking ID number 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: 25219 Cc: 25219@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: jpff writes: > Load a text file (I used cvte but every file I have tried failed) > > run M-x ispell-buffer > > watch it fail on fist word not in dictionry > > I use ispell before sending mail (dyslexia and sspect keyboad) > > een this way fo a week or so [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [74.125.82.43 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.125.82.43 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [74.125.82.43 listed in wl.mailspike.net] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (athird[at]googlemail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 SPF_PASS SPF: sender matches SPF record 1.1 TRACKER_ID BODY: Incorporates a tracking ID number 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different jpff writes: > Load a text file (I used cvte but every file I have tried failed) > > run M-x ispell-buffer > > watch it fail on fist word not in dictionry > > I use ispell before sending mail (dyslexia and sspect keyboad) > > een this way fo a week or so It looks like this started with commit: db6e1f82976a7f232a4a206a3c850ed34cfbfdd3 The following patch appears to fix the problem for me, but I have my doubts it's the best way to handle it and I've only tested with hunspell. modified lisp/textmodes/ispell.el @@ -3338,7 +3338,7 @@ ispell-process-line ;; Markers can move with highlighting! This destroys ;; end of region markers line-end and ispell-region-end (let ((word-start - (copy-marker (+ ispell-start (car (cdr poss))))) + (copy-marker (+ ispell-start -1 (car (cdr poss))))) (word-len (length (car poss))) (line-end (copy-marker ispell-end)) (line-start (copy-marker ispell-start)) Any thoughts? -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 10:19:01 2016 Received: (at 25219) by debbugs.gnu.org; 18 Dec 2016 15:19:01 +0000 Received: from localhost ([127.0.0.1]:46270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIdEr-00006H-LU for submit@debbugs.gnu.org; Sun, 18 Dec 2016 10:19:01 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIdEp-00005y-TW for 25219@debbugs.gnu.org; Sun, 18 Dec 2016 10:19:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cIdEh-0007jn-Gv for 25219@debbugs.gnu.org; Sun, 18 Dec 2016 10:18:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cIdEh-0007ja-Dd; Sun, 18 Dec 2016 10:18:51 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4817 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cIdEf-0002N1-Eh; Sun, 18 Dec 2016 10:18:50 -0500 Date: Sun, 18 Dec 2016 17:18:15 +0200 Message-Id: <83vauh5kqw.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-reply-to: (message from Alan Third on Sun, 18 Dec 2016 11:51:37 +0000) Subject: Re: bug#25219: 26.0.50; ispell failing References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-Debbugs-Envelope-To: 25219 Cc: 25219@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) > From: Alan Third > Date: Sun, 18 Dec 2016 11:51:37 +0000 > Cc: 25219@debbugs.gnu.org > > > run M-x ispell-buffer > > > > watch it fail on fist word not in dictionry > > > > I use ispell before sending mail (dyslexia and sspect keyboad) > > > > een this way fo a week or so > > It looks like this started with commit: > > db6e1f82976a7f232a4a206a3c850ed34cfbfdd3 > > The following patch appears to fix the problem for me, but I have my > doubts it's the best way to handle it and I've only tested with > hunspell. > > modified lisp/textmodes/ispell.el > @@ -3338,7 +3338,7 @@ ispell-process-line > ;; Markers can move with highlighting! This destroys > ;; end of region markers line-end and ispell-region-end > (let ((word-start > - (copy-marker (+ ispell-start (car (cdr poss))))) > + (copy-marker (+ ispell-start -1 (car (cdr poss))))) > (word-len (length (car poss))) > (line-end (copy-marker ispell-end)) > (line-start (copy-marker ispell-start)) > > Any thoughts? We definitely need to keep the -1 offset there. (It was previously supplied by ispell-offset, but that variable was deleted.) The reason for the offset is that the line we send to the speller has a "^" prepended to it (see the documentation of the Ispell interface for the reason why). Please add a comment to that effect when you commit the above. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 11:08:52 2016 Received: (at 25219-done) by debbugs.gnu.org; 18 Dec 2016 16:08:52 +0000 Received: from localhost ([127.0.0.1]:46294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIe16-0001H7-LX for submit@debbugs.gnu.org; Sun, 18 Dec 2016 11:08:52 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIe14-0001Gt-VC for 25219-done@debbugs.gnu.org; Sun, 18 Dec 2016 11:08:51 -0500 Received: by mail-wm0-f46.google.com with SMTP id t79so80811363wmt.0 for <25219-done@debbugs.gnu.org>; Sun, 18 Dec 2016 08:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CzZbieaCfvw6tFU1VZYPKS2Pa+xu9cUAx2KIyiY7E64=; b=RX/6rpPL35644aCVhdxOkbbCzenMOm3kFFLaI91uGgqQQphzB2xEbL8p89/7kVlBFH WsQuPvrX4+1ysnmo0SwBKBi/LIz0LWQ7tNWzPiULG5Pep/2Z7oJ0uH+2C1jDeTic2zUS BnZgLrYPvp61QMuoCFzGL49CR7gbcj8cHMVjWpzbMD4x8S5rtNlGYkRlS+/cfArs9hRo XQ1bKR/iXNxCJj8s4nUfYOZNs37b55q0P3rKdnf8hzwRmq7HDiviYNfDM1GilNiHclf6 nBCB9BVHxszunW0FmOxbhx6NbVZflRrAoC4BlyPZzMHsPqVnE+C8XJT22kz177UxItK5 SpJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=CzZbieaCfvw6tFU1VZYPKS2Pa+xu9cUAx2KIyiY7E64=; b=rGvTOTCe2hF+cuNFs/0OnMiGJOW8bBF67bbK8yoNIwLcENqvZ5uL5BgLF883BO9AR2 4EqTX0hhxeYFDHn/LQQlZcsJ1IN0R/JlfKf6csZbFqHzAHmC1W1QmMKP8eWAmOLqvAiK rk2KmF/Z1bUD1f4F3cuBJPcNx3Nz8Th0tosl9bdBx+SrZCXq+OHtNxnGCMlAgh+YgAU7 gw/y6F2IuwMzhBZoRpD0hSIipKjndAESVbDnz1rRWjdrrvhyvczTIVhuaNaHOZ6xkDpS hGeAF2hbSnt/pntIZ1RGCqhtaEkvqGAQkCbNdxuV5eQ4SB4BZW8tm1c+95mvcMhIkq01 aR1w== X-Gm-Message-State: AIkVDXJxhEO6kg+DIKys5yDv5nA/9On7xjIhL0jsL15YmpuxBbc71w0wKttQLcjPEQ3bFg== X-Received: by 10.28.40.67 with SMTP id o64mr9879305wmo.40.1482077325284; Sun, 18 Dec 2016 08:08:45 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-f570-80e4-3e8c-1ced.holly.idiocy.org. [2001:8b0:3f8:8129:f570:80e4:3e8c:1ced]) by smtp.gmail.com with ESMTPSA id ab10sm16553171wjc.45.2016.12.18.08.08.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 18 Dec 2016 08:08:44 -0800 (PST) Date: Sun, 18 Dec 2016 16:08:40 +0000 From: Alan Third To: Eli Zaretskii Subject: Re: bug#25219: 26.0.50; ispell failing Message-ID: <20161218160840.GA56991@breton.holly.idiocy.org> References: <83vauh5kqw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83vauh5kqw.fsf@gnu.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25219-done Cc: 25219-done@debbugs.gnu.org, rrt@sc3d.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sun, Dec 18, 2016 at 05:18:15PM +0200, Eli Zaretskii wrote: > > From: Alan Third > > Date: Sun, 18 Dec 2016 11:51:37 +0000 > > Cc: 25219@debbugs.gnu.org > > > > > run M-x ispell-buffer > > > > > > watch it fail on fist word not in dictionry > > > > > > I use ispell before sending mail (dyslexia and sspect keyboad) > > > > > > een this way fo a week or so > > > > It looks like this started with commit: > > > > db6e1f82976a7f232a4a206a3c850ed34cfbfdd3 > > > > The following patch appears to fix the problem for me, but I have my > > doubts it's the best way to handle it and I've only tested with > > hunspell. > > > > modified lisp/textmodes/ispell.el > > @@ -3338,7 +3338,7 @@ ispell-process-line > > ;; Markers can move with highlighting! This destroys > > ;; end of region markers line-end and ispell-region-end > > (let ((word-start > > - (copy-marker (+ ispell-start (car (cdr poss))))) > > + (copy-marker (+ ispell-start -1 (car (cdr poss))))) > > (word-len (length (car poss))) > > (line-end (copy-marker ispell-end)) > > (line-start (copy-marker ispell-start)) > > > > Any thoughts? > > We definitely need to keep the -1 offset there. (It was previously > supplied by ispell-offset, but that variable was deleted.) The reason > for the offset is that the line we send to the speller has a "^" > prepended to it (see the documentation of the Ispell interface for the > reason why). > > Please add a comment to that effect when you commit the above. Done. Thanks! -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 18 11:57:52 2016 Received: (at 25219-done) by debbugs.gnu.org; 18 Dec 2016 16:57:52 +0000 Received: from localhost ([127.0.0.1]:46337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIemW-0002QP-0p for submit@debbugs.gnu.org; Sun, 18 Dec 2016 11:57:52 -0500 Received: from mail-qk0-f174.google.com ([209.85.220.174]:36067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cIemU-0002QB-7G for 25219-done@debbugs.gnu.org; Sun, 18 Dec 2016 11:57:50 -0500 Received: by mail-qk0-f174.google.com with SMTP id n21so5704191qka.3 for <25219-done@debbugs.gnu.org>; Sun, 18 Dec 2016 08:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZRyL/tQkDcWpF2PNZRGIf/h5XKJdlJ0HMKxBWd+fNes=; b=u3MDbhkVuZGGbDR1zwgboQC1lvVDnKa/oJycerfErPFgAHzETv+U4WjZUWOpcCainF 5pabwchLInHX0nUm1f2B6soXgmLaiRPpj2mUi0bq6A4F2SYHQ2xfobvnEkCxc/FZ2icn EE39YazDkrHk6wDUtsvgzr0WhN2zB9i6Iy+Rk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZRyL/tQkDcWpF2PNZRGIf/h5XKJdlJ0HMKxBWd+fNes=; b=JyfYfebnbKTTimJqZ+pH2ufhc/HoTgfsOXJm8z1cgzmulfoJDXEXRHF+YioXVMcnZX VoFvilRhH6X5g8ux27SvLmFAx5RIxqYsfNWA4keIorK/SQPRB8+Wv5nhLyjNQVBZEBs9 07k2gPk1NuTp9umXykr9OuO6AtHKr5074+g57cqlP1D0tYkQMIjA7X3uCXJowZzEXdkF qMwCcDjr3wtGincQIo4e0uadnAx0hq/ji4bLZzGa6s6L7lINQiOQ3CEFbA2v1PHIBY65 bpaMRCSda6iQYhy430sbRVGaZqZgkTgeF2uhnPIn6ZbAKXDOE9582HLc+6AITkmWv3Kj apjw== X-Gm-Message-State: AIkVDXLyy37xW3byH5ntqayH1gf5zGVMDcCx6Kf3U1u26+0tCb4haXkkmWFhsr9H2XT8xLYtCi6Tc0IqruLlX061 X-Received: by 10.55.113.69 with SMTP id m66mr9971976qkc.186.1482080264615; Sun, 18 Dec 2016 08:57:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.88.51 with HTTP; Sun, 18 Dec 2016 08:57:44 -0800 (PST) In-Reply-To: <20161218160840.GA56991@breton.holly.idiocy.org> References: <83vauh5kqw.fsf@gnu.org> <20161218160840.GA56991@breton.holly.idiocy.org> From: Reuben Thomas Date: Sun, 18 Dec 2016 16:57:44 +0000 Message-ID: Subject: Re: bug#25219: 26.0.50; ispell failing To: Alan Third Content-Type: multipart/alternative; boundary=94eb2c05a830b39fdf0543f1b31e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25219-done Cc: Eli Zaretskii , 25219-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --94eb2c05a830b39fdf0543f1b31e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 18 December 2016 at 16:08, Alan Third wrote: > On Sun, Dec 18, 2016 at 05:18:15PM +0200, Eli Zaretskii wrote: > > > > We definitely need to keep the -1 offset there. (It was previously > > supplied by ispell-offset, but that variable was deleted.) The reason > > for the offset is that the line we send to the speller has a "^" > > prepended to it (see the documentation of the Ispell interface for the > > reason why). > =E2=80=8BApologies for introducing this bug. I deleted this -1 on purpose, = but I misread the (logical) sense of ispell-offset with respect to the version of ispell, so I managed to parlay a logical negation error into an off-by-one error. --=20 http://rrt.sc3d.org --94eb2c05a830b39fdf0543f1b31e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 18 December 2016 at 16:08, Alan Third <alan@idiocy.org> wrote:=
On Sun, Dec 18,= 2016 at 05:18:15PM +0200, Eli Zaretskii wrote:
>
> We definitely need to keep the -1 offset there.=C2=A0 (It was previous= ly
> supplied by ispell-offset, but that variable was deleted.)=C2=A0 The r= eason
> for the offset is that the line we send to the speller has a "^&q= uot;
> prepended to it (see the documentation of the Ispell interface for the=
> reason why).

=E2=80=8BApolo= gies for introducing this bug. I deleted this -1 on purpose, but I misread = the (logical) sense of ispell-offset with respect to the version of ispell,= so I managed to parlay a logical negation error into an off-by-one error.<= /div>

--
--94eb2c05a830b39fdf0543f1b31e-- From unknown Sun Aug 10 09:47:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 16 Jan 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator