GNU bug report logs - #25201
Mumble opts users into statistics gathering by default

Previous Next

Full log

Message #31 received at 25201-done <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: mike <at> rohleder.de
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 25201-done <at> debbugs.gnu.org
Subject: Re: bug#25201: [PATCH] gnu: Patch mumble to disable statistic
 gathering by default.
Date: Tue, 10 Mar 2020 13:14:00 -0400 (EDT)

On Tue, 10 Mar 2020, mike <at> rohleder.de wrote:

> Hi Jack,
>
> Jack Hill <jackhill <at> jackhill.us> writes:
>> I'm trying to follow along, and learn some things about making Guix
>> packages. One question I have after seeing this change is how did you
>> decide whether to make this change in the source definition (with a
>> patch or a snippet) or in a phase during the build?
>
> Well, I saw the substitute* of a #include header
> (fix-libspeechd-include) in the phase, but the removing of dirs in the
> source definition and I thought, ok, it might make more sense this way.
> (because, eg, the phase names (fix-libspeechd-include,
> fix-statistic-gathering-default etc) could be printed in the log etc)
>
> This decition was more a "it feels better" than knowledge, because I'm
> new to guix and scheme and love to learn (by doing) ;)

Makes sense, thanks for sharing.

Jack

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.