Subject: Re: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default.

From: Efraim Flashner <[email-masked]>
Date: Mon, 9 Mar 2020 12:42:42 +0200

When you add a patch you also need to register it in gnu/local.mk so
when we create tarballs it makes sure that all the files are included.

On the other hand, since it's really only a 1 line change it would
probably be better to do it in the snippet. Can you send a revised
patch? (Or let me know why it should be a patch file :) )

On Sun, Mar 08, 2020 at 06:03:16PM +0100, [email-masked] wrote:
> Fixes <https://bugs.gnu.org/25201>
> ---
>  gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++
>  gnu/packages/telephony.scm                        |  2 ++
>  2 files changed, 15 insertions(+)
>  create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch
> 
> diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/packages/patches/mumble-statistic-25201.patch
> new file mode 100644
> index 0000000000..3cce1826a7
> --- /dev/null
> +++ b/gnu/packages/patches/mumble-statistic-25201.patch
> @@ -0,0 +1,13 @@
> +changed usage statistic gathering defaults to off. See <https://bugs.gnu.org/25201>
> +
> +--- a/src/mumble/Settings.cpp	2020-03-08 15:29:11.897056953 +0100
> ++++ b/src/mumble/Settings.cpp	2020-03-08 14:11:53.600486793 +0100
> +@@ -298,7 +298,7 @@
> + 	bHideInTray = !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvailable();
> + #endif
> + 	bStateInTray = true;
> +-	bUsage = true;
> ++	bUsage = false;
> + 	bShowUserCount = false;
> + 	bChatBarUseSelection = false;
> + 	bFilterHidesEmptyChannels = true;
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index a645c58562..74991079db 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -15,6 +15,7 @@
>  ;;; Copyright © 2019 Jan Wielkiewicz <[email-masked]>
>  ;;; Copyright © 2019 Ivan Vilata i Balaguer <[email-masked]>
>  ;;; Copyright © 2020 Brett Gilio <[email-masked]>
> +;;; Copyright © 2020 Michael Rohleder <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -404,6 +405,7 @@ address of one of the participants.")
>                 (base32
>                  "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs"))
>                (modules '((guix build utils)))
> +              (patches (search-patches "mumble-statistic-25201.patch"))
>                (snippet
>                 `(begin
>                    ;; Remove bundled software.  Keep arc4random, celt-0.7.0,
> -- 
> 2.25.1
> 
> 
> 
> 

-- 
Efraim Flashner   <[email-masked]>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted