From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: Mumble opts users into statistics gathering by default Resent-From: "Thompson, David" Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 14 Dec 2016 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 25201@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148174169620122 (code B ref -1); Wed, 14 Dec 2016 18:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2016 18:54:56 +0000 Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHEhc-0005ET-BC for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHEhb-0005EH-1b for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHEhV-0005zA-1E for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46192) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHEhU-0005yq-Tu for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHEhT-0000ua-QR for bug-guix@gnu.org; Wed, 14 Dec 2016 13:54:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHEhP-0005ul-Vd for bug-guix@gnu.org; Wed, 14 Dec 2016 13:54:47 -0500 Received: from mail-vk0-f45.google.com ([209.85.213.45]:34851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHEhP-0005u8-PY for bug-guix@gnu.org; Wed, 14 Dec 2016 13:54:43 -0500 Received: by mail-vk0-f45.google.com with SMTP id w194so41894255vkw.2 for ; Wed, 14 Dec 2016 10:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=z23fShij9cEKI+wqP0FzLj6GuPdOyHVGhuJ7uHitnY8=; b=vjXpieblX0RTLHNEOI3DvtFAeunrHMBAGgKB7obKLbFg7Pq7QsiTJ7uDYpr6dYzogq 2OOnn3R5q5yUIzhHHupufywCRRs/6dmfywwq4iinY8uggqskCc61mQFUNHMvEHRBtqwY rNL4F2POFKC/kTfwxPSCTYmtsObZEBUW/DOPoS62i7Loe7EHUZjGa78soaJovNSzK6OI 81+GR0IoG0k+QKE9YlcAalYIUFV+YLn6Jg31slDG3ma+dwf16vkv/p6AOev32NPkKYFb L0kum+F+NPBp52i+ISuZ0rdApgAGeOz6ON8fKEAw5H7gHA1wFCS554Q61+/QehCPv31S 2aRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=z23fShij9cEKI+wqP0FzLj6GuPdOyHVGhuJ7uHitnY8=; b=U/xM/rhpKlr3SVbgIrPIxHxvfhRPB7HfKcv8Z0F+tNLVieHJmQ3zOuj53em5o5kQ89 Ry2a4LkapRIkKrknkyNujfGo96oIy7FZxOWhlA/c4pXzaxU5Nf75mzPtMFsODK6Y4Y5D gmIloW3ZC/1u4DXTUpjFTg5T+uaXHtCai7yQlHFQdbNuKqC6gPt4EWtzvzk31xhtBr4q +648Z4uoSGEEA9PaVmtcr+w6BY+VwspVCnSX0Z/6CICFhOwrUb3XvVeb1lWu8aQqoO0L T2xYBiAmdOgCb/CA/68SoB7Kfq1bCiC468isjNNM4M7BTPcA1WAfjjoQ2XouX8nar6ec ajwQ== X-Gm-Message-State: AKaTC01Kr8Hx2xo3HxXFRqgN4g/Tyjhkb+IdTQGR8AxEokAPnnuwxA/yjInv2bn0JTxAm56MgtLGDg4MBCpyHG9d X-Received: by 10.31.52.145 with SMTP id b139mr40269073vka.151.1481741620749; Wed, 14 Dec 2016 10:53:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.31.83.135 with HTTP; Wed, 14 Dec 2016 10:53:40 -0800 (PST) From: "Thompson, David" Date: Wed, 14 Dec 2016 13:53:40 -0500 Message-ID: Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The first time you run the mumble client there is a setup wizard. One of the screens asks if you'd like to send some sort of usage data to the Mumble developers. The checkbox is checked by default. I think it should be unchecked by default. - Dave From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: Mumble opts users into statistics gathering by default Resent-From: ng0 Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 26 Dec 2016 22:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "Thompson\, David" Cc: 25201@debbugs.gnu.org Received: via spool by 25201-submit@debbugs.gnu.org id=B25201.14827921357587 (code B ref 25201); Mon, 26 Dec 2016 22:43:01 +0000 Received: (at 25201) by debbugs.gnu.org; 26 Dec 2016 22:42:15 +0000 Received: from localhost ([127.0.0.1]:56090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLdy7-0001yD-J0 for submit@debbugs.gnu.org; Mon, 26 Dec 2016 17:42:15 -0500 Received: from aibo.runbox.com ([91.220.196.211]:58240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLdy4-0001y3-Ho for 25201@debbugs.gnu.org; Mon, 26 Dec 2016 17:42:09 -0500 Received: from [10.9.9.212] (helo=mailfront12.runbox.com) by bars.runbox.com with esmtp (Exim 4.71) (envelope-from ) id 1cLdy3-0003Pl-2I; Mon, 26 Dec 2016 23:42:07 +0100 Received: from [91.223.82.156] (helo=localhost) by mailfront12.runbox.com with esmtpsa (uid:892961 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1cLdxa-0004rZ-Oc; Mon, 26 Dec 2016 23:41:39 +0100 From: ng0 In-Reply-To: References: Date: Mon, 26 Dec 2016 22:42:00 +0000 Message-ID: <87wpemcnyf.fsf@wasp.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) "Thompson, David" writes: > The first time you run the mumble client there is a setup wizard. One > of the screens asks if you'd like to send some sort of usage data to > the Mumble developers. The checkbox is checked by default. I think > it should be unchecked by default. > > - Dave Upstream source in addition to SF: https://github.com/mumble-voip/mumble This commit has introduced the statistics button: commit 36c9d56d7959fbf5bc83ea746a143b57614f9a4d Author: Thorvald Natvig Date: Fri Jan 9 20:29:44 2009 +0000 Mute loopback in wizard during welcome and finish pages. Add question about statistics to the end of the audio wizard. git-svn-id: https://mumble.svn.sourceforge.net/svnroot/mumble/trunk@1402 05730e5d-ab1b-0410-a4ac-84af 385074fa Chances are it moved elsewhere in those 7 years, but maybe someone can work with this information. -- ♥Ⓐ ng0 PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. References: In-Reply-To: Resent-From: mike@rohleder.de Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 08 Mar 2020 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 25201@debbugs.gnu.org Cc: Michael Rohleder , dthompson2@worcester.edu Received: via spool by 25201-submit@debbugs.gnu.org id=B25201.15836916135691 (code B ref 25201); Sun, 08 Mar 2020 18:21:01 +0000 Received: (at 25201) by debbugs.gnu.org; 8 Mar 2020 18:20:13 +0000 Received: from localhost ([127.0.0.1]:49265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jB0X6-0001Ti-9p for submit@debbugs.gnu.org; Sun, 08 Mar 2020 14:20:12 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:45258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jAzMx-00089w-NL for 25201@debbugs.gnu.org; Sun, 08 Mar 2020 13:05:40 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jAzMv-0006jB-Hx; Sun, 08 Mar 2020 18:05:37 +0100 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with smtp (Exim 4.93) (envelope-from ) id 1jAzMu-0006Oi-1S; Sun, 08 Mar 2020 18:05:37 +0100 Received: by micha (sSMTP sendmail emulation); Sun, 08 Mar 2020 18:05:22 +0100 From: mike@rohleder.de Date: Sun, 8 Mar 2020 18:03:16 +0100 Message-Id: <20200308170316.22591-1-mike@rohleder.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1583687139;75c4d83b; X-HE-SMSGID: 1jAzMv-0006jB-Hx X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Sun, 08 Mar 2020 14:20:11 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Fixes --- gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++ gnu/packages/telephony.scm | 2 ++ 2 files changed, 15 insertions(+) create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/packages/patches/mumble-statistic-25201.patch new file mode 100644 index 0000000000..3cce1826a7 --- /dev/null +++ b/gnu/packages/patches/mumble-statistic-25201.patch @@ -0,0 +1,13 @@ +changed usage statistic gathering defaults to off. See + +--- a/src/mumble/Settings.cpp 2020-03-08 15:29:11.897056953 +0100 ++++ b/src/mumble/Settings.cpp 2020-03-08 14:11:53.600486793 +0100 +@@ -298,7 +298,7 @@ + bHideInTray = !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvailable(); + #endif + bStateInTray = true; +- bUsage = true; ++ bUsage = false; + bShowUserCount = false; + bChatBarUseSelection = false; + bFilterHidesEmptyChannels = true; diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index a645c58562..74991079db 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -15,6 +15,7 @@ ;;; Copyright © 2019 Jan Wielkiewicz ;;; Copyright © 2019 Ivan Vilata i Balaguer ;;; Copyright © 2020 Brett Gilio +;;; Copyright © 2020 Michael Rohleder ;;; ;;; This file is part of GNU Guix. ;;; @@ -404,6 +405,7 @@ address of one of the participants.") (base32 "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs")) (modules '((guix build utils))) + (patches (search-patches "mumble-statistic-25201.patch")) (snippet `(begin ;; Remove bundled software. Keep arc4random, celt-0.7.0, -- 2.25.1 From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 09 Mar 2020 10:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: mike@rohleder.de Cc: 25201@debbugs.gnu.org Received: via spool by 25201-submit@debbugs.gnu.org id=B25201.158375061114812 (code B ref 25201); Mon, 09 Mar 2020 10:44:01 +0000 Received: (at 25201) by debbugs.gnu.org; 9 Mar 2020 10:43:31 +0000 Received: from localhost ([127.0.0.1]:49856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBFsb-0003qk-Dr for submit@debbugs.gnu.org; Mon, 09 Mar 2020 06:43:30 -0400 Received: from flashner.co.il ([178.62.234.194]:53390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBFsV-0003qT-S6 for 25201@debbugs.gnu.org; Mon, 09 Mar 2020 06:43:23 -0400 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id C5E6A403A7; Mon, 9 Mar 2020 10:43:13 +0000 (UTC) Date: Mon, 9 Mar 2020 12:42:42 +0200 From: Efraim Flashner Message-ID: <20200309104242.GH1423@E5400> References: <20200308170316.22591-1-mike@rohleder.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9sSKoi6Rw660DLir" Content-Disposition: inline In-Reply-To: <20200308170316.22591-1-mike@rohleder.de> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --9sSKoi6Rw660DLir Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable When you add a patch you also need to register it in gnu/local.mk so when we create tarballs it makes sure that all the files are included. On the other hand, since it's really only a 1 line change it would probably be better to do it in the snippet. Can you send a revised patch? (Or let me know why it should be a patch file :) ) On Sun, Mar 08, 2020 at 06:03:16PM +0100, mike@rohleder.de wrote: > Fixes > --- > gnu/packages/patches/mumble-statistic-25201.patch | 13 +++++++++++++ > gnu/packages/telephony.scm | 2 ++ > 2 files changed, 15 insertions(+) > create mode 100644 gnu/packages/patches/mumble-statistic-25201.patch >=20 > diff --git a/gnu/packages/patches/mumble-statistic-25201.patch b/gnu/pack= ages/patches/mumble-statistic-25201.patch > new file mode 100644 > index 0000000000..3cce1826a7 > --- /dev/null > +++ b/gnu/packages/patches/mumble-statistic-25201.patch > @@ -0,0 +1,13 @@ > +changed usage statistic gathering defaults to off. See > + > +--- a/src/mumble/Settings.cpp 2020-03-08 15:29:11.897056953 +0100 > ++++ b/src/mumble/Settings.cpp 2020-03-08 14:11:53.600486793 +0100 > +@@ -298,7 +298,7 @@ > + bHideInTray =3D !isUnityDesktop && QSystemTrayIcon::isSystemTrayAvaila= ble(); > + #endif > + bStateInTray =3D true; > +- bUsage =3D true; > ++ bUsage =3D false; > + bShowUserCount =3D false; > + bChatBarUseSelection =3D false; > + bFilterHidesEmptyChannels =3D true; > diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm > index a645c58562..74991079db 100644 > --- a/gnu/packages/telephony.scm > +++ b/gnu/packages/telephony.scm > @@ -15,6 +15,7 @@ > ;;; Copyright =C2=A9 2019 Jan Wielkiewicz > ;;; Copyright =C2=A9 2019 Ivan Vilata i Balaguer > ;;; Copyright =C2=A9 2020 Brett Gilio > +;;; Copyright =C2=A9 2020 Michael Rohleder > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -404,6 +405,7 @@ address of one of the participants.") > (base32 > "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs")) > (modules '((guix build utils))) > + (patches (search-patches "mumble-statistic-25201.patch")) > (snippet > `(begin > ;; Remove bundled software. Keep arc4random, celt-0.7= =2E0, > --=20 > 2.25.1 >=20 >=20 >=20 >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --9sSKoi6Rw660DLir Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5mHZ8ACgkQQarn3Mo9 g1GXoQ//Zk5tXb4gbtBDwvD44R7ItE57YqwO/XeLbks/jGqODUvjFdeeumrqlLeF 7TsNqj7MsfLl/QX0NfMyvvYXQ4PqSrnP9S8+Vjecj60zcDEUAIF7Q6OdzYRwIQTz cO7rc5Brlwrqhe5nfmnNggXqRfqn4lccu5BkBzaJSHS1BF+AGqpEYQrC9BQJXZjX nD4RAJF0q3krw9+gxfVa7uqzDNs+RF61VB5bYdOsIs8/AmwirmlOlHOKZEwvnkxw gHYZYqpTKd3pxS8F+StshI/W0sUZu36WyIFj21on4DPU2nWwiCkdbRHBxHLnY0MF oknCXIEwmYrVF/I3U0F3glEOMCi6xik8Imj52bOgB0wMcCeMpJWPaSaavjOeQCzl YYBS84dVOoowIgdECz9jKRPKV0g2Y08HZD/kcvlN39ip+YYKdPnB5YFRUzzEhpTv MMTI5mM3ItWZDOj5RBBJV5nvrVD1mC7txSUrjRVOMd9bEaiHTQXVO4hGTRVWrXXM MaBaMCzGthKjRTSth1xZHnKaccoEeCvNJTsrb3HsBvJjaRJV3SEEn1pofoBYkZ/p cKr/Kx2HzJ/8A/hW04dKHhGArurcH+FPY04WwoPDRmcXToZyVEQGCjEjHdyoG1SS ErUlDqzSQQALF/UD5N3qgkjUJDKWq8P9dJQ48jVkhbGspXh90ck= =fwlF -----END PGP SIGNATURE----- --9sSKoi6Rw660DLir-- From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Resent-From: mike@rohleder.de Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Mar 2020 00:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 25201@debbugs.gnu.org Cc: Michael Rohleder , Efraim Flashner Received: via spool by 25201-submit@debbugs.gnu.org id=B25201.158380033627699 (code B ref 25201); Tue, 10 Mar 2020 00:33:01 +0000 Received: (at 25201) by debbugs.gnu.org; 10 Mar 2020 00:32:16 +0000 Received: from localhost ([127.0.0.1]:51653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBSoh-0007Ch-UU for submit@debbugs.gnu.org; Mon, 09 Mar 2020 20:32:16 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:50680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBSE2-0006Gd-UZ for 25201@debbugs.gnu.org; Mon, 09 Mar 2020 19:54:23 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jBSE0-0000bN-Ed; Tue, 10 Mar 2020 00:54:20 +0100 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with smtp (Exim 4.93) (envelope-from ) id 1jBSDy-00011A-1i; Tue, 10 Mar 2020 00:54:19 +0100 Received: by micha (sSMTP sendmail emulation); Tue, 10 Mar 2020 00:54:17 +0100 From: mike@rohleder.de Date: Tue, 10 Mar 2020 00:54:02 +0100 Message-Id: <20200309235402.24941-1-mike@rohleder.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200309104242.GH1423@E5400> References: <20200309104242.GH1423@E5400> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1583798062;c090af91; X-HE-SMSGID: 1jBSE0-0000bN-Ed X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Mon, 09 Mar 2020 20:32:14 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * disable statistic gathering by default. see --- gnu/packages/telephony.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index a645c58562..3d0384c8bc 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -462,6 +462,12 @@ address of one of the participants.") (substitute* "src/mumble/TextToSpeech_unix.cpp" (("libspeechd.h") "speech-dispatcher/libspeechd.h")) #t)) + ;; disable statistic gathering by default. see + (add-before 'configure 'fix-statistic-gathering-default + (lambda _ + (substitute* "src/mumble/Settings.cpp" + (("bUsage = true;") "bUsage = false;")) + #t)) (add-before 'install 'disable-murmur-ice (lambda _ (substitute* "scripts/murmur.ini.system" -- 2.25.1 From unknown Sat Aug 16 18:39:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Thompson, David" Subject: bug#25201: closed (Re: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default.) Message-ID: References: <20200310085601.GR1423@E5400> X-Gnu-PR-Message: they-closed 25201 X-Gnu-PR-Package: guix Reply-To: 25201@debbugs.gnu.org Date: Tue, 10 Mar 2020 08:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1583830622-9606-1" This is a multi-part message in MIME format... ------------=_1583830622-9606-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25201: Mumble opts users into statistics gathering by default which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25201@debbugs.gnu.org. --=20 25201: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25201 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1583830622-9606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25201-done) by debbugs.gnu.org; 10 Mar 2020 08:56:41 +0000 Received: from localhost ([127.0.0.1]:51843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBagr-0002UL-8L for submit@debbugs.gnu.org; Tue, 10 Mar 2020 04:56:41 -0400 Received: from flashner.co.il ([178.62.234.194]:52288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBagp-0002U5-B1 for 25201-done@debbugs.gnu.org; Tue, 10 Mar 2020 04:56:39 -0400 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id C3F3C400E5; Tue, 10 Mar 2020 08:56:32 +0000 (UTC) Date: Tue, 10 Mar 2020 10:56:01 +0200 From: Efraim Flashner To: Michael Rohleder Subject: Re: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Message-ID: <20200310085601.GR1423@E5400> References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lpUp1egui7PDlNtH" Content-Disposition: inline In-Reply-To: <20200309235402.24941-1-mike@rohleder.de> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25201-done Cc: 25201-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --lpUp1egui7PDlNtH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I changed the commit message to fit our conventions better and pushed it. Thanks! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --lpUp1egui7PDlNtH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5nViEACgkQQarn3Mo9 g1EYthAAhpIQxZSlPBahFBgEJ65UrlvCuckKCHiPpnWNYF/2+3bO71RN2vWhHaBP rs81EVDVbYVBt+feDfpr75QSl4iI+JK9qxjYWL9bKW1Ni4KMIOwvkQgRWDfL4Jrx x259uBEJZvtWkFThiLccIQPn1AELLdHy8swmAH5UdB20U2yJd6U2yGPIGfurMxpK ct+yDWYZdOwuEQat+bS6q3UE8hbjfZCoatyhclJvCUWpPVPUxAGN6SVpnOgNY9lV WjSNIYEySNvSVGFaQyyJIh+458gBVb4/MM3SesjY/1qZackoqTwCMmZWIqzurB6F FLYKsHNjbD4ZYnKYMOABzQu+NZiv+1ZAHEe2VuF2Cj+uNY79xuS8pIVtGoTyZ43Y TaA1DijrlE7Iao/vFYQp1Ch05tUgzs66oPo8diYwWnFCaDQ1ZdCQmx3/KnlF3CEb f4cxOdMo6E3eH4zSxrCD4fr+Qdy0nTxk+rTB6MTGHWGSq3CybWvxu4cpS3xkEqi+ woll+GNUoQtcEcEfApzgOykLMkvHwM+Um+5sjsBV9mtDxQqR94raD7V9aY0Yysy/ PHhzdGXrr/is+yFgSWt1zT9I6KqenNmDfCkbFqxJcrDmXP9Q4VRJYcTjVu3qij5E at3ernN/Wy+8TwyxyzTqAZOjJQ96GPiAZeGa0fFTdAbDVQmIdt0= =WRoU -----END PGP SIGNATURE----- --lpUp1egui7PDlNtH-- ------------=_1583830622-9606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Dec 2016 18:54:56 +0000 Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHEhc-0005ET-BC for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHEhb-0005EH-1b for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHEhV-0005zA-1E for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46192) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cHEhU-0005yq-Tu for submit@debbugs.gnu.org; Wed, 14 Dec 2016 13:54:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59673) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHEhT-0000ua-QR for bug-guix@gnu.org; Wed, 14 Dec 2016 13:54:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHEhP-0005ul-Vd for bug-guix@gnu.org; Wed, 14 Dec 2016 13:54:47 -0500 Received: from mail-vk0-f45.google.com ([209.85.213.45]:34851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cHEhP-0005u8-PY for bug-guix@gnu.org; Wed, 14 Dec 2016 13:54:43 -0500 Received: by mail-vk0-f45.google.com with SMTP id w194so41894255vkw.2 for ; Wed, 14 Dec 2016 10:54:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=z23fShij9cEKI+wqP0FzLj6GuPdOyHVGhuJ7uHitnY8=; b=vjXpieblX0RTLHNEOI3DvtFAeunrHMBAGgKB7obKLbFg7Pq7QsiTJ7uDYpr6dYzogq 2OOnn3R5q5yUIzhHHupufywCRRs/6dmfywwq4iinY8uggqskCc61mQFUNHMvEHRBtqwY rNL4F2POFKC/kTfwxPSCTYmtsObZEBUW/DOPoS62i7Loe7EHUZjGa78soaJovNSzK6OI 81+GR0IoG0k+QKE9YlcAalYIUFV+YLn6Jg31slDG3ma+dwf16vkv/p6AOev32NPkKYFb L0kum+F+NPBp52i+ISuZ0rdApgAGeOz6ON8fKEAw5H7gHA1wFCS554Q61+/QehCPv31S 2aRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=z23fShij9cEKI+wqP0FzLj6GuPdOyHVGhuJ7uHitnY8=; b=U/xM/rhpKlr3SVbgIrPIxHxvfhRPB7HfKcv8Z0F+tNLVieHJmQ3zOuj53em5o5kQ89 Ry2a4LkapRIkKrknkyNujfGo96oIy7FZxOWhlA/c4pXzaxU5Nf75mzPtMFsODK6Y4Y5D gmIloW3ZC/1u4DXTUpjFTg5T+uaXHtCai7yQlHFQdbNuKqC6gPt4EWtzvzk31xhtBr4q +648Z4uoSGEEA9PaVmtcr+w6BY+VwspVCnSX0Z/6CICFhOwrUb3XvVeb1lWu8aQqoO0L T2xYBiAmdOgCb/CA/68SoB7Kfq1bCiC468isjNNM4M7BTPcA1WAfjjoQ2XouX8nar6ec ajwQ== X-Gm-Message-State: AKaTC01Kr8Hx2xo3HxXFRqgN4g/Tyjhkb+IdTQGR8AxEokAPnnuwxA/yjInv2bn0JTxAm56MgtLGDg4MBCpyHG9d X-Received: by 10.31.52.145 with SMTP id b139mr40269073vka.151.1481741620749; Wed, 14 Dec 2016 10:53:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.31.83.135 with HTTP; Wed, 14 Dec 2016 10:53:40 -0800 (PST) From: "Thompson, David" Date: Wed, 14 Dec 2016 13:53:40 -0500 Message-ID: Subject: Mumble opts users into statistics gathering by default To: bug-guix@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The first time you run the mumble client there is a setup wizard. One of the screens asks if you'd like to send some sort of usage data to the Mumble developers. The checkbox is checked by default. I think it should be unchecked by default. - Dave ------------=_1583830622-9606-1-- From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Mar 2020 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Efraim Flashner Cc: Michael Rohleder , 25201-done@debbugs.gnu.org Received: via spool by 25201-done@debbugs.gnu.org id=D25201.15838518726768 (code D ref 25201); Tue, 10 Mar 2020 14:52:02 +0000 Received: (at 25201-done) by debbugs.gnu.org; 10 Mar 2020 14:51:12 +0000 Received: from localhost ([127.0.0.1]:53068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBgDw-0001l6-7N for submit@debbugs.gnu.org; Tue, 10 Mar 2020 10:51:12 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:53766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBgDr-0001kW-AB for 25201-done@debbugs.gnu.org; Tue, 10 Mar 2020 10:51:11 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jBgDh-0005L2-HP; Tue, 10 Mar 2020 10:50:57 -0400 Date: Tue, 10 Mar 2020 10:50:57 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <20200310085601.GR1423@E5400> Message-ID: References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thanks for improving Guix! Having an old bug closed is great. I'm trying to follow along, and learn some things about making Guix packages. One question I have after seeing this change is how did you decide whether to make this change in the source definition (with a patch or a snippet) or in a phase during the build? Perhaps for this change the differences don't matter to much, so I won't learn much, but I thought I'd ask anyway :) Best, Jack From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Resent-From: mike@rohleder.de Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Mar 2020 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: Efraim Flashner , 25201-done@debbugs.gnu.org Received: via spool by 25201-done@debbugs.gnu.org id=D25201.158385676114564 (code D ref 25201); Tue, 10 Mar 2020 16:13:01 +0000 Received: (at 25201-done) by debbugs.gnu.org; 10 Mar 2020 16:12:41 +0000 Received: from localhost ([127.0.0.1]:53170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBhUm-0003mp-F1 for submit@debbugs.gnu.org; Tue, 10 Mar 2020 12:12:40 -0400 Received: from wp224.webpack.hosteurope.de ([80.237.132.231]:54218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBhLj-0003Yp-IM for 25201-done@debbugs.gnu.org; Tue, 10 Mar 2020 12:03:20 -0400 Received: from www.rohleder.de ([37.61.204.227]); authenticated by wp224.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jBhLh-0000J7-Eo; Tue, 10 Mar 2020 17:03:17 +0100 Received: from [192.168.1.3] (helo=micha) by www.rohleder.de with smtp (Exim 4.93) (envelope-from ) id 1jBhLf-0007kd-W6; Tue, 10 Mar 2020 17:03:17 +0100 Received: by micha (sSMTP sendmail emulation); Tue, 10 Mar 2020 17:03:15 +0100 From: mike@rohleder.de References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400> X-PGP-Fingerprint: 755E 2DE5 D0D5 85C5 2E78 2830 7C7A FFBE FEF2 CB25 X-PGP-Key: https://www.rohleder.de/~mike/pgpkey.asc Date: Tue, 10 Mar 2020 17:03:14 +0100 In-Reply-To: (Jack Hill's message of "Tue, 10 Mar 2020 10:50:57 -0400 (EDT)") Message-ID: <87ftegqjst.fsf_-_@rohleder.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-bounce-key: webpack.hosteurope.de;mike@rohleder.de;1583856199;c76f0043; X-HE-SMSGID: 1jBhLh-0000J7-Eo X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Tue, 10 Mar 2020 12:12:39 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Jack, Jack Hill writes: > I'm trying to follow along, and learn some things about making Guix > packages. One question I have after seeing this change is how did you > decide whether to make this change in the source definition (with a > patch or a snippet) or in a phase during the build? Well, I saw the substitute* of a #include header (fix-libspeechd-include) in the phase, but the removing of dirs in the source definition and I thought, ok, it might make more sense this way. (because, eg, the phase names (fix-libspeechd-include, fix-statistic-gathering-default etc) could be printed in the log etc) This decition was more a "it feels better" than knowledge, because I'm new to guix and scheme and love to learn (by doing) ;) Regards mike =2D-=20 I have seen the needle and the damage done and every junkie is like a setting sun. -- Neil Young --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEdV4t5dDVhcUueCgwfHr/vv7yyyUFAl5nukIACgkQfHr/vv7y yyVL0Af+I5j8yVf8oA+CKqyqLRcNWkziPbvncl0myOpQVFBx/w3pe/XeHvoOTAky BWmecUZpSCHJaG+XXZJIYkJmDASHl6v1+kI+eEq9CVIJqeSik0qwHsijj643F2m+ oCvFRz65zbHz2PI+OJNV6XySe2k9ZH2l03gOv07yXb2EAPK4SUc+P2ScadDs3Odu IcYTW/lhkoXf/8o9UDqGTsQFqoBHoSWmEja9DMVkmR9/NscuGT35MccxphTnYFBb u8zeSUQUROqB+XoahYTwO+Mx4s9V/Yly1dDTkH8+g1o3va5+MghMLeeVMZHxt6pF Li+1Csd+1HbaExheQGGKMw19djG3Ag== =zHj6 -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Resent-From: Jack Hill Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Mar 2020 17:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: mike@rohleder.de Cc: Efraim Flashner , 25201-done@debbugs.gnu.org Received: via spool by 25201-done@debbugs.gnu.org id=D25201.158386045220087 (code D ref 25201); Tue, 10 Mar 2020 17:15:02 +0000 Received: (at 25201-done) by debbugs.gnu.org; 10 Mar 2020 17:14:12 +0000 Received: from localhost ([127.0.0.1]:53211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBiSK-0005Dv-Bt for submit@debbugs.gnu.org; Tue, 10 Mar 2020 13:14:12 -0400 Received: from minsky.hcoop.net ([104.248.1.95]:55174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBiSI-0005Dh-7f for 25201-done@debbugs.gnu.org; Tue, 10 Mar 2020 13:14:10 -0400 Received: from marsh.hcoop.net ([45.55.52.66]) by minsky.hcoop.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1jBiS8-0007kM-Gc; Tue, 10 Mar 2020 13:14:00 -0400 Date: Tue, 10 Mar 2020 13:14:00 -0400 (EDT) From: Jack Hill X-X-Sender: jackhill@marsh.hcoop.net In-Reply-To: <87ftegqjst.fsf_-_@rohleder.de> Message-ID: References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400> <87ftegqjst.fsf_-_@rohleder.de> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 10 Mar 2020, mike@rohleder.de wrote: > Hi Jack, > > Jack Hill writes: >> I'm trying to follow along, and learn some things about making Guix >> packages. One question I have after seeing this change is how did you >> decide whether to make this change in the source definition (with a >> patch or a snippet) or in a phase during the build? > > Well, I saw the substitute* of a #include header > (fix-libspeechd-include) in the phase, but the removing of dirs in the > source definition and I thought, ok, it might make more sense this way. > (because, eg, the phase names (fix-libspeechd-include, > fix-statistic-gathering-default etc) could be printed in the log etc) > > This decition was more a "it feels better" than knowledge, because I'm > new to guix and scheme and love to learn (by doing) ;) Makes sense, thanks for sharing. Jack From unknown Sat Aug 16 18:39:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25201: Re bug#25201: [PATCH] gnu: Patch mumble to disable statistic gathering by default. Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 10 Mar 2020 18:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jack Hill Cc: Michael Rohleder , 25201-done@debbugs.gnu.org Received: via spool by 25201-done@debbugs.gnu.org id=D25201.15838646101962 (code D ref 25201); Tue, 10 Mar 2020 18:24:02 +0000 Received: (at 25201-done) by debbugs.gnu.org; 10 Mar 2020 18:23:30 +0000 Received: from localhost ([127.0.0.1]:53293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBjXO-0000Va-8S for submit@debbugs.gnu.org; Tue, 10 Mar 2020 14:23:30 -0400 Received: from flashner.co.il ([178.62.234.194]:33338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jBjXL-0000VL-Th for 25201-done@debbugs.gnu.org; Tue, 10 Mar 2020 14:23:28 -0400 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id 87664400E5; Tue, 10 Mar 2020 18:23:21 +0000 (UTC) Date: Tue, 10 Mar 2020 20:22:50 +0200 From: Efraim Flashner Message-ID: <20200310182250.GA26542@E5400> References: <20200309104242.GH1423@E5400> <20200309235402.24941-1-mike@rohleder.de> <20200310085601.GR1423@E5400> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2020 at 10:50:57AM -0400, Jack Hill wrote: > Hi, >=20 > Thanks for improving Guix! Having an old bug closed is great. >=20 > I'm trying to follow along, and learn some things about making Guix > packages. One question I have after seeing this change is how did you dec= ide > whether to make this change in the source definition (with a patch or a > snippet) or in a phase during the build? >=20 > Perhaps for this change the differences don't matter to much, so I won't > learn much, but I thought I'd ask anyway :) >=20 > Best, > Jack In general changes in snippets are used to remove non-free software and to allow the software to build. The idea is that 'guix build -S foo' will return the source for foo which could be taken to a non-guix system and built normally. In practice I'm not sure how often this is the case. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl5n2vcACgkQQarn3Mo9 g1Gdqg//Rv+aAwgTIkN80uueLDjYDxKxOv5o9SAzkSRjPOdAkMo0S9emhqaUVDjX ZJN5hRdKTsP1llDqt4FJh68rt+F9YrzwoTSkO9xkEP/25NvwE0hM2dzcCxkts2fz yER32DpX0TXaQyJYKF65peW+Vo4WjsHngIN0JZ1vNEGeCVGHn9KSnf+4fDVnJxdk Po/rDSaaxVmEMFxKh2gIwPSjPbjvuZ5psWHJpocnQHEC8uY36vnlY/oS/+jhFmur ff9MraMtem8jHqT4IhG00S3w3udD/rBulG0/3kpXjFV2oOBmktECmTwVcQteUxvE Q2JiL/UiMCDAl45HQeMeyLK9LYmmd8SOJxeiLk2yK+AbBL52gQFRc5VQBB7mXb7p mC3OJ1fqXuWeYnKCT74VciIm77FmGuXWPnPzD4VUivD54y2tkNx0ILrQGveT0y3n V8AxSzgrCmP4hal7OyvoN1yFU3//3mOvvbBWI71/mB5D4z14Lx4dXX1hqaHFDq23 u+iiD4m3O0xLV05o22GJocysq7dAqaMvJV9N1hnhMP7+HugU3hWggeNjrTz2F6iT tyutbl37ZHmRsat5hVsK1qUuAgqxPXQxu0IqZPeqmVyTSGaflIxpVO0hv81rR8bR ylkgA3HgvmY4wUyYnxKbZ9P2q2QoPJj9k8SEnYiAKyqNmeEsTDo= =J2ls -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--