From unknown Mon Aug 18 14:22:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25191: Redesign `recentf-menu-bar' logic and its callers Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2016 01:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25191@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1481590791982 (code B ref -1); Tue, 13 Dec 2016 01:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Dec 2016 00:59:51 +0000 Received: from localhost ([127.0.0.1]:39813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGbRe-0000Fm-WE for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:59:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGbRd-0000FZ-Hr for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:59:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGbRX-000496-8a for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:59:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39393) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGbRX-000492-5Z for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:59:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGbRV-0005MV-UD for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 19:59:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGbRS-00048J-QG for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 19:59:42 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50595) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGbRS-00048B-Je for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 19:59:38 -0500 Received: from mfilter48-d.gandi.net (mfilter48-d.gandi.net [217.70.178.179]) by relay8-d.mail.gandi.net (Postfix) with ESMTP id 2EB7040496 for ; Tue, 13 Dec 2016 01:59:36 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter48-d.gandi.net Received: from relay8-d.mail.gandi.net ([IPv6:::ffff:217.70.183.201]) by mfilter48-d.gandi.net (mfilter48-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id KIT6F-s8hcfu for ; Tue, 13 Dec 2016 01:59:34 +0100 (CET) X-Originating-IP: 88.68.181.111 Received: from [192.168.3.110] (dslb-088-068-181-111.088.068.pools.vodafone-ip.de [88.68.181.111]) (Authenticated sender: forum@alexander.shukaev.name) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id A58A040493 for ; Tue, 13 Dec 2016 01:59:34 +0100 (CET) From: Alexander Shukaev Message-ID: Date: Tue, 13 Dec 2016 01:59:34 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, consider (defsubst recentf-menu-bar () "Return the keymap of the global menu bar." (lookup-key global-map [menu-bar])) (defun recentf-show-menu () "Show the menu of recently opened files." (easy-menu-add-item (recentf-menu-bar) recentf-menu-path (list recentf-menu-title :filter 'recentf-make-menu-items) recentf-menu-before)) (defun recentf-hide-menu () "Hide the menu of recently opened files." (easy-menu-remove-item (recentf-menu-bar) recentf-menu-path recentf-menu-title)) from 'recentf.el'. This code is ill-formed. When `global-map' is customized in such a way that it does not have `(kbd "")' (or `[menu-bar]'), then both `recentf-show-menu' and `recentf-hide-menu' will fail. Furthermore, according to Emacs documentation, using `(current-global-map)' is more correct than `global-map'. Looking forward to fix. Regards, Alexander From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 04 01:30:41 2017 Received: (at control) by debbugs.gnu.org; 4 Dec 2017 06:30:42 +0000 Received: from localhost ([127.0.0.1]:44204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLkH3-00048n-Ni for submit@debbugs.gnu.org; Mon, 04 Dec 2017 01:30:41 -0500 Received: from mail-it0-f43.google.com ([209.85.214.43]:39661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eLkH1-00046y-T6 for control@debbugs.gnu.org; Mon, 04 Dec 2017 01:30:40 -0500 Received: by mail-it0-f43.google.com with SMTP id 68so4006036ite.4 for ; Sun, 03 Dec 2017 22:30:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=HCziABK8ebNMfltADQ75ov0yqgDKj9dPT3LNXmmbB5g=; b=EdPVAiKeO/J4O6aPceS9z/WmZQWSryjhQkmVYe4l7YbJzEbPJLHKVmC0+4DkY91dCV y3n4JHl7Iv3r5eeL9P8cQQVYdhIThUw4HJybjwoPUBCs9hMOWd8lyjZx5kIrZnZvC37R 6mCcCYiVC+ZztJCpHNHpghidW0exSgX6b9KmFNqRmgjnOxD1qRlGtIgbkzhLfVczUZaI jXujUZOU2opkUwAWw8Ei3ewl+Hk46WMc5CT/8b6E29uJNBEdbWy2xOit5ZDPX3iG1nqd +JyMvZj9rngUCYxP9N2D4TPPKepDIstMHP9OTxdfVyahwZfW+Uy7uuHsUovK0StLT+Uf eo8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=HCziABK8ebNMfltADQ75ov0yqgDKj9dPT3LNXmmbB5g=; b=dcxD1eZyPwuVw9wtcDKpj9kV/tsSr7tbPazvdbI4ilP9woSXYeGKGgdCPEDk6kx954 9uHv0IvhBt2/Zu2s1thmAggHPK9CNFKtFCKlW4bldvpZqcmKCg/CXASjxGQppDOP5pvk xX2ATvnc652WcZlbh6L94B1a+BDBt6Nsz6bPWLx9yK2NYUP9ugfnOjxIMTJF0GP5QIBW OPOck5CaaPakLsWBPe+Lcv3iBML4xBbt34Y1IN/KG6Bz54A30MyEKaerMiJHl9xTfi7/ s1WcR25IuuLJAtHMkEcWYqOz0RXHfbBiTIwSDcfjfCqRVJVhVht/hHiAVLqizxLxlar/ TbzA== X-Gm-Message-State: AKGB3mIPBafioiwXJqtA6m6RO0T1AK2GzpA4F4reu7yFH0yHxXXYk6ir 8CpN3srugaJGLkQeL9aVhTALDg== X-Google-Smtp-Source: AGs4zMaAkNTQyoZRrh2vnOjzrFaAcsfsmPSs8mw3mW6y9s89+NOQn/iILx5LgHb+GGB9C3z1W+rJDA== X-Received: by 10.36.207.132 with SMTP id y126mr3100565itf.132.1512369034296; Sun, 03 Dec 2017 22:30:34 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id k3sm5661917iok.61.2017.12.03.22.30.33 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Dec 2017 22:30:33 -0800 (PST) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #25191 Date: Mon, 04 Dec 2017 01:30:32 -0500 Message-ID: <87r2sbgg3b.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) retitle 25191 `recentf-menu-bar' assumes [menu-bar] is bound in global-map quit From unknown Mon Aug 18 14:22:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25191: Redesign `recentf-menu-bar' logic and its callers Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25191 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alexander Shukaev Cc: 25191@debbugs.gnu.org Received: via spool by 25191-submit@debbugs.gnu.org id=B25191.157060718410708 (code B ref 25191); Wed, 09 Oct 2019 07:47:01 +0000 Received: (at 25191) by debbugs.gnu.org; 9 Oct 2019 07:46:24 +0000 Received: from localhost ([127.0.0.1]:52027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6fu-0002kI-Hm for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6ft-0002iY-5f for 25191@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:21 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6fo-0004ZZ-Tk; Wed, 09 Oct 2019 09:46:19 +0200 From: Lars Ingebrigtsen References: Date: Wed, 09 Oct 2019 09:46:16 +0200 In-Reply-To: (Alexander Shukaev's message of "Tue, 13 Dec 2016 01:59:34 +0100") Message-ID: <87v9sypdiv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alexander Shukaev writes: > (defsubst recentf-menu-bar () > "Return the keymap of the global menu bar." > (lookup-key global-map [menu-bar])) > > (defun recentf-show-menu () > "Show the menu of recently opened files." > (easy- [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alexander Shukaev writes: > (defsubst recentf-menu-bar () > "Return the keymap of the global menu bar." > (lookup-key global-map [menu-bar])) > > (defun recentf-show-menu () > "Show the menu of recently opened files." > (easy-menu-add-item > (recentf-menu-bar) recentf-menu-path > (list recentf-menu-title :filter 'recentf-make-menu-items) > recentf-menu-before)) > > (defun recentf-hide-menu () > "Hide the menu of recently opened files." > (easy-menu-remove-item (recentf-menu-bar) recentf-menu-path > recentf-menu-title)) > > from 'recentf.el'. This code is ill-formed. When `global-map' is > customized in such a way that it does not have `(kbd "")' > (or `[menu-bar]'), then both `recentf-show-menu' and > `recentf-hide-menu' will fail. I've now added checks to protect against this in Emacs 27. > Furthermore, according to Emacs documentation, using > `(current-global-map)' is more correct than `global-map'. That's true, but I think fixing that is more a matter of somebody grepping and replacing rather than fixing piecemeal, perhaps... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 03:46:31 2019 Received: (at control) by debbugs.gnu.org; 9 Oct 2019 07:46:31 +0000 Received: from localhost ([127.0.0.1]:52030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6g2-0002sF-Ra for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:31 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6g0-0002p1-1g for control@debbugs.gnu.org; Wed, 09 Oct 2019 03:46:29 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6fx-0004Zi-AS for control@debbugs.gnu.org; Wed, 09 Oct 2019 09:46:27 +0200 Date: Wed, 09 Oct 2019 09:46:24 +0200 Message-Id: <87tv8ipdin.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #25191 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 25191 fixed close 25191 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25191 fixed close 25191 27.1 quit