From unknown Mon Aug 18 17:54:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25190: Initialization of `dired-mode-map' in by the `dired-x' feature is not safe Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2016 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25190@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1481590368303 (code B ref -1); Tue, 13 Dec 2016 00:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Dec 2016 00:52:48 +0000 Received: from localhost ([127.0.0.1]:39799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGbKp-0008WU-Vb for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:52:48 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGbKo-0008WH-K3 for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:52:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGbKi-0002O1-Kd for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:52:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50979) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGbKi-0002Nx-Hd for submit@debbugs.gnu.org; Mon, 12 Dec 2016 19:52:40 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGbKh-0004Q0-C2 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 19:52:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGbKe-0002NX-8L for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 19:52:39 -0500 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:55352) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGbKd-0002NH-Uj for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 19:52:36 -0500 Received: from mfilter10-d.gandi.net (mfilter10-d.gandi.net [217.70.178.139]) by relay6-d.mail.gandi.net (Postfix) with ESMTP id A22C4FB883 for ; Tue, 13 Dec 2016 01:52:33 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter10-d.gandi.net Received: from relay6-d.mail.gandi.net ([IPv6:::ffff:217.70.183.198]) by mfilter10-d.gandi.net (mfilter10-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id Rp07QhxYiEAP for ; Tue, 13 Dec 2016 01:52:32 +0100 (CET) X-Originating-IP: 88.68.181.111 Received: from [192.168.3.110] (dslb-088-068-181-111.088.068.pools.vodafone-ip.de [88.68.181.111]) (Authenticated sender: forum@alexander.shukaev.name) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 35442FB87D for ; Tue, 13 Dec 2016 01:52:32 +0100 (CET) From: Alexander Shukaev Message-ID: Date: Tue, 13 Dec 2016 01:52:31 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, consider the two ;;; KEY BINDINGS. (define-key dired-mode-map "\C-x\M-o" 'dired-omit-mode) (define-key dired-mode-map "*O" 'dired-mark-omitted) (define-key dired-mode-map "\M-(" 'dired-mark-sexp) (define-key dired-mode-map "*(" 'dired-mark-sexp) (define-key dired-mode-map "*." 'dired-mark-extension) (define-key dired-mode-map "\M-!" 'dired-smart-shell-command) (define-key dired-mode-map "\M-G" 'dired-goto-subdir) (define-key dired-mode-map "F" 'dired-do-find-marked-files) (define-key dired-mode-map "Y" 'dired-do-relsymlink) (define-key dired-mode-map "%Y" 'dired-do-relsymlink-regexp) (define-key dired-mode-map "V" 'dired-do-run-mail) ;;; MENU BINDINGS (require 'easymenu) (let ((menu (lookup-key dired-mode-map [menu-bar]))) (easy-menu-add-item menu '("Operate") ["Find Files" dired-do-find-marked-files :help "Find current or marked files"] "Shell Command...") (easy-menu-add-item menu '("Operate") ["Relative Symlink to..." dired-do-relsymlink :visible (fboundp 'make-symbolic-link) :help "Make relative symbolic links for current or \ marked files"] "Hardlink to...") (easy-menu-add-item menu '("Mark") ["Flag Extension..." dired-flag-extension :help "Flag files with a certain extension for deletion"] "Mark Executables") (easy-menu-add-item menu '("Mark") ["Mark Extension..." dired-mark-extension :help "Mark files with a certain extension"] "Unmark All") (easy-menu-add-item menu '("Mark") ["Mark Omitted" dired-mark-omitted :help "Mark files matching `dired-omit-files' \ and `dired-omit-extensions'"] "Unmark All") (easy-menu-add-item menu '("Regexp") ["Relative Symlink..." dired-do-relsymlink-regexp :visible (fboundp 'make-symbolic-link) :help "Make relative symbolic links for files \ matching regexp"] "Hardlink...") (easy-menu-add-item menu '("Immediate") ["Omit Mode" dired-omit-mode :style toggle :selected dired-omit-mode :help "Enable or disable omitting \"uninteresting\" \ files"] "Refresh")) sections. Both can easily fail. For instance, (define-key dired-mode-map "%Y" 'dired-do-relsymlink-regexp) assumes that the "%" prefix command has been defined in `dired-mode-map' which is not at all true for any customization. The `easy-menu-add-item' calls suffers from similar issue. It should be possible to conditionally disable these code sections or even remove them altogether as they are maldesigned. Looking forward to fix. P.S. Just a side question: why `dired-x' is not yet merged into `dired'? IMO, makes no sense to maintain separate extension packages of the main package when they are already built-in anyway. Regards, Alexander From unknown Mon Aug 18 17:54:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25190: Initialization of `dired-mode-map' in by the `dired-x' feature is not safe Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2016 02:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alexander Shukaev Cc: 25190@debbugs.gnu.org Received: via spool by 25190-submit@debbugs.gnu.org id=B25190.14815955388269 (code B ref 25190); Tue, 13 Dec 2016 02:19:02 +0000 Received: (at 25190) by debbugs.gnu.org; 13 Dec 2016 02:18:58 +0000 Received: from localhost ([127.0.0.1]:39883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGcgD-00029J-Qu for submit@debbugs.gnu.org; Mon, 12 Dec 2016 21:18:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGcgC-000297-9z for 25190@debbugs.gnu.org; Mon, 12 Dec 2016 21:18:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGcg6-00030x-Cr for 25190@debbugs.gnu.org; Mon, 12 Dec 2016 21:18:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGcg4-00030a-A7; Mon, 12 Dec 2016 21:18:48 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cGcg3-0004HT-UB; Mon, 12 Dec 2016 21:18:47 -0500 From: Glenn Morris References: X-Spook: terrorist rs9512c PET fundamentalist mania Brown out Pipe X-Ran: [CeCEhv,E7b/g?|G/mg"t[zK|*JT%6d~@ptA|v"38h7E=KCoQHFbJ^4/<]WK-1Z(X&f_~0 X-Hue: blue X-Attribution: GM Date: Mon, 12 Dec 2016 21:18:47 -0500 In-Reply-To: (Alexander Shukaev's message of "Tue, 13 Dec 2016 01:52:31 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.1 (--------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.1 (--------) Alexander Shukaev wrote: > P.S. Just a side question: why `dired-x' is not yet merged into > dired'? Since dired-x hasn't changed qualitatively in 5 years, neither has my answer to this question. :) http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00718.html (Just IMO.) From unknown Mon Aug 18 17:54:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25190: Initialization of `dired-mode-map' in by the `dired-x' feature is not safe Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2016 03:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris , Alexander Shukaev Cc: 25190@debbugs.gnu.org Received: via spool by 25190-submit@debbugs.gnu.org id=B25190.148159830619209 (code B ref 25190); Tue, 13 Dec 2016 03:06:02 +0000 Received: (at 25190) by debbugs.gnu.org; 13 Dec 2016 03:05:06 +0000 Received: from localhost ([127.0.0.1]:39938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGdOs-0004zl-Fq for submit@debbugs.gnu.org; Mon, 12 Dec 2016 22:05:06 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:40510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGdOq-0004zE-UQ for 25190@debbugs.gnu.org; Mon, 12 Dec 2016 22:05:05 -0500 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uBD34sen010989 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Dec 2016 03:04:55 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uBD34sC4019681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Dec 2016 03:04:54 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id uBD34rwX026907; Tue, 13 Dec 2016 03:04:53 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 12 Dec 2016 19:04:48 -0800 (PST) From: Drew Adams References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) > > P.S. Just a side question: why `dired-x' is not yet merged into > > dired'? >=20 > Since dired-x hasn't changed qualitatively in 5 years, neither has my > answer to this question. :) >=20 > http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00718.html > (Just IMO.) Yes, well, those (such as Glenn and Stefan) in that thread who claimed to want to keep only a bit of dired-x and toss the rest, claiming that it is only "cruft" are also people who have admitted that they hardly, if ever, use Dired. There are plenty of other people, myself included, who use not only dired.el but dired-x.el and dired-aux.el, all the time. I don't think it's useful to rehash the previous thread, which went nowhere, and certainly not here, in a bug thread that is not related. But we should not particularly be listening to non-users of Dired about tossing parts of it out. (Just IMO.) From unknown Mon Aug 18 17:54:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25190: Initialization of `dired-mode-map' in by the `dired-x' feature is not safe Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Alexander Shukaev Cc: 25190@debbugs.gnu.org Received: via spool by 25190-submit@debbugs.gnu.org id=B25190.15706068675387 (code B ref 25190); Wed, 09 Oct 2019 07:42:01 +0000 Received: (at 25190) by debbugs.gnu.org; 9 Oct 2019 07:41:07 +0000 Received: from localhost ([127.0.0.1]:52017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6ap-0001Op-IU for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:41:07 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6ao-0001Og-7R for 25190@debbugs.gnu.org; Wed, 09 Oct 2019 03:41:06 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6ak-0004Xh-NY; Wed, 09 Oct 2019 09:41:05 +0200 From: Lars Ingebrigtsen References: Date: Wed, 09 Oct 2019 09:41:02 +0200 In-Reply-To: (Alexander Shukaev's message of "Tue, 13 Dec 2016 01:52:31 +0100") Message-ID: <871rvmqsc1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alexander Shukaev writes: > consider the two > > ; ; ; KEY BINDINGS. > > (define-key dired-mode-map "\C-x\M-o" 'dired-omit-mode) > (define-key dired-mode-map "*O" 'dired-mark-omitted) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alexander Shukaev writes: > consider the two > > ;;; KEY BINDINGS. > > (define-key dired-mode-map "\C-x\M-o" 'dired-omit-mode) > (define-key dired-mode-map "*O" 'dired-mark-omitted) [...] > sections. Both can easily fail. For instance, > > (define-key dired-mode-map "%Y" 'dired-do-relsymlink-regexp) > > assumes that the "%" prefix command has been defined in > `dired-mode-map' which is not at all true for any customization. The > `easy-menu-add-item' calls suffers from similar issue. It should be > possible to conditionally disable these code sections or even remove > them altogether as they are maldesigned. I've now added some checks to Emacs 27 to ensure that dired-x doesn't try to define keys in sub-keymaps that doesn't exist. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 03:41:13 2019 Received: (at control) by debbugs.gnu.org; 9 Oct 2019 07:41:13 +0000 Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6au-0001P9-RJ for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:41:13 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6at-0001P0-70 for control@debbugs.gnu.org; Wed, 09 Oct 2019 03:41:11 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6aq-0004Xq-FU for control@debbugs.gnu.org; Wed, 09 Oct 2019 09:41:10 +0200 Date: Wed, 09 Oct 2019 09:41:08 +0200 Message-Id: <87zhiapdrf.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #25190 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 25190 fixed close 25190 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25190 fixed close 25190 27.1 quit