From unknown Sun Sep 07 13:36:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25188: Initialization of `global-edebug-map' is not safe Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2016 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25188@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148158632526465 (code B ref -1); Mon, 12 Dec 2016 23:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2016 23:45:25 +0000 Received: from localhost ([127.0.0.1]:39742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaHd-0006sn-2p for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaHc-0006sb-61 for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGaHW-0002oM-5k for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40599) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGaHW-0002oA-2h for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:45:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGaHU-0005jo-T4 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:45:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGaHQ-0002n1-Uh for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:45:16 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:50652) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGaHQ-0002mY-OY for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:45:12 -0500 Received: from mfilter12-d.gandi.net (mfilter12-d.gandi.net [217.70.178.129]) by relay8-d.mail.gandi.net (Postfix) with ESMTP id 2865340496 for ; Tue, 13 Dec 2016 00:45:10 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter12-d.gandi.net Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by mfilter12-d.gandi.net (mfilter12-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 4m63UJklSDLk for ; Tue, 13 Dec 2016 00:45:08 +0100 (CET) X-Originating-IP: 88.68.181.111 Received: from [192.168.3.110] (dslb-088-068-181-111.088.068.pools.vodafone-ip.de [88.68.181.111]) (Authenticated sender: forum@alexander.shukaev.name) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 6FD3C40406 for ; Tue, 13 Dec 2016 00:45:08 +0100 (CET) From: Alexander Shukaev Message-ID: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> Date: Tue, 13 Dec 2016 00:45:07 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, first of all, in 'edebug.el', the ;; If you wish to change the default edebug global command prefix, change: ;; (setq edebug-global-prefix "\C-xX") is invalid because the name of the variable is actually `global-edebug-prefix'. But that's just a minor point. Consider (defvar global-edebug-map (let ((map (make-sparse-keymap))) (define-key map " " 'edebug-step-mode) (define-key map "g" 'edebug-go-mode) (define-key map "G" 'edebug-Go-nonstop-mode) (define-key map "t" 'edebug-trace-mode) (define-key map "T" 'edebug-Trace-fast-mode) (define-key map "c" 'edebug-continue-mode) (define-key map "C" 'edebug-Continue-fast-mode) ;; breakpoints (define-key map "b" 'edebug-set-breakpoint) (define-key map "u" 'edebug-unset-breakpoint) (define-key map "x" 'edebug-set-conditional-breakpoint) (define-key map "X" 'edebug-set-global-break-condition) ;; views (define-key map "w" 'edebug-where) (define-key map "W" 'edebug-toggle-save-windows) ;; quitting (define-key map "q" 'top-level) (define-key map "Q" 'edebug-top-level-nonstop) (define-key map "a" 'abort-recursive-edit) ;; statistics (define-key map "=" 'edebug-display-freq-count) map) "Global map of edebug commands, available from any buffer.") (global-unset-key global-edebug-prefix) (global-set-key global-edebug-prefix global-edebug-map) and imagine that somebody has customized `global-map' in such a way that it has no "\C-x" prefix command at all. Then of course the above code will fail. Furthermore, if one does not want to pollute the `global-map' with `global-edebug-map', one cannot simply set `global-edebug-prefix' to nil because this would also fail. I believe `global-edebug-map' should support the nil value which would mean that the above code is disabled completely. Looking forward to fix. Regards, Alexander From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 20:35:24 2017 Received: (at control) by debbugs.gnu.org; 12 Jun 2017 00:35:24 +0000 Received: from localhost ([127.0.0.1]:41614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKDKG-0006T7-JO for submit@debbugs.gnu.org; Sun, 11 Jun 2017 20:35:24 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:35517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKDKF-0006Su-EV for control@debbugs.gnu.org; Sun, 11 Jun 2017 20:35:23 -0400 Received: by mail-io0-f179.google.com with SMTP id k93so49392965ioi.2 for ; Sun, 11 Jun 2017 17:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=OagI+jqpn9D7czKGVm1rzS8zC55mSlH2k1ibeJnYDfk=; b=dv+A7i26KNI6FIh4DKCMlxBVq42I2wKbpVdLMDuzfkyu1EwCm0DbWnMe00uVz+CpMb 3MVdyPgtvHsBWHNEWNQQSoJW8Je6mLvg2nUZum1eGVTc/3nPRwia0x3xCviWbXLCr0ac gRF4It39rSpsRH7Y/j6godzQTMsMqAv2udCjsKaVCU+gtz6z0fi/BYj90AnuwbGOO7qG mIeX/JPWsUMGR/icKjuiQum3DAfQ6MQpCbyFg3aOhBZdrXx72uCW4OOVpgymhaSCKauO uAbQKQ03lSZFfEXH0V3PzLTIotzrw4KAvvmZyjkVcO0hFMiCbjbY7PoZd/NyQJmxqH0u Jb+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=OagI+jqpn9D7czKGVm1rzS8zC55mSlH2k1ibeJnYDfk=; b=uVeNMXyC+rgjELa/ou4PYiK+M4X+kUXZdMm5W3weTzQFcu1mtX412yz8NLwY/cwDmE 4BWh2uLeRlcQjXc43V8rUTuO3x8uUY3joV4kl1jjPrM3ehVQqceEB+yDAD5kMgi9sRm4 xkr622n7yIh28Cn4t/umFMEsCzJI6eX4llvcyEpjC9TcPvtjgokxdpO/oy2zU1YAggT5 2vttuY0UzucCaPKkfMKETmwyPteWXdqdKkbyt1VIPkrwnTHk4pek2xfZseM/r+8cLD1z /Jw399mEwAcNhiun7AbgEgrqhOhRGPcyS+D1w2ftkio/DZmcOHR4++8KyjleH/itfEaM Az2Q== X-Gm-Message-State: AODbwcCDyW6FU2SzLZcfiNaZG/M1QkdVQHVnRNvJ50UNbV1nDYNfF93z M7dNs3N+J7qdU3n/ X-Received: by 10.107.189.199 with SMTP id n190mr49133118iof.95.1497227717882; Sun, 11 Jun 2017 17:35:17 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g67sm822697iof.9.2017.06.11.17.35.16 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 17:35:17 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #25188 Date: Sun, 11 Jun 2017 20:36:54 -0400 Message-ID: <8737b6ujmh.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25188 + easy quit From unknown Sun Sep 07 13:36:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25188: Initialization of `global-edebug-map' is not safe Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy To: Alexander Shukaev Cc: 25188@debbugs.gnu.org Received: via spool by 25188-submit@debbugs.gnu.org id=B25188.157060607628649 (code B ref 25188); Wed, 09 Oct 2019 07:28:01 +0000 Received: (at 25188) by debbugs.gnu.org; 9 Oct 2019 07:27:56 +0000 Received: from localhost ([127.0.0.1]:52006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6O3-0007S1-Ss for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:27:56 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6O1-0007Rr-Qo for 25188@debbugs.gnu.org; Wed, 09 Oct 2019 03:27:54 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6Ny-0004Pe-I4; Wed, 09 Oct 2019 09:27:52 +0200 From: Lars Ingebrigtsen References: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> Date: Wed, 09 Oct 2019 09:27:50 +0200 In-Reply-To: <4f637d8d-29c0-d6cb-6e7e-824bdb173601@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 13 Dec 2016 00:45:07 +0100") Message-ID: <877e5eqsy1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alexander Shukaev writes: > (global-unset-key global-edebug-prefix) > (global-set-key global-edebug-prefix global-edebug-map) > > and imagine that somebody has customized `global-map' in such a way > that it has no "\C-x" pref [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alexander Shukaev writes: > (global-unset-key global-edebug-prefix) > (global-set-key global-edebug-prefix global-edebug-map) > > and imagine that somebody has customized `global-map' in such a way > that it has no "\C-x" prefix command at all. Then of course the above > code will fail. Furthermore, if one does not want to pollute the > `global-map' with `global-edebug-map', one cannot simply set > `global-edebug-prefix' to nil because this would also fail. I believe > `global-edebug-map' should support the nil value which would mean that > the above code is disabled completely. I've now made it check whether global-edebug-prefix is nil before using in Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 03:28:02 2019 Received: (at control) by debbugs.gnu.org; 9 Oct 2019 07:28:02 +0000 Received: from localhost ([127.0.0.1]:52010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6OA-0007Sc-Ae for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:28:02 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56156) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6O7-0007SC-RB for control@debbugs.gnu.org; Wed, 09 Oct 2019 03:28:00 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6O5-0004Pm-4i for control@debbugs.gnu.org; Wed, 09 Oct 2019 09:27:59 +0200 Date: Wed, 09 Oct 2019 09:27:56 +0200 Message-Id: <875zkyqsxv.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #25188 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 25188 fixed close 25188 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25188 fixed close 25188 27.1 quit