From unknown Sat Sep 06 14:23:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25187: Initialization of `shell-mode-map' is not safe Resent-From: Alexander Shukaev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2016 23:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25187 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25187@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148158435423560 (code B ref -1); Mon, 12 Dec 2016 23:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Dec 2016 23:12:34 +0000 Received: from localhost ([127.0.0.1]:39731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGZlq-00067w-C2 for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:12:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGZi6-00062H-7r for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:08:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZi0-0001yg-6l for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:08:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34742) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGZi0-0001yc-35 for submit@debbugs.gnu.org; Mon, 12 Dec 2016 18:08:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZhy-0006wx-V6 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:08:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZhv-0001xm-Pi for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:08:34 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:56565) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGZhv-0001xT-K3 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2016 18:08:31 -0500 Received: from mfilter36-d.gandi.net (mfilter36-d.gandi.net [217.70.178.167]) by relay7-d.mail.gandi.net (Postfix) with ESMTP id 47CE4B82 for ; Tue, 13 Dec 2016 00:08:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter36-d.gandi.net Received: from relay7-d.mail.gandi.net ([IPv6:::ffff:217.70.183.200]) by mfilter36-d.gandi.net (mfilter36-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id xLoW0a4sDkc7 for ; Tue, 13 Dec 2016 00:08:26 +0100 (CET) X-Originating-IP: 88.68.181.111 Received: from [192.168.3.110] (dslb-088-068-181-111.088.068.pools.vodafone-ip.de [88.68.181.111]) (Authenticated sender: forum@alexander.shukaev.name) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id D1D88298 for ; Tue, 13 Dec 2016 00:08:25 +0100 (CET) From: Alexander Shukaev Message-ID: <49c53840-659f-5e60-a1d9-161a7e1d8004@Alexander.Shukaev.name> Date: Tue, 13 Dec 2016 00:08:07 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Mon, 12 Dec 2016 18:12:33 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, consider (defvar shell-mode-map (let ((map (nconc (make-sparse-keymap) comint-mode-map))) (define-key map "\C-c\C-f" 'shell-forward-command) (define-key map "\C-c\C-b" 'shell-backward-command) (define-key map "\t" 'completion-at-point) (define-key map (kbd "M-RET") 'shell-resync-dirs) (define-key map "\M-?" 'comint-dynamic-list-filename-completions) (define-key map [menu-bar completion] (cons "Complete" (copy-keymap (lookup-key comint-mode-map [menu-bar completion])))) (define-key-after (lookup-key map [menu-bar completion]) [complete-env-variable] '("Complete Env. Variable Name" . shell-dynamic-complete-environment-variable) 'complete-file) (define-key-after (lookup-key map [menu-bar completion]) [expand-directory] '("Expand Directory Reference" . shell-replace-by-expanded-directory) 'complete-expand) map)) from 'shell.el'. When somebody decides to customize `comint-mode-map' by, for example, first wiping it out and then filling it again, (with-eval-after-load 'comint ;; Wipe `comint-mode-map': (setcdr comint-mode-map nil) ;; Fill `comint-mode-map': ...) then when the `shell' feature is loaded, it will inevitably fail because `(lookup-key comint-mode-map [menu-bar completion])' may no longer return a keymap but rather nil or a number. Looking forward for fix. Regards, Alexander From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 20:33:52 2017 Received: (at control) by debbugs.gnu.org; 12 Jun 2017 00:33:52 +0000 Received: from localhost ([127.0.0.1]:41609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKDIm-0006QJ-Al for submit@debbugs.gnu.org; Sun, 11 Jun 2017 20:33:52 -0400 Received: from mail-it0-f48.google.com ([209.85.214.48]:38836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKDIk-0006Q7-Rr for control@debbugs.gnu.org; Sun, 11 Jun 2017 20:33:51 -0400 Received: by mail-it0-f48.google.com with SMTP id l6so6499527iti.1 for ; Sun, 11 Jun 2017 17:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=MLi50SBuj8sNtVvmN2+Lanq3tkBFBxkylLjuzJu490c=; b=WNg35zy8KAv7QpjeFs+IqSJW2/GnCQ9kzGC8uheX2YlS7vLqWgvQt1WOvctBvsaHQy bsQ2i6SQiC012Jq4E/s910JCjfiJOO2AqJu8tN86Pc7HB7Tz7PfTZhHbR6JYENrTHFbv nMQaFqCQjxvFTyYN7zlEeX7tdNaaFAIJ6axrMJkE64TnIQKddxq73XM/X1iZ64X6iJAb W1Y1Pw9kEUywR37XA/XLF/EiNQHV3mETlPguLoglm0RLUBsWYsD15NCQI96hGzA9/nLD NFzZjwpHxvHNhiIe7oYCMOE5UZ+3nRqcw0BBWlylavkVroq069PNg3xgtiAg0kPyaN9H hnGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=MLi50SBuj8sNtVvmN2+Lanq3tkBFBxkylLjuzJu490c=; b=L/XDysR+brOOclGiUJ63ljMPv7ZFOyRQpffPJPVoOzXAEqRlhfxi947GLG4bUIck+/ bVzIfu9LmKlXxdrZSNpLdoQPgwIIqUEvP5xRxGrpYAYIQMuO9D/REngnanlvAojlODOU rPV9GO03dD9rYy3PpkjsAXlLIhaOApiNg3fvQXpYelJUy+4mxjvPgbgoMnToIlYMcYqM 27in7fAUyHnluBTEOhmwPhDaG/P/7fQ6iBbJgRPFiRUZSMztyKIdnlx21mHEjgzSNmC7 0ornc+ji7t/vCDHTO9mEin23fjtAEQszflJuVg3cc7UJeM55nujAo5cRhpwHjpknPZKk +/5g== X-Gm-Message-State: AODbwcAVQ/A2Y/Kt7YLyyHYWV6Pws4R0soSiVKebgn70y2yDvOSLxxgK NepVpbWhcXNvFENO X-Received: by 10.36.222.194 with SMTP id d185mr9722539itg.111.1497227625123; Sun, 11 Jun 2017 17:33:45 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n3sm3699428itg.3.2017.06.11.17.33.43 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 17:33:44 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #25187 Date: Sun, 11 Jun 2017 20:35:21 -0400 Message-ID: <874lvmujp2.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) # should just use parent keymap, also maybe check if keymapp tags 25187 + easy quit From unknown Sat Sep 06 14:23:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25187: Initialization of `shell-mode-map' is not safe Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25187 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy To: Alexander Shukaev Cc: 25187@debbugs.gnu.org Received: via spool by 25187-submit@debbugs.gnu.org id=B25187.157060586128297 (code B ref 25187); Wed, 09 Oct 2019 07:25:02 +0000 Received: (at 25187) by debbugs.gnu.org; 9 Oct 2019 07:24:21 +0000 Received: from localhost ([127.0.0.1]:51996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6Ka-0007ML-VP for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:24:21 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6KZ-0007MB-5d for 25187@debbugs.gnu.org; Wed, 09 Oct 2019 03:24:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6KV-0004M9-HM; Wed, 09 Oct 2019 09:24:17 +0200 From: Lars Ingebrigtsen References: <49c53840-659f-5e60-a1d9-161a7e1d8004@Alexander.Shukaev.name> Date: Wed, 09 Oct 2019 09:24:15 +0200 In-Reply-To: <49c53840-659f-5e60-a1d9-161a7e1d8004@Alexander.Shukaev.name> (Alexander Shukaev's message of "Tue, 13 Dec 2016 00:08:07 +0100") Message-ID: <87d0f6qt40.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alexander Shukaev writes: > consider > > (defvar shell-mode-map > (let ((map (nconc (make-sparse-keymap) comint-mode-map))) [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Alexander Shukaev writes: > consider > > (defvar shell-mode-map > (let ((map (nconc (make-sparse-keymap) comint-mode-map))) [...] > from 'shell.el'. When somebody decides to customize `comint-mode-map' > by, for example, first wiping it out and then filling it again, > > (with-eval-after-load 'comint > ;; Wipe `comint-mode-map': > (setcdr comint-mode-map nil) > ;; Fill `comint-mode-map': > ...) > > then when the `shell' feature is loaded, it will inevitably fail > because `(lookup-key comint-mode-map [menu-bar completion])' may no > longer return a keymap but rather nil or a number. I've now fixed this in Emacs 27 by just removing the nconc from the shell mode map -- shell-mode is derived from comint-mode, so it automatically inherits its map. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 09 03:24:26 2019 Received: (at control) by debbugs.gnu.org; 9 Oct 2019 07:24:26 +0000 Received: from localhost ([127.0.0.1]:51999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6Kg-0007Mf-AI for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:24:26 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6Ke-0007MV-En for control@debbugs.gnu.org; Wed, 09 Oct 2019 03:24:24 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6Kb-0004MI-MW for control@debbugs.gnu.org; Wed, 09 Oct 2019 09:24:23 +0200 Date: Wed, 09 Oct 2019 09:24:21 +0200 Message-Id: <87bluqqt3u.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #25187 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 25187 fixed close 25187 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 25187 fixed close 25187 27.1 quit