GNU bug report logs - #25157
26.0.50; whitespace-cleanup does not remove single trailing empty line anymore

Previous Next

Package: emacs;

Reported by: Mark Karpov <markkarpov <at> openmailbox.org>

Date: Sat, 10 Dec 2016 14:43:02 UTC

Severity: normal

Tags: confirmed, fixed

Found in version 26.0.50

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

Message #41 received at control <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: Mark Karpov <markkarpov <at> openmailbox.org>, 25157 <at> debbugs.gnu.org
Subject: Re: bug#25157: 26.0.50;
 whitespace-cleanup does not remove single trailing empty line anymore
Date: Sat, 24 Dec 2016 10:34:50 -0500

tags 25157 fixed
close 25157 26.1
quit

Reuben Thomas <rrt <at> sc3d.org> writes:

>  >>
>  >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
>  >> is the call of re-search-forward.
>  >>
>  >> I'm not sure this is a sufficient explanation of why save-match-data is
>  >> needed. Usually in Emacs the caller is responsible for saving the match
>  >> data, if it needs to. I don't really see the need here.
>  >
>  > Can it be removed then?
>
>  Probably yes.
>
> ​Great; can you then install a suitable patch, please?

I've pushed the first patch as cf5417f02887 "Fix whitespace eob
cleanup", removed save-match-data in da52e939aa26 "Remove redundant
`save-match-data' in whitespace.el".
This bug report was last modified 8 years and 200 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.