GNU bug report logs - #25157
26.0.50; whitespace-cleanup does not remove single trailing empty line anymore

Previous Next

Full log

View this message in rfc822 format

From: Reuben Thomas <rrt <at> sc3d.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: Mark Karpov <markkarpov <at> openmailbox.org>, 25157 <at> debbugs.gnu.org
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Fri, 23 Dec 2016 10:44:54 +0000

[Message part 1 (text/plain, inline)]

On 23 December 2016 at 00:03, <npostavs <at> users.sourceforge.net> wrote:

> Reuben Thomas <rrt <at> sc3d.org> writes:
>
> > On Dec 22, 2016 2:17 AM, <npostavs <at> users.sourceforge.net> wrote:
> >> >
> >> > The only thing I'd change in your match is, as in mine, remove the
> FIXME after save-match-data.​
> >>
> >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
> >> is the call of re-search-forward.
> >>
> >> I'm not sure this is a sufficient explanation of why save-match-data is
> >> needed. Usually in Emacs the caller is responsible for saving the match
> >> data, if it needs to. I don't really see the need here.
> >
> > Can it be removed then?
>
> Probably yes.


​Great; can you then install a suitable patch, please?

-- 
http://rrt.sc3d.org

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.