GNU bug report logs - #25157
26.0.50; whitespace-cleanup does not remove single trailing empty line anymore

Previous Next

Full log

Message #31 received at 25157 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Reuben Thomas <rrt <at> sc3d.org>
Cc: Mark Karpov <markkarpov <at> openmailbox.org>, 25157 <at> debbugs.gnu.org
Subject: Re: bug#25157: 26.0.50;
 whitespace-cleanup does not remove single trailing empty line anymore
Date: Thu, 22 Dec 2016 19:03:53 -0500

Reuben Thomas <rrt <at> sc3d.org> writes:

> On Dec 22, 2016 2:17 AM, <npostavs <at> users.sourceforge.net> wrote:
>> >
>> > The only thing I'd change in your match is, as in mine, remove the FIXME after save-match-data.​
>>
>> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
>> is the call of re-search-forward.
>>
>> I'm not sure this is a sufficient explanation of why save-match-data is
>> needed. Usually in Emacs the caller is responsible for saving the match
>> data, if it needs to. I don't really see the need here.
>
> Can it be removed then?

Probably yes.

> The only perhaps unexpected thing I can think of is that whitespace-cleanup can be called from a hook, such as save-file-hook, but that
> doesn't seem to matter.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.