GNU bug report logs - #25128
Reorder lisp.h to declare types before using them

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#25128: closed (Reorder lisp.h to declare types before using them)
Date: Sun, 25 Dec 2016 17:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 25 Dec 2016 09:38:14 -0800
with message-id <79183a94-7a2c-18a2-9fa6-e2e4ead47ab9 <at> cs.ucla.edu>
and subject line Re: bug#25128: Reorder lisp.h to declare types before using them
has caused the debbugs.gnu.org bug report #25128,
regarding Reorder lisp.h to declare types before using them
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
25128: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25128
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Emacs bug reports and feature requests <bug-gnu-emacs <at> gnu.org>
Subject: Reorder lisp.h to declare types before using them
Date: Tue, 6 Dec 2016 23:19:19 -0800

[Message part 3 (text/plain, inline)]

Tags: patch

Attached is a patch to reorder src/lisp.h so that more types are declared before 
use. The main motivation is to eventually add support for 
-fcheck-pointer-bounds; future changes will need access to type sizes (e.g., 
XCONS might need sizeof (struct Lisp_Cons)), which should be easy after this 
change. Also, the change shortens lisp.h a bit and (if you ask me) makes it 
easier to read, since the basic functions for a type are now declared next to 
the type.

I would like to install this soon, and am posting this as a bug report to give 
Eli and others a heads-up, in case some MS-Windows module now needs to include 
process.h. This may be needed because XPROCESS is now defined in process.h 
instead of lisp.h; similarly for buffer.h, window.h, termhooks.h.

[0001-Reorder-lisp.h-to-declare-types-before-using-them.patch (text/x-diff, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 25128-done <at> debbugs.gnu.org
Subject: Re: bug#25128: Reorder lisp.h to declare types before using them
Date: Sun, 25 Dec 2016 09:38:14 -0800

I installed this patch, after fixing it up to work with the concurrency branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.