GNU bug report logs - #25124
[PATCH] gnus-message-citation-mode should fontify if derived from message-mode.

Previous Next

Package: emacs;

Reported by: Hong Xu <hong <at> topbug.net>

Date: Tue, 6 Dec 2016 09:28:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 25022

Found in version 25.1.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Hong Xu <hong <at> topbug.net>
To: 25124 <at> debbugs.gnu.org
Subject: bug#25124: [PATCH] gnus-message-citation-mode should fontify if derived from message-mode.
Date: Thu, 16 Feb 2017 14:12:42 -0800
[Message part 1 (text/plain, inline)]
On 2016-12-06 Tue 01:27 GMT-0800, Hong Xu <hong <at> topbug.net> wrote:

> 	* gnus-cite.el (gnus-message-citation-mode): Fontify if the major
> 	mode is derived from message-mode (not necessarily equal to
> 	message-mode).
> ---
>  lisp/gnus/gnus-cite.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/gnus/gnus-cite.el b/lisp/gnus/gnus-cite.el
> index 502a3be35550..e012b256d09d 100644
> --- a/lisp/gnus/gnus-cite.el
> +++ b/lisp/gnus/gnus-cite.el
> @@ -1204,7 +1204,7 @@ gnus-message-citation-mode
>    nil ;; init-value
>    "" ;; lighter
>    nil ;; keymap
> -  (when (eq major-mode 'message-mode)   ;FIXME: Use derived-mode-p.
> +  (when (derived-mode-p 'message-mode)
>      ;; FIXME: Use font-lock-add-keywords!
>      (let ((defaults (car (if (featurep 'xemacs)
>  			     (get 'message-mode 'font-lock-defaults)


Still consider this patch? The fix is quite straightforward.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 241 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.