From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 04 01:28:07 2016 Received: (at submit) by debbugs.gnu.org; 4 Dec 2016 06:28:07 +0000 Received: from localhost ([127.0.0.1]:51796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDQHO-0002f3-Oz for submit@debbugs.gnu.org; Sun, 04 Dec 2016 01:28:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDQHM-0002eZ-J6 for submit@debbugs.gnu.org; Sun, 04 Dec 2016 01:28:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDQHG-0008Cz-Cn for submit@debbugs.gnu.org; Sun, 04 Dec 2016 01:27:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51082) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cDQHG-0008Cv-8t for submit@debbugs.gnu.org; Sun, 04 Dec 2016 01:27:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDQHF-0004YE-3z for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2016 01:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDQHB-0008CM-W7 for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2016 01:27:57 -0500 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]:34406) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cDQHB-0008CG-NX for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2016 01:27:53 -0500 Received: by mail-io0-x22b.google.com with SMTP id c21so504753490ioj.1 for ; Sat, 03 Dec 2016 22:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version; bh=trp8eGEpV6ko4jRzp19TTEq0yeodHgf8iEohVqQtl8g=; b=QQGAPmDJvfDearBFpnWG/wxNvOFZWXbJC8g99Gyxcc8o1UFzZLNKgIaeeN9A6LXtpz G7/MrX3mwDUPQwrwRe7elfMGT1BW+iKwao0PZZ7U421qIwaQ4crTp867v7fJHY6ZjGpq rjOBZYZ0JFcjKQU1mmXzkwGgWkwF0wLohcO5Xe6O1ynvrgSPagifpQ8Hggh9M6yKYXsd ULE9E9KkU/gUa8I3OpDvZ9tcMPlZ3HBGPNf/XZG3I5vHbHG9UhME7BaR5yJgm6fgs5qd sFCusPq1o6RMXhOv+cbhXHxw+yNjVS8D3YNJ1GatR8SPed0bK/zIMrNHQCx65IS9bpDP v3Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=trp8eGEpV6ko4jRzp19TTEq0yeodHgf8iEohVqQtl8g=; b=Hnulbdz8iBD9sHs2TbeMp09nRzrAbwl0UE169+jr6xhbBj80vy8Ou8r4VPv+o1P9fY cogwSuyXlXAtAxd9xppbA2/W1UKkvxsl24/CKrtwKfzGqs14kTNH1/tAO9BgjqV659n5 xuRFbB7MPLXL1nwNR/wTyMwFTPWbs+J2mgZOhv/MhRwuxQwxBdMvlcgRlQ4MNsG4foZH CzgYEpEJ2XOEYVQsYkgBTSO1s5z+6ZKhMa2/hSMOdLA/RBZjQDCrPSSoe2Hwd8U5rW9a dVgu9/ytDsynMSSswav8AZ02C+ttYIcVIZFjJqfcYW2BnsG91M/HOWh/PFgSEehwGjI9 d7sA== X-Gm-Message-State: AKaTC01m9+Hsl8h4/q2ed4DgmqkoFl8Y+uLh0jqQCfhUSx5YIGCD9moJgb8jrD9YEcFAqg== X-Received: by 10.36.189.201 with SMTP id x192mr3763037ite.114.1480832871819; Sat, 03 Dec 2016 22:27:51 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g185sm4114018ith.14.2016.12.03.22.27.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Dec 2016 22:27:51 -0800 (PST) From: npostavs@users.sourceforge.net To: bug-gnu-emacs@gnu.org Subject: 25.1; cursor-sensor--detect can go beyond buffer bounds Date: Sun, 04 Dec 2016 01:28:49 -0500 Message-ID: <87vav0fbry.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain tags: patch >From emacs -Q, insert the following in *scratch*, and evaluate it twice. (with-current-buffer (get-buffer-create "foo") (erase-buffer) (insert (make-string 200 ?\n)) (cursor-sensor-mode +1) (display-buffer (current-buffer))) The second time an error is triggered, here is a backtrace: Debugger entered--Lisp error: (args-out-of-range 0) get-char-property(0 cursor-sensor-functions) cursor-sensor--detect(#) run-hook-with-args(cursor-sensor--detect #) redisplay--pre-redisplay-functions((#)) apply(redisplay--pre-redisplay-functions (#)) #[128 "\300\301\"\210\300\302\"\207" [apply redisplay--pre-redisplay-functions ignore nil] 4 nil nil]((#)) redisplay_internal\ \(C\ function\)() cursor-sensor-mode is a new feature in Emacs 25, so I propose the following patch for emacs-25: --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=v1-0001-Don-t-assume-window-point-and-point-are-the-same.patch Content-Description: patch >From 67817cd0727a1b257952afb93fc9a8238965b3c4 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sun, 4 Dec 2016 01:06:52 -0500 Subject: [PATCH v1] Don't assume window-point and point are the same The function `cursor-sensor--detect' calls `bobp' to decide whether to check properties at (1- (window-point)). However, (window-point) may be at beginning of buffer, even if (point) is not. In this case an `args-out-of-range' error will be signaled. * lisp/emacs-lisp/cursor-sensor.el (cursor-sensor--detect): Check the value of (window-point) against (point-min), rather than (bobp) to decide if (1- (window-point)) is accessible. --- lisp/emacs-lisp/cursor-sensor.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cursor-sensor.el b/lisp/emacs-lisp/cursor-sensor.el index 2231179..28b6188 100644 --- a/lisp/emacs-lisp/cursor-sensor.el +++ b/lisp/emacs-lisp/cursor-sensor.el @@ -114,7 +114,7 @@ cursor-sensor--detect ;; non-sticky on both ends, but that means get-pos-property might ;; never see it. (new (or (get-char-property point 'cursor-sensor-functions) - (unless (bobp) + (unless (<= (point-min) point) (get-char-property (1- point) 'cursor-sensor-functions)))) (old (window-parameter window 'cursor-sensor--last-state)) (oldposmark (car old)) -- 2.9.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 04 10:39:41 2016 Received: (at 25104) by debbugs.gnu.org; 4 Dec 2016 15:39:41 +0000 Received: from localhost ([127.0.0.1]:56107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDYtA-0001kr-P2 for submit@debbugs.gnu.org; Sun, 04 Dec 2016 10:39:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDYt9-0001kZ-9f for 25104@debbugs.gnu.org; Sun, 04 Dec 2016 10:39:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDYsz-0006qU-BD for 25104@debbugs.gnu.org; Sun, 04 Dec 2016 10:39:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDYsz-0006qO-7j; Sun, 04 Dec 2016 10:39:29 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1667 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cDYsy-0003A9-O2; Sun, 04 Dec 2016 10:39:29 -0500 Date: Sun, 04 Dec 2016 17:39:44 +0200 Message-Id: <83k2bfln3z.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87vav0fbry.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25104: 25.1; cursor-sensor--detect can go beyond buffer bounds References: <87vav0fbry.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25104 Cc: 25104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Date: Sun, 04 Dec 2016 01:28:49 -0500 > > cursor-sensor-mode is a new feature in Emacs 25, so I propose the > following patch for emacs-25: Thanks, the patch looks trivially correct for me, and I agree it should go to the release branch. Please wait for a couple of days (this being a weekend) for possible comments or objections, and push then if none are raised. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 06 22:41:08 2016 Received: (at 25104) by debbugs.gnu.org; 7 Dec 2016 03:41:08 +0000 Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cET6S-00080f-3Z for submit@debbugs.gnu.org; Tue, 06 Dec 2016 22:41:08 -0500 Received: from mail-io0-f195.google.com ([209.85.223.195]:34833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cET6P-0007zy-NF; Tue, 06 Dec 2016 22:41:06 -0500 Received: by mail-io0-f195.google.com with SMTP id h133so25646888ioe.2; Tue, 06 Dec 2016 19:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0f+OofJffrfIBHobXPuIrO7CNmHTAkpTUEBcaTuwm3E=; b=lRTquCEXUSrpXd6EytvY9kGfnBB228dBm1bVkKnyxTGzUCQVRLN2HceKd1eVbr0p93 w87hqLu+yvdAd1QUW35ySOZj6cOzkyiW1zUqfdyRjYyMFHmblOM/RbAdYmj/YkKDWBZ9 XL9ZLbXakrtVtfe5edI0MQl+xY9J6rrVC3bH1IovCCskXpqFijEuTmNKcLg/XqCgr9cI vQugmmM/FN38Y7dQhsdcjQty7mCQwkc9AriIwthszZxy9aJCaZd4SeQfqGyGCVKo4WBd hGm88ulmaHRP1jj3UdBYO2q9E5Ah45I9wAuaH+s3XwrpHBh2i+o8nOW62/vjkz9D360i H4gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=0f+OofJffrfIBHobXPuIrO7CNmHTAkpTUEBcaTuwm3E=; b=WTOy2l1D1r13eEFEBROlwV3sgKjgTVnJ7M/B2TUjuy8uA78mdBc/csIuX4AbqI5N8q JOZ7nE82owwv+yCgoVj93ulgpqpI/+9AxDbSZ6CC/ZlKea7G+N4P/iu7H1N8l0/9VfC3 eOA8x3eA4vWrjAUmyIbwjEY5s4W4AyYKxbRQ+h1xK/KMB7MwAHNzQ1gN6+SbrK3Iv293 Mbn+CfCUBObWJ94wLVNB1QnX8lq6KCT8Mf6hzaeAIH6kLJsf2Vrwcq6vJtEbiCQOnyhW jjj4AFt2pDaXNiEGepMTAwD2G/GwYLSjcptbgU+/XT08Ary6kf/DjO2Vw8WE3fx1QQTs UeqQ== X-Gm-Message-State: AKaTC00TIec5MWgboBxgZ3AjKm/lK6jC7tkX1KcKKbeOTS7NEyXlzIj7B4Cd1XdRvkeDCA== X-Received: by 10.36.215.70 with SMTP id y67mr574171itg.16.1481082059767; Tue, 06 Dec 2016 19:40:59 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id h69sm2692663ith.5.2016.12.06.19.40.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Dec 2016 19:40:59 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25104: 25.1; cursor-sensor--detect can go beyond buffer bounds References: <87vav0fbry.fsf@users.sourceforge.net> <83k2bfln3z.fsf@gnu.org> Date: Tue, 06 Dec 2016 22:41:59 -0500 In-Reply-To: <83k2bfln3z.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Dec 2016 17:39:44 +0200") Message-ID: <87fum0flrs.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25104 Cc: 25104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 25104 fixed close 25104 25.2 quit Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Date: Sun, 04 Dec 2016 01:28:49 -0500 >> >> cursor-sensor-mode is a new feature in Emacs 25, so I propose the >> following patch for emacs-25: > > Thanks, the patch looks trivially correct for me, and I agree it > should go to the release branch. Please wait for a couple of days > (this being a weekend) for possible comments or objections, and push > then if none are raised. Pushed as 35ce3fb. From unknown Sat Jun 21 10:44:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Jan 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator