From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 00:23:21 2016 Received: (at submit) by debbugs.gnu.org; 2 Dec 2016 05:23:21 +0000 Received: from localhost ([127.0.0.1]:49349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCgJd-0000Go-7p for submit@debbugs.gnu.org; Fri, 02 Dec 2016 00:23:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCgJc-0000Gd-7E for submit@debbugs.gnu.org; Fri, 02 Dec 2016 00:23:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCgJW-0005TL-90 for submit@debbugs.gnu.org; Fri, 02 Dec 2016 00:23:15 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37110) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cCgJW-0005TD-6T for submit@debbugs.gnu.org; Fri, 02 Dec 2016 00:23:14 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCgJV-0004Aq-35 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 00:23:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCgJR-0005Qk-1c for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 00:23:13 -0500 Received: from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b]:35756) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cCgJQ-0005PZ-P5 for bug-gnu-emacs@gnu.org; Fri, 02 Dec 2016 00:23:08 -0500 Received: by mail-io0-x22b.google.com with SMTP id a124so464076741ioe.2 for ; Thu, 01 Dec 2016 21:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version; bh=mqnE4sG/jft0vuxWtA4Icmi4U2Usuh1MY9eLRn82E9c=; b=vy0m3IzkSQj+ze3jBRNPwhldVns4oAMgoCFrRuNGxkt98Q/SoPySX6Yp+EXGIHnZ5O ZdpZoZnEN5OR2k5fWX3mGBYBNY6XUGdSO6nti0E63TLE66mNB3oueO9gL2voo2t8ZwAg NPtFPxNwYzW7nL6Ei1SN0LDN63WWHP0goShUp9/d+tInXrUi16U35hvQQ5+rHgr8p7LV Eys8tyiJbvpeJ44xOpuPEcHVfEdEyPURR/2wU/zKK01v8WWSkY+Zmt+mThygIxHDjjAv aTlHRg4V/79O+JmAAzUX26LwQqa16DDMvnIT6ETIpyHI/UVeISvYrh2PIZXx2kSWt710 lXqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=mqnE4sG/jft0vuxWtA4Icmi4U2Usuh1MY9eLRn82E9c=; b=ju0AQROeUkqkuw0QUu22Py7K6rL7oi1ESo3CinNXuIdESyxvNrCAcaLuFmzgSvOSEu d8Z2i4Tt3DaSyiue96Xhx5WNYFxP8GaI/vt82xnevRtWnw6lZCeq0q6RxT/u8Ju/xnzi LChpSR8yMSIqbxD7GbtcD50OwTJbU271gv4RWoxi7sdvP2g1GWmHBaHV0vpQyGpBjzdA g60GM4/3GdirIWiPh0Uo9JCKXhj064DpGVETd1hH/FUMn6jYevcr4OSea/eLaDhaNtWk cL3kWNp5pJX52Tb6MQQwJAsIkWXcJRvxPDT7TG377KOkqRz9ie30nIIEJiYz5r3pgrUe jRkw== X-Gm-Message-State: AKaTC00oj2deBT5rGQ1DRIRBC4Gdk9AxFBQHGOBcP4m90S5DUG4hlZS10L8c7afBQka58w== X-Received: by 10.36.103.200 with SMTP id u191mr1197491itc.8.1480656187035; Thu, 01 Dec 2016 21:23:07 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e202sm1527806ioe.27.2016.12.01.21.23.05 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Dec 2016 21:23:06 -0800 (PST) From: npostavs@users.sourceforge.net To: bug-gnu-emacs@gnu.org Subject: 25.1; feature-unload and reload of cl-defstruct fails Date: Fri, 02 Dec 2016 00:24:04 -0500 Message-ID: <87eg1qhpjf.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain tags: patch Running emacs -Q -l bug-struct-reload.el --eval "(unload-feature 'bug-struct-reload)" -l bug-struct-reload.el Where bug-struct-reload.el contains (eval-when-compile (require 'cl-lib)) (cl-defstruct foo f1) (provide 'bug-struct-reload) Shows in *Messages* the following error Unexpected element (define-type . foo) in load-history Compiler-macro error for foo-p: (void-function foo-p--cmacro) [2 times] This is because cl-defstruct defines the field accessors before the predicate. After calling `feature-unload', the `macro-compiler' symbol property remains on the predicate even though the function itself is undefined. Then when reloading, the compiler tries to call the predicate's compiler-macro to inline it in the accessor function, and fails to find the definition. Since this is a regression in 25.1, I'd like to apply the following patch to emacs-25, which simply puts the predicate definition before the accessor functions. --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=v1-0001-Define-struct-predicate-before-acccesors.patch Content-Description: patch >From d6285c44150fc9f6d0d3d6dadcd272bae3c498e5 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 2 Dec 2016 00:03:57 -0500 Subject: [PATCH v1] Define struct predicate before acccesors The accessor functions use the predicate function, which causes problems when reloading after unload-feature: the compiler-macro property is still present on the predicate symbol, and the compiler fails to find the definition when trying to inline it into the accessor function. * lisp/emacs-lisp/cl-macs.el (cl-defstruct): Move predicate definition before field accessor definitions. --- lisp/emacs-lisp/cl-macs.el | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index c51ed9d..b3a60b1 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -2687,6 +2687,14 @@ cl-defstruct (= safety 1)) (cons 'and (cl-cdddr pred-form)) `(,predicate cl-x)))) + (when pred-form + (push `(cl-defsubst ,predicate (cl-x) + (declare (side-effect-free error-free)) + ,(if (eq (car pred-form) 'and) + (append pred-form '(t)) + `(and ,pred-form t))) + forms) + (push `(put ',name 'cl-deftype-satisfies ',predicate) forms)) (let ((pos 0) (descp descs)) (while descp (let* ((desc (pop descp)) @@ -2741,14 +2749,6 @@ cl-defstruct (setq pos (1+ pos)))) (setq slots (nreverse slots) defaults (nreverse defaults)) - (when pred-form - (push `(cl-defsubst ,predicate (cl-x) - (declare (side-effect-free error-free)) - ,(if (eq (car pred-form) 'and) - (append pred-form '(t)) - `(and ,pred-form t))) - forms) - (push `(put ',name 'cl-deftype-satisfies ',predicate) forms)) (and copier (push `(defalias ',copier #'copy-sequence) forms)) (if constructor -- 2.9.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 03:13:46 2016 Received: (at 25088) by debbugs.gnu.org; 2 Dec 2016 08:13:46 +0000 Received: from localhost ([127.0.0.1]:49451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCiyY-0004Rg-9p for submit@debbugs.gnu.org; Fri, 02 Dec 2016 03:13:46 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCiyX-0004RT-4H for 25088@debbugs.gnu.org; Fri, 02 Dec 2016 03:13:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCiyN-0006g9-5F for 25088@debbugs.gnu.org; Fri, 02 Dec 2016 03:13:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCiyN-0006g5-1O; Fri, 02 Dec 2016 03:13:35 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1208 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCiyM-0001Mh-9I; Fri, 02 Dec 2016 03:13:34 -0500 Date: Fri, 02 Dec 2016 10:13:44 +0200 Message-Id: <83eg1qoiiv.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87eg1qhpjf.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25088 Cc: 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Date: Fri, 02 Dec 2016 00:24:04 -0500 > > Running > > emacs -Q -l bug-struct-reload.el --eval "(unload-feature 'bug-struct-reload)" -l bug-struct-reload.el > > Where bug-struct-reload.el contains > > (eval-when-compile (require 'cl-lib)) > (cl-defstruct foo f1) > (provide 'bug-struct-reload) > > Shows in *Messages* the following error > > Unexpected element (define-type . foo) in load-history > Compiler-macro error for foo-p: (void-function foo-p--cmacro) [2 times] > > This is because cl-defstruct defines the field accessors before the > predicate. After calling `feature-unload', the `macro-compiler' symbol > property remains on the predicate even though the function itself is > undefined. Then when reloading, the compiler tries to call the > predicate's compiler-macro to inline it in the accessor function, and > fails to find the definition. > > Since this is a regression in 25.1, I'd like to apply the following > patch to emacs-25, which simply puts the predicate definition before the > accessor functions. How risky is this change? cl-defstruct is a very widely used macro, whereas unload-feature is a relatively obscure feature. Is it really worth fixing the (IMO minor) error and risking to break Emacs 25.2? I don't have an intuition I can trust in these matters, so I need you and others who do to offer their opinions, after carefully considering the pros and cons. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 03 17:37:46 2016 Received: (at 25088) by debbugs.gnu.org; 3 Dec 2016 22:37:46 +0000 Received: from localhost ([127.0.0.1]:51708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDIwD-0004my-SO for submit@debbugs.gnu.org; Sat, 03 Dec 2016 17:37:46 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:33255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDIwC-0004mk-IQ for 25088@debbugs.gnu.org; Sat, 03 Dec 2016 17:37:44 -0500 Received: by mail-io0-f169.google.com with SMTP id j65so540323989iof.0 for <25088@debbugs.gnu.org>; Sat, 03 Dec 2016 14:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4B+0Mu9EKipIf8xvyq1rcMPi2IZ8kR8Tgc8OIbwFaaY=; b=O+U1RIreGstzAgpaFk3yxPGewJQKwKeDhy+znFuI3OudX/EIJatYVV3mClQ34Cbj7x 8rB/hCUDZhVvNcalBs8xOLGKPAka68jvCCHox1Rf2HVLRScCNNzejvvh2+v0kA+ZyURD aujd0f3yKGiYpp0w1lpDfD9pcdxv1IzU+c6SgZch5zqpqyx34Exg6hjsXEMTYJp8R2Sn ZY7VRryyRc6lPEKM7x2S0h+ogC02JYqGiu/ckHAEZTH13gdA+1pSIyinB9PxopVJC/PS h/Ii0c56n1Zu5lX9dCvoe4YVzoxSy8eMWZUFrNKQ+gfMQxc2aG1zP+USBpxEDdnnDcuC WZJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4B+0Mu9EKipIf8xvyq1rcMPi2IZ8kR8Tgc8OIbwFaaY=; b=fYTM6zO1fv1je9KkY2xTxVn3laUTe2RLPI8OHw0/fJ4LrQcuB3KhqJ7cUlCgnnmobA 0LY3sfalxpDS5MZaj0G4gzbDWeo+gFCOILtAatB1R4ZUVSJDxV/zrXGqvg28JmwtTzaX MLToObRoFZs44rcoIWbDPPiNJwuffnrU5Cmsug9qIKxnDepBQjbcEwHsz7q5NE4iW/F8 Fx4xR6+LB5FMK5caYJebE5WNDxF9ewpp3pdL3e6qAsCd2gCwwk4En9kzprK64fRQAXBA tRYIXf6WRt0jbI4gSTVJX9aj/tTRLye2zvQFNDewmhQODum2RJQKzrRLuyBx95gdk34W 1dxw== X-Gm-Message-State: AKaTC01ohsO4CwMa0ltfcFoVRDuppnPxzSy3HGLjjVAveIXBWqYRzvpfmLFajo7kTOe9aA== X-Received: by 10.36.80.145 with SMTP id m139mr3088334itb.24.1480804658808; Sat, 03 Dec 2016 14:37:38 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 9sm4113021itv.0.2016.12.03.14.37.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 03 Dec 2016 14:37:38 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> Date: Sat, 03 Dec 2016 17:38:36 -0500 In-Reply-To: <83eg1qoiiv.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Dec 2016 10:13:44 +0200") Message-ID: <87y3zwfxjn.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 25088 Cc: 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Eli Zaretskii writes: > > How risky is this change? cl-defstruct is a very widely used macro, > whereas unload-feature is a relatively obscure feature. Is it really > worth fixing the (IMO minor) error and risking to break Emacs 25.2? > > I don't have an intuition I can trust in these matters, so I need you > and others who do to offer their opinions, after carefully considering > the pros and cons. I think it's safe, but I've been wrong before. I agree that unload-feature is sufficiently obscure that this can go to master instead of emacs-25. Perhaps the real bug is that unload-feature doesn't undo `put', thus the compiler-macro still hangs around. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 03 22:35:30 2016 Received: (at 25088) by debbugs.gnu.org; 4 Dec 2016 03:35:30 +0000 Received: from localhost ([127.0.0.1]:51767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDNaM-000771-A9 for submit@debbugs.gnu.org; Sat, 03 Dec 2016 22:35:30 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cDNaK-00076p-PW for 25088@debbugs.gnu.org; Sat, 03 Dec 2016 22:35:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDNaA-0006FF-JD for 25088@debbugs.gnu.org; Sat, 03 Dec 2016 22:35:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDNaA-0006F9-Fn; Sat, 03 Dec 2016 22:35:18 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4832 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cDNa9-0002xQ-N2; Sat, 03 Dec 2016 22:35:18 -0500 Date: Sun, 04 Dec 2016 05:35:32 +0200 Message-Id: <83pol8l62j.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87y3zwfxjn.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25088 Cc: 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Cc: 25088@debbugs.gnu.org > Date: Sat, 03 Dec 2016 17:38:36 -0500 > > Eli Zaretskii writes: > > > > How risky is this change? cl-defstruct is a very widely used macro, > > whereas unload-feature is a relatively obscure feature. Is it really > > worth fixing the (IMO minor) error and risking to break Emacs 25.2? > > > > I don't have an intuition I can trust in these matters, so I need you > > and others who do to offer their opinions, after carefully considering > > the pros and cons. > > I think it's safe, but I've been wrong before. I agree that > unload-feature is sufficiently obscure that this can go to master > instead of emacs-25. Thanks. Any other opinions? I will leave it for a few days for others to chime in. > Perhaps the real bug is that unload-feature doesn't undo `put', thus the > compiler-macro still hangs around. If this means there could be another, safer way of fixing this, please show the details. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 00:07:35 2016 Received: (at 25088) by debbugs.gnu.org; 9 Dec 2016 05:07:35 +0000 Received: from localhost ([127.0.0.1]:35082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFDPD-0000Jn-4i for submit@debbugs.gnu.org; Fri, 09 Dec 2016 00:07:35 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:33750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFDPB-0000JY-Bo for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 00:07:33 -0500 Received: by mail-io0-f171.google.com with SMTP id d9so38985207ioe.0 for <25088@debbugs.gnu.org>; Thu, 08 Dec 2016 21:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=z+/tpaJEam8eSsIa1od3kC+Y6W45AFGJMf5carYTDys=; b=OQbCVMSHa0mNlcgaKHPI+PLn4sw1ZCUiRTXR19d5vCPydoycU5HRuwecKm4nOzhUUZ HBnw4UWEKVRhOGC5mSRlTigpScJaOBXHYSJ6vYya0VXU/n8nC2Jv3Qt/HtSzorAAkiRY RDfJlPM3Xwh4RtLJkQoLSh2OuN/5OVqx10kU1NRuom1MiwOoaBf4HfLOb0eVDcvsx2sK 8c2dDW7XEyZhn8QyosdtkWcddbPH/0Uy9EfuAxgY5Orl+rKfbEoWFmXe9qQMn8+0tPcN V5qOZTrXwlWkmG7gOPFU5lus3wF+qKsxd+0cSMLPJIzHzRnJjyKG5tH6TrB98FB2cLBY /2Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=z+/tpaJEam8eSsIa1od3kC+Y6W45AFGJMf5carYTDys=; b=kMWzH+1Ze88XuANUsyTI0VC7fzfd7qmOjOw2lMQPbGbzs3xDX2Tsr5kdnnCSkwS0Bp ldw+A4Y5zJlbcTR41Jc8WOe2xBVSWMiG44w/kfu6nB0J8wxBaeGKzGT9NfYhwyo8e/Bm 2kF3Jx9CiR+mWlGPmASn9NdKK8j+GJQ15iHwjaLHIZTwyNyKrgswZ6JrhHKTRggnMOt8 hoLeJShf91e4wJNLCmu2ORsaLCPoBCp5d5mrc2RPwSjw6vCjREIqf5pvi7M8DvXH5RuL a4ICIGIiqE63Aeif7TjtdKJ4TxNu77lyBA67Qf8u73kfzrNCKntCilLEHLTRCfuQ8HPa MOfA== X-Gm-Message-State: AKaTC02PVPDaXjmSHy3904By5amrm7sabaMmom5VamdFMDBOMTnIdKpsXb+ME3nGtq0ycg== X-Received: by 10.36.81.79 with SMTP id s76mr5173173ita.28.1481260047688; Thu, 08 Dec 2016 21:07:27 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n206sm2548494itg.1.2016.12.08.21.07.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Dec 2016 21:07:27 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> Date: Fri, 09 Dec 2016 00:08:28 -0500 In-Reply-To: <83pol8l62j.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Dec 2016 05:35:32 +0200") Message-ID: <87shpxelkj.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25088 Cc: 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: >> Perhaps the real bug is that unload-feature doesn't undo `put', thus the >> compiler-macro still hangs around. > > If this means there could be another, safer way of fixing this, please > show the details. Not sure how much safer this is, I think we would have to record the which symbol plists are being modified during `load' so that `unload-feature' could find them in `load-history' and reverse them along with functions definitions. This would get rid of the compiler-macro entries that were added to cl-defstruct accessor function symbols, and so they would load successfully the second time round just like the first (presumably). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 03:22:40 2016 Received: (at 25088) by debbugs.gnu.org; 9 Dec 2016 08:22:40 +0000 Received: from localhost ([127.0.0.1]:35184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFGS0-0007K6-3I for submit@debbugs.gnu.org; Fri, 09 Dec 2016 03:22:40 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFGRy-0007Jr-Ah for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 03:22:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFGRs-0002rw-BK for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 03:22:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52783) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFGRs-0002rs-8G; Fri, 09 Dec 2016 03:22:32 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3387 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cFGRq-00074o-K2; Fri, 09 Dec 2016 03:22:31 -0500 Date: Fri, 09 Dec 2016 10:22:58 +0200 Message-Id: <83vauth5p9.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net, Stefan Monnier , Dmitry Gutov In-reply-to: <87shpxelkj.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> <87shpxelkj.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 25088 Cc: 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: npostavs@users.sourceforge.net > Cc: 25088@debbugs.gnu.org > Date: Fri, 09 Dec 2016 00:08:28 -0500 > > > If this means there could be another, safer way of fixing this, please > > show the details. > > Not sure how much safer this is, I think we would have to record the > which symbol plists are being modified during `load' so that > `unload-feature' could find them in `load-history' and reverse them > along with functions definitions. This would get rid of the > compiler-macro entries that were added to cl-defstruct accessor function > symbols, and so they would load successfully the second time round just > like the first (presumably). It could be safer because it doesn't change cl-defstruct. But it's hard to tell without seeing an implementation. What do others think? Is the patch proposed by Noam safe enough for the release branch? Stefan? Dmitry? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 11:27:43 2016 Received: (at 25088) by debbugs.gnu.org; 9 Dec 2016 16:27:43 +0000 Received: from localhost ([127.0.0.1]:36196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFO1P-0006Ao-1P for submit@debbugs.gnu.org; Fri, 09 Dec 2016 11:27:43 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:43988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFO1M-0006AZ-C3 for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 11:27:41 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AFKQAu3EVY/xnsSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZRWggiGHAQCAoIRQhIBAgEBAQEBAQFiKIRpAQQBViMFCws0EhQYDYkeCK0Ui0QBAQEBBgIBJIsZhRSFFQWPfIpqmxqGOpIPJgcpeBMOg1wcgXsgiS0BAQE X-IPAS-Result: A0AFKQAu3EVY/xnsSC1dGgEBAQECAQEBAQgBAQEBgzgBAQEBAR+EW4VUnAImAZRWggiGHAQCAoIRQhIBAgEBAQEBAQFiKIRpAQQBViMFCws0EhQYDYkeCK0Ui0QBAQEBBgIBJIsZhRSFFQWPfIpqmxqGOpIPJgcpeBMOg1wcgXsgiS0BAQE X-IronPort-AV: E=Sophos;i="5.33,749,1477972800"; d="scan'208";a="282088025" Received: from 45-72-236-25.cpe.teksavvy.com (HELO pastel.home) ([45.72.236.25]) by smtp.teksavvy.com with ESMTP; 09 Dec 2016 11:27:29 -0500 Received: by pastel.home (Postfix, from userid 20848) id 3DC6D6554A; Fri, 9 Dec 2016 11:27:29 -0500 (EST) From: Stefan Monnier To: npostavs@users.sourceforge.net Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails Message-ID: References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> Date: Fri, 09 Dec 2016 11:27:29 -0500 In-Reply-To: <87y3zwfxjn.fsf@users.sourceforge.net> (npostavs's message of "Sat, 03 Dec 2016 17:38:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 25088 Cc: Eli Zaretskii , 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I think it's safe, but I've been wrong before. I also think it's safe, and I've also been wrong before. Another thing: the patch makes sense regardless of the change, since it's good to define the things before we use them. > Not sure how much safer this is, I think we would have to record the > which symbol plists are being modified during `load' so that > `unload-feature' could find them in `load-history' and reverse them > along with functions definitions. This would get rid of the > compiler-macro entries that were added to cl-defstruct accessor function > symbols, and so they would load successfully the second time round just > like the first (presumably). Yes, that would be good. Currently unload-feature automatically un-does defalias and defvar, more or less, but it would be good to extend this to other top-level operations like `put`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 19:34:46 2016 Received: (at 25088) by debbugs.gnu.org; 10 Dec 2016 00:34:46 +0000 Received: from localhost ([127.0.0.1]:36412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFVcj-0004tG-MI for submit@debbugs.gnu.org; Fri, 09 Dec 2016 19:34:46 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFVci-0004t5-CY for 25088@debbugs.gnu.org; Fri, 09 Dec 2016 19:34:44 -0500 Received: by mail-wm0-f68.google.com with SMTP id m203so244391wma.3 for <25088@debbugs.gnu.org>; Fri, 09 Dec 2016 16:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L0T5d8lf23EvEcgSOIb8bXbL11lLQ9JVLcMGSKIjkWA=; b=oLopGqj5toaAm4Y+aUkuus+stcTgpxYVUOvHGiE6J5ucUY5//9iTAZAwfGVHDIUfQK PN82XdzBQZcghHkobSXX+CGJJYkORLABJfjkH9z21ci2m/UG9BOPTww6/DEL1C1iHabg 9bxEo/J5Yo6SDCJfh7GPwCePAf8gQyqCkSHqhOZltjY1+0zo0v695UM+MeTvD5tRuzqw tda915hSgrGJGGUTp1lu2IItqBVcoDeWx9Ti/gjmqKTvfwureruiQICnoZNFEDFAA6xI FxIXCpMPiZzBJ909Y2BCL1nVeoOyvl4wbddVCt67J2P4jne/r6fQt6sYnTEMy2mF+Bx6 aFdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L0T5d8lf23EvEcgSOIb8bXbL11lLQ9JVLcMGSKIjkWA=; b=R07uo7eaI3YueAfgZcY0YdxXL2ECzcbNwRsUkqW84qRfy2x1QZhFLHObPc0tJHZCcq +QBuL1FvSh5wJ5GzELWWffh/4ft2+1DK7sRKZxpLw8KwadjfytcAENuvvMNU855z7SdX WPprVFhzVre0226jLtLIFbeVQeV0Eh8ggvO7gQTf2FP803AoutZuHufNMbiVLH0Gxgql AONDrEJd4AJxaR5JHyIIFaxl/aOB5hOhsq3KaFlHe0rZue5Sy91Wu93dwrBOHNTTx9xd DgoXSreDHaCrCtw4wUVnONuwS1ViA+WotqUtfRkDqachfyHjqo3AvYzXFduapx4eisi3 HGLg== X-Gm-Message-State: AKaTC015XxR5ENdJuHQMt66x/xrwJfxoga/to4LgL/DQmCtiHRBkQPSD2UM270kvXS474Q== X-Received: by 10.28.71.137 with SMTP id m9mr459656wmi.88.1481326439441; Fri, 09 Dec 2016 15:33:59 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id t82sm22922057wmd.17.2016.12.09.15.33.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2016 15:33:59 -0800 (PST) Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails To: Eli Zaretskii , npostavs@users.sourceforge.net, Stefan Monnier References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> <87shpxelkj.fsf@users.sourceforge.net> <83vauth5p9.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Sat, 10 Dec 2016 01:33:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <83vauth5p9.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25088 Cc: 25088@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 09.12.2016 10:22, Eli Zaretskii wrote: > What do others think? Is the patch proposed by Noam safe enough for > the release branch? Stefan? Dmitry? Personally, the first option sounds safer for me (for the release branch), because the other one might affect many packages and not just this one. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 02:18:09 2016 Received: (at 25088) by debbugs.gnu.org; 10 Dec 2016 07:18:09 +0000 Received: from localhost ([127.0.0.1]:36492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFbv6-0007OR-S0 for submit@debbugs.gnu.org; Sat, 10 Dec 2016 02:18:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFbv4-0007O9-SL for 25088@debbugs.gnu.org; Sat, 10 Dec 2016 02:18:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cFbuw-0007OM-JO for 25088@debbugs.gnu.org; Sat, 10 Dec 2016 02:18:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cFbuw-0007OI-GN; Sat, 10 Dec 2016 02:17:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cFbuv-0001gl-IT; Sat, 10 Dec 2016 02:17:58 -0500 Date: Sat, 10 Dec 2016 09:18:29 +0200 Message-Id: <8337hwgsl6.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Sat, 10 Dec 2016 01:33:57 +0200) Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> <87shpxelkj.fsf@users.sourceforge.net> <83vauth5p9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 25088 Cc: monnier@iro.umontreal.ca, 25088@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > Cc: 25088@debbugs.gnu.org > From: Dmitry Gutov > Date: Sat, 10 Dec 2016 01:33:57 +0200 > > On 09.12.2016 10:22, Eli Zaretskii wrote: > > > What do others think? Is the patch proposed by Noam safe enough for > > the release branch? Stefan? Dmitry? > > Personally, the first option sounds safer for me (for the release > branch), because the other one might affect many packages and not just > this one. By "first option" do you mean the original patch posted by Noam? If so, given a similar opinion from Stefan, let's install that on emacs-25. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 04:49:53 2016 Received: (at 25088) by debbugs.gnu.org; 10 Dec 2016 09:49:53 +0000 Received: from localhost ([127.0.0.1]:36535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFeHw-00064Q-RD for submit@debbugs.gnu.org; Sat, 10 Dec 2016 04:49:53 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFeHu-00064C-T5 for 25088@debbugs.gnu.org; Sat, 10 Dec 2016 04:49:51 -0500 Received: by mail-wm0-f68.google.com with SMTP id u144so1300133wmu.0 for <25088@debbugs.gnu.org>; Sat, 10 Dec 2016 01:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=81J/yNcO4LKJWPMku5j13c7v5F7miDmcwMzDjTGmJNs=; b=tCwEdhsnnHjRUCF5QnqqDIaPOh21/R41R7s6E82QGHqMCZc0ohlY5k2deQzu4mxqHi T0keZqDmxWJ3l3c6hGom7boacpuCKLI8bHvVCPq0AmhduqpQq6mZagCuLpZMq/E4Mo07 9LaZMOteaKfrmllU7rhGgVQHYGkUjvqmvZiYUq3RTKDmGLVVhdsKt59LKuAbGujSD6jJ ia9Om8cbA3DtU9hVdgtOdTnL75+gslCMENavxm4R834m+cuRwolpfAq0x6NUzA74Yjy1 vAi+PRZ/TcAeHXT9GLRaV7vniwhEf4ciuHw+5cYLoh6lDPTN64wNr8Ptq3OiJnsHtveE jGuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=81J/yNcO4LKJWPMku5j13c7v5F7miDmcwMzDjTGmJNs=; b=Oxj2kR3/3jVoPZ0X2iCgMJcAtnXPjay7pluunsXrfp2tgUCnOqI8uP60QMiegtFfDt 3Cdp+jae1sTxFL9nDyrX1mwH3+fj3vJdA7DgSZRXpctf7hlZVudoRtUAMeVlC9nstQr2 1YXMJ5PsvVL2A4ZyV/S3BN+JaqDAcNait+pqbOBpxVZsRLgWhScP9BqcSwhpdUf7uRKH U0Dma9Q/PMlR7m7s2Ul+UJuYO3wGah9QjHR8TK6Wov08gEcQkBBeEsqXl63Ux00ftc48 P+EPl96q7XzpvzoryAXMLikOsw/Aw0K8ylzbvvoeZQb0URqtr37GlkJPlqoo6OvZ/cHR MN3g== X-Gm-Message-State: AKaTC01f9y8HRxmHFo53e7/1Pc8ojyMlKtuWy81qy+/pjPmjdfoWuLppncL9uoNVTkFvzQ== X-Received: by 10.28.170.202 with SMTP id t193mr9729816wme.10.1481363385121; Sat, 10 Dec 2016 01:49:45 -0800 (PST) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id t82sm24936544wmd.17.2016.12.10.01.49.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 10 Dec 2016 01:49:44 -0800 (PST) Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails To: Eli Zaretskii References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> <87shpxelkj.fsf@users.sourceforge.net> <83vauth5p9.fsf@gnu.org> <8337hwgsl6.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Sat, 10 Dec 2016 11:49:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <8337hwgsl6.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25088 Cc: monnier@iro.umontreal.ca, 25088@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 10.12.2016 09:18, Eli Zaretskii wrote: > By "first option" do you mean the original patch posted by Noam? Yup! From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 16:04:11 2016 Received: (at 25088) by debbugs.gnu.org; 10 Dec 2016 21:04:11 +0000 Received: from localhost ([127.0.0.1]:37286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFooV-0001JE-54 for submit@debbugs.gnu.org; Sat, 10 Dec 2016 16:04:11 -0500 Received: from mail-io0-f194.google.com ([209.85.223.194]:36030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFooS-0001Iv-E8; Sat, 10 Dec 2016 16:04:09 -0500 Received: by mail-io0-f194.google.com with SMTP id b194so13921295ioa.3; Sat, 10 Dec 2016 13:04:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ZsHNkxri5yUrz+HAhtUoMES8ISMPbnQICG20dphBs2Q=; b=RNO+PlppGGGi4XSUtJF2tCzCqWHWXsoNPA0QkXdx7QURx0a0gwGIY4Nx2uBEnV/Guw sXsh/d90hFdcfgKpsQgDX8ekBZrQoWIofzU4bqyskeY7CPr+vkHVjC+0vAi8NC3LEWGL GzBKFCNkO4Z99TWdsHtXC8YOjmtnwBFbx+nHCAJsaufPp/hl1/6poitJ+5fimsaOvOdl wyE9lG2l9hKec4smStKV7fFJ337X4Uh+tYenhzsuF0e9TYXVH1iANuMLhsdl0ApoYZav zU9vG36eYXORCtzNOxc005vMXyi7rEJz8/o3YxEvcFVPIl3dvOf1bRwvggmJswQRByf3 sPbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=ZsHNkxri5yUrz+HAhtUoMES8ISMPbnQICG20dphBs2Q=; b=l0aLt1cyF2SU8U+nHlMO39c16zOP5lwB+X5Qf860TzjwKhIdeX7gyj2MizWETozuwk 2w1n1tc2yOf0f+d+t/qBDm6sAILGxqzaGG5EUBPW1drediUaB3tN96P3jqXvMVqQ4B+S OYX44LseurQBPo4W84iTL+IqhXY8btKqf0g/6wh//HT/VNWE9pwZxGe0BmH0VCp+3GZe 0Tr1MR8az1342ojY53RU/fNR4YGM3hfrqVUKSNlqvlIjG+KdPXh8/vbMad4SyIsYyvcx qOgRjY6CKRvJ96h17Odc/JA4VLDT6T+V7hUWJzF25WEPWYNb5pdVgJt1eAvRmm+e67mH yN+w== X-Gm-Message-State: AKaTC00p3bXhRAiLwQmZd9pbT3g4He3MeeuNV/c5g3LDa8so+jqFNx5t++26P+CdSClsww== X-Received: by 10.107.29.148 with SMTP id d142mr6410712iod.44.1481403842821; Sat, 10 Dec 2016 13:04:02 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n206sm1680830itg.1.2016.12.10.13.04.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 10 Dec 2016 13:04:02 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25088: 25.1; feature-unload and reload of cl-defstruct fails References: <87eg1qhpjf.fsf@users.sourceforge.net> <83eg1qoiiv.fsf@gnu.org> <87y3zwfxjn.fsf@users.sourceforge.net> <83pol8l62j.fsf@gnu.org> <87shpxelkj.fsf@users.sourceforge.net> <83vauth5p9.fsf@gnu.org> <8337hwgsl6.fsf@gnu.org> Date: Sat, 10 Dec 2016 16:05:04 -0500 In-Reply-To: <8337hwgsl6.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 10 Dec 2016 09:18:29 +0200") Message-ID: <878trnebr3.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25088 Cc: monnier@iro.umontreal.ca, 25088@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 25088 fixed close 25088 25.2 quit Eli Zaretskii writes: >> Cc: 25088@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Sat, 10 Dec 2016 01:33:57 +0200 >> >> On 09.12.2016 10:22, Eli Zaretskii wrote: >> >> > What do others think? Is the patch proposed by Noam safe enough for >> > the release branch? Stefan? Dmitry? >> >> Personally, the first option sounds safer for me (for the release >> branch), because the other one might affect many packages and not just >> this one. > > By "first option" do you mean the original patch posted by Noam? > > If so, given a similar opinion from Stefan, let's install that on > emacs-25. Okay, pushed as e4ac4507968b. From unknown Sun Jun 22 00:55:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 08 Jan 2017 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator