Subject: Re: bug#25068: 25.1; Edebug fails to instrument code which uses propertized strings

From: Gemini Lasswell <[email-masked]>
Date: Sat, 04 Feb 2017 17:49:49 -0800

Gemini Lasswell <[email-masked]> writes:

> This could be fixed by updating the list in edebug-read-function of
> characters that might possibly follow # to keep up with the changes to
> read1 since the last time that list was updated (in 2001). But I think
> it's better to remove the test entirely. If there is an invalid
> character then read1 will report a syntax error.

Ooops, attached the wrong patch. Here's the right one:

>From 781b23e55488f80ab310f376cf27b5066fea7114 Mon Sep 17 00:00:00 2001
From: Gemini Lasswell <[email-masked]>
Date: Sat, 4 Feb 2017 08:39:55 -0800
Subject: [PATCH] Remove syntax error check from edebug-read-function
 (Bug#25068)

	* lisp/emacs-lisp/edebug.el (edebug-read-function): Allow
	`read' to decide what is and isn't a syntax error.
---
 lisp/emacs-lisp/edebug.el | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index ec0f08d..a883804 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -880,11 +880,9 @@ edebug-read-function
 	 (list
 	  (edebug-storing-offsets (- (point) 2) 'function)
 	  (edebug-read-storing-offsets stream)))
-	((memq (following-char) '(?: ?B ?O ?X ?b ?o ?x ?1 ?2 ?3 ?4 ?5 ?6
-				  ?7 ?8 ?9 ?0))
+        (t
 	 (backward-char 1)
-	 (read stream))
-	(t (edebug-syntax-error "Bad char after #"))))
+	 (read stream))))
 
 (defun edebug-read-list (stream)
   (forward-char 1)			; skip \(
-- 
2.10.1