GNU bug report logs - #25049
ibuffer bug when saving existing filter, with patches

Previous Next

Full log

Message #20 received at 25049 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Christopher Genovese <genovese <at> cmu.edu>
Cc: 25049 <at> debbugs.gnu.org, tino.calancha <at> gmail.com
Subject: Re: bug#25049: ibuffer bug when saving existing filter, with patches
Date: Wed, 30 Nov 2016 16:02:53 +0900

Christopher Genovese <genovese <at> cmu.edu> writes:

> I've attached a modified patch file that includes
> all your suggested changes.  I did some squashing
> and editing, so this patch has the same three parts
> as before, with properly formatted Change Logs in
> each.
Thank you very much fr your prompt replay!

I)
+           'follow-link t
+           'help-echo "Click or RET: save new value in customize"
+           'action (lambda (b)
+                     (if (not (fboundp 'customize-save-variable))
+                         (message "Customize not available; value not saved")
+                       (customize-save-variable 'ibuffer-saved-filters
+                                                ibuffer-saved-filters)
+                       (message "Saved updated ibuffer-saved-filters."))))
The lambda form above doesn't use its 'b' argument, so i have dropped it.

II)
I see you define `ibuffer-update-saved-filters-format' right before
than `ibuffer-saved-filters', because this defcustom use that function
to set its default.

In the other hand `ibuffer-repair-saved-filters' isn't used by any
defcustom so i moved out after the variable definitions.

If we don't get further comments to address in 1 week, then let's
push this fix to the master branch.

Thank you
Tino

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.