From unknown Sat Aug 09 22:37:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25046 <25046@debbugs.gnu.org> To: bug#25046 <25046@debbugs.gnu.org> Subject: Status: 26.0.50; Arguments of `ediff-janitor' undocumented Reply-To: bug#25046 <25046@debbugs.gnu.org> Date: Sun, 10 Aug 2025 05:37:41 +0000 retitle 25046 26.0.50; Arguments of `ediff-janitor' undocumented reassign 25046 emacs submitter 25046 Philipp Stephani severity 25046 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 15:33:14 2016 Received: (at submit) by debbugs.gnu.org; 27 Nov 2016 20:33:14 +0000 Received: from localhost ([127.0.0.1]:43889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB68P-0002s8-Qo for submit@debbugs.gnu.org; Sun, 27 Nov 2016 15:33:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB68O-0002rv-Da for submit@debbugs.gnu.org; Sun, 27 Nov 2016 15:33:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB68I-0004H8-6a for submit@debbugs.gnu.org; Sun, 27 Nov 2016 15:33:07 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56078) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cB68I-0004H4-3e for submit@debbugs.gnu.org; Sun, 27 Nov 2016 15:33:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB68G-0000Dk-Oo for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 15:33:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB68B-0004GK-SD for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 15:33:04 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:35149) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cB68B-0004FL-KX for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 15:32:59 -0500 Received: by mail-wm0-x22d.google.com with SMTP id a197so187721445wmd.0 for ; Sun, 27 Nov 2016 12:32:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=4dTyK3CEl/WPL+u8KtGxLfSVoRX6UdB/n1f0FF5jdBQ=; b=ComizKjuiX7irN8DN2vHW/fjj3Romn4XoP+Afeou1MQUt/su+gbcbQnp0uTS5nY7eE f7GKbt/XE2y1Z8YChsYc4WYgSuI7rkjDKvdL6sjLJTP5HJKsDfuZOL0zEx8U4ImEqCIs soZ36HKA2H1aNtCjXOTA050oJiukPLEZNHcQBV8T1+n1I/EUq9/jdVOVsdb4XFs+YV8Y S4v2mX6sIRpiTp0Bq3H0rKyWZb5v8bV99RbofcaJbv8nfpTpsbGVnt+tQ6/PG79xzDW9 MJOHwae7LW3WFmbGiUGjb+F2Ft/Bxu8K7TLGNinDIMBNuLaIEM3pKTvCadqzMR13iOJo xhHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=4dTyK3CEl/WPL+u8KtGxLfSVoRX6UdB/n1f0FF5jdBQ=; b=GPzJZR6mzObW9O07uM5Z6rPzSSlIMY1nUzuWT0pp0VV70D+CcvFsCC80oVLu5D5t+x ieJrLz/6fnm9NKxr+5xe2KExKXL2oHwhrQsw3gaae9TC45YJ0aCBozezpVLLVXnipv5v Drxtshas1fgTAu21qA4+8YUO4N7YanOI8FyJpCW7QqPEwmja8K+f4sPE9Sw9NhCfWz1T dJNf5SXuwAS3Bcx+94beDrHS1grNWL0qr/Yso4d+QCBdtVteYpJONoQjYBo8LZZpdd4A lKl8qHM9D7P4S1puXZbD2CIb0hu/kEyQWhS3+IJpMT1RpH4nW8at1DAhMb2K7rgBmT3A f+BA== X-Gm-Message-State: AKaTC03Jg1cYW/cPbkillFEVY0U0oWJXeGCwGe++uOjGKzt1b5gj1/llWDtL36dHerEz7Q== X-Received: by 10.28.178.205 with SMTP id b196mr17037325wmf.8.1480278777994; Sun, 27 Nov 2016 12:32:57 -0800 (PST) Received: from p (46.128.198.151.dynamic.cablesurf.de. [46.128.198.151]) by smtp.gmail.com with ESMTPSA id 14sm25212000wmk.1.2016.11.27.12.32.57 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 12:32:57 -0800 (PST) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Arguments of `ediff-janitor' undocumented Date: Sun, 27 Nov 2016 21:30:18 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) The function `ediff-janitor' has two required arguments, ASK and KEEP-JANITOR, which are not documented in the docstring. In GNU Emacs 26.0.50.2 (x86_64-apple-darwin16.1.0, NS appkit-1504.60 Version 10.12.1 (Build 16B2555)) of 2016-11-27 built on p Repository revision: 416adda38521c6246f77877c57843264fa4ae711 Windowing system distributor 'Apple', version 10.3.1504 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Quit Loading ediff...done Type C-x 1 to delete the help window. Configured using: 'configure --with-modules --enable-checking --enable-check-lisp-object-type --without-xml2 --disable-silent-rules 'CFLAGS=-ggdb3 -O0'' Configured features: RSVG IMAGEMAGICK DBUS NOTIFY ACL GNUTLS ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff cl-extra thingatpt help-fns radix-tree help-mode easymenu cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 214548 8247) (symbols 48 21296 0) (miscs 40 59 218) (strings 32 21922 6536) (string-bytes 1 726263) (vectors 16 36800) (vector-slots 8 690820 5774) (floats 8 196 20) (intervals 56 234 4) (buffers 976 12)) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 04:30:22 2016 Received: (at 25046-done) by debbugs.gnu.org; 2 Dec 2016 09:30:22 +0000 Received: from localhost ([127.0.0.1]:49494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCkAg-0006GN-Bx for submit@debbugs.gnu.org; Fri, 02 Dec 2016 04:30:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCkAf-0006G8-Eu for 25046-done@debbugs.gnu.org; Fri, 02 Dec 2016 04:30:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCkAX-00085I-5X for 25046-done@debbugs.gnu.org; Fri, 02 Dec 2016 04:30:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCkAX-00085E-2N; Fri, 02 Dec 2016 04:30:13 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1299 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCkAW-0000na-Bm; Fri, 02 Dec 2016 04:30:12 -0500 Date: Fri, 02 Dec 2016 11:30:21 +0200 Message-Id: <837f7ioez6.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Sun, 27 Nov 2016 21:30:18 +0100) Subject: Re: bug#25046: 26.0.50; Arguments of `ediff-janitor' undocumented References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25046-done Cc: 25046-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Philipp Stephani > Date: Sun, 27 Nov 2016 21:30:18 +0100 > > The function `ediff-janitor' has two required arguments, ASK and > KEEP-JANITOR, which are not documented in the docstring. Thanks, fixed on the emacs-25 branch. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 08:47:52 2016 Received: (at 25046-done) by debbugs.gnu.org; 2 Dec 2016 13:47:52 +0000 Received: from localhost ([127.0.0.1]:49609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoBr-0005dJ-Ts for submit@debbugs.gnu.org; Fri, 02 Dec 2016 08:47:52 -0500 Received: from mail-wj0-f169.google.com ([209.85.210.169]:36466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoBq-0005d4-9P for 25046-done@debbugs.gnu.org; Fri, 02 Dec 2016 08:47:50 -0500 Received: by mail-wj0-f169.google.com with SMTP id qp4so232612150wjc.3 for <25046-done@debbugs.gnu.org>; Fri, 02 Dec 2016 05:47:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=icAGlxWJBA9QhyY1bhbU+AUIKBnjgk/UZMBPb+jzXvU=; b=bWfvxhIkcYJklSjmex5N3vKeoyqqDqrF1UE9OHuRx2p7e+9KlQWcyGLXTUzwt2v4s4 WGb8Ald85S1Tocg/3pnb+UWbvavMWVT9/swn2ssw6UsBxbKL789mYKsPr69UMvjo55ej UvvLhNlrYxEP7y7yy3Vh9WuGp/EWIS6NkbgYjcbPUnIJH9qwEAU3gmqPBfG0g+yYQeCR cdB/adXGs9cxqu8mEvwEFrZhtWOyHsSEpdkGFKYoTqdn2ScAi6UXkIqTF8dK4rxx6W+z SbxZCs4mnQtYrG81VTOyNz9ccb0otU/SFXPZcGEU83saiCWg8MGXXUe4Ro4v8jcoffrQ osTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=icAGlxWJBA9QhyY1bhbU+AUIKBnjgk/UZMBPb+jzXvU=; b=adbldAXWFcUFqhaaDKxMpMcktEVdNOAHGl6VN7y481ya6fZkhlWeKU0kOfHcKDHLLP 2OwiSatcTS90kwevZ2R0+z9xP2WNe/ySP6SuXAxngwBpjY2+fOF8H6td7w8IGT2azQa+ QrZceLvG/YDRn1dCPBQ0Sl1bRM93Q5h7Rtst2NuYf0NHg/q4DzHZBvzkDWKB4QCTUHlJ fEhT7xjMkppjTp9lpie10a9qBYrKOaKkdSk2sT7qeqk9GsBkPQoCyhlpvuZtYHcVkriN XtmD1/6ViOyL6oUZTKShNQVTt/vcweZha4mgqaiAVJyypAg6vw0UO8Lz4LaUG26A/Gag awNw== X-Gm-Message-State: AKaTC02yMa9owLtXkefC57n4kWymxXzs6dqLR21uPCk9Za/MaO2mU8EB0/BatsOsvtiemo2ayxbTxwjhLoTptg== X-Received: by 10.194.95.35 with SMTP id dh3mr40124895wjb.141.1480686464449; Fri, 02 Dec 2016 05:47:44 -0800 (PST) MIME-Version: 1.0 References: <837f7ioez6.fsf@gnu.org> In-Reply-To: <837f7ioez6.fsf@gnu.org> From: Philipp Stephani Date: Fri, 02 Dec 2016 13:47:33 +0000 Message-ID: Subject: Re: bug#25046: 26.0.50; Arguments of `ediff-janitor' undocumented To: Eli Zaretskii Content-Type: multipart/alternative; boundary=047d7bb04050bcc6e70542ad2e29 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 25046-done Cc: 25046-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --047d7bb04050bcc6e70542ad2e29 Content-Type: text/plain; charset=UTF-8 Eli Zaretskii schrieb am Fr., 2. Dez. 2016 um 10:30 Uhr: > > From: Philipp Stephani > > Date: Sun, 27 Nov 2016 21:30:18 +0100 > > > > The function `ediff-janitor' has two required arguments, ASK and > > KEEP-JANITOR, which are not documented in the docstring. > > Thanks, fixed on the emacs-25 branch. > Thanks, however I'm still not quite sure about the meaning. "ASK non-nil means ask the user whether to keep each unmodified buffer, unless KEEP-VARIANTS is non-nil, in which case buffers are killed unconditionally." So if ASK = nil, KEEP-VARIANTS = nil: kill buffers, don't ask about any buffer ASK = (nil or non-nil), KEEP-VARIANTS = non-nil: don't kill any buffer, don't ask ASK = non-nil, KEEP-VARIANTS = nil: ask about each buffer If that's the case, shouldn't the documentation rather be something like: "If KEEP-VARIANTS is non-nil, only indirect buffers are killed [what does that mean for the user?], and ASK is ignored. Otherwise, if ASK is non-nil, ask the user for each unmodified buffer whether it should be killed. Otherwise (both ASK and KEEP-VARIANTS) are nil, all unmodified buffers are killed without confirmation." WDYT? --047d7bb04050bcc6e70542ad2e29 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Eli Za= retskii <eliz@gnu.org> schrieb am= Fr., 2. Dez. 2016 um 10:30=C2=A0Uhr:
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 27 Nov 2016 21:30:18 +0100
>
> The function `ediff-janitor' has two required arguments, ASK and > KEEP-JANITOR, which are not documented in the docstring.

Thanks, fixed on the emacs-25 branch.
<= div>
Thanks, however I'm still not quite sure about the m= eaning.
"ASK non-nil means ask the user whether to keep each= unmodified buffer, unless KEEP-VARIANTS is non-nil, in which case buffers = are killed unconditionally."
So if ASK =3D nil, KEEP-VARIANT= S =3D nil: kill buffers, don't ask about any buffer
ASK =3D (= nil or non-nil), KEEP-VARIANTS =3D non-nil: don't kill any buffer, don&= #39;t ask
ASK =3D non-nil, KEEP-VARIANTS =3D nil: ask about each = buffer

If that's the case, shouldn't the d= ocumentation rather be something like:
"If KEEP-VARIANTS is = non-nil, only indirect buffers are killed [what does that mean for the user= ?], and ASK is ignored. Otherwise, if ASK is non-nil, ask the user for each= unmodified buffer whether it should be killed. Otherwise (both ASK and KEE= P-VARIANTS) are nil, all unmodified buffers are killed without confirmation= ."
WDYT?=C2=A0
--047d7bb04050bcc6e70542ad2e29-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 09:37:57 2016 Received: (at 25046) by debbugs.gnu.org; 2 Dec 2016 14:37:57 +0000 Received: from localhost ([127.0.0.1]:49653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoyK-0006oT-OF for submit@debbugs.gnu.org; Fri, 02 Dec 2016 09:37:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCoyI-0006oG-Sk for 25046@debbugs.gnu.org; Fri, 02 Dec 2016 09:37:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCoy8-0005zW-VT for 25046@debbugs.gnu.org; Fri, 02 Dec 2016 09:37:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCoy8-0005zH-Rg; Fri, 02 Dec 2016 09:37:44 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1697 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCoy4-0000pD-Kq; Fri, 02 Dec 2016 09:37:41 -0500 Date: Fri, 02 Dec 2016 16:37:48 +0200 Message-Id: <83twammm6b.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-reply-to: (message from Philipp Stephani on Fri, 02 Dec 2016 13:47:33 +0000) Subject: Re: bug#25046: 26.0.50; Arguments of `ediff-janitor' undocumented References: <837f7ioez6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25046 Cc: 25046@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Philipp Stephani > Date: Fri, 02 Dec 2016 13:47:33 +0000 > Cc: 25046-done@debbugs.gnu.org > > Thanks, however I'm still not quite sure about the meaning. > "ASK non-nil means ask the user whether to keep each unmodified buffer, unless KEEP-VARIANTS is > non-nil, in which case buffers are killed unconditionally." > So if ASK = nil, KEEP-VARIANTS = nil: kill buffers, don't ask about any buffer Yes. > ASK = (nil or non-nil), KEEP-VARIANTS = non-nil: don't kill any buffer, don't ask Yes, I've goofed. KEEP-VARIANTS non-nil means never kill. Now fixed. > ASK = non-nil, KEEP-VARIANTS = nil: ask about each buffer Yes. > If that's the case, shouldn't the documentation rather be something like: > "If KEEP-VARIANTS is non-nil, only indirect buffers are killed [what does that mean for the user?], and ASK is > ignored. Otherwise, if ASK is non-nil, ask the user for each unmodified buffer whether it should be killed. > Otherwise (both ASK and KEEP-VARIANTS) are nil, all unmodified buffers are killed without confirmation." > WDYT? I don't think mentioning indirect buffers will add anything but confusion. I fixed the incorrect meaning of KEEP-VARIANTS, and I think the result is okay, definitely so for an internal utility function. Thanks. From unknown Sat Aug 09 22:37:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 31 Dec 2016 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator