From unknown Tue Aug 19 05:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2016 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25032@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.148011969211268 (code B ref -1); Sat, 26 Nov 2016 00:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Nov 2016 00:21:32 +0000 Received: from localhost ([127.0.0.1]:41914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkF-0002vg-Uy for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkD-0002vQ-5d for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQk7-0002WL-3A for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAQk7-0002WF-0S for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAQk5-00062i-RQ for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQk0-0002TT-Tf for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:21 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20821) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAQk0-0002SY-Jh for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:16 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uAQ0LDVw014825 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 26 Nov 2016 00:21:14 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uAQ0LDlC011539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 26 Nov 2016 00:21:13 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id uAQ0LDGN029338 for ; Sat, 26 Nov 2016 00:21:13 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 25 Nov 2016 16:21:12 -0800 (PST) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Why is "internal" function `bookmark-set-internal' a _command_ (interactive)? What sense does an "internal" command make? It seems that the `interactive' spec here was a copy+paste mistake. It should be removed, I think. 2. The `interactive' spec for `bookmark-set-internal' seems wrong anyway. NAME is the raw prefix arg? And then NAME is simply taken as is (as STR) and compared using `string-equal'? This cannot be correct. 3. Similarly, why does the doc string of `bookmark-set-internal' say "_Interactively_..."? It should just say that it prompts for a bookmark name and then... And "error" is not easily and commonly understood as a verb - use "raise an error" instead. 4. `bookmark-set-internal' should preferably not accept both args PROMPT and NAME. If NAME is present (e.g. for non-interactive use of `bookmark-set') then PROMPT makes no sense and is not used (and the doc string is wrong about PROMPT in that case). =20 5. In `bookmark-set-internal', a nil third arg should have been used to mean overwrite, not raise an error, as overwriting is still, and always has been, the default behavior of `bookmark-set'. You should have introduced the new value `error', not the new value `overwrite', and kept the default (nil) behavior as overwriting. You will no doubt argue that this does not matter because `bookmark-set-internal' is "internal". But the main command is still, and should still be `bookmark-set'. `bookmark-set-internal' should reflect _its_ behavior for the default case (nil). 6. Error messages, like other messages, should not end with a period. No doubt it is "too late" for #4 and #5. Hopefully not for the rest. In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17 built on LAPHROAIG Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --without-dbus --without-compress-install CFLAGS=3D-static' From unknown Tue Aug 19 05:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' References: In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jun 2019 09:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 25032@debbugs.gnu.org, Drew Adams Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156033059313668 (code B ref 25032); Wed, 12 Jun 2019 09:10:02 +0000 Received: (at 25032) by debbugs.gnu.org; 12 Jun 2019 09:09:53 +0000 Received: from localhost ([127.0.0.1]:60707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hazGS-0003YN-Vh for submit@debbugs.gnu.org; Wed, 12 Jun 2019 05:09:53 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:40914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hazGQ-0003Y5-L1 for 25032@debbugs.gnu.org; Wed, 12 Jun 2019 05:09:51 -0400 Received: by mail-wm1-f49.google.com with SMTP id v19so5677231wmj.5 for <25032@debbugs.gnu.org>; Wed, 12 Jun 2019 02:09:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9w4Klhk5ksFQBxwfkexxrURPF/3v2iRWciNco9M8MLI=; b=eFWnPzLL5bZSqjDgiS+vP5SVzET7/zV6sAcTvGBwt2I/bqXrPe5uq7KN+joG5BXVyv R+oXsr7bXtlnGD5NNSkGTJeMnGeNgtN9f1y4DVzj68FYiqJ0Ni6l4CFmUcztV5vugNEc uzCGJVsIBqWvWMj10a5CM3/7b92d+UbEbZMOJIIGQwQ8vJpOWhuWLVzUKBzl+SlKmfnV 26RpJb0/Goxpz9BewOrMVQ8Jyd9UIFXsajKnlUHEfof5guTTP5BqWgMThlK/K832jFAs cj71xhdfwlgzEB51/CRdl2XatL7FouAKdM9I78yrHZiftMmDvyAetM8CIZZA4G3OngeW m2eQ== X-Gm-Message-State: APjAAAVogkNp4JbSWNwD39s26FGyxBcPgWIptEmmeFnRiTTEeLR1UGnk AZJrvsEmqA1VFDqM/b525U/PY7kR8birURb0sU7d9xpl X-Google-Smtp-Source: APXvYqypt+5+kx/SMQhKJhknfGcewkJ/sqAMn/mUaNx7AgMQGDOazvtz9ovOtW/DjNtepg0akSEyg4j34hPfFvaccgY= X-Received: by 2002:a1c:f515:: with SMTP id t21mr2329698wmh.39.1560330584463; Wed, 12 Jun 2019 02:09:44 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 12 Jun 2019 11:09:33 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Drew Adams writes: > 1. Why is "internal" function `bookmark-set-internal' a _command_ > (interactive)? What sense does an "internal" command make? It seems > that the `interactive' spec here was a copy+paste mistake. It should > be removed, I think. > > 2. The `interactive' spec for `bookmark-set-internal' seems wrong > anyway. NAME is the raw prefix arg? And then NAME is simply taken > as is (as STR) and compared using `string-equal'? This cannot be > correct. This has now been fixed. See bug#36121. > 6. Error messages, like other messages, should not end with a period. This too has been fixed. See bug#35916. Best regards, Stefan Kangas From unknown Tue Aug 19 05:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' References: In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 05:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 25032@debbugs.gnu.org Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156204502722803 (code B ref 25032); Tue, 02 Jul 2019 05:24:02 +0000 Received: (at 25032) by debbugs.gnu.org; 2 Jul 2019 05:23:47 +0000 Received: from localhost ([127.0.0.1]:46460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiBGc-0005vj-Sa for submit@debbugs.gnu.org; Tue, 02 Jul 2019 01:23:47 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:37040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiBGa-0005vW-K0 for 25032@debbugs.gnu.org; Tue, 02 Jul 2019 01:23:45 -0400 Received: by mail-wm1-f44.google.com with SMTP id f17so1737303wme.2 for <25032@debbugs.gnu.org>; Mon, 01 Jul 2019 22:23:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=4CltBeYUySvyiT+eIa+4Xz+fCuZ1eqiNQ6c9uK44emE=; b=GQa/KLMUyh2KSw8OLzwDrjyaUzTCIwUkCOvTe5Thbv5WgsCCo/EkGiIc/PinH9US4v VkCBoCHx5gaGqfq7uXJ6/MKHyGZ+Q1X22+W2Oa+Flp1fClmLf1IcN9rScLrDPJfnRxKE O/T3Pp+GabuwKXAeRG05F7+aVXORzaanZBsvtTnt/Fg8273Y2zTgqOBFeSfAb0FhRhKo 4QNCpxnptgyVfTBLwXTcxUq7SaxZwPwk9Oc+w83N9Tw4sXhywG/vkJwb/uVsR7TsZEB3 y4AYR2ZCYaI02HG4KM1i9tKo7ybiVWvmyPKXhlP01L5xfWMbn0tGK0r7H83MzprsiMM0 Do+Q== X-Gm-Message-State: APjAAAXb8VxsjEikwETKset7216JtDcwVm2BDtlptG1vACZdgS9u/ZPQ XDqYnbnavZnv+qVO9Y7f4uc0Dwrwu65aqejZAJo= X-Google-Smtp-Source: APXvYqxiJUuHoEtx++gjJL3vgGReJGuNdWc9of7BFLZccEdPX4nDcmxCGdQezUWLhcHRk7sejSZEiOhIDZxcsyhf0/Y= X-Received: by 2002:a1c:9696:: with SMTP id y144mr1804954wmd.73.1562045018681; Mon, 01 Jul 2019 22:23:38 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 2 Jul 2019 07:23:27 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Drew Adams writes: > 3. Similarly, why does the doc string of `bookmark-set-internal' say > "_Interactively_..."? It should just say that it prompts for a > bookmark name and then... And "error" is not easily and commonly > understood as a verb - use "raise an error" instead. I have attached a patch which tries to improve the doc string. > 4. `bookmark-set-internal' should preferably not accept both args PROMPT > and NAME. See below. > If NAME is present (e.g. for non-interactive use of > `bookmark-set') then PROMPT makes no sense and is not used (and the > doc string is wrong about PROMPT in that case). Please see if my above patch does not improve the situation. > 5. In `bookmark-set-internal', a nil third arg should have been used to > mean overwrite, not raise an error, as overwriting is still, and > always has been, the default behavior of `bookmark-set'. You should > have introduced the new value `error', not the new value `overwrite', > and kept the default (nil) behavior as overwriting. I see your point. But on the other hand a user can just use bookmark-set and bookmark-set-overwrite, which are not advertised as internal. > You will no doubt argue that this does not matter because > `bookmark-set-internal' is "internal". But the main command is > still, and should still be `bookmark-set'. `bookmark-set-internal' > should reflect _its_ behavior for the default case (nil). I suspect that some of the things above will be a bit tricky to fix if we still want to keep this as a general (internal) function used by bookmark-set and bookmark-set-internal. Which would be the main purpose of this function, as I understand it. The way it's written actually makes the implementation of the latter two functions very straghtforward. The code is not very hard to follow, in my opinion. But it's harder to think of a better alternative. So, after we improve the doc string, this reviewer sees two options for moving forward here: 1. Someone writes up a concrete suggestion. 2. We close this as wontfix and move on. Thanks, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 01:26:35 2019 Received: (at control) by debbugs.gnu.org; 2 Jul 2019 05:26:35 +0000 Received: from localhost ([127.0.0.1]:46466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiBJL-000608-Cn for submit@debbugs.gnu.org; Tue, 02 Jul 2019 01:26:35 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:40644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiBJJ-0005zn-VF for control@debbugs.gnu.org; Tue, 02 Jul 2019 01:26:34 -0400 Received: by mail-wr1-f50.google.com with SMTP id p11so16170733wre.7 for ; Mon, 01 Jul 2019 22:26:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=BYJYjwPmflc+BYKPrKUd90rxRhKP/GXU50mrVyhkx6w=; b=eiOxliwebIxhze+iPHgdo4JPj304bYBmdXbVs3D1wjJlIHbQlX1MaMB7dEurckh8US qapd3Wl4RifcvoR0dQuer+j9DzOCQkAlwJ0ZcTlCeyBDjxh40fMn8v1mnnALhJ8INxoA +M+cAo8bVYVNTAZfN3spsbR/awasQ8IJ3m+gzuZh/vKjPDEVFaEzoDgPqw+VokEwNG5r whcKAqxXw74sTYO8YeRtQ4y6s3IWuscL05sUOwIyL/1jPpLy9m32mPwSYK6LQQzFKRHS EQadUwXKh0JZL/cEpCExDtaclb7qKWmcRnCms9AjsVhI/8tZZGVDZ1zaH8Lc2aBPHmP5 3BmQ== X-Gm-Message-State: APjAAAW9rrmrGfbZpICeLFAbymi11dfvYsEiXUXArEk5SVJ/JfPDMK4q XnOQAN6z3mS03d2vtCF3AL+SW6keBBE+0vTGpCl0vMMH X-Google-Smtp-Source: APXvYqyJp1tr0TjNz3BApfaDhonNn57+mr8BYYn23v71wZc0zBbSYQFZDj+K1C9rizKszjukc97a9kTzgzQtOuFtpos= X-Received: by 2002:a5d:4609:: with SMTP id t9mr6502560wrq.85.1562045187549; Mon, 01 Jul 2019 22:26:27 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 2 Jul 2019 07:26:16 +0200 Message-ID: Subject: 25032 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) severity 25032 wishlist quit From unknown Tue Aug 19 05:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 05:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 25032@debbugs.gnu.org Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156204527223223 (code B ref 25032); Tue, 02 Jul 2019 05:28:01 +0000 Received: (at 25032) by debbugs.gnu.org; 2 Jul 2019 05:27:52 +0000 Received: from localhost ([127.0.0.1]:46471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiBKa-00062V-MK for submit@debbugs.gnu.org; Tue, 02 Jul 2019 01:27:52 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:51970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiBKZ-00062I-7J for 25032@debbugs.gnu.org; Tue, 02 Jul 2019 01:27:51 -0400 Received: by mail-wm1-f46.google.com with SMTP id 207so1565953wma.1 for <25032@debbugs.gnu.org>; Mon, 01 Jul 2019 22:27:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2MK0vh8yD4otGbM+VO+vDNm6y++QTSL1RQXbungdpj0=; b=gJHkeavy9VM0a9Fd8oZqu519Pa/YwbA3NwqvBOTxuVewssyVMCNtvreORokKycw80Z RjDMFpxpYe0tMQYpH63lakO7/b8cMDznCFcgvhoKGemtrxjvlojSUzQRR2yv31w6syf0 1D6taJnX6te9DJ2d0sF6YZqpYJ2ceafrhUDI4pCut7WZlpMtWpBea0t5TRmt9kSkUeqJ b+YuI5uE6EkfAP5EofAt3FBxBFLYPLu7XrJEeNdVHhEQmFoeFvxYeZXw6fa2UvFRkH86 auFjzq7RWeAGcTkmkPdM1qpfGBTO2LIz313I8gEEIp3Z8bBSRNKMqGGjohF2Z9+OEfea +wnw== X-Gm-Message-State: APjAAAX2w1Q/uk2WCxAZDmjlzNCIx2BMIYTSckNTfBRxvoqbWavPAGCF dYA0fY0uG2EajBm54gNSezvPrXjW4oYDWgNZx/U= X-Google-Smtp-Source: APXvYqzugp97onL2l5lc28qiFRv8Gb6i5IQ4cp+TRbsCanJNg+/DE5MwcR3JJyBXTn32vtJEeZJusNojIH4kS4sWQt8= X-Received: by 2002:a1c:9696:: with SMTP id y144mr1822942wmd.73.1562045265534; Mon, 01 Jul 2019 22:27:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Tue, 2 Jul 2019 07:27:34 +0200 Message-ID: Content-Type: multipart/mixed; boundary="0000000000002d0408058cac01ca" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000002d0408058cac01ca Content-Type: text/plain; charset="UTF-8" Patch attached. Thanks, Stefan Kangas --0000000000002d0408058cac01ca Content-Type: application/octet-stream; name="0001-lisp-bookmark.el-bookmark-set-internal-Doc-fix.-Bug-.patch" Content-Disposition: attachment; filename="0001-lisp-bookmark.el-bookmark-set-internal-Doc-fix.-Bug-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxlder680 RnJvbSA3MzJmNDkyMmFlOGU0YTA2ZjE0ZjcwZDA0ODVmOWY4MTZmYjFmNjBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDc6MDk6MTMgKzAyMDAKU3ViamVjdDogW1BBVENIXSAq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNldC1pbnRlcm5hbCk6IERvYyBmaXguCiAoQnVn IzI1MDMyKQoKLS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMjkgKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlzcC9ib29rbWFyay5lbAppbmRl eCBiYmVmMGE5MjdkLi5jMjg5OWZhOWYxIDEwMDY0NAotLS0gYS9saXNwL2Jvb2ttYXJrLmVsCisr KyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTc2MywxOCArNzYzLDIzIEBAIGJvb2ttYXJrLW1pbmli dWZmZXItcmVhZC1uYW1lLW1hcAogICAgIG1hcCkpCiAKIChkZWZ1biBib29rbWFyay1zZXQtaW50 ZXJuYWwgKHByb21wdCBuYW1lIG92ZXJ3cml0ZS1vci1wdXNoKQotICAiSW50ZXJhY3RpdmVseSBz ZXQgYSBib29rbWFyayBuYW1lZCBOQU1FIGF0IHRoZSBjdXJyZW50IGxvY2F0aW9uLgotCi1CZWdp biB0aGUgaW50ZXJhY3RpdmUgcHJvbXB0IHdpdGggUFJPTVBULCBmb2xsb3dlZCBieSBhIHNwYWNl LCBhCi1nZW5lcmF0ZWQgZGVmYXVsdCBuYW1lIGluIHBhcmVudGhlc2VzLCBhIGNvbG9uIGFuZCBh IHNwYWNlLgotCi1JZiBPVkVSV1JJVEUtT1ItUFVTSCBpcyBuaWwsIHRoZW4gZXJyb3IgaWYgdGhl cmUgaXMgYWxyZWFkeSBhCi1ib29rbWFyayBuYW1lZCBOQU1FOyBpZiBgb3ZlcndyaXRlJywgdGhl biByZXBsYWNlIGFueSBleGlzdGluZwotYm9va21hcmsgaWYgdGhlcmUgaXMgb25lOyBpZiBgcHVz aCcgdGhlbiBwdXNoIHRoZSBuZXcgYm9va21hcmsKLW9udG8gdGhlIGJvb2ttYXJrIGFsaXN0LiAg VGhlIGBwdXNoJyBiZWhhdmlvciBtZWFucyB0aGF0IGFtb25nCi1ib29rbWFya3MgbmFtZWQgTkFN RSwgdGhpcyBtb3N0IHJlY2VudGx5IHNldCBvbmUgYmVjb21lcyB0aGUgb25lIGluCi1lZmZlY3Qs IGJ1dCB0aGUgb3RoZXJzIGFyZSBzdGlsbCB0aGVyZSwgaW4gb3JkZXIsIGlmIHRoZSB0b3Btb3N0 IG9uZQotaXMgZXZlciBkZWxldGVkLiIKKyAgIlNldCBhIGJvb2ttYXJrIHVzaW5nIHNwZWNpZmll ZCBOQU1FIG9yIHByb21wdGluZyB3aXRoIFBST01QVC4KK1RoZSBib29rbWFyayBpcyBzZXQgYXQg dGhlIGN1cnJlbnQgbG9jYXRpb24uCisKK0lmIE5BTUUgaXMgbm9uLW5pbCwgdXNlIGl0IGFzIHRo ZSBuYW1lIG9mIHRoZSBuZXcgYm9va21hcmsuICBJbgordGhpcyBjYXNlLCB0aGUgdmFsdWUgb2Yg UFJPTVBUIGlzIGlnbm9yZWQuCisKK090aGVyd2lzZSwgcHJvbXB0IHRoZSB1c2VyIGZvciB0aGUg Ym9va21hcmsgbmFtZS4gIEJlZ2luIHRoZQoraW50ZXJhY3RpdmUgcHJvbXB0IHdpdGggUFJPTVBU LCBmb2xsb3dlZCBieSBhIHNwYWNlLCBhIGdlbmVyYXRlZAorZGVmYXVsdCBuYW1lIGluIHBhcmVu dGhlc2VzLCBhIGNvbG9uIGFuZCBhIHNwYWNlLgorCitJZiBPVkVSV1JJVEUtT1ItUFVTSCBpcyBu aWwsIHRoZW4gcmFpc2UgYW4gZXJyb3IgaWYgdGhlcmUgaXMKK2FscmVhZHkgYSBib29rbWFyayBu YW1lZCBOQU1FOyBpZiBgb3ZlcndyaXRlJywgdGhlbiByZXBsYWNlIGFueQorZXhpc3RpbmcgYm9v a21hcmsgaWYgdGhlcmUgaXMgb25lOyBpZiBgcHVzaCcgdGhlbiBwdXNoIHRoZSBuZXcKK2Jvb2tt YXJrIG9udG8gdGhlIGJvb2ttYXJrIGFsaXN0LiAgVGhlIGBwdXNoJyBiZWhhdmlvciBtZWFucyB0 aGF0CithbW9uZyBib29rbWFya3MgbmFtZWQgTkFNRSwgdGhpcyBtb3N0IHJlY2VudGx5IHNldCBv bmUgYmVjb21lcwordGhlIG9uZSBpbiBlZmZlY3QsIGJ1dCB0aGUgb3RoZXJzIGFyZSBzdGlsbCB0 aGVyZSwgaW4gb3JkZXIsIGlmCit0aGUgdG9wbW9zdCBvbmUgaXMgZXZlciBkZWxldGVkLiIKICAg KHVud2luZC1wcm90ZWN0CiAgICAgICAgKGxldCogKChyZWNvcmQgKGJvb2ttYXJrLW1ha2UtcmVj b3JkKSkKICAgICAgICAgICAgICAgOzsgYGRlZmF1bHRzJyBpcyBhIHRyYW5zaWVudCBlbGVtZW50 IG9mIHRoZQotLSAKMi4yMS4wCgo= --0000000000002d0408058cac01ca-- From unknown Tue Aug 19 05:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 25032@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156208613823133 (code B ref 25032); Tue, 02 Jul 2019 16:49:02 +0000 Received: (at 25032) by debbugs.gnu.org; 2 Jul 2019 16:48:58 +0000 Received: from localhost ([127.0.0.1]:47796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLxh-000612-Rd for submit@debbugs.gnu.org; Tue, 02 Jul 2019 12:48:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLxg-00060o-NE for 25032@debbugs.gnu.org; Tue, 02 Jul 2019 12:48:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiLxY-0005kB-Vf; Tue, 02 Jul 2019 12:48:50 -0400 Received: from [176.228.60.248] (port=1173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiLxY-0008P4-Cf; Tue, 02 Jul 2019 12:48:48 -0400 Date: Tue, 02 Jul 2019 19:48:34 +0300 Message-Id: <83y31gcrh9.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Stefan Kangas on Tue, 2 Jul 2019 07:27:34 +0200) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Jul 2019 07:27:34 +0200 > Cc: 25032@debbugs.gnu.org > > +If OVERWRITE-OR-PUSH is nil, then raise an error if there is We use "signal an error". > +already a bookmark named NAME; if `overwrite', then replace any > +existing bookmark if there is one; if `push' then push the new > +bookmark onto the bookmark alist. It is generally better to precede a description of several optional behaviors with a short summary: OVERWRITE-OR-PUSH controls what happens if there is already a bookmark by that NAME: nil means signal an error, `overwrite' means replace the existing bookmark, `push' means ... From unknown Tue Aug 19 05:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25032 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 25032@debbugs.gnu.org, Drew Adams Received: via spool by 25032-submit@debbugs.gnu.org id=B25032.156208729625840 (code B ref 25032); Tue, 02 Jul 2019 17:09:01 +0000 Received: (at 25032) by debbugs.gnu.org; 2 Jul 2019 17:08:16 +0000 Received: from localhost ([127.0.0.1]:47824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiMGO-0006ii-1T for submit@debbugs.gnu.org; Tue, 02 Jul 2019 13:08:16 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:35094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiMGM-0006iK-Ok for 25032@debbugs.gnu.org; Tue, 02 Jul 2019 13:08:15 -0400 Received: by mail-wr1-f48.google.com with SMTP id c27so11019513wrb.2 for <25032@debbugs.gnu.org>; Tue, 02 Jul 2019 10:08:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q4e83L7o9M1SAzF1qXw1i9fQU2Ppu/0V5shM4dhJOFo=; b=rdIwDHLmw2s76zu/nLq7t+AfmU9lq+hECov6DUJ2uDdMkxDEtQ0Ru889lp6oNb7o++ 15lNlbIxzmSXV/Oua91fhGsIqmtn4DgN5N1sJCXWQW50ixupExpFGyJRwQdknir2R6Q+ /XQhidl5P4WrJK7cFvIa5cbt+3ujp3okOoNiqZjYgu2SKzaBCV95lPjJdR2+CnjtVSVx I3ZSPELURPDRyQBQVtW+K8U5tGsAGV5TF2G0EevukVNhWwDvOaPT3tk8VjaKr2rzns0L PPu60+BWtHc+s+3+240r72KS6PxdQmLY8yMsYIPhCxkZ5anQCuuHQZoUWbcMXiVOWTDG pLig== X-Gm-Message-State: APjAAAVQI31ox5r+bh3Z0BF1RMF0KJkSGThDZ31Pfp+g+nlz5wZSN2ov +DTUzIx0YNQwPDZXLyOwnhi08Rn+u7gYYUxPwPM= X-Google-Smtp-Source: APXvYqykfB410I0c26LV+nIzElljZPAAIXnsgCXUmGNlwcpPovKM6sekslGa8LcNSHEYKASAr9l+iQgwQYgcBi+52D4= X-Received: by 2002:adf:eb49:: with SMTP id u9mr25500267wrn.215.1562087289109; Tue, 02 Jul 2019 10:08:09 -0700 (PDT) MIME-Version: 1.0 References: <83y31gcrh9.fsf@gnu.org> In-Reply-To: <83y31gcrh9.fsf@gnu.org> From: Stefan Kangas Date: Tue, 2 Jul 2019 19:07:57 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000f9e603058cb5c927" X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --000000000000f9e603058cb5c927 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > > +If OVERWRITE-OR-PUSH is nil, then raise an error if there is > > We use "signal an error". Fixed. > > +already a bookmark named NAME; if `overwrite', then replace any > > +existing bookmark if there is one; if `push' then push the new > > +bookmark onto the bookmark alist. > > It is generally better to precede a description of several optional > behaviors with a short summary: > > OVERWRITE-OR-PUSH controls what happens if there is already a > bookmark by that NAME: nil means signal an error, `overwrite' means > replace the existing bookmark, `push' means ... Fixed. Although I chose the wording "with the same name" rather than "by that NAME", since the name could also come from the prompt. Thanks for the review; attached an updated version. Best regards, Stefan Kangas --000000000000f9e603058cb5c927 Content-Type: application/octet-stream; name="0001-lisp-bookmark.el-bookmark-set-internal-Doc-fix.-Bug-2.patch" Content-Disposition: attachment; filename="0001-lisp-bookmark.el-bookmark-set-internal-Doc-fix.-Bug-2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxm2f8sf0 RnJvbSA3YjcyYzM2NDJmNGNjMDE3YjE0NzdiMDM3N2ZiMTc1MjZmMGRjMGY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDIgSnVsIDIwMTkgMDc6MDk6MTMgKzAyMDAKU3ViamVjdDogW1BBVENIXSAq IGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLXNldC1pbnRlcm5hbCk6IERvYyBmaXguCiAoQnVn IzI1MDMyKQoKLS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMjkgKysrKysrKysrKysrKysrKystLS0t LS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlzcC9ib29rbWFyay5lbAppbmRl eCBiYmVmMGE5MjdkLi5lMTkwNjQ5ZmQxIDEwMDY0NAotLS0gYS9saXNwL2Jvb2ttYXJrLmVsCisr KyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTc2MywxOCArNzYzLDIzIEBAIGJvb2ttYXJrLW1pbmli dWZmZXItcmVhZC1uYW1lLW1hcAogICAgIG1hcCkpCiAKIChkZWZ1biBib29rbWFyay1zZXQtaW50 ZXJuYWwgKHByb21wdCBuYW1lIG92ZXJ3cml0ZS1vci1wdXNoKQotICAiSW50ZXJhY3RpdmVseSBz ZXQgYSBib29rbWFyayBuYW1lZCBOQU1FIGF0IHRoZSBjdXJyZW50IGxvY2F0aW9uLgotCi1CZWdp biB0aGUgaW50ZXJhY3RpdmUgcHJvbXB0IHdpdGggUFJPTVBULCBmb2xsb3dlZCBieSBhIHNwYWNl LCBhCi1nZW5lcmF0ZWQgZGVmYXVsdCBuYW1lIGluIHBhcmVudGhlc2VzLCBhIGNvbG9uIGFuZCBh IHNwYWNlLgotCi1JZiBPVkVSV1JJVEUtT1ItUFVTSCBpcyBuaWwsIHRoZW4gZXJyb3IgaWYgdGhl cmUgaXMgYWxyZWFkeSBhCi1ib29rbWFyayBuYW1lZCBOQU1FOyBpZiBgb3ZlcndyaXRlJywgdGhl biByZXBsYWNlIGFueSBleGlzdGluZwotYm9va21hcmsgaWYgdGhlcmUgaXMgb25lOyBpZiBgcHVz aCcgdGhlbiBwdXNoIHRoZSBuZXcgYm9va21hcmsKLW9udG8gdGhlIGJvb2ttYXJrIGFsaXN0LiAg VGhlIGBwdXNoJyBiZWhhdmlvciBtZWFucyB0aGF0IGFtb25nCi1ib29rbWFya3MgbmFtZWQgTkFN RSwgdGhpcyBtb3N0IHJlY2VudGx5IHNldCBvbmUgYmVjb21lcyB0aGUgb25lIGluCi1lZmZlY3Qs IGJ1dCB0aGUgb3RoZXJzIGFyZSBzdGlsbCB0aGVyZSwgaW4gb3JkZXIsIGlmIHRoZSB0b3Btb3N0 IG9uZQotaXMgZXZlciBkZWxldGVkLiIKKyAgIlNldCBhIGJvb2ttYXJrIHVzaW5nIHNwZWNpZmll ZCBOQU1FIG9yIHByb21wdGluZyB3aXRoIFBST01QVC4KK1RoZSBib29rbWFyayBpcyBzZXQgYXQg dGhlIGN1cnJlbnQgbG9jYXRpb24uCisKK0lmIE5BTUUgaXMgbm9uLW5pbCwgdXNlIGl0IGFzIHRo ZSBuYW1lIG9mIHRoZSBuZXcgYm9va21hcmsuICBJbgordGhpcyBjYXNlLCB0aGUgdmFsdWUgb2Yg UFJPTVBUIGlzIGlnbm9yZWQuCisKK090aGVyd2lzZSwgcHJvbXB0IHRoZSB1c2VyIGZvciB0aGUg Ym9va21hcmsgbmFtZS4gIEJlZ2luIHRoZQoraW50ZXJhY3RpdmUgcHJvbXB0IHdpdGggUFJPTVBU LCBmb2xsb3dlZCBieSBhIHNwYWNlLCBhIGdlbmVyYXRlZAorZGVmYXVsdCBuYW1lIGluIHBhcmVu dGhlc2VzLCBhIGNvbG9uIGFuZCBhIHNwYWNlLgorCitPVkVSV1JJVEUtT1ItUFVTSCBjb250cm9s cyB3aGF0IGhhcHBlbnMgaWYgdGhlcmUgaXMgYWxyZWFkeSBhCitib29rbWFyayB3aXRoIHRoZSBz YW1lIG5hbWU6IG5pbCBtZWFucyBzaWduYWwgYW4gZXJyb3I7Citgb3ZlcndyaXRlJyBtZWFucyBy ZXBsYWNlIGFueSBleGlzdGluZyBib29rbWFyazsgYHB1c2gnIG1lYW5zCitwdXNoIHRoZSBuZXcg Ym9va21hcmsgb250byB0aGUgYm9va21hcmsgYWxpc3QuICBUaGUgYHB1c2gnCitiZWhhdmlvciBt ZWFucyB0aGF0IGFtb25nIGJvb2ttYXJrcyB3aXRoIHRoZSBzYW1lIG5hbWUsIHRoaXMgbW9zdAor cmVjZW50bHkgc2V0IG9uZSBiZWNvbWVzIHRoZSBvbmUgaW4gZWZmZWN0LCBidXQgdGhlIG90aGVy cyBhcmUKK3N0aWxsIHRoZXJlLCBpbiBvcmRlciwgaWYgdGhlIHRvcG1vc3Qgb25lIGlzIGV2ZXIg ZGVsZXRlZC4iCiAgICh1bndpbmQtcHJvdGVjdAogICAgICAgIChsZXQqICgocmVjb3JkIChib29r bWFyay1tYWtlLXJlY29yZCkpCiAgICAgICAgICAgICAgIDs7IGBkZWZhdWx0cycgaXMgYSB0cmFu c2llbnQgZWxlbWVudCBvZiB0aGUKLS0gCjIuMjEuMAoK --000000000000f9e603058cb5c927-- From unknown Tue Aug 19 05:09:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Drew Adams Subject: bug#25032: closed (Re: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite') Message-ID: References: <83tvbz8rty.fsf@gnu.org> X-Gnu-PR-Message: they-closed 25032 X-Gnu-PR-Package: emacs Reply-To: 25032@debbugs.gnu.org Date: Sat, 06 Jul 2019 08:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1562403422-16694-1" This is a multi-part message in MIME format... ------------=_1562403422-16694-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 25032@debbugs.gnu.org. --=20 25032: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25032 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1562403422-16694-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 25032-done) by debbugs.gnu.org; 6 Jul 2019 08:56:06 +0000 Received: from localhost ([127.0.0.1]:54207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjgUI-0004K8-Cj for submit@debbugs.gnu.org; Sat, 06 Jul 2019 04:56:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hjgUG-0004Jf-IO for 25032-done@debbugs.gnu.org; Sat, 06 Jul 2019 04:56:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52088) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hjgUB-0004ob-2K; Sat, 06 Jul 2019 04:55:59 -0400 Received: from [176.228.60.248] (port=4613 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hjgUA-0007x6-9G; Sat, 06 Jul 2019 04:55:58 -0400 Date: Sat, 06 Jul 2019 11:55:53 +0300 Message-Id: <83tvbz8rty.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Tue, 2 Jul 2019 19:07:57 +0200) Subject: Re: bug#25032: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' References: <83y31gcrh9.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 25032-done Cc: drew.adams@oracle.com, 25032-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 2 Jul 2019 19:07:57 +0200 > Cc: Drew Adams , 25032@debbugs.gnu.org > > Thanks for the review; attached an updated version. Thanks, I pushed this to the master branch. ------------=_1562403422-16694-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 Nov 2016 00:21:32 +0000 Received: from localhost ([127.0.0.1]:41914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkF-0002vg-Uy for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:32 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAQkD-0002vQ-5d for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQk7-0002WL-3A for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAQk7-0002WF-0S for submit@debbugs.gnu.org; Fri, 25 Nov 2016 19:21:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAQk5-00062i-RQ for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAQk0-0002TT-Tf for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:21 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20821) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAQk0-0002SY-Jh for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 19:21:16 -0500 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uAQ0LDVw014825 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 26 Nov 2016 00:21:14 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id uAQ0LDlC011539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sat, 26 Nov 2016 00:21:13 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id uAQ0LDGN029338 for ; Sat, 26 Nov 2016 00:21:13 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 25 Nov 2016 16:21:12 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.1; `bookmark-set-internal', `bookmark-set-no-overwrite' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Why is "internal" function `bookmark-set-internal' a _command_ (interactive)? What sense does an "internal" command make? It seems that the `interactive' spec here was a copy+paste mistake. It should be removed, I think. 2. The `interactive' spec for `bookmark-set-internal' seems wrong anyway. NAME is the raw prefix arg? And then NAME is simply taken as is (as STR) and compared using `string-equal'? This cannot be correct. 3. Similarly, why does the doc string of `bookmark-set-internal' say "_Interactively_..."? It should just say that it prompts for a bookmark name and then... And "error" is not easily and commonly understood as a verb - use "raise an error" instead. 4. `bookmark-set-internal' should preferably not accept both args PROMPT and NAME. If NAME is present (e.g. for non-interactive use of `bookmark-set') then PROMPT makes no sense and is not used (and the doc string is wrong about PROMPT in that case). =20 5. In `bookmark-set-internal', a nil third arg should have been used to mean overwrite, not raise an error, as overwriting is still, and always has been, the default behavior of `bookmark-set'. You should have introduced the new value `error', not the new value `overwrite', and kept the default (nil) behavior as overwriting. You will no doubt argue that this does not matter because `bookmark-set-internal' is "internal". But the main command is still, and should still be `bookmark-set'. `bookmark-set-internal' should reflect _its_ behavior for the default case (nil). 6. Error messages, like other messages, should not end with a period. No doubt it is "too late" for #4 and #5. Hopefully not for the rest. In GNU Emacs 25.1.1 (x86_64-w64-mingw32) of 2016-09-17 built on LAPHROAIG Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Configured using: 'configure --without-dbus --without-compress-install CFLAGS=3D-static' ------------=_1562403422-16694-1--