From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 16:22:22 2016 Received: (at submit) by debbugs.gnu.org; 25 Nov 2016 21:22:22 +0000 Received: from localhost ([127.0.0.1]:41793 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cANwr-0005Rz-Rt for submit@debbugs.gnu.org; Fri, 25 Nov 2016 16:22:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cANwp-0005Rm-Ie for submit@debbugs.gnu.org; Fri, 25 Nov 2016 16:22:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cANwj-0007L9-Ed for submit@debbugs.gnu.org; Fri, 25 Nov 2016 16:22:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37387) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cANwj-0007L5-BG for submit@debbugs.gnu.org; Fri, 25 Nov 2016 16:22:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cANwi-0006eG-2U for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 16:22:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cANwe-0007Jm-TK for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 16:22:12 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:57579) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cANwe-0007J9-Lr for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 16:22:08 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A5EAD208A2 for ; Fri, 25 Nov 2016 16:22:06 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 25 Nov 2016 16:22:06 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=secretsauce.net; h=content-type:date:from:message-id:mime-version:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=WTh Qm+8k8fLuxASUuNQAdHY5Cjs=; b=KeS0zeRpMmNoGI9EP9iivfW4/K4iym9d/42 ScDjrFbP5ffc92fx07SYCPxypzhxx6V2UwTLhUICy0r3mu05dV9UQaCDJThZLGWV OmJ7Cpk+hxt295C13JxQ0yCH3oQ5gNfB3jPNHbLQ2689GgLPYDCWMI0BQ/mcMfeV 5HZC2FGo= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=smtpout; bh=WThQm+8k8fLuxASUuNQAdHY5Cjs=; b=EAkjS qhimn5G2m1u1dfZocM9GRAYxZih8Mnpdi3hWHS3g5qUXNr86ekcIG+Ny9tfwIoH9 W+xRmHFSfNUw5GJUyac9vcz/EKA3pN8JTl/SgwWCPVhztP950p8WMUxeKbb9GG9C MBlQx4zCXN38PVApEcNDok/mDIGi/sI1A7yN1o= X-ME-Sender: X-Sasl-enc: 6oOf6htabs6n9DATy1L3F1mRuiug8li5QPA6ps2ZiSf1 1480108926 Received: from scrawny (50-1-153-216.dsl.dynamic.fusionbroadband.com [50.1.153.216]) by mail.messagingengine.com (Postfix) with ESMTPA id 3ED497E046 for ; Fri, 25 Nov 2016 16:22:06 -0500 (EST) Received: from dima by scrawny with local (Exim 4.87) (envelope-from ) id 1cANwb-0002gT-4J for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 13:22:05 -0800 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: 26.0.50; comint-get-old-input-default: behavior follows docstring Date: Fri, 25 Nov 2016 13:22:05 -0800 Message-ID: <87a8cn5k76.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Here's a simple patch to tweak the behavior of (comint-get-old-input-default) to do what the docstring says it should do. Example: 1. emacs -Q 2. M-x shell 3. seq 5 [RET] This produces the output 1 2 3 4 5 4. Move point to "3" 5. (comint-get-old-input-default) According to the docstring, this should return the current line; i.e. "3". Instead it returns "3\n4\n5\n" + the next prompt. This behavior can produce lots of unwanted commands executing accidentally, and it goes against what the docstring says. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-comint-get-old-input-default-behavior-follows-docstr.patch >From 8af07631226f0dafc90c7d481085c2d08b37a710 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Fri, 25 Nov 2016 13:15:12 -0800 Subject: [PATCH] comint-get-old-input-default: behavior follows docstring lisp/comint.el (comint-get-old-input-default): Modify behavior to follow docstring: if `comint-use-prompt-regexp' is nil, then return the CURRENT LINE, if point is on an output field. --- lisp/comint.el | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index b9c65b0..0288157 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2239,10 +2239,7 @@ comint-get-old-input-default (null (get-char-property (setq bof (field-beginning)) 'field))) (field-string-no-properties bof) (comint-bol) - (buffer-substring-no-properties (point) - (if comint-use-prompt-regexp - (line-end-position) - (field-end)))))) + (buffer-substring-no-properties (point) (line-end-position))))) (defun comint-copy-old-input () "Insert after prompt old input at point as new input to be edited. -- 2.8.0.rc3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 11 07:11:59 2018 Received: (at 25028) by debbugs.gnu.org; 11 May 2018 11:11:59 +0000 Received: from localhost ([127.0.0.1]:57178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fH5xu-0008RX-W3 for submit@debbugs.gnu.org; Fri, 11 May 2018 07:11:59 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:35807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fH5xt-0008RG-9I for 25028@debbugs.gnu.org; Fri, 11 May 2018 07:11:58 -0400 Received: by mail-io0-f176.google.com with SMTP id g1-v6so6572885iob.2 for <25028@debbugs.gnu.org>; Fri, 11 May 2018 04:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jn/nfUL3bb1ZLBLVgLxFW5C45n2KGy0XNNY+KhRKC00=; b=ZHeaZtEosCUs9Xhq8z6+wzP5oRdbInn+jylm+PdfgoKU1nRM3x6KA8J8ss1u7t8jRk aMYb75eixyrpWP9T4I80J+hKisv90g10dA3RiIBFtMmSR0RUF/uZK2ACTb6Rlv5FBTvS U27iyQDdiyIsHE7MwaA4Hc2lBqTETpFk4Jl6qSOVvY7DYGOJtpwihkrnn1nV27/agqJv O8o/B0lvuxOkUY7B84yRLN2mB+B1TOaUl1zKEveZiog+lV8SOw/15wxZRXzctiNLB+eb jI83CjT43eZMbmGUr5/FI6HR9VRVQmCSPrpXPJSraWZqir04Jucye7q/h77ds+oxLS1e fEfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=jn/nfUL3bb1ZLBLVgLxFW5C45n2KGy0XNNY+KhRKC00=; b=GjU8NNDZFaoqpXBWXbtNKpf/Ec3oeiPBJW08TeMSil/eb9XFGZNiX1r3bhOI3ynn4X RE/Q32nxkQi01RLYJ2QPbgL1YIZYfTUNh5s3L45/sUGmpEwT22DrccD7qIpaKvI2/NvT 4jI38vcp4KOi3oJiHz+MAXiNGzQQt7ybKe8Z3DRop9yDtJP/XYRJf7mR+l7r777l/ZFB XSted9VZeP8xATJQhecyEsVPyzdYzcvPvWalvyqqTN/6izgTU9wpD9SmEmR9VemJsI0+ 4cAX7PEEMFZ+zThC+Va3XN2fe4N8+7hVSbo9tspg83+vF3psVQaEBpjC8XPoBNK8UNR+ secQ== X-Gm-Message-State: ALKqPwf+45grEzzr16yT33bz4ILOscKTHoFinWX8bJgUOdJ3s6w+c9YG ATHBAWnGBY20+1o/eXBEA1iAbw== X-Google-Smtp-Source: AB8JxZpVYtz82WVTAdcVRNJNlzS+bZfT5ap64YX26q78wv1VxHkZoCQp3rkeKbNKSc4fpFQru6O75Q== X-Received: by 2002:a6b:af56:: with SMTP id y83-v6mr5522696ioe.55.1526037111717; Fri, 11 May 2018 04:11:51 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d143-v6sm504771itd.35.2018.05.11.04.11.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 04:11:50 -0700 (PDT) From: Noam Postavsky To: Dima Kogan Subject: Re: bug#25028: 26.0.50; comint-get-old-input-default: behavior follows docstring References: <87a8cn5k76.fsf@secretsauce.net> Date: Fri, 11 May 2018 07:11:49 -0400 In-Reply-To: <87a8cn5k76.fsf@secretsauce.net> (Dima Kogan's message of "Fri, 25 Nov 2016 13:22:05 -0800") Message-ID: <87fu2yla4q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25028 Cc: 25028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Dima Kogan writes: > lisp/comint.el (comint-get-old-input-default): Modify behavior to follow > docstring: if `comint-use-prompt-regexp' is nil, then return the CURRENT LINE, > if point is on an output field. That patch returns current line when point is on an output field even if comint-use-prompt-regexp is non-nil. I think it should rather go like this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-comint-get-old-input-default-for-output-field-ca.patch Content-Description: patch >From 8f1c83af6b69c0d6007b4afe68f2d61eb1bb98f2 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 11 May 2018 07:05:53 -0400 Subject: [PATCH] Fix comint-get-old-input-default for output field case (Bug#25028) * lisp/comint.el (comint-get-old-input-default): Don't return whole field when point was on an output field. --- lisp/comint.el | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index e81f739849..5c1918ffad 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2262,16 +2262,18 @@ comint-get-old-input-default If `comint-use-prompt-regexp' is non-nil, then return the current line with any initial string matching the regexp `comint-prompt-regexp' removed." - (let (bof) + (let (field-prop bof) (if (and (not comint-use-prompt-regexp) ;; Make sure we're in an input rather than output field. - (null (get-char-property (setq bof (field-beginning)) 'field))) + (not (setq field-prop (get-char-property + (setq bof (field-beginning)) 'field)))) (field-string-no-properties bof) (comint-bol) - (buffer-substring-no-properties (point) - (if comint-use-prompt-regexp - (line-end-position) - (field-end)))))) + (buffer-substring-no-properties + (point) + (if (or comint-use-prompt-regexp (eq field-prop 'output)) + (line-end-position) + (field-end)))))) (defun comint-copy-old-input () "Insert after prompt old input at point as new input to be edited. -- 2.11.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 04 20:38:36 2018 Received: (at 25028) by debbugs.gnu.org; 5 Jun 2018 00:38:36 +0000 Received: from localhost ([127.0.0.1]:33735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPzzf-0005Lb-S5 for submit@debbugs.gnu.org; Mon, 04 Jun 2018 20:38:35 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:37763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPzzd-0005LH-DY; Mon, 04 Jun 2018 20:38:33 -0400 Received: by mail-it0-f54.google.com with SMTP id l6-v6so1303861iti.2; Mon, 04 Jun 2018 17:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Z2SxWuJCU0xOA/HErJcSH+4MJcb+zvG49d61vNHDIXU=; b=s7qrZ1vTTm97UUvmMUg4UhRKD76rddCnTtKg671oZff+8GcdfePY7t9qe7K0JW3sCF OhdQi6DW6ixOHNwjBg9tIQ5tADlQNHosszikhOUDWemVs9lYQmAGVkMn7/J2hKuWKyAI ce8TYM1VaaeTlOJjJ5ljurwEAt2tTfpIVJf2tkar4GOvQhnUTv0RnvFRYjfubwle0Ybw Mg6iwiVgOWfq8UNqSuKHrzx7IljC8i+OgA/dJpT9fHPV+DMbGbnbXrk/sHE5E3zBYX1W vbVXFk7Jw2tL4b4ZserbEKRbApfOxcRrkPTI+WU3n534VZnAVDobKGEq8VFCr5hLMgvt 5Usw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Z2SxWuJCU0xOA/HErJcSH+4MJcb+zvG49d61vNHDIXU=; b=hA51yWLBOfZ7rvkPYKq+ojL4lNDDviPtMfuvkKEuKO7ddliSZ2F7Z6nx2uGVWoDMNp lbnj+iE8asdhCLIAnXaXfksLhCINP5OI5eqwF4qwdZJ04cEhPJJbhtlNzROPA47X9AP7 fMsvNP3/bALp5Sy9lSKz9CfX8NMZ7xo57t/0F/SHIG+g5R6ECI8mRR8NfHAWaYeplKP8 BoB3JvQcKeXmVXstebRyYYKg29h1OCSmYVa/6HY2TrsF0O6i2Df03jkStcjCjQ50eDxi q7dBX9oR7bqIBEEXTFT3xG9EsR+2fUksGQXX3Zwwpl1wPswhJleK6yJR9wPV9r4dNL4l 3TkQ== X-Gm-Message-State: APt69E37Rw05sY6I8QGVRfZV4Xd15o9sU+qkcHuzVrYKZVZKz1QEMtAI pKmbC0PxV99qZVhJniJKtvu4Kw== X-Google-Smtp-Source: ADUXVKIWDvpyZXkUl2HN/pozKVf/Vne6PkXUeaD33C12xJY8I04dP6lSwioPrZWWNCQONfKpfZVFlQ== X-Received: by 2002:a24:1c42:: with SMTP id c63-v6mr9784504itc.8.1528159107713; Mon, 04 Jun 2018 17:38:27 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id d136-v6sm171469itd.22.2018.06.04.17.38.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jun 2018 17:38:26 -0700 (PDT) From: Noam Postavsky To: Dima Kogan Subject: Re: bug#25028: 26.0.50; comint-get-old-input-default: behavior follows docstring References: <87a8cn5k76.fsf@secretsauce.net> <87fu2yla4q.fsf@gmail.com> Date: Mon, 04 Jun 2018 20:38:25 -0400 In-Reply-To: <87fu2yla4q.fsf@gmail.com> (Noam Postavsky's message of "Fri, 11 May 2018 07:11:49 -0400") Message-ID: <87y3fu6pa6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25028 Cc: 25028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) # it was a regression in 24.5 found 25028 24.5 tags 25028 fixed close 25028 26.2 quit Noam Postavsky writes: > Subject: [PATCH] Fix comint-get-old-input-default for output field case > (Bug#25028) > > * lisp/comint.el (comint-get-old-input-default): Don't return whole > field when point was on an output field. Pushed to emacs-26. [1: 55c9bb9f3c]: 2018-06-04 19:42:22 -0400 Fix comint-get-old-input-default for output field case (Bug#25028) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=55c9bb9f3c2971e347caeea1402f97fb603c4210 From unknown Tue Jun 17 01:46:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 03 Jul 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator