GNU bug report logs - #25025
python-shell-calculate-command is wrong

Previous Next

Full log

Message #55 received at 25025 <at> debbugs.gnu.org (full text, mbox):

From: Clément Pit--Claudel <clement.pit <at> gmail.com>
To: npostavs <at> users.sourceforge.net, Eli Zaretskii <eliz <at> gnu.org>
Cc: 25025 <at> debbugs.gnu.org
Subject: Re: bug#25025: python-shell-calculate-command is wrong
Date: Tue, 29 Nov 2016 20:35:46 -0500

[Message part 1 (text/plain, inline)]

On 2016-11-29 19:36, npostavs <at> users.sourceforge.net wrote:
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>>> From: npostavs <at> users.sourceforge.net
>>> Cc: 25025 <at> debbugs.gnu.org,  clement.pit <at> gmail.com
>>> Date: Sun, 27 Nov 2016 11:06:03 -0500
>>>
>>>> Why does it need to be split?  A shell command can (even should) be
>>>> handed to the shell as a single string.
>>>
>>> Currently it's not a shell command, because a shell isn't being used.
>>> My other suggestion was to use a shell:
>>>
>>>>> It might be more intuitive to actually use a shell and then the user
>>>>> would enter a shell command (though inserting a shell into things
>>>>> might bring more complications).
>>
>> If it doesn't use a shell, then it has no business quoting commands or
>> their parts using shell-related APIs.
>>
>> So yes, I think using a shell would be TRT here.  Can someone please
>> work on a patch in that direction?  This problem exists for a long
>> time, so I hope we could solve it soon.
> 
> Hmm, the difficulty in using a shell is that the current code wants to
> parse the command into interpreter and arguments in order to match
> against `python-shell-completion-native-disabled-interpreters'.

That doesn't prevent us from using a shell.  We run the command unmodified through a shell, and we split it and analyze it separately to decide whether to enable completion.  But we don't split and reassemble it before running it.

Clément.

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.