GNU bug report logs - #25025
python-shell-calculate-command is wrong

Previous Next

Package: emacs;

Reported by: Fabrice Popineau <fabrice.popineau <at> gmail.com>

Date: Fri, 25 Nov 2016 06:26:01 UTC

Severity: normal

Tags: confirmed, fixed

Merged with 20744

Found in version 25.1

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 25025 <at> debbugs.gnu.org, Clément Pit--Claudel <clement.pit <at> gmail.com>
Subject: bug#25025: python-shell-calculate-command is wrong
Date: Wed, 16 Aug 2017 15:27:24 -0400

On Wed, Aug 16, 2017 at 12:57 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> I see, thanks.  So I guess all it (maybe) tests is that
> python-shell-interpreter and what executable-find returns are
> identical?  Is that something that could somehow fail and would be
> useful to verify?

No, python-shell-interpreter is by default just "python", not an
absolute filename, so it shouldn't match with executable-find. The
test is let-binding python-shell-interpreter anyway:

    (defvar python-tests-shell-interpreter "python")
    ...
    (ert-deftest python-shell-calculate-command-1 ()
      ...
      (skip-unless (executable-find python-tests-shell-interpreter))
      (let ((python-shell-interpreter (executable-find
                                       python-tests-shell-interpreter))
         ...


>  If not, I agree to removing the test.

Okay, I'll push in a few days.
This bug report was last modified 7 years and 276 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.