From unknown Fri Jun 20 05:29:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25025 <25025@debbugs.gnu.org> To: bug#25025 <25025@debbugs.gnu.org> Subject: Status: python-shell-calculate-command is wrong Reply-To: bug#25025 <25025@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:29:59 +0000 retitle 25025 python-shell-calculate-command is wrong reassign 25025 emacs submitter 25025 Fabrice Popineau severity 25025 normal tag 25025 fixed confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 01:25:26 2016 Received: (at submit) by debbugs.gnu.org; 25 Nov 2016 06:25:26 +0000 Received: from localhost ([127.0.0.1]:40928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cA9wq-0003ra-UG for submit@debbugs.gnu.org; Fri, 25 Nov 2016 01:25:26 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cA9wn-0003rL-NJ for submit@debbugs.gnu.org; Fri, 25 Nov 2016 01:25:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cA9wc-0006Ng-F5 for submit@debbugs.gnu.org; Fri, 25 Nov 2016 01:25:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60214) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cA9wc-0006NN-BF for submit@debbugs.gnu.org; Fri, 25 Nov 2016 01:25:10 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cA9wW-0008Vt-QE for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 01:25:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cA9wR-0006Bp-H5 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 01:25:04 -0500 Received: from mail-wj0-x234.google.com ([2a00:1450:400c:c01::234]:33003) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cA9wR-0006Ba-0H for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 01:24:59 -0500 Received: by mail-wj0-x234.google.com with SMTP id xy5so49943927wjc.0 for ; Thu, 24 Nov 2016 22:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=hVqTAyaUfruWMqL8oGBUbomUuHgv+EMlAzVE7O+ecnU=; b=bidAVf4Q0LSPFqFfpQRTFVUatgvqPF4FvVRLVFbjh725h2pgkX7M1QPIR5/1qXYknT ij762XrunKN1AtZZsnhk//L8s7QcKr4lhRy/4lc4pzhjrrm0qpXD4YH7+R/TqeBBtoy+ glEXqVzS4jajwWCwmHzwX1r4IM68ckgeBCZM98LyqHZjUH+xKSQw5mZQ7IyL2JrQoF7j ConM6+p7wQA20ZqooK2M8WJ4vrl9SNXI8/Fr2J/suoHnIMD3bcRQFv5mK2b7q20iMD2Q V6cuA+wbtZNY7zu+dsUUzQkZXy6c7NRRIcLtMGlbacFyW5Mzt8MSffWr3x32ZsZEfDvK /V2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=hVqTAyaUfruWMqL8oGBUbomUuHgv+EMlAzVE7O+ecnU=; b=JXpyHwSpJZU83y460C1ZJTVphSiWN+Q5pWYldFR6GLGoHUQRv+0xheIUHm3koNc3Ry tMXfYsyOaPWnPG4QgHn2RGVgkqIhw68Lpc36tG/+A7rzKnKcInWYc8yLx4K7LgGjQIWS AO8Yym/BL0Hj2XpB88vDPktXCJL/Etrv3yO6794KAilJeainlLtDwp8yu3uPs1UDHqbj iiC8uYCjVIsWQBMTdVICa27BdLcx6vrplLU3gY89YQyOrz08ru3p6k6YvdhYrkmwRQx7 wz87Tj+P7If9l7vQDdNvzPj+eiMzw6n9VnHRUztaxWrqV1v4VDlPiKi+FPPa4G5mKpMR GcOQ== X-Gm-Message-State: AKaTC02xiyoqX1zovXvkgKEoiMHq6T2EcwEJk4s4PUSU2OFnBrEAWLDiRi5TZSBqZMVLcc/C+OMeCZOhLyn4jw== X-Received: by 10.194.243.231 with SMTP id xb7mr6331196wjc.60.1480055096427; Thu, 24 Nov 2016 22:24:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.153.205 with HTTP; Thu, 24 Nov 2016 22:24:35 -0800 (PST) From: Fabrice Popineau Date: Fri, 25 Nov 2016 07:24:35 +0100 Message-ID: Subject: python-shell-calculate-command is wrong To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=089e01493e64454d0c05421a2ebf X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e01493e64454d0c05421a2ebf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Run Emacs-W64 from an MSYS2 shell (bash) In your init file: (setq python-shell-interpreter "c:/Local/Miniconda3/Scripts/ipython.exe") and then launch a python shell. It results in this weird error that No such file or directory "c\:/Local/Miniconda3/Scripts/ipython.exe" Culprit is `python-shell-calculate-command' which wrongly uses `shell-quote-argument' on python-shell-interpreter. (defun python-shell-calculate-command () "Calculate the string used to execute the inferior Python process." (format "%s %s" (shell-quote-argument python-shell-interpreter) python-shell-interpreter-args)) IMHO, it should read: (defun python-shell-calculate-command () "Calculate the string used to execute the inferior Python process." (format "%s %s" python-shell-interpreter python-shell-interpreter-args)) at least for windows-nt. The python shell name is not passed to any underlying shell. It is used to create a process, so it must not be quoted in anyway. Regards, Fabrice In GNU Emacs 25.1.50.25 (x86_64-w64-mingw32) of 2016-11-24 built on LOBSANG Repository revision: 43f4fc4a57af39b4a7f166f27dcf07fc9e8e2e3b Windowing system distributor 'Microsoft Corp.', version 6.2.9200 Configured using: 'configure --prefix=3D/c/Local/Emacs-25 --libexecdir=3D/c/Local/Emacs-25/bin --datarootdir=3D/c/Local/Emacs-25 --localstatedir=3D/c/Local/Emacs-25 --sysconfdir=3D/c/Local/Emacs-25/etc --with-jpeg --with-xpm --with-png --with-tiff --with-rsvg --with-xml2 --with-gnutls --with-imagemagick --without-dbus --enable-checking=3Dno 'CFLAGS=3D-I/mingw64/include -fomit-frame-pointer -O3 -g0 -mtune=3Dcorei7' CPPFLAGS=3D-I/mingw64/include LDFLAGS=3D-L/mingw64/lib' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS Important settings: value of $LANG: en_US locale-coding-system: cp1252 Major mode: Emacs-Lisp Minor modes in effect: popwin-mode: t pdf-occur-global-minor-mode: t pyvenv-mode: t company-statistics-mode: t rainbow-delimiters-mode: t global-undo-tree-mode: t undo-tree-mode: t global-anzu-mode: t anzu-mode: t projectile-mode: t desktop-save-mode: t TeX-PDF-mode: t winner-mode: t which-key-mode: t which-function-mode: t volatile-highlights-mode: t save-place-mode: t savehist-mode: t recentf-mode: t global-page-break-lines-mode: t page-break-lines-mode: t outline-minor-mode: t magit-auto-revert-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t flx-ido-mode: t ido-vertical-mode: t ido-ubiquitous-mode: t ido-everywhere: t global-hungry-delete-mode: t hungry-delete-mode: t global-hl-line-mode: t global-diff-hl-mode: t diff-hl-mode: t diff-auto-refine-mode: t beacon-mode: t global-auto-revert-mode: t cua-mode: t delete-selection-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t prettify-symbols-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t Recent messages: Mark set Quit Mark set next-line: End of buffer Quit uncompressing python.el.gz...done You can run the command =E2=80=98find-function=E2=80=99 with C-h C-f uncompressing python.el.gz...done Mark set Mark saved where search started Load-path shadows: c:/Home/.emacs.d/local/org-mode/lisp/htmlize hides c:/Home/.emacs.d/elpa/htmlize-20130207.1202/htmlize c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-virtual hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-virtual c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-view hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-view c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-util hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-util c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-tools c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools-pkg hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-tools-pkg c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools-autoloads hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-tools-autoloads c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-sync hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-sync c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-outline hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-outline c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-occur hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-occur c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-misc hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-misc c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-links hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-links c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-isearch hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-isearch c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-info hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-info c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-history hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-history c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-dev hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-dev c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-cache hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-cache c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-annot hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-annot c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-virtual hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-virtual c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-view hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-view c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-util hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-util c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-tools c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools-pkg hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-tools-pkg c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools-autoloads hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-tools-autoloads c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-sync hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-sync c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-outline hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-outline c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-occur hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-occur c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-misc hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-misc c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-links hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-links c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-isearch hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-isearch c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-info hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-info c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-history hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-history c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-dev hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-dev c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-cache hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-cache c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-annot hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-annot c:/Home/.emacs.d/elpa/tablist-20160424.235/tablist hides c:/Local/Emacs/site-lisp/tablist/tablist c:/Home/.emacs.d/elpa/tablist-20160424.235/tablist-pkg hides c:/Local/Emacs/site-lisp/tablist/tablist-pkg c:/Home/.emacs.d/elpa/tablist-20160424.235/tablist-filter hides c:/Local/Emacs/site-lisp/tablist/tablist-filter c:/Home/.emacs.d/elpa/tablist-20160424.235/tablist-autoloads hides c:/Local/Emacs/site-lisp/tablist/tablist-autoloads c:/Home/.emacs.d/local/org-mode/lisp/ox hides c:/Local/Emacs/lisp/org/ox c:/Home/.emacs.d/local/org-mode/lisp/ox-texinfo hides c:/Local/Emacs/lisp/org/ox-texinfo c:/Home/.emacs.d/local/org-mode/lisp/ox-publish hides c:/Local/Emacs/lisp/org/ox-publish c:/Home/.emacs.d/local/org-mode/lisp/ox-org hides c:/Local/Emacs/lisp/org/ox-org c:/Home/.emacs.d/local/org-mode/lisp/ox-odt hides c:/Local/Emacs/lisp/org/ox-odt c:/Home/.emacs.d/local/org-mode/lisp/ox-md hides c:/Local/Emacs/lisp/org/ox-md c:/Home/.emacs.d/local/org-mode/lisp/ox-man hides c:/Local/Emacs/lisp/org/ox-man c:/Home/.emacs.d/local/org-mode/lisp/ox-latex hides c:/Local/Emacs/lisp/org/ox-latex c:/Home/.emacs.d/local/org-mode/lisp/ox-icalendar hides c:/Local/Emacs/lisp/org/ox-icalendar c:/Home/.emacs.d/local/org-mode/lisp/ox-html hides c:/Local/Emacs/lisp/org/ox-html c:/Home/.emacs.d/local/org-mode/lisp/ox-beamer hides c:/Local/Emacs/lisp/org/ox-beamer c:/Home/.emacs.d/local/org-mode/lisp/ox-ascii hides c:/Local/Emacs/lisp/org/ox-ascii c:/Home/.emacs.d/local/org-mode/lisp/org hides c:/Local/Emacs/lisp/org/org c:/Home/.emacs.d/local/org-mode/lisp/org-w3m hides c:/Local/Emacs/lisp/org/org-w3m c:/Home/.emacs.d/local/org-mode/lisp/org-version hides c:/Local/Emacs/lisp/org/org-version c:/Home/.emacs.d/local/org-mode/lisp/org-timer hides c:/Local/Emacs/lisp/org/org-timer c:/Home/.emacs.d/local/org-mode/lisp/org-table hides c:/Local/Emacs/lisp/org/org-table c:/Home/.emacs.d/local/org-mode/lisp/org-src hides c:/Local/Emacs/lisp/org/org-src c:/Home/.emacs.d/local/org-mode/lisp/org-rmail hides c:/Local/Emacs/lisp/org/org-rmail c:/Home/.emacs.d/local/org-mode/lisp/org-protocol hides c:/Local/Emacs/lisp/org/org-protocol c:/Home/.emacs.d/local/org-mode/lisp/org-plot hides c:/Local/Emacs/lisp/org/org-plot c:/Home/.emacs.d/local/org-mode/lisp/org-pcomplete hides c:/Local/Emacs/lisp/org/org-pcomplete c:/Home/.emacs.d/local/org-mode/lisp/org-mouse hides c:/Local/Emacs/lisp/org/org-mouse c:/Home/.emacs.d/local/org-mode/lisp/org-mobile hides c:/Local/Emacs/lisp/org/org-mobile c:/Home/.emacs.d/local/org-mode/lisp/org-mhe hides c:/Local/Emacs/lisp/org/org-mhe c:/Home/.emacs.d/local/org-mode/lisp/org-macs hides c:/Local/Emacs/lisp/org/org-macs c:/Home/.emacs.d/local/org-mode/lisp/org-macro hides c:/Local/Emacs/lisp/org/org-macro c:/Home/.emacs.d/local/org-mode/lisp/org-loaddefs hides c:/Local/Emacs/lisp/org/org-loaddefs c:/Home/.emacs.d/local/org-mode/lisp/org-list hides c:/Local/Emacs/lisp/org/org-list c:/Home/.emacs.d/local/org-mode/lisp/org-irc hides c:/Local/Emacs/lisp/org/org-irc c:/Home/.emacs.d/local/org-mode/lisp/org-install hides c:/Local/Emacs/lisp/org/org-install c:/Home/.emacs.d/local/org-mode/lisp/org-inlinetask hides c:/Local/Emacs/lisp/org/org-inlinetask c:/Home/.emacs.d/local/org-mode/lisp/org-info hides c:/Local/Emacs/lisp/org/org-info c:/Home/.emacs.d/local/org-mode/lisp/org-indent hides c:/Local/Emacs/lisp/org/org-indent c:/Home/.emacs.d/local/org-mode/lisp/org-id hides c:/Local/Emacs/lisp/org/org-id c:/Home/.emacs.d/local/org-mode/lisp/org-habit hides c:/Local/Emacs/lisp/org/org-habit c:/Home/.emacs.d/local/org-mode/lisp/org-gnus hides c:/Local/Emacs/lisp/org/org-gnus c:/Home/.emacs.d/local/org-mode/lisp/org-footnote hides c:/Local/Emacs/lisp/org/org-footnote c:/Home/.emacs.d/local/org-mode/lisp/org-feed hides c:/Local/Emacs/lisp/org/org-feed c:/Home/.emacs.d/local/org-mode/lisp/org-faces hides c:/Local/Emacs/lisp/org/org-faces c:/Home/.emacs.d/local/org-mode/lisp/org-eshell hides c:/Local/Emacs/lisp/org/org-eshell c:/Home/.emacs.d/local/org-mode/lisp/org-entities hides c:/Local/Emacs/lisp/org/org-entities c:/Home/.emacs.d/local/org-mode/lisp/org-element hides c:/Local/Emacs/lisp/org/org-element c:/Home/.emacs.d/local/org-mode/lisp/org-docview hides c:/Local/Emacs/lisp/org/org-docview c:/Home/.emacs.d/local/org-mode/lisp/org-datetree hides c:/Local/Emacs/lisp/org/org-datetree c:/Home/.emacs.d/local/org-mode/lisp/org-ctags hides c:/Local/Emacs/lisp/org/org-ctags c:/Home/.emacs.d/local/org-mode/lisp/org-crypt hides c:/Local/Emacs/lisp/org/org-crypt c:/Home/.emacs.d/local/org-mode/lisp/org-compat hides c:/Local/Emacs/lisp/org/org-compat c:/Home/.emacs.d/local/org-mode/lisp/org-colview hides c:/Local/Emacs/lisp/org/org-colview c:/Home/.emacs.d/local/org-mode/lisp/org-clock hides c:/Local/Emacs/lisp/org/org-clock c:/Home/.emacs.d/local/org-mode/lisp/org-capture hides c:/Local/Emacs/lisp/org/org-capture c:/Home/.emacs.d/local/org-mode/lisp/org-bibtex hides c:/Local/Emacs/lisp/org/org-bibtex c:/Home/.emacs.d/local/org-mode/lisp/org-bbdb hides c:/Local/Emacs/lisp/org/org-bbdb c:/Home/.emacs.d/local/org-mode/lisp/org-attach hides c:/Local/Emacs/lisp/org/org-attach c:/Home/.emacs.d/local/org-mode/lisp/org-archive hides c:/Local/Emacs/lisp/org/org-archive c:/Home/.emacs.d/local/org-mode/lisp/org-agenda hides c:/Local/Emacs/lisp/org/org-agenda c:/Home/.emacs.d/local/org-mode/lisp/ob hides c:/Local/Emacs/lisp/org/ob c:/Home/.emacs.d/local/org-mode/lisp/ob-tangle hides c:/Local/Emacs/lisp/org/ob-tangle c:/Home/.emacs.d/local/org-mode/lisp/ob-table hides c:/Local/Emacs/lisp/org/ob-table c:/Home/.emacs.d/local/org-mode/lisp/ob-sqlite hides c:/Local/Emacs/lisp/org/ob-sqlite c:/Home/.emacs.d/local/org-mode/lisp/ob-sql hides c:/Local/Emacs/lisp/org/ob-sql c:/Home/.emacs.d/local/org-mode/lisp/ob-shen hides c:/Local/Emacs/lisp/org/ob-shen c:/Home/.emacs.d/local/org-mode/lisp/ob-screen hides c:/Local/Emacs/lisp/org/ob-screen c:/Home/.emacs.d/local/org-mode/lisp/ob-scheme hides c:/Local/Emacs/lisp/org/ob-scheme c:/Home/.emacs.d/local/org-mode/lisp/ob-scala hides c:/Local/Emacs/lisp/org/ob-scala c:/Home/.emacs.d/local/org-mode/lisp/ob-sass hides c:/Local/Emacs/lisp/org/ob-sass c:/Home/.emacs.d/local/org-mode/lisp/ob-ruby hides c:/Local/Emacs/lisp/org/ob-ruby c:/Home/.emacs.d/local/org-mode/lisp/ob-ref hides c:/Local/Emacs/lisp/org/ob-ref c:/Home/.emacs.d/local/org-mode/lisp/ob-R hides c:/Local/Emacs/lisp/org/ob-= R c:/Home/.emacs.d/local/org-mode/lisp/ob-python hides c:/Local/Emacs/lisp/org/ob-python c:/Home/.emacs.d/local/org-mode/lisp/ob-plantuml hides c:/Local/Emacs/lisp/org/ob-plantuml c:/Home/.emacs.d/local/org-mode/lisp/ob-picolisp hides c:/Local/Emacs/lisp/org/ob-picolisp c:/Home/.emacs.d/local/org-mode/lisp/ob-perl hides c:/Local/Emacs/lisp/org/ob-perl c:/Home/.emacs.d/local/org-mode/lisp/ob-org hides c:/Local/Emacs/lisp/org/ob-org c:/Home/.emacs.d/local/org-mode/lisp/ob-octave hides c:/Local/Emacs/lisp/org/ob-octave c:/Home/.emacs.d/local/org-mode/lisp/ob-ocaml hides c:/Local/Emacs/lisp/org/ob-ocaml c:/Home/.emacs.d/local/org-mode/lisp/ob-mscgen hides c:/Local/Emacs/lisp/org/ob-mscgen c:/Home/.emacs.d/local/org-mode/lisp/ob-maxima hides c:/Local/Emacs/lisp/org/ob-maxima c:/Home/.emacs.d/local/org-mode/lisp/ob-matlab hides c:/Local/Emacs/lisp/org/ob-matlab c:/Home/.emacs.d/local/org-mode/lisp/ob-makefile hides c:/Local/Emacs/lisp/org/ob-makefile c:/Home/.emacs.d/local/org-mode/lisp/ob-lob hides c:/Local/Emacs/lisp/org/ob-lob c:/Home/.emacs.d/local/org-mode/lisp/ob-lisp hides c:/Local/Emacs/lisp/org/ob-lisp c:/Home/.emacs.d/local/org-mode/lisp/ob-lilypond hides c:/Local/Emacs/lisp/org/ob-lilypond c:/Home/.emacs.d/local/org-mode/lisp/ob-ledger hides c:/Local/Emacs/lisp/org/ob-ledger c:/Home/.emacs.d/local/org-mode/lisp/ob-latex hides c:/Local/Emacs/lisp/org/ob-latex c:/Home/.emacs.d/local/org-mode/lisp/ob-keys hides c:/Local/Emacs/lisp/org/ob-keys c:/Home/.emacs.d/local/org-mode/lisp/ob-js hides c:/Local/Emacs/lisp/org/ob-js c:/Home/.emacs.d/local/org-mode/lisp/ob-java hides c:/Local/Emacs/lisp/org/ob-java c:/Home/.emacs.d/local/org-mode/lisp/ob-io hides c:/Local/Emacs/lisp/org/ob-io c:/Home/.emacs.d/local/org-mode/lisp/ob-haskell hides c:/Local/Emacs/lisp/org/ob-haskell c:/Home/.emacs.d/local/org-mode/lisp/ob-gnuplot hides c:/Local/Emacs/lisp/org/ob-gnuplot c:/Home/.emacs.d/local/org-mode/lisp/ob-fortran hides c:/Local/Emacs/lisp/org/ob-fortran c:/Home/.emacs.d/local/org-mode/lisp/ob-exp hides c:/Local/Emacs/lisp/org/ob-exp c:/Home/.emacs.d/local/org-mode/lisp/ob-eval hides c:/Local/Emacs/lisp/org/ob-eval c:/Home/.emacs.d/local/org-mode/lisp/ob-emacs-lisp hides c:/Local/Emacs/lisp/org/ob-emacs-lisp c:/Home/.emacs.d/local/org-mode/lisp/ob-dot hides c:/Local/Emacs/lisp/org/ob-dot c:/Home/.emacs.d/local/org-mode/lisp/ob-ditaa hides c:/Local/Emacs/lisp/org/ob-ditaa c:/Home/.emacs.d/local/org-mode/lisp/ob-css hides c:/Local/Emacs/lisp/org/ob-css c:/Home/.emacs.d/local/org-mode/lisp/ob-core hides c:/Local/Emacs/lisp/org/ob-core c:/Home/.emacs.d/local/org-mode/lisp/ob-comint hides c:/Local/Emacs/lisp/org/ob-comint c:/Home/.emacs.d/local/org-mode/lisp/ob-clojure hides c:/Local/Emacs/lisp/org/ob-clojure c:/Home/.emacs.d/local/org-mode/lisp/ob-calc hides c:/Local/Emacs/lisp/org/ob-calc c:/Home/.emacs.d/local/org-mode/lisp/ob-C hides c:/Local/Emacs/lisp/org/ob-= C c:/Home/.emacs.d/local/org-mode/lisp/ob-awk hides c:/Local/Emacs/lisp/org/ob-awk c:/Home/.emacs.d/local/org-mode/lisp/ob-asymptote hides c:/Local/Emacs/lisp/org/ob-asymptote c:/Home/.emacs.d/elpa/seq-2.19/seq hides c:/Local/Emacs/lisp/emacs-lisp/seq Features: (shadow sort mail-extr emacsbug sendmail misearch multi-isearch network-stream nsm starttls texmathp debug smex two-column iso-transl popwin latexenc reftex-auc preview prv-emacs tex-buf pdf-occur tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch let-alist pdf-misc font-latex view reftex-global reftex-parse reftex-dcr org-eldoc org-indent company-jedi yasnippet highlight-indentation flymake elpy pyvenv elpy-refactor files-x smartparens jedi-core python-environment epc ctable concurrent deferred company-statistics company-oddmuse company-keywords company-etags company-gtags company-dabbrev-code company-dabbrev company-files company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-bbdb company python autoconf autoconf-mode sh-script executable rainbow-delimiters undo-tree diff anzu projectile grep ibuf-ext ibuffer make-mode desktop frameset ox-bibtex reftex-cite reftex reftex-vars pdf-tools pdf-view pdf-cache pdf-info tq pdf-util ob-shell ob-gnuplot ob-python ob-org ob-dot ob-lisp ob-latex ox-koma-letter ox-beamer ox-reveal ox-odt ox-latex ox-icalendar ox-html table ox-ascii ox-publish ox org-wl org-toc org-timer org-clock org-screen term ehelp org-protocol org-panel org-mouse org-mime org-interactive-query org-inlinetask org-info org-habit org-expiry org-eval org-drill org-learn org-id hi-lock org-contacts org-capture org-agenda gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems nnheader org-checklist org-bibtex bibtex org-annotate-file web-mode caml tuareg_indent tuareg speedbar sb-image ezimage dframe smie caml-help caml-types caml-emacs magic-latex-buffer iimage tex-mode latex tex-ispell tex-style tex fp-specif slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime lisp-mnt gud apropos arc-mode archive-mode hyperspec browse-url fp-pseudocode pascal rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok ediprolog writegood-mode winner windmove whitespace which-key which-func volatile-highlights sumatra-forward ssh smart-mode-line rich-minority saveplace savehist graphene-meta-theme sanityinc-tomorrow-night-theme color-theme-sanityinc-tomorrow recentf tree-widget ranger ps-print ps-def lpr popup page-break-lines ov outshine outshine-org-cmds outorg org-element avl-tree org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs noutline outline operate-on-number calc-bin calc-ext calc calc-loaddefs calc-macs oauth2 warnings plstore move-text midnight memory-usage magithub magithub-ci magithub-issue magithub-cache magithub-core magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert magit-process magit-popup magit-mode magit-git crm magit-section magit-utils git-commit log-edit message rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async tramp-sh tramp tramp-compat tramp-loaddefs trampver shell pcomplete server lua-mode key-chord js2-mode etags xref project js sgml-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs imenu-anywhere imenu ido-hacks flx-ido flx ido-vertical-mode ido-ubiquitous ido-completing-read+ cus-edit cus-start cus-load wid-edit ido hungry-delete htmlize hl-line highlight-symbol guru-mode grizzl god-mode gitignore-mode gitconfig-mode conf-mode git-timemachine vc-git gist gh-gist gh-oauth gh-api logito gh-cache pcache gh-auth gh-url url-http tls gnutls url url-proxy url-privacy url-expand url-methods url-history mailcap url-auth mail-parse rfc2231 rfc2047 rfc2045 ietf-drums url-cookie url-domsuf url-util url-gw timezone eieio-base framemove flyspell ispell flycheck find-func epl ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff easy-kill thingatpt doc-view subr-x jka-compr image-mode discover-my-major makey dired+ image-dired format-spec image-file dired-x dired-aux diff-hl smartrep vc-dir ewoc vc vc-dispatcher diff-mode dictionary link connection browse-kill-ring derived bookmark pp beacon autorevert filenotify ag vc-svn compile comint ansi-color ring find-dired dired cl edmacro kmacro cua-base delsel use-package diminish bind-key easy-mmode finder-inf tex-site gh-common gh-profile url-parse auth-source gnus-util mm-util help-fns mail-prsvr password-cache url-vars rx s ucs-normalize marshal eieio-compat cl-seq ht json map dash eieio eieio-core cl-macs advice info package epg-config seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify w32 multi-tty make-network-process emacs) Memory information: ((conses 16 1899150 677834) (symbols 56 98781 0) (miscs 48 71108 15295) (strings 32 352119 167999) (string-bytes 1 10705287) (vectors 16 174375) (vector-slots 8 4203177 425963) (floats 8 16169 10128) (intervals 56 128230 8752) (buffers 976 80)) --089e01493e64454d0c05421a2ebf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Run Emacs-W64 from an MSYS2 shell (bas= h)

In your init file:

(se= tq python-shell-interpreter
=C2=A0 =C2=A0 =C2=A0 "c:/Local/M= iniconda3/Scripts/ipython.exe")

and then laun= ch a python shell.
It results in this weird error that
= No such file or directory
"c\:/Local/Miniconda3/Scripts/ipyt= hon.exe"

Culprit is `python-shell-calculate-c= ommand' which wrongly
uses `shell-quote-argument' on pyth= on-shell-interpreter.

(defun python-shell-calculat= e-command ()
=C2=A0 "Calculate the string used to execute th= e inferior Python process."
=C2=A0 (format "%s %s"=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (shell-quote-argument python-= shell-interpreter)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 python-shel= l-interpreter-args))

IMHO, it should read:

(defun python-shell-calculate-command ()
=C2=A0= "Calculate the string used to execute the inferior Python process.&qu= ot;
=C2=A0 (format "%s %s"
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 python-shell-interpreter
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 python-shell-interpreter-args))

at l= east for windows-nt. The python shell name is not passed to any underlying = shell.
It is used to create a process, so it must not be quoted i= n anyway.

Regards,

Fabric= e


In GNU Emacs 25.1.50.25 (x86_64-w= 64-mingw32)
=C2=A0of 2016-11-24 built on LOBSANG
Reposi= tory revision: 43f4fc4a57af39b4a7f166f27dcf07fc9e8e2e3b
Windowing= system distributor 'Microsoft Corp.', version 6.2.9200
C= onfigured using:
=C2=A0'configure --prefix=3D/c/Local/Emacs-2= 5
=C2=A0--libexecdir=3D/c/Local/Emacs-25/bin --datarootdir=3D/c/L= ocal/Emacs-25
=C2=A0--localstatedir=3D/c/Local/Emacs-25 --sysconf= dir=3D/c/Local/Emacs-25/etc
=C2=A0--with-jpeg --with-xpm --with-p= ng --with-tiff --with-rsvg --with-xml2
=C2=A0--with-gnutls --with= -imagemagick --without-dbus --enable-checking=3Dno
=C2=A0'CFL= AGS=3D-I/mingw64/include -fomit-frame-pointer -O3 -g0 -mtune=3Dcorei7'<= /div>
=C2=A0CPPFLAGS=3D-I/mingw64/include LDFLAGS=3D-L/mingw64/lib'=

Configured features:
XPM JPEG TIFF GIF = PNG RSVG IMAGEMAGICK SOUND NOTIFY ACL GNUTLS LIBXML2
ZLIB TOOLKIT= _SCROLL_BARS

Important settings:
=C2=A0 = value of $LANG: en_US
=C2=A0 locale-coding-system: cp1252

Major mode: Emacs-Lisp

Minor mod= es in effect:
=C2=A0 popwin-mode: t
=C2=A0 pdf-occur-gl= obal-minor-mode: t
=C2=A0 pyvenv-mode: t
=C2=A0 company= -statistics-mode: t
=C2=A0 rainbow-delimiters-mode: t
= =C2=A0 global-undo-tree-mode: t
=C2=A0 undo-tree-mode: t
=C2=A0 global-anzu-mode: t
=C2=A0 anzu-mode: t
=C2=A0= projectile-mode: t
=C2=A0 desktop-save-mode: t
=C2=A0 = TeX-PDF-mode: t
=C2=A0 winner-mode: t
=C2=A0 which-key-= mode: t
=C2=A0 which-function-mode: t
=C2=A0 volatile-h= ighlights-mode: t
=C2=A0 save-place-mode: t
=C2=A0 save= hist-mode: t
=C2=A0 recentf-mode: t
=C2=A0 global-page-= break-lines-mode: t
=C2=A0 page-break-lines-mode: t
=C2= =A0 outline-minor-mode: t
=C2=A0 magit-auto-revert-mode: t
<= div>=C2=A0 global-git-commit-mode: t
=C2=A0 async-bytecomp-packag= e-mode: t
=C2=A0 shell-dirtrack-mode: t
=C2=A0 flx-ido-= mode: t
=C2=A0 ido-vertical-mode: t
=C2=A0 ido-ubiquito= us-mode: t
=C2=A0 ido-everywhere: t
=C2=A0 global-hungr= y-delete-mode: t
=C2=A0 hungry-delete-mode: t
=C2=A0 gl= obal-hl-line-mode: t
=C2=A0 global-diff-hl-mode: t
=C2= =A0 diff-hl-mode: t
=C2=A0 diff-auto-refine-mode: t
=C2= =A0 beacon-mode: t
=C2=A0 global-auto-revert-mode: t
= =C2=A0 cua-mode: t
=C2=A0 delete-selection-mode: t
=C2= =A0 override-global-mode: t
=C2=A0 tooltip-mode: t
=C2= =A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 global-prettify-symbols-mode: = t
=C2=A0 prettify-symbols-mode: t
=C2=A0 menu-bar-mode:= t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-l= ock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 auto-compos= ition-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 aut= o-compression-mode: t
=C2=A0 size-indication-mode: t
= =C2=A0 column-number-mode: t
=C2=A0 line-number-mode: t
=C2=A0 global-visual-line-mode: t
=C2=A0 visual-line-mode: t
=C2=A0 transient-mark-mode: t

Recent messag= es:
Mark set
Quit
Mark set
next-lin= e: End of buffer
Quit
uncompressing python.el.gz...done=
You can run the command =E2=80=98find-function=E2=80=99 with C-h= C-f
uncompressing python.el.gz...done
Mark set
Mark saved where search started

Load-path shado= ws:
c:/Home/.emacs.d/local/org-mode/lisp/htmlize hides c:/Home/.e= macs.d/elpa/htmlize-20130207.1202/htmlize
c:/Home/.emacs.d/local/= pdf-tools-0.70/pdf-virtual hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1= 557/pdf-virtual
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-view hi= des c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-view
c:/Hom= e/.emacs.d/local/pdf-tools-0.70/pdf-util hides c:/Home/.emacs.d/elpa/pdf-to= ols-20161026.1557/pdf-util
c:/Home/.emacs.d/local/pdf-tools-0.70/= pdf-tools hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-tools
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools-pkg hides c:/Home/.e= macs.d/elpa/pdf-tools-20161026.1557/pdf-tools-pkg
c:/Home/.emacs.= d/local/pdf-tools-0.70/pdf-tools-autoloads hides c:/Home/.emacs.d/elpa/pdf-= tools-20161026.1557/pdf-tools-autoloads
c:/Home/.emacs.d/local/pd= f-tools-0.70/pdf-sync hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/p= df-sync
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-outline hides c= :/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-outline
c:/Home/= .emacs.d/local/pdf-tools-0.70/pdf-occur hides c:/Home/.emacs.d/elpa/pdf-too= ls-20161026.1557/pdf-occur
c:/Home/.emacs.d/local/pdf-tools-0.70/= pdf-misc hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-misc
=
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-links hides c:/Home/.emacs.d= /elpa/pdf-tools-20161026.1557/pdf-links
c:/Home/.emacs.d/local/pd= f-tools-0.70/pdf-isearch hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.155= 7/pdf-isearch
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-info hide= s c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-info
c:/Home/= .emacs.d/local/pdf-tools-0.70/pdf-history hides c:/Home/.emacs.d/elpa/pdf-t= ools-20161026.1557/pdf-history
c:/Home/.emacs.d/local/pdf-tools-0= .70/pdf-dev hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.1557/pdf-dev
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-cache hides c:/Home/.emacs= .d/elpa/pdf-tools-20161026.1557/pdf-cache
c:/Home/.emacs.d/local/= pdf-tools-0.70/pdf-annot hides c:/Home/.emacs.d/elpa/pdf-tools-20161026.155= 7/pdf-annot
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-virtual hid= es c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-virtual
c:/Home/.e= macs.d/local/pdf-tools-0.70/pdf-view hides c:/Local/Emacs/site-lisp/pdf-too= ls-0.70/pdf-view
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-util h= ides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-util
c:/Home/.em= acs.d/local/pdf-tools-0.70/pdf-tools hides c:/Local/Emacs/site-lisp/pdf-too= ls-0.70/pdf-tools
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools= -pkg hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-tools-pkg
= c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-tools-autoloads hides c:/Local/Em= acs/site-lisp/pdf-tools-0.70/pdf-tools-autoloads
c:/Home/.emacs.d= /local/pdf-tools-0.70/pdf-sync hides c:/Local/Emacs/site-lisp/pdf-tools-0.7= 0/pdf-sync
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-outline hide= s c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-outline
c:/Home/.em= acs.d/local/pdf-tools-0.70/pdf-occur hides c:/Local/Emacs/site-lisp/pdf-too= ls-0.70/pdf-occur
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-misc = hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-misc
c:/Home/.e= macs.d/local/pdf-tools-0.70/pdf-links hides c:/Local/Emacs/site-lisp/pdf-to= ols-0.70/pdf-links
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-isea= rch hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-isearch
c:/= Home/.emacs.d/local/pdf-tools-0.70/pdf-info hides c:/Local/Emacs/site-lisp/= pdf-tools-0.70/pdf-info
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf= -history hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-history
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-dev hides c:/Local/Emacs/site-l= isp/pdf-tools-0.70/pdf-dev
c:/Home/.emacs.d/local/pdf-tools-0.70/= pdf-cache hides c:/Local/Emacs/site-lisp/pdf-tools-0.70/pdf-cache
c:/Home/.emacs.d/local/pdf-tools-0.70/pdf-annot hides c:/Local/Emacs/site-= lisp/pdf-tools-0.70/pdf-annot
c:/Home/.emacs.d/elpa/tablist-20160= 424.235/tablist hides c:/Local/Emacs/site-lisp/tablist/tablist
c:= /Home/.emacs.d/elpa/tablist-20160424.235/tablist-pkg hides c:/Local/Emacs/s= ite-lisp/tablist/tablist-pkg
c:/Home/.emacs.d/elpa/tablist-201604= 24.235/tablist-filter hides c:/Local/Emacs/site-lisp/tablist/tablist-filter=
c:/Home/.emacs.d/elpa/tablist-20160424.235/tablist-autoloads hid= es c:/Local/Emacs/site-lisp/tablist/tablist-autoloads
c:/Home/.em= acs.d/local/org-mode/lisp/ox hides c:/Local/Emacs/lisp/org/ox
c:/= Home/.emacs.d/local/org-mode/lisp/ox-texinfo hides c:/Local/Emacs/lisp/org/= ox-texinfo
c:/Home/.emacs.d/local/org-mode/lisp/ox-publish hides = c:/Local/Emacs/lisp/org/ox-publish
c:/Home/.emacs.d/local/org-mod= e/lisp/ox-org hides c:/Local/Emacs/lisp/org/ox-org
c:/Home/.emacs= .d/local/org-mode/lisp/ox-odt hides c:/Local/Emacs/lisp/org/ox-odt
c:/Home/.emacs.d/local/org-mode/lisp/ox-md hides c:/Local/Emacs/lisp/org/= ox-md
c:/Home/.emacs.d/local/org-mode/lisp/ox-man hides c:/Local/= Emacs/lisp/org/ox-man
c:/Home/.emacs.d/local/org-mode/lisp/ox-lat= ex hides c:/Local/Emacs/lisp/org/ox-latex
c:/Home/.emacs.d/local/= org-mode/lisp/ox-icalendar hides c:/Local/Emacs/lisp/org/ox-icalendar
=
c:/Home/.emacs.d/local/org-mode/lisp/ox-html hides c:/Local/Emacs/lisp= /org/ox-html
c:/Home/.emacs.d/local/org-mode/lisp/ox-beamer hides= c:/Local/Emacs/lisp/org/ox-beamer
c:/Home/.emacs.d/local/org-mod= e/lisp/ox-ascii hides c:/Local/Emacs/lisp/org/ox-ascii
c:/Home/.e= macs.d/local/org-mode/lisp/org hides c:/Local/Emacs/lisp/org/org
= c:/Home/.emacs.d/local/org-mode/lisp/org-w3m hides c:/Local/Emacs/lisp/org/= org-w3m
c:/Home/.emacs.d/local/org-mode/lisp/org-version hides c:= /Local/Emacs/lisp/org/org-version
c:/Home/.emacs.d/local/org-mode= /lisp/org-timer hides c:/Local/Emacs/lisp/org/org-timer
c:/Home/.= emacs.d/local/org-mode/lisp/org-table hides c:/Local/Emacs/lisp/org/org-tab= le
c:/Home/.emacs.d/local/org-mode/lisp/org-src hides c:/Local/Em= acs/lisp/org/org-src
c:/Home/.emacs.d/local/org-mode/lisp/org-rma= il hides c:/Local/Emacs/lisp/org/org-rmail
c:/Home/.emacs.d/local= /org-mode/lisp/org-protocol hides c:/Local/Emacs/lisp/org/org-protocol
c:/Home/.emacs.d/local/org-mode/lisp/org-plot hides c:/Local/Emacs/li= sp/org/org-plot
c:/Home/.emacs.d/local/org-mode/lisp/org-pcomplet= e hides c:/Local/Emacs/lisp/org/org-pcomplete
c:/Home/.emacs.d/lo= cal/org-mode/lisp/org-mouse hides c:/Local/Emacs/lisp/org/org-mouse
c:/Home/.emacs.d/local/org-mode/lisp/org-mobile hides c:/Local/Emacs/lis= p/org/org-mobile
c:/Home/.emacs.d/local/org-mode/lisp/org-mhe hid= es c:/Local/Emacs/lisp/org/org-mhe
c:/Home/.emacs.d/local/org-mod= e/lisp/org-macs hides c:/Local/Emacs/lisp/org/org-macs
c:/Home/.e= macs.d/local/org-mode/lisp/org-macro hides c:/Local/Emacs/lisp/org/org-macr= o
c:/Home/.emacs.d/local/org-mode/lisp/org-loaddefs hides c:/Loca= l/Emacs/lisp/org/org-loaddefs
c:/Home/.emacs.d/local/org-mode/lis= p/org-list hides c:/Local/Emacs/lisp/org/org-list
c:/Home/.emacs.= d/local/org-mode/lisp/org-irc hides c:/Local/Emacs/lisp/org/org-irc
c:/Home/.emacs.d/local/org-mode/lisp/org-install hides c:/Local/Emacs/li= sp/org/org-install
c:/Home/.emacs.d/local/org-mode/lisp/org-inlin= etask hides c:/Local/Emacs/lisp/org/org-inlinetask
c:/Home/.emacs= .d/local/org-mode/lisp/org-info hides c:/Local/Emacs/lisp/org/org-info
c:/Home/.emacs.d/local/org-mode/lisp/org-indent hides c:/Local/Emacs/= lisp/org/org-indent
c:/Home/.emacs.d/local/org-mode/lisp/org-id h= ides c:/Local/Emacs/lisp/org/org-id
c:/Home/.emacs.d/local/org-mo= de/lisp/org-habit hides c:/Local/Emacs/lisp/org/org-habit
c:/Home= /.emacs.d/local/org-mode/lisp/org-gnus hides c:/Local/Emacs/lisp/org/org-gn= us
c:/Home/.emacs.d/local/org-mode/lisp/org-footnote hides c:/Loc= al/Emacs/lisp/org/org-footnote
c:/Home/.emacs.d/local/org-mode/li= sp/org-feed hides c:/Local/Emacs/lisp/org/org-feed
c:/Home/.emacs= .d/local/org-mode/lisp/org-faces hides c:/Local/Emacs/lisp/org/org-faces
c:/Home/.emacs.d/local/org-mode/lisp/org-eshell hides c:/Local/Emac= s/lisp/org/org-eshell
c:/Home/.emacs.d/local/org-mode/lisp/org-en= tities hides c:/Local/Emacs/lisp/org/org-entities
c:/Home/.emacs.= d/local/org-mode/lisp/org-element hides c:/Local/Emacs/lisp/org/org-element=
c:/Home/.emacs.d/local/org-mode/lisp/org-docview hides c:/Local/= Emacs/lisp/org/org-docview
c:/Home/.emacs.d/local/org-mode/lisp/o= rg-datetree hides c:/Local/Emacs/lisp/org/org-datetree
c:/Home/.e= macs.d/local/org-mode/lisp/org-ctags hides c:/Local/Emacs/lisp/org/org-ctag= s
c:/Home/.emacs.d/local/org-mode/lisp/org-crypt hides c:/Local/E= macs/lisp/org/org-crypt
c:/Home/.emacs.d/local/org-mode/lisp/org-= compat hides c:/Local/Emacs/lisp/org/org-compat
c:/Home/.emacs.d/= local/org-mode/lisp/org-colview hides c:/Local/Emacs/lisp/org/org-colview
c:/Home/.emacs.d/local/org-mode/lisp/org-clock hides c:/Local/Emac= s/lisp/org/org-clock
c:/Home/.emacs.d/local/org-mode/lisp/org-cap= ture hides c:/Local/Emacs/lisp/org/org-capture
c:/Home/.emacs.d/l= ocal/org-mode/lisp/org-bibtex hides c:/Local/Emacs/lisp/org/org-bibtex
c:/Home/.emacs.d/local/org-mode/lisp/org-bbdb hides c:/Local/Emacs/li= sp/org/org-bbdb
c:/Home/.emacs.d/local/org-mode/lisp/org-attach h= ides c:/Local/Emacs/lisp/org/org-attach
c:/Home/.emacs.d/local/or= g-mode/lisp/org-archive hides c:/Local/Emacs/lisp/org/org-archive
c:/Home/.emacs.d/local/org-mode/lisp/org-agenda hides c:/Local/Emacs/lisp/= org/org-agenda
c:/Home/.emacs.d/local/org-mode/lisp/ob hides c:/L= ocal/Emacs/lisp/org/ob
c:/Home/.emacs.d/local/org-mode/lisp/ob-ta= ngle hides c:/Local/Emacs/lisp/org/ob-tangle
c:/Home/.emacs.d/loc= al/org-mode/lisp/ob-table hides c:/Local/Emacs/lisp/org/ob-table
= c:/Home/.emacs.d/local/org-mode/lisp/ob-sqlite hides c:/Local/Emacs/lisp/or= g/ob-sqlite
c:/Home/.emacs.d/local/org-mode/lisp/ob-sql hides c:/= Local/Emacs/lisp/org/ob-sql
c:/Home/.emacs.d/local/org-mode/lisp/= ob-shen hides c:/Local/Emacs/lisp/org/ob-shen
c:/Home/.emacs.d/lo= cal/org-mode/lisp/ob-screen hides c:/Local/Emacs/lisp/org/ob-screen
c:/Home/.emacs.d/local/org-mode/lisp/ob-scheme hides c:/Local/Emacs/lisp= /org/ob-scheme
c:/Home/.emacs.d/local/org-mode/lisp/ob-scala hide= s c:/Local/Emacs/lisp/org/ob-scala
c:/Home/.emacs.d/local/org-mod= e/lisp/ob-sass hides c:/Local/Emacs/lisp/org/ob-sass
c:/Home/.ema= cs.d/local/org-mode/lisp/ob-ruby hides c:/Local/Emacs/lisp/org/ob-ruby
c:/Home/.emacs.d/local/org-mode/lisp/ob-ref hides c:/Local/Emacs/lisp= /org/ob-ref
c:/Home/.emacs.d/local/org-mode/lisp/ob-R hides c:/Lo= cal/Emacs/lisp/org/ob-R
c:/Home/.emacs.d/local/org-mode/lisp/ob-p= ython hides c:/Local/Emacs/lisp/org/ob-python
c:/Home/.emacs.d/lo= cal/org-mode/lisp/ob-plantuml hides c:/Local/Emacs/lisp/org/ob-plantuml
c:/Home/.emacs.d/local/org-mode/lisp/ob-picolisp hides c:/Local/Emac= s/lisp/org/ob-picolisp
c:/Home/.emacs.d/local/org-mode/lisp/ob-pe= rl hides c:/Local/Emacs/lisp/org/ob-perl
c:/Home/.emacs.d/local/o= rg-mode/lisp/ob-org hides c:/Local/Emacs/lisp/org/ob-org
c:/Home/= .emacs.d/local/org-mode/lisp/ob-octave hides c:/Local/Emacs/lisp/org/ob-oct= ave
c:/Home/.emacs.d/local/org-mode/lisp/ob-ocaml hides c:/Local/= Emacs/lisp/org/ob-ocaml
c:/Home/.emacs.d/local/org-mode/lisp/ob-m= scgen hides c:/Local/Emacs/lisp/org/ob-mscgen
c:/Home/.emacs.d/lo= cal/org-mode/lisp/ob-maxima hides c:/Local/Emacs/lisp/org/ob-maxima
c:/Home/.emacs.d/local/org-mode/lisp/ob-matlab hides c:/Local/Emacs/lisp= /org/ob-matlab
c:/Home/.emacs.d/local/org-mode/lisp/ob-makefile h= ides c:/Local/Emacs/lisp/org/ob-makefile
c:/Home/.emacs.d/local/o= rg-mode/lisp/ob-lob hides c:/Local/Emacs/lisp/org/ob-lob
c:/Home/= .emacs.d/local/org-mode/lisp/ob-lisp hides c:/Local/Emacs/lisp/org/ob-lisp<= /div>
c:/Home/.emacs.d/local/org-mode/lisp/ob-lilypond hides c:/Local/E= macs/lisp/org/ob-lilypond
c:/Home/.emacs.d/local/org-mode/lisp/ob= -ledger hides c:/Local/Emacs/lisp/org/ob-ledger
c:/Home/.emacs.d/= local/org-mode/lisp/ob-latex hides c:/Local/Emacs/lisp/org/ob-latex
c:/Home/.emacs.d/local/org-mode/lisp/ob-keys hides c:/Local/Emacs/lisp/o= rg/ob-keys
c:/Home/.emacs.d/local/org-mode/lisp/ob-js hides c:/Lo= cal/Emacs/lisp/org/ob-js
c:/Home/.emacs.d/local/org-mode/lisp/ob-= java hides c:/Local/Emacs/lisp/org/ob-java
c:/Home/.emacs.d/local= /org-mode/lisp/ob-io hides c:/Local/Emacs/lisp/org/ob-io
c:/Home/= .emacs.d/local/org-mode/lisp/ob-haskell hides c:/Local/Emacs/lisp/org/ob-ha= skell
c:/Home/.emacs.d/local/org-mode/lisp/ob-gnuplot hides c:/Lo= cal/Emacs/lisp/org/ob-gnuplot
c:/Home/.emacs.d/local/org-mode/lis= p/ob-fortran hides c:/Local/Emacs/lisp/org/ob-fortran
c:/Home/.em= acs.d/local/org-mode/lisp/ob-exp hides c:/Local/Emacs/lisp/org/ob-exp
=
c:/Home/.emacs.d/local/org-mode/lisp/ob-eval hides c:/Local/Emacs/lisp= /org/ob-eval
c:/Home/.emacs.d/local/org-mode/lisp/ob-emacs-lisp h= ides c:/Local/Emacs/lisp/org/ob-emacs-lisp
c:/Home/.emacs.d/local= /org-mode/lisp/ob-dot hides c:/Local/Emacs/lisp/org/ob-dot
c:/Hom= e/.emacs.d/local/org-mode/lisp/ob-ditaa hides c:/Local/Emacs/lisp/org/ob-di= taa
c:/Home/.emacs.d/local/org-mode/lisp/ob-css hides c:/Local/Em= acs/lisp/org/ob-css
c:/Home/.emacs.d/local/org-mode/lisp/ob-core = hides c:/Local/Emacs/lisp/org/ob-core
c:/Home/.emacs.d/local/org-= mode/lisp/ob-comint hides c:/Local/Emacs/lisp/org/ob-comint
c:/Ho= me/.emacs.d/local/org-mode/lisp/ob-clojure hides c:/Local/Emacs/lisp/org/ob= -clojure
c:/Home/.emacs.d/local/org-mode/lisp/ob-calc hides c:/Lo= cal/Emacs/lisp/org/ob-calc
c:/Home/.emacs.d/local/org-mode/lisp/o= b-C hides c:/Local/Emacs/lisp/org/ob-C
c:/Home/.emacs.d/local/org= -mode/lisp/ob-awk hides c:/Local/Emacs/lisp/org/ob-awk
c:/Home/.e= macs.d/local/org-mode/lisp/ob-asymptote hides c:/Local/Emacs/lisp/org/ob-as= ymptote
c:/Home/.emacs.d/elpa/seq-2.19/seq hides c:/Local/Emacs/l= isp/emacs-lisp/seq

Features:
(shadow sor= t mail-extr emacsbug sendmail misearch multi-isearch
network-stre= am nsm starttls texmathp debug smex two-column iso-transl
popwin = latexenc reftex-auc preview prv-emacs tex-buf pdf-occur tablist
t= ablist-filter semantic/wisent/comp semantic/wisent
semantic/wisen= t/wisent semantic/util-modes semantic/util semantic
semantic/tag = semantic/lex semantic/fw mode-local cedet pdf-isearch
let-alist p= df-misc font-latex view reftex-global reftex-parse reftex-dcr
org= -eldoc org-indent company-jedi yasnippet highlight-indentation
fl= ymake elpy pyvenv elpy-refactor files-x smartparens jedi-core
pyt= hon-environment epc ctable concurrent deferred company-statistics
company-oddmuse company-keywords company-etags company-gtags
com= pany-dabbrev-code company-dabbrev company-files company-cmake
com= pany-xcode company-clang company-semantic company-eclim
company-t= emplate company-css company-nxml company-bbdb company python
auto= conf autoconf-mode sh-script executable rainbow-delimiters undo-tree
<= div>diff anzu projectile grep ibuf-ext ibuffer make-mode desktop frameset
ox-bibtex reftex-cite reftex reftex-vars pdf-tools pdf-view pdf-ca= che
pdf-info tq pdf-util ob-shell ob-gnuplot ob-python ob-org ob-= dot ob-lisp
ob-latex ox-koma-letter ox-beamer ox-reveal ox-odt ox= -latex ox-icalendar
ox-html table ox-ascii ox-publish ox org-wl o= rg-toc org-timer org-clock
org-screen term ehelp org-protocol org= -panel org-mouse org-mime
org-interactive-query org-inlinetask or= g-info org-habit org-expiry
org-eval org-drill org-learn org-id h= i-lock org-contacts org-capture
org-agenda gnus-art mm-uu mml2015= mm-view mml-smime smime dig gnus-sum
gnus-group gnus-undo gnus-s= tart gnus-cloud nnimap nnmail mail-source
utf7 netrc nnoo parse-t= ime gnus-spec gnus-int gnus-range gnus-win gnus
gnus-ems nnheader= org-checklist org-bibtex bibtex org-annotate-file
web-mode caml = tuareg_indent tuareg speedbar sb-image ezimage dframe smie
caml-h= elp caml-types caml-emacs magic-latex-buffer iimage tex-mode latex
tex-ispell tex-style tex fp-specif slime-fancy slime-trace-dialog
slime-fontifying-fu slime-package-fu slime-references
slime-co= mpiler-notes-tree slime-scratch slime-presentations bridge
slime-= macrostep macrostep slime-mdot-fu slime-enclosing-context
slime-f= uzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c
slime-ed= iting-commands slime-autodoc slime-repl elp slime-parse slime
lis= p-mnt gud apropos arc-mode archive-mode hyperspec browse-url
fp-p= seudocode pascal rng-nxml rng-valid rng-loc rng-uri rng-parse
nxm= l-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode
nxm= l-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok ediprolog
w= ritegood-mode winner windmove whitespace which-key which-func
vol= atile-highlights sumatra-forward ssh smart-mode-line rich-minority
saveplace savehist graphene-meta-theme sanityinc-tomorrow-night-theme
color-theme-sanityinc-tomorrow recentf tree-widget ranger ps-print
ps-def lpr popup page-break-lines ov outshine outshine-org-cmds ou= torg
org-element avl-tree org org-macro org-footnote org-pcomplet= e org-list
org-faces org-entities org-version ob-emacs-lisp ob ob= -tangle org-src
ob-ref ob-lob ob-table ob-keys ob-exp ob-comint o= b-core ob-eval
org-compat org-macs org-loaddefs cal-menu calendar= cal-loaddefs noutline
outline operate-on-number calc-bin calc-ex= t calc calc-loaddefs calc-macs
oauth2 warnings plstore move-text = midnight memory-usage magithub
magithub-ci magithub-issue magithu= b-cache magithub-core magit-blame
magit-stash magit-bisect magit-= remote magit-commit magit-sequence magit
magit-apply magit-wip ma= git-log magit-diff smerge-mode magit-core
magit-autorevert magit-= process magit-popup magit-mode magit-git crm
magit-section magit-= utils git-commit log-edit message rfc822 mml mml-sec
epg mm-decod= e mm-bodies mm-encode mailabbrev mail-utils gmm-utils
mailheader = pcvs-util add-log with-editor async-bytecomp async tramp-sh
tramp= tramp-compat tramp-loaddefs trampver shell pcomplete server
lua-= mode key-chord js2-mode etags xref project js sgml-mode cc-mode
c= c-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs imenu-anywhere imenu ido-hacks flx-ido flx ido-vertical-mode<= /div>
ido-ubiquitous ido-completing-read+ cus-edit cus-start cus-load w= id-edit
ido hungry-delete htmlize hl-line highlight-symbol guru-m= ode grizzl
god-mode gitignore-mode gitconfig-mode conf-mode git-t= imemachine vc-git
gist gh-gist gh-oauth gh-api logito gh-cache pc= ache gh-auth gh-url
url-http tls gnutls url url-proxy url-privacy= url-expand url-methods
url-history mailcap url-auth mail-parse r= fc2231 rfc2047 rfc2045
ietf-drums url-cookie url-domsuf url-util = url-gw timezone eieio-base
framemove flyspell ispell flycheck fin= d-func epl ediff-merg ediff-wind
ediff-diff ediff-mult ediff-help= ediff-init ediff-util ediff easy-kill
thingatpt doc-view subr-x = jka-compr image-mode discover-my-major makey
dired+ image-dired f= ormat-spec image-file dired-x dired-aux diff-hl
smartrep vc-dir e= woc vc vc-dispatcher diff-mode dictionary link
connection browse-= kill-ring derived bookmark pp beacon autorevert
filenotify ag vc-= svn compile comint ansi-color ring find-dired dired cl
edmacro km= acro cua-base delsel use-package diminish bind-key easy-mmode
fin= der-inf tex-site gh-common gh-profile url-parse auth-source gnus-util
=
mm-util help-fns mail-prsvr password-cache url-vars rx s ucs-normalize=
marshal eieio-compat cl-seq ht json map dash eieio eieio-core cl= -macs
advice info package epg-config seq byte-opt gv bytecomp byt= e-compile
cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-= lib time-date
mule-util tooltip eldoc electric uniquify ediff-hoo= k vc-hooks
lisp-float-type mwheel dos-w32 ls-lisp disp-table w32-= win w32-vars
term/common-win tool-bar dnd fontset image regexp-op= t fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode= register page
menu-bar rfn-eshadow timer select scroll-bar mouse= jit-lock font-lock
syntax facemenu font-core frame cl-generic ch= am georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet= lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slova= k czech european ethiopic indian
cyrillic chinese charscript case= -table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-pr= eloaded nadvice loaddefs button faces
cus-face macroexp files tex= t-properties overlay sha1 md5 base64 format
env code-pages mule c= ustom widget hashtable-print-readable backquote
w32notify w32 mul= ti-tty make-network-process emacs)

Memory informat= ion:
((conses 16 1899150 677834)
=C2=A0(symbols 56 9878= 1 0)
=C2=A0(miscs 48 71108 15295)
=C2=A0(strings 32 352= 119 167999)
=C2=A0(string-bytes 1 10705287)
=C2=A0(vect= ors 16 174375)
=C2=A0(vector-slots 8 4203177 425963)
= =C2=A0(floats 8 16169 10128)
=C2=A0(intervals 56 128230 8752)
=C2=A0(buffers 976 80))

--089e01493e64454d0c05421a2ebf-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 02:04:08 2016 Received: (at submit) by debbugs.gnu.org; 25 Nov 2016 07:04:08 +0000 Received: from localhost ([127.0.0.1]:40940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAAYK-0004pa-CY for submit@debbugs.gnu.org; Fri, 25 Nov 2016 02:04:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAAYJ-0004pO-HH for submit@debbugs.gnu.org; Fri, 25 Nov 2016 02:04:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAAYA-0003Tn-JQ for submit@debbugs.gnu.org; Fri, 25 Nov 2016 02:04:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAAYA-0003Ta-G5 for submit@debbugs.gnu.org; Fri, 25 Nov 2016 02:03:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAAY9-0004k7-Gj for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 02:03:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAAY4-0003Pl-KO for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 02:03:57 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:62762) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cAAY4-0003Oh-AK for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2016 02:03:52 -0500 Received: from [18.189.106.208] ([18.189.106.208]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.184]) with ESMTPSA (Nemesis) id 0M3MGG-1d0lAT2ijw-00r1it for ; Fri, 25 Nov 2016 08:03:49 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: bug-gnu-emacs@gnu.org References: From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: Date: Fri, 25 Nov 2016 02:03:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LpNTPeTXNKGsBssRFxUWNVq6IOVRTWel3" X-Provags-ID: V03:K0:9bqBBwX5SB5IQTejJxQCx8BSronlcNjsyjyNg3X7fNYHmwnKdhU YzLAA0f1U9twKSHU6asxsD3+OL8zFT2e6N1xdh10NhSfU/wKNvpWD5iQ242Hi4wcmpAFjVI gbpE65xrrxZYBgxo5JA4P4Nkuh5ejjr1oRss3oWEtELOwvl7EfEKdkxPuAbn1TYoiwTq1k2 q9mat4df97fA7m1YkD8Rg== X-UI-Out-Filterresults: notjunk:1;V01:K0:VfEs5Bzapf4=:PknECu12PEbl8cUiDTCYxR YdIekQlOj2nuVTzacKYCJug0YZz6DXVQz6WlqQAhvHDsHVue97yb8VnhPGb3P9/8UX1S86P7s ZJ22TbSs20RtyZy5/FVVVqnJvv1HG+Ujb91yuj9T+Rxjy62eVo7896dGI4sYTkpNz1Ag6XHX4 yRwhO3E+/rp9Bp+NuAtNcK/umEZq2UAORuLhwYS+m8juJ0E06BJYwW26B12l/pBS49tLISOgX 0DvHKVUE48cbl9/gpuajg2bDzsMExKxKLZjdBgC+6q6VzT4sh8khdUAWf6vHBuahWkq+0H4mj Xo1tMDqk4yFnK5SQ5ApP+cKt9F/wZ+6+gQdkgH+1iBWYukRK1WW2BO54S/YlVjNgNYNXWTlXo h95tYnSCeuxdiqPzyCxaZNju8uzv9y/BcDlLmGdOA7gODP8ApzC+RiVSmyXU3ujeY7yaBPVmn oMjR5DKOUYCQvm69fuwCls2G3KAoPq0s9FD1TUDSHOiNCdqSWz8j66RdRAZkkWMJCrZYktZUD hSnJBl7gCjJ7CHc9eafsgmaYz9EeBxTmkEbm2mpemibmTxhGKIV6ElSKkkBj4zk0S0qx7SO4R 1grys3yjVT9ugxU+Xibu6EqyXy8Rc2rqwdLmRVMKMWZ1+TP/YJQfQPTJTpr2M/sNoPQDVLv64 BXYlIuZkXvt9cUCrQ36kV6XhxsIZ2actZ+eiTb6JgKzGtyddiVYGtlt2IlTmgeLID8Qo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LpNTPeTXNKGsBssRFxUWNVq6IOVRTWel3 Content-Type: multipart/mixed; boundary="NfR9B5lq0vA6cfoNwaajM7FK42qNncsOj"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong References: In-Reply-To: --NfR9B5lq0vA6cfoNwaajM7FK42qNncsOj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-11-25 01:24, Fabrice Popineau wrote: > The python shell name is not passed to any underlying shell. > It is used to create a process, so it must not be quoted in anyway. Are you sure? Looking at the code, I see this: (python-shell-make-comint (or cmd (python-shell-calculate-command)) =E2=80=A6) And python-shell-make-comint does this: (split-string-and-unquote cmd) (ok, this is weird). But still, if the command is "C:\Program Files\Pyth= on\python.exe", then we *do* need the shell quoting, right? Cl=C3=A9ment. =20 --NfR9B5lq0vA6cfoNwaajM7FK42qNncsOj-- --LpNTPeTXNKGsBssRFxUWNVq6IOVRTWel3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYN+JTAAoJEPqg+cTm90wjfrUP/2nsNfF7U9dYp7gO3UpR3T5k VK9IQy6whEACU+ZjvnHUpDuKQ7mmBzy5ez5gVhKsLcX2Buvt1I0JJWlA5ItHT0TI +/iPNN2V1sKMiiNb2qdHzJtRZUDU8batMrGpYfeWX2aDXu56YXYMsqHyqpuRcFN4 jzbYrXhojfW+lxFuYbj3sk3+SWz4iBJLX6JhMIZxF4Db4EH40DeBDGbtYGKKThVW Q36ISA6n2Q7dUvAZTkJyozM0f3UUTm/PavbArYbhCGTav4ZDN+E9iPhuOtTcXozV 5pcs4bLNppTrOamkF0sNifQbsrUM1HIEuioc+QNR+SlrJzBUv7Q18ktqBxzlK7Xc OgjATn+b459uJDIjYM47AtNO+9ZxGqxGPKVlKgoxgVWWZdfuO8zE3jhAu53I+Iwz AzBePc5EDSm51mOtPKvbxCnCDdWOlw43dOnSffIO8QCkRHGGdtXNZ+cnZjq3MSYf QElIr+ujNm5fr4rqqfAvxlNpvDV4xIOoRsjcq5kDgwyzZsmo6oIps9311xIcC/X3 L35lriUgaIdQdnbM98ADY+HneEvM88K7yZ80SemmTi0JgME8jYbnZJN3MCTMBRhG 3bgvQtjmCginwVG0uBCpYud4ux3boUdRgNtfnVrO20iLYkw6tTHTD+B8Z8fMhAtP HD9sixF3aRhvZGDuR+4W =BSFK -----END PGP SIGNATURE----- --LpNTPeTXNKGsBssRFxUWNVq6IOVRTWel3-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 03:32:54 2016 Received: (at 25025) by debbugs.gnu.org; 25 Nov 2016 08:32:54 +0000 Received: from localhost ([127.0.0.1]:41016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cABwE-0006xl-F8 for submit@debbugs.gnu.org; Fri, 25 Nov 2016 03:32:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cABwC-0006xY-Dr for 25025@debbugs.gnu.org; Fri, 25 Nov 2016 03:32:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cABw2-0000Sm-TM for 25025@debbugs.gnu.org; Fri, 25 Nov 2016 03:32:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cABw2-0000Sg-Q3; Fri, 25 Nov 2016 03:32:42 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2085 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cABw1-0005QG-UG; Fri, 25 Nov 2016 03:32:42 -0500 Date: Fri, 25 Nov 2016 10:32:31 +0200 Message-Id: <83polk3qow.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel In-reply-to: (message from =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel on Fri, 25 Nov 2016 02:03:38 -0500) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: ClĂ©ment Pit--Claudel > Date: Fri, 25 Nov 2016 02:03:38 -0500 > > On 2016-11-25 01:24, Fabrice Popineau wrote: > > The python shell name is not passed to any underlying shell. > > It is used to create a process, so it must not be quoted in anyway. > > Are you sure? Looking at the code, I see this: > > (python-shell-make-comint > (or cmd (python-shell-calculate-command)) …) > > And python-shell-make-comint does this: > > (split-string-and-unquote cmd) > > (ok, this is weird). But still, if the command is "C:\Program Files\Python\python.exe", then we *do* need the shell quoting, right? The quoting needs to be done only where a shell command is created that is about to be passed to a shell. I believe in this case the quoting is done too early. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 09:44:38 2016 Received: (at 25025) by debbugs.gnu.org; 25 Nov 2016 14:44:38 +0000 Received: from localhost ([127.0.0.1]:41313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAHjy-0002MK-1h for submit@debbugs.gnu.org; Fri, 25 Nov 2016 09:44:38 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:62141) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAHjv-0002M6-Uw for 25025@debbugs.gnu.org; Fri, 25 Nov 2016 09:44:36 -0500 Received: from [18.189.106.208] ([18.189.106.208]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.184]) with ESMTPSA (Nemesis) id 0M1GfI-1cywTt0Aq8-00tE7H; Fri, 25 Nov 2016 15:44:29 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii References: <83polk3qow.fsf@gnu.org> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: Date: Fri, 25 Nov 2016 09:44:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <83polk3qow.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qflNML5uGxuI1d2O18viu6FE7DtJ6xj17" X-Provags-ID: V03:K0:bWhSDYJpdLjuDT+ZYxWyf9XqRCP9KH/x+hmfoSBdVuCNY8OC6mJ Wt1WQ4EZNliZqyqnOuSE5ULpOSdGWNaaaFUA7crDP7b/tma8Y9nswFIYAt63PB6FEk6bIxG e1VGaNDOjYw7pOuzuKf7pM8BDX9BwZD9+IVUZXc/5IWD/+r4gF2eO/vG7VtHiIDmN/INOdh Sq76z7rHFIvlSghPD9t7A== X-UI-Out-Filterresults: notjunk:1;V01:K0:zpLJ3F0qDuY=:945xl2B8bo325kwNDYIc7G XwV7MfwQlC8Ytj8/piZdAZTICQ+bdMZS0xcJtkDzA1Ap1kWi5iF4gAoTLgKFIT8ogCfBi00/+ dgU21QrdSSiRPMX47p52e3dfPBE4ILs9RlWLLKHQze9F/qE+3uOK/L5nDaAa9wlTmGDg9ANx8 tBGYNEg6QEeNUou8wA9rJXEjhEba0IolNoeWXYjdbi3f+qvBQAtz/IWHHXmjQHdy3XNNzjZVi +o9ZzZgZwd1cD9+Q9Ybqb+bGAKmFqpYlY3zH2PZb+lalFdgIZaCCZgW8UjSvQmkWkMRvfMaoW 5zxKj9dSa4N67nvUumHSbnc6x5cyUYjU7o2cJqq0AeHIFKBjmR0LrVO1K1EpRc+IvgMYaZ74h UyU+J2m2NSo45XMt/iwtnY4tBHsYocptV3JZN4qXjQLlnCm19+rxs3oV6w9whTi3qcKRkZYYM qSwZIjSm6ncMw0m/SoVK2epcx97bzsgIuLk/BZUcRYSHLsaTmajJAluKIh8AdA2nUSxvLA2jU abD8UQIAyvAZHayu8PwIA+rq2F8hHNymmy62Flv7/ZZw5kMDN8Ikkmxn/eZu4qXRhLPDGt07B pZqImAifrHKg0YcwGvpkhKgwRv/APM3dQBObr2YEJMavQvM0IJ9/1LIj+NONTXLVUkm4owx2o Y4HQnWiKq5yyif26NmPqNxbhIB3lBeF5/TsBYTFfranoRAMLccyQ9Ym+JeAvKwy9QAOs= X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qflNML5uGxuI1d2O18viu6FE7DtJ6xj17 Content-Type: multipart/mixed; boundary="sHRF6iWwk7hkemOsSCF12N2FBGJ0uC689"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Eli Zaretskii Cc: 25025@debbugs.gnu.org Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> In-Reply-To: <83polk3qow.fsf@gnu.org> --sHRF6iWwk7hkemOsSCF12N2FBGJ0uC689 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-11-25 03:32, Eli Zaretskii wrote: >> From: Cl=C3=A9ment Pit--Claudel >> Date: Fri, 25 Nov 2016 02:03:38 -0500 >> >> On 2016-11-25 01:24, Fabrice Popineau wrote: >>> The python shell name is not passed to any underlying shell. >>> It is used to create a process, so it must not be quoted in anyway. >> >> Are you sure? Looking at the code, I see this: >> >> (python-shell-make-comint >> (or cmd (python-shell-calculate-command)) =E2=80=A6) >> >> And python-shell-make-comint does this: >> >> (split-string-and-unquote cmd) >> >> (ok, this is weird). But still, if the command is "C:\Program Files\P= ython\python.exe", then we *do* need the shell quoting, right? >=20 > The quoting needs to be done only where a shell command is created > that is about to be passed to a shell. I believe in this case the > quoting is done too early. Certainly; but it seems like we'll need to modify more than just python-s= hell-calculate-command; in fact, we probably could remove it entirely: th= ere's no need to glue together the command name and its arguments before = passing them to comint, is there? I was just pointing out that Fabrice's solution of writing (format "%s %s" python-shell-interpreter python-shell-interpreter-args)) would probably break things. Won't it? --sHRF6iWwk7hkemOsSCF12N2FBGJ0uC689-- --qflNML5uGxuI1d2O18viu6FE7DtJ6xj17 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYOE5BAAoJEPqg+cTm90wjWugP/iKFOtg9jtgh2Tm/Mbq5/f33 b0h7Uvd+qMI0clhslz1j6lnZ99jIYzU4ZJjNiDKTm2RyU+BvbaIcUIbZ71TYlLRu 6FfksFDheTgdUx8HahZEjk1stj1X4X2lm/4fnCRcL43lV7Kjqv8FA/VlN1V8mXRh UhN/9XSe3qatR4P9OCuZNTThchiOKZ5Y4g/lplPQU0pMMTkuVn/hl55iR1JiXpDH Lx2h6jA98089aeWu5iYfGyo/csTfWx/kRVToZ2gPnEv3UzvfNhrBofY4sgy9Vavr 5U4Vs0K3NuB0iZz66aEOfARXXGcsjAUYIjM5OI6a32RiqSTvAjD6SGmdmqW7kMm0 eNQ/BYdih68PmgKXsmAYR/PhGfotPsC/zLApHWYaLCnjPsB+RBN/tllmjxlq2obR jcmM1J/zaAyNdchZ5jsXt5mcuR+k2B2cDXD1oot2hDp7g7anIgLyyvjnJlPV4dGo Pz2SowYEk0gXSVddu3BO3nI4UY0JrS4lqYfT1ZqOvRH+mYyc6sOYoBsNBLXXiUcc VbY/lgJ6fPbTfwm9sS1UmELMj8V+VEsvz6IvF8IWwNfsIpmcrgVWvcDSozFifgEw cyi2KRl+8SACL9WnFQUc6POtj/3mGY5oS2kUYiOBk9GY9SwFIEBqeG+h7gHFP/nw +0K+oskbBroyS4dnbggv =2MDZ -----END PGP SIGNATURE----- --qflNML5uGxuI1d2O18viu6FE7DtJ6xj17-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 25 09:59:55 2016 Received: (at 25025) by debbugs.gnu.org; 25 Nov 2016 14:59:55 +0000 Received: from localhost ([127.0.0.1]:41594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAHyl-0002lk-BQ for submit@debbugs.gnu.org; Fri, 25 Nov 2016 09:59:55 -0500 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAHyf-0002lM-IY for 25025@debbugs.gnu.org; Fri, 25 Nov 2016 09:59:53 -0500 Received: by mail-oi0-f67.google.com with SMTP id v84so5253741oie.2 for <25025@debbugs.gnu.org>; Fri, 25 Nov 2016 06:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=xeOh+hNRJiqFI1kRHm6z0Df57Ivx3t+yZZHCUqhujaI=; b=zygqi/Yjw+HluFDJrAQwDNH2QW7BikjS65nYBoEETG7hoMEAq5d1OK1rF8PV0bFyNU shIyUW796hzGNcWhgFKQhM1qQ1G5PwhU8r+E03QpIKcQjXzvxuDjF68UBkEHabvIEvV8 PQp0InZKiUF/rxqTrGK9JXjer2i/Zah9gcO76BwPnnZ71IfmOiYtmvG3u+c/d9m/7UjR J+HBS+suuprpif9eD0nGtGP8m29wnQRl6W5aW+89fDBT574oxOSSlZ75POsQYfWkQmD1 +L8suKd+ZQLmic7CeTg095Da0vUonOyRHeGbSM+z8vPXSUgOWYZAvnAXskcXxYsFRuzR Lnug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=xeOh+hNRJiqFI1kRHm6z0Df57Ivx3t+yZZHCUqhujaI=; b=ZRsU9k2vxOnqmVw0xTaH8Q4MxIe9omopCQGyOuD/QfPf7LOo9tYcHJuxGzg7EQdomr 2OWb2seFfiTpk8Nc+Nk8H/gipai59c/keau+fGG4eGP0crBuZK8Dv92T41Eua+bIg4Ur MTIIEzgk/dY9FG+1Y/dpHHHaEXUq1dJdeT5CFAut44A4uamy9e4Q2C/pWfC0DvmR+L5w 4Y5H3TKmJQdETuqJxvBOGKglozSbyK6mVo5hmygAlIyPhL6V/IpWATtX71FSoTj0JCjS UBk6VoYtjophPFtcR5RhOQczHLNy4TkGD1gZGnrU1vvTeIVACoFkd67U7+n9fFVpA79b tttA== X-Gm-Message-State: AKaTC014z2rCCHAipdDcD1y03B4NTOWJEn6hvAHHGbe5A0bHycg0Lh+mnirlJiXX5Ve3ZWe5YQuf3WqnTAKoKw== X-Received: by 10.157.54.245 with SMTP id s50mr4761559otd.181.1480085983637; Fri, 25 Nov 2016 06:59:43 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.4.67 with HTTP; Fri, 25 Nov 2016 06:59:43 -0800 (PST) In-Reply-To: <83polk3qow.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> From: Noam Postavsky Date: Fri, 25 Nov 2016 09:59:43 -0500 X-Google-Sender-Auth: CslCrOqqywOWrBMp8AOkAuH8mxo Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) merge 25025 20744 quit On Fri, Nov 25, 2016 at 3:32 AM, Eli Zaretskii wrote: >> From: Cl=C3=A9ment Pit--Claudel >> Date: Fri, 25 Nov 2016 02:03:38 -0500 >> >> On 2016-11-25 01:24, Fabrice Popineau wrote: >> > The python shell name is not passed to any underlying shell. >> > It is used to create a process, so it must not be quoted in anyway. >> >> Are you sure? Looking at the code, I see this: >> >> (python-shell-make-comint >> (or cmd (python-shell-calculate-command)) =E2=80=A6) >> >> And python-shell-make-comint does this: >> >> (split-string-and-unquote cmd) >> >> (ok, this is weird). But still, if the command is "C:\Program Files\Pyt= hon\python.exe", then we *do* need the shell quoting, right? > > The quoting needs to be done only where a shell command is created > that is about to be passed to a shell. I believe in this case the > quoting is done too early. > I think the whole command should be quoted with combine-and-quote-strings to balance the call to split-string-and-unquote. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 13:43:45 2016 Received: (at 25025) by debbugs.gnu.org; 26 Nov 2016 18:43:45 +0000 Received: from localhost ([127.0.0.1]:42626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAhwv-0007T1-2q for submit@debbugs.gnu.org; Sat, 26 Nov 2016 13:43:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAhwu-0007Sp-3V for 25025@debbugs.gnu.org; Sat, 26 Nov 2016 13:43:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cAhwl-0006ng-1A for 25025@debbugs.gnu.org; Sat, 26 Nov 2016 13:43:38 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cAhwk-0006nT-UV; Sat, 26 Nov 2016 13:43:34 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cAhwi-0007LZ-2S; Sat, 26 Nov 2016 13:43:34 -0500 Date: Sat, 26 Nov 2016 20:43:12 +0200 Message-Id: <83inra13r3.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Fri, 25 Nov 2016 09:59:43 -0500) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -8.0 (--------) > From: Noam Postavsky > Date: Fri, 25 Nov 2016 09:59:43 -0500 > Cc: ClĂ©ment Pit--Claudel , > 25025@debbugs.gnu.org > > >> > The python shell name is not passed to any underlying shell. > >> > It is used to create a process, so it must not be quoted in anyway. > >> > >> Are you sure? Looking at the code, I see this: > >> > >> (python-shell-make-comint > >> (or cmd (python-shell-calculate-command)) …) > >> > >> And python-shell-make-comint does this: > >> > >> (split-string-and-unquote cmd) > >> > >> (ok, this is weird). But still, if the command is "C:\Program Files\Python\python.exe", then we *do* need the shell quoting, right? > > > > The quoting needs to be done only where a shell command is created > > that is about to be passed to a shell. I believe in this case the > > quoting is done too early. > > > > I think the whole command should be quoted with > combine-and-quote-strings to balance the call to > split-string-and-unquote. Why not remove both of those calls? Do you understand why they are needed in that case? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 19:50:48 2016 Received: (at 25025) by debbugs.gnu.org; 27 Nov 2016 00:50:48 +0000 Received: from localhost ([127.0.0.1]:42773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAng8-0008Oz-Ko for submit@debbugs.gnu.org; Sat, 26 Nov 2016 19:50:48 -0500 Received: from mail-oi0-f50.google.com ([209.85.218.50]:36010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cAng6-0008OW-Hq for 25025@debbugs.gnu.org; Sat, 26 Nov 2016 19:50:47 -0500 Received: by mail-oi0-f50.google.com with SMTP id v84so115533107oie.3 for <25025@debbugs.gnu.org>; Sat, 26 Nov 2016 16:50:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=H4b76pzBB7J8Ucx9ebiZLBvaBNDfOnn/OMgX5RwMiVM=; b=MYHdX+5TpUDRZRODB8OVfcRJMRMYFk/hOp18zZI6Ioh9XPunBeBU1mMaBPoOIUP90I HtJUyjGoxS5JSY0Jd0BR3nJ6nZbJg8U+iWqTDEeEcMRc2tX7HWsQ5DyxqWaCgRNE4j97 uxBgSDKxED1sIM5TNzDoumNo4QFpuDu4SOXZMIRecO4XvpOn82uSpUpcp3uND7CNu32l 5MHO9VZaSN5Xcsc8A+RzOfzLqNcUBaYXRuaMYdzlpbLvxWzmNbK0t9pWjp1tgCdBDLbY rM+w2nSR/v15xwKqcFhW7Cu2rhXpJkCxO8xdcqI/HN83oaKkZv0rRV7hTQh3XBDdg6/m ANTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=H4b76pzBB7J8Ucx9ebiZLBvaBNDfOnn/OMgX5RwMiVM=; b=Hwg6ngvCj2nTxuBpb8mpZVuZnkTMuwVIdUw7tfamGflk4sxdtMqmE+Bakk7sSlCB8v rachlzotmyRzIAyJWIdDwOlVOvgUj9yCBE87tsUiFnhh0dFSr/e6Ef8pZtwBD2UfBsIK +oJwBdWhxhBtOdsF/8oWGWqXMqfIeWwQkJgf5r6mBaAaeVeGUD/u/oB0/kyzPNSMAcdz DEa/EIF2r9CvC/HNHNQY3wj9AX2YDLFO3fTnSmmiseThtwvHWo+CVdN5RurQO5/fUmnD TgCdy1zoWeVc7nulgXIek3Uig9yOo46t5XqE7R+rFrvcEwWg9tmB1Dl3olvBq6edmxdT MF2Q== X-Gm-Message-State: AKaTC00Y6OQlQAI2WQW82V3Ih9teVdP/GrnofDjlb/UQwaBwNrzdc0o9ihNUtQ2y4Bll00t9wMu057P3JWKa7w== X-Received: by 10.157.54.245 with SMTP id s50mr8304136otd.181.1480207840904; Sat, 26 Nov 2016 16:50:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.4.67 with HTTP; Sat, 26 Nov 2016 16:50:40 -0800 (PST) In-Reply-To: <83inra13r3.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> From: Noam Postavsky Date: Sat, 26 Nov 2016 19:50:40 -0500 X-Google-Sender-Auth: 1FeH5FhuPOkAZaAWD4yWqtZCcTE Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Sat, Nov 26, 2016 at 1:43 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Fri, 25 Nov 2016 09:59:43 -0500 >> Cc: Cl=C3=A9ment Pit--Claudel , >> 25025@debbugs.gnu.org >> >> >> > The python shell name is not passed to any underlying shell. >> >> > It is used to create a process, so it must not be quoted in anyway. >> >> >> >> Are you sure? Looking at the code, I see this: >> >> >> >> (python-shell-make-comint >> >> (or cmd (python-shell-calculate-command)) =E2=80=A6) >> >> >> >> And python-shell-make-comint does this: >> >> >> >> (split-string-and-unquote cmd) >> >> >> >> (ok, this is weird). But still, if the command is "C:\Program Files\= Python\python.exe", then we *do* need the shell quoting, right? >> > >> > The quoting needs to be done only where a shell command is created >> > that is about to be passed to a shell. I believe in this case the >> > quoting is done too early. >> > >> >> I think the whole command should be quoted with >> combine-and-quote-strings to balance the call to >> split-string-and-unquote. > > Why not remove both of those calls? Do you understand why they are > needed in that case? Well, CMD can also come from user input, so we would need some way for the user to specify a list of arguments. Currently that can work by entering a string that would be split by split-string-and-unquote. It might be more intuitive to actually use a shell and then the user would enter a shell command (though inserting a shell into things might bring more complications). From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 26 21:35:43 2016 Received: (at 25025) by debbugs.gnu.org; 27 Nov 2016 02:35:43 +0000 Received: from localhost ([127.0.0.1]:42786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cApJe-0002n3-TP for submit@debbugs.gnu.org; Sat, 26 Nov 2016 21:35:43 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:57779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cApJc-0002mq-SQ for 25025@debbugs.gnu.org; Sat, 26 Nov 2016 21:35:41 -0500 Received: from [18.111.109.153] ([18.111.109.153]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.168]) with ESMTPSA (Nemesis) id 0MaiSH-1cQRQ62vYv-00KAET; Sun, 27 Nov 2016 03:35:19 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Noam Postavsky , Eli Zaretskii References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <9350b93c-c584-1676-f778-3432a078049f@gmail.com> Date: Sat, 26 Nov 2016 21:35:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eG6GnFwO0h0W6Anh1Q6ra9eU3Ip7ohud7" X-Provags-ID: V03:K0:Vzqf9haTQHSrgkK9SeMZo9G/3w2hjLjTVnQ86qYLNWTX2deIc13 5e+6fA4RW/a9wWBO8Rc2SkkmKWu5p2yNM3Pwu7yK4EobSTDtuc6AGJIiUkaq7JoaC71kTpa 1Gy8DvtGl/OPAGX+SxuViFdYDKrVdFi0VwL95G8EQs41ngbaiPvIuFz+F6qDe54J0a5JKEx ITJu9pJKc4T5FE3uSoKtg== X-UI-Out-Filterresults: notjunk:1;V01:K0:T5EZN24fs3g=:/FpHCZxKOY1rJ/W4T81BMT osCUgh1d+UcjFSRIoNVvvLTGmuYAn6NUidOmfzoOQJQ4Qf38pm3POToDVGTMR+dFs5j9btbeh PcGjxIt3OhUkqVcy00VBO+/1pmiAVb1N04VAbkgBKVlS1XmIi5CZH+35xhYvwS2PffKLJmTlt +WiZi0Fpv9tpageOa8KwcUh3ZIC4hYTyybkoHXPLsBJI5zqlxNKemDoWZ+hBrrN9x2XRJmhPr ctDAeH+lr7LTtId+cnusvTzDprXWZUHce7T6HkR9mYsZvg6L9TI9U4itK2O144nPk8sR+I9An y+9ZpY2ia8JB+9w0K4jtm084CQNS4Pf5f8W3AHpl1Vg8Zz7gnuTBtj0mFIiKoBmL9lohonvWx TrqPI37tZefpqhg9seDg3xNRaI5NqzQhOn/f8FuovcypKEfrbVTMQktQZXluHh+MfjquGJDdS 4Fx4USxPJKxD6ESMx97MIH04t6pbXgYU5SV8sn9e1Mjjq0EPpv1tJkhJPndtEsun9v4lY2/Ln RA1dNZ7dV4UCOdwD7z7G1m0q1TwWIIHuX0cGtFlA0ZrrwKKZ78nMvhXRI4XeqgWLr4xJffLMI otzgWQAubYCmEyhiBUy8tTxr89ZuIrcH6M9A5pL1hL+/JI2qdHZJ1tIBG/qayzuKy6PoIM/Xr ruMP1M14LbYbzuieR58uhuBFggsR5xBN6uIJ+S8fe48wdsasdbl2VhlD8d66fJvmWzyM= X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2016-11-26 19:50, Noam Postavsky wrote: > Well, CMD can also come from user input, so we would need some way for > the user to specify a list of arguments. Currently that can work by > entering a string that would be split by split-string-and-unquote. It > might be more intuitive to actually use a shell and then the user > would enter a shell command (though inserting a shell into things > might bring more complications). [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (clement.pit[at]gmail.com) 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [212.227.126.133 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.133 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 2016-11-26 19:50, Noam Postavsky wrote: > Well, CMD can also come from user input, so we would need some way for > the user to specify a list of arguments. Currently that can work by > entering a string that would be split by split-string-and-unquote. It > might be more intuitive to actually use a shell and then the user > would enter a shell command (though inserting a shell into things > might bring more complications). [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source [212.227.126.133 listed in dnsbl.sorbs.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [212.227.126.133 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (clement.pit[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eG6GnFwO0h0W6Anh1Q6ra9eU3Ip7ohud7 Content-Type: multipart/mixed; boundary="hogm6kJpnIN1eH2uKDfRGCmCj4RPEh79u"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Noam Postavsky , Eli Zaretskii Cc: 25025@debbugs.gnu.org Message-ID: <9350b93c-c584-1676-f778-3432a078049f@gmail.com> Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> In-Reply-To: --hogm6kJpnIN1eH2uKDfRGCmCj4RPEh79u Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-11-26 19:50, Noam Postavsky wrote: > Well, CMD can also come from user input, so we would need some way for > the user to specify a list of arguments. Currently that can work by > entering a string that would be split by split-string-and-unquote. It > might be more intuitive to actually use a shell and then the user > would enter a shell command (though inserting a shell into things > might bring more complications). On that topic, I feel that Emacs is missing a solid, standard thing like = python's shlex. split-string-and-unquote is entirely inadequate to split= shell commands (it's a great tool, but isn't a mistake to use it on user= -supplied command lines?): (split-string-and-unquote "python -c 'print \"a\"'") =E2=87=92 ("python" "-c" "'print" "a" "'") John's eshell has such parsing features, but I've never seen them used in= other packages; is there a good reason? Cheers, Cl=C3=A9ment. --hogm6kJpnIN1eH2uKDfRGCmCj4RPEh79u-- --eG6GnFwO0h0W6Anh1Q6ra9eU3Ip7ohud7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYOkZlAAoJEPqg+cTm90wjN6sQAJavytJ18WGXlGnLdBDzlq3e slkJMRn/ktLLyB5eav2EFFJ3+IQeSm1MXyZo0Q5//7H4bqabVNb1ztoUvplmULGT gB3JhyjwbC/wLMexlq6eLZNI2SSLjZg2tMtTCCd95DA8ZcMDxekcvxD6VeYz8Wid +bebNWo/4Smatz+Bktebwkl6A2zdx9/v2XPu0LaIYw2rl2hluZIq1FguYHpILDUN BR9v9TynGf/V4cSKfzsPqZP7DK7rx+bYRGxb/QQCa9SnCPWF5wAeITL4OQbX3XUF exAESkT9gxj7qm/HTPpkZb9V/Div+u9arwuq58RK4V8JWni7op9I2i5rIwYPUZuC a58dBAEQ1EwQ7PVKs85KKs8A6dZIKVnX771c2t53ud77BzvtXuqM2heC23WARury FrIaYg9Na8KC79jJjxKqcHHdCzPsY9NSyWzf1KCIccCUUOoH/deHgoQ5hlhVWfAR oXDYWWJjFvw/v1ATK5rkQAZkbnSLtV+BqwMrgNRnyGgr91u7IjNlQpBIpl6w0ykR YExi7HYc1EyBsioCc1baKy4BDpjcDuQMEwUvy5huh1RfPzXWQYwGGGmHUue8k7AH S8DhtwCjeGqAA92q5pjdf0U0g9xA/+j3jBUOUZ3PPIP+ZpyOEYqaPW8lqVr5O8ZG rplDvufFvXA1qL4A4rl8 =s0E7 -----END PGP SIGNATURE----- --eG6GnFwO0h0W6Anh1Q6ra9eU3Ip7ohud7-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 10:56:37 2016 Received: (at 25025) by debbugs.gnu.org; 27 Nov 2016 15:56:37 +0000 Received: from localhost ([127.0.0.1]:43728 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1oh-0001Pd-M5 for submit@debbugs.gnu.org; Sun, 27 Nov 2016 10:56:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1of-0001PO-FY for 25025@debbugs.gnu.org; Sun, 27 Nov 2016 10:56:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB1oZ-0005tK-Ks for 25025@debbugs.gnu.org; Sun, 27 Nov 2016 10:56:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB1oZ-0005tG-HE; Sun, 27 Nov 2016 10:56:27 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1467 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cB1oY-0000rE-DD; Sun, 27 Nov 2016 10:56:27 -0500 Date: Sun, 27 Nov 2016 17:56:23 +0200 Message-Id: <8337ic29y0.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sat, 26 Nov 2016 19:50:40 -0500) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Noam Postavsky > Date: Sat, 26 Nov 2016 19:50:40 -0500 > Cc: ClĂ©ment Pit--Claudel , > 25025@debbugs.gnu.org > > >> I think the whole command should be quoted with > >> combine-and-quote-strings to balance the call to > >> split-string-and-unquote. > > > > Why not remove both of those calls? Do you understand why they are > > needed in that case? > > Well, CMD can also come from user input, so we would need some way for > the user to specify a list of arguments. Currently that can work by > entering a string that would be split by split-string-and-unquote. Why does it need to be split? A shell command can (even should) be handed to the shell as a single string. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 11:05:15 2016 Received: (at 25025) by debbugs.gnu.org; 27 Nov 2016 16:05:15 +0000 Received: from localhost ([127.0.0.1]:43732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1x4-0001d2-QO for submit@debbugs.gnu.org; Sun, 27 Nov 2016 11:05:14 -0500 Received: from mail-io0-f181.google.com ([209.85.223.181]:33613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB1x3-0001cp-4D for 25025@debbugs.gnu.org; Sun, 27 Nov 2016 11:05:13 -0500 Received: by mail-io0-f181.google.com with SMTP id j65so193622086iof.0 for <25025@debbugs.gnu.org>; Sun, 27 Nov 2016 08:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+1UW51wA9MXo0vpgOXuhVz3YFBN9pCzA9aXuUh3xDBg=; b=Vlwd+54qPI5k92X66pwceig24BtHQcFcpIzwRFi2rrvSoG7HHI2CVKSvoghs6VfecN +CwZzzZ928xtE0sh5+VK5Hj+cEnOB/UxOpETQhaeBzl5hDfy2gGxWslWH5P3HGwMExwk CmBtNHjVJxHnH0vojAQUtEj+JoK06MzfUTp/46QbS4VmOc6RKTLywpRGJhZWbLGflwz6 yM3a4lcjASC3sanARVbS47fmybx9+H7CGOvCLKQeAMsHRvffzw3Ck0XExgfsyKH+cZad /uEtbHXsUAxCW5wdFPZxcVykevITBI0DhNlJsQhLTDH97QLam6iCBHY2FD4S8BGd7j0Q TvoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=+1UW51wA9MXo0vpgOXuhVz3YFBN9pCzA9aXuUh3xDBg=; b=Gf0cXRMmlxuAI8BhrhZzNbT2SBKo6kLWyW/oNdNKnQhsLAuqfO7YNDNo60RZfd7z2w K5yZl7YwgwcSNoNvmO2nxF0IPol3tvfUOIQZuPLOmQDUJUsslhQjxmaUvYpX3FOGW+QU ql7QDsKqWIB3WX/OXVAD0B745jjDQQXu9eWZfGgGqggg5gwxnuvxlVXRZx2uiDVlLo2u 7+A7jsAwKqs3CIBoDRcgPED2DCE98dnL1QcuwbSLLGuiA+9zyTox9c4V2cSvrlx0b6x8 srYjP2MnacKnt4hErCoQrH6BcA2EgUxeD0mCpFGZKq13C9acneQIJ+nyZx2EcMIfxkkB PIpw== X-Gm-Message-State: AKaTC01Wr4prUdMuKLIpnlFBBoCoq2UWjzIh1Ij7HBbIul21ZU8u+FqO70Tyq09wRJHeEQ== X-Received: by 10.107.20.82 with SMTP id 79mr14848447iou.158.1480262707551; Sun, 27 Nov 2016 08:05:07 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p20sm8727608itc.2.2016.11.27.08.05.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 27 Nov 2016 08:05:06 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> Date: Sun, 27 Nov 2016 11:06:03 -0500 In-Reply-To: <8337ic29y0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Nov 2016 17:56:23 +0200") Message-ID: <87r35wj4b8.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Sat, 26 Nov 2016 19:50:40 -0500 >> Cc: Cl=C3=A9ment Pit--Claudel ,=20 >> 25025@debbugs.gnu.org >>=20 >> >> I think the whole command should be quoted with >> >> combine-and-quote-strings to balance the call to >> >> split-string-and-unquote. >> > >> > Why not remove both of those calls? Do you understand why they are >> > needed in that case? >>=20 >> Well, CMD can also come from user input, so we would need some way for >> the user to specify a list of arguments. Currently that can work by >> entering a string that would be split by split-string-and-unquote. > > Why does it need to be split? A shell command can (even should) be > handed to the shell as a single string. Currently it's not a shell command, because a shell isn't being used. My other suggestion was to use a shell: >> It might be more intuitive to actually use a shell and then the user >> would enter a shell command (though inserting a shell into things >> might bring more complications). From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 27 11:12:58 2016 Received: (at 25025) by debbugs.gnu.org; 27 Nov 2016 16:12:58 +0000 Received: from localhost ([127.0.0.1]:43755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB24Y-0001oq-HI for submit@debbugs.gnu.org; Sun, 27 Nov 2016 11:12:58 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB24X-0001oc-79 for 25025@debbugs.gnu.org; Sun, 27 Nov 2016 11:12:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB24R-0003bq-Cm for 25025@debbugs.gnu.org; Sun, 27 Nov 2016 11:12:52 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB24N-0003bG-LQ; Sun, 27 Nov 2016 11:12:47 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1481 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1cB24M-0006lq-TT; Sun, 27 Nov 2016 11:12:47 -0500 Date: Sun, 27 Nov 2016 18:12:44 +0200 Message-Id: <83zikkzytf.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87r35wj4b8.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com > Date: Sun, 27 Nov 2016 11:06:03 -0500 > > > Why does it need to be split? A shell command can (even should) be > > handed to the shell as a single string. > > Currently it's not a shell command, because a shell isn't being used. > My other suggestion was to use a shell: > > >> It might be more intuitive to actually use a shell and then the user > >> would enter a shell command (though inserting a shell into things > >> might bring more complications). If it doesn't use a shell, then it has no business quoting commands or their parts using shell-related APIs. So yes, I think using a shell would be TRT here. Can someone please work on a patch in that direction? This problem exists for a long time, so I hope we could solve it soon. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 03:33:34 2016 Received: (at submit) by debbugs.gnu.org; 28 Nov 2016 08:33:34 +0000 Received: from localhost ([127.0.0.1]:44156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBHNW-0000A7-4E for submit@debbugs.gnu.org; Mon, 28 Nov 2016 03:33:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBHNU-00009q-1G for submit@debbugs.gnu.org; Mon, 28 Nov 2016 03:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBHNN-0002Ks-Tc for submit@debbugs.gnu.org; Mon, 28 Nov 2016 03:33:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBHNN-0002Ko-QH for submit@debbugs.gnu.org; Mon, 28 Nov 2016 03:33:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cBHNM-0002MG-Fa for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2016 03:33:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cBHNJ-0002K4-DI for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2016 03:33:24 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:54086) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cBHNJ-0002JU-3t for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2016 03:33:21 -0500 Received: from [192.168.178.35] ([77.3.37.191]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.183]) with ESMTPSA (Nemesis) id 0MUEtu-1cJQJ20Zr0-00R4iB for ; Mon, 28 Nov 2016 09:33:18 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: bug-gnu-emacs@gnu.org References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> Date: Mon, 28 Nov 2016 09:42:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <83zikkzytf.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CTBORHes9NNy3TsQq3TyZ1DxWhnd/5mmnmNvrQZU1buYLf8RLpS vVPwZ+3b+LP6wfOTZ9YNkRlbxsX1ZUnKpDx7FXZDTMAmyaLDa5cA5FpstePnlDq1Q4rKwIl tGN3ZXPSdVx37BxZ3ViQ66gks4c1WVPI5K+L5kBQMHQbBgW8KsCGOunFvGVfckFvYTKIin6 ojXvgE2A1/gHvIbqsjtlQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:bKu0jNstjSw=:ywsxz1qyulhqGD007dL5X0 n04hLoScQAzEd8BxT2nXvppGQq2JACI3RECfERIQCdUpqg8wKlv2ZSTdJuyqGx9E3m9eTqWlE DZ+1Z5BQAqERT0S3QRvk/b3a9NiAQyU4Vt1qDAoQ8lgG4olFKrzeiAVcnAjtko0MokfFDD28v sA3M1bYUx2GF53CfhWHui5So4dm8qpZWfHKaoYuZgzH8IHqzge59a+MRObr/4hYuxfXnJWp8d 16WV8h1YWq5xqWIrInsmJm4q6B4ciUf9e5sDm4QwzzcLAYS+p1SIQG3XfYT8fQv9ABKy+zBWm VxPXSaPWQPEmU+tiagJqT8MxanUK/yNr/PyV75ApjzTykEoTiUCNJW0mk5oeCNcV4FmV247dj XOJPY+wPdBL5Lr9BaKwKJG6FLcQYIB3c/wKh36G3RCImdflldh/6hB1WsZBP5WfKhDqtrDHhg xYv44rTGk4MKXMeAFg/qDMbCGojrVnr0wBl4g0g6fKwlvMhGpcFs6TgKp2mjsxpuJ0kGsfNLO RgDNrK2Pdo00CDQI0Lt39r155x0WA886PJpnJw8BtSCHMd+oarHgwBz7REfLvAhCuhf+Yr6Cd mLasIGm9y8B54E+sOIPPYLYY5rciKGi8l+GaQdZ/b7rBOjQBgvIwVsmlR4bUloTJImfM+Ljb1 uHvsX4Vq1J6q5FLYiTxug+zoDoFqZmsCgep+EiDrYZJgXGuwLSVPbsjkgxE74b3XDEKZ/9pWu mZRwWo/D0SDyrncT X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 27.11.2016 17:12, Eli Zaretskii wrote: >> From: npostavs@users.sourceforge.net >> Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com >> Date: Sun, 27 Nov 2016 11:06:03 -0500 >> >>> Why does it need to be split? A shell command can (even should) be >>> handed to the shell as a single string. >> Currently it's not a shell command, because a shell isn't being used. >> My other suggestion was to use a shell: >> >>>> It might be more intuitive to actually use a shell and then the user >>>> would enter a shell command (though inserting a shell into things >>>> might bring more complications). > If it doesn't use a shell, then it has no business quoting commands or > their parts using shell-related APIs. > > So yes, I think using a shell would be TRT here. Can someone please > work on a patch in that direction? This problem exists for a long > time, so I hope we could solve it soon. > > > Executing Python code via a shell might produce subtle bugs. See https://bugs.launchpad.net/python-mode/+bug/550661 Following the OP's suggestion seems reasonable. Just drop it at place and see if something gets broken - wouldn't expect it. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 09:15:04 2016 Received: (at 25025) by debbugs.gnu.org; 28 Nov 2016 14:15:05 +0000 Received: from localhost ([127.0.0.1]:44305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBMi0-0001gt-MI for submit@debbugs.gnu.org; Mon, 28 Nov 2016 09:15:04 -0500 Received: from mail-qk0-f177.google.com ([209.85.220.177]:34394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBMhy-0001g6-Nl for 25025@debbugs.gnu.org; Mon, 28 Nov 2016 09:15:03 -0500 Received: by mail-qk0-f177.google.com with SMTP id q130so140583445qke.1 for <25025@debbugs.gnu.org>; Mon, 28 Nov 2016 06:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oqwkvhUwhDzTAOYXjgBiMyImIhBPUNKjmHVq6Fwiwak=; b=0ym2F26ZWwlEMtUM4vABwWtsRgpi/9XbR+6Y+Hjzjx58KBznev8Cb6Y5REaTyoGpyv iqYB+PxC6zvClW9XBFeLOnFhe5cNGB8l0BVG2LUJkUmzwfH2cyIF4O3JVmYvyGzzWSaj 78zpiGR/iUBzqSF0HHmrAqQ68FiD3qFaXA3On34uD1OTblNZA1KLAAuaMAfox38bx9MA XdahLxOZYZBPaxPBXWorjGzKR1Q+r0PIYlK7UVAZ5t3dx1pljJsjtjeWu9XdTqzSXyqv TKW4ELVCcEQDBZsOFwWYaRU95PRXUAAAeFHRo2c4OAGTqKnIaqDPuEiMYrxPElcQf+FE yvfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=oqwkvhUwhDzTAOYXjgBiMyImIhBPUNKjmHVq6Fwiwak=; b=XxQ4gETq+IAoy7HXpXLhQWjrEPgCSCX1cNR3zXlE5MsohpgyNDcb3JmnYXcx8h3vgC kci0QCQeaMQa9yk28zXyg/qPxfW/l5HH6DhwlGvske8tTZKbNGpn1d6v2booemWRQBdm nAvbptrMAx1zga83Qjipr+lldc9jYtjqQnipbr/sMWyQz+j1U8UyNuhkfIwEemaT+/p6 HKSNAEXny95Lrqc6fEHI7q41xhb6vDQcEcSFNJ1TVEJK4EAI5JHbpRH3QRiTSeiamve0 KmZj4JaCxpb1qSapg8QirLFl3gKSN+vOJbkBDCloXwYZBdKVlfNeszNoMCvGknDtKBO+ HNXA== X-Gm-Message-State: AKaTC03FnNLdAb6L2ZC44h4kfhQskx3r5jU8GypPtvkyechML6eTKjIg894KE2i2/SRTSw== X-Received: by 10.55.207.134 with SMTP id v6mr20888952qkl.105.1480342497022; Mon, 28 Nov 2016 06:14:57 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 124sm28486684qki.14.2016.11.28.06.14.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Nov 2016 06:14:56 -0800 (PST) From: npostavs@users.sourceforge.net To: Andreas =?utf-8?Q?R=C3=B6hler?= Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> Date: Mon, 28 Nov 2016 09:15:52 -0500 In-Reply-To: <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> ("Andreas \=\?utf-8\?Q\?R\=C3\=B6hler\=22's\?\= message of "Mon, 28 Nov 2016 09:42:16 +0100") Message-ID: <87bmwzitbb.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Andreas R=C3=B6hler writes: > > Executing Python code via a shell might produce subtle bugs. See > https://bugs.launchpad.net/python-mode/+bug/550661 We're talking about executing the python executable via a shell, not python code via a "python shell", which is something different. > > Following the OP's suggestion seems reasonable. Just drop it at place > and see if something gets broken - wouldn't expect it. See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25025#8 for why it would break. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 11:35:06 2016 Received: (at 25025) by debbugs.gnu.org; 28 Nov 2016 16:35:06 +0000 Received: from localhost ([127.0.0.1]:45129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBOtW-0005FI-Ch for submit@debbugs.gnu.org; Mon, 28 Nov 2016 11:35:06 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:55228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBOtU-0005Ee-Py for 25025@debbugs.gnu.org; Mon, 28 Nov 2016 11:35:05 -0500 Received: from [192.168.178.35] ([77.3.37.191]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.183]) with ESMTPSA (Nemesis) id 0MUTsx-1cKzg71DXv-00RLnC; Mon, 28 Nov 2016 17:34:44 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: npostavs@users.sourceforge.net References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> <87bmwzitbb.fsf@users.sourceforge.net> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: Date: Mon, 28 Nov 2016 17:43:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <87bmwzitbb.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:8PtNx/yPK1O6UyiUo2FhFWzmv4XUBuPXY4tJsI243JgQ5sxnHNq qd7aSqeJEQpolNCginPfM5TzaDpjUdaU7uC+jBNHdYpbJfEvixMlnWbF6hPtUD55Z/7iyDo g7ZqBQyUbtaHkDHZvTs7W/+kCm/YP3Kf1y95hBEBySju+stlHS3GtzQ2d/XkZd1fA3bZcOn n1rAXSv5JCTqNxTCgQPmA== X-UI-Out-Filterresults: notjunk:1;V01:K0:uP08gzUDQFo=:ei7sUPDy7CHpO38vhjE93+ Rq5jSszVpeedZrJjYDxx4VZ0ha7IVtPmryPbxisQeZaB7XIqpgOb2y9ZI7NStNOxmMto0Rnvn 9hRnil1OdprQwmD/Ws04tNZ+7Ga2nzJo4ukHQzOzi6WjR8STilUQZ2cy1tsqkUlyN9+qS3K5m tm6B8Gt6ZxXzArDxCOI/2GFpFj/W2wMH8w+tHDdhnnl4KLGObYdIc7SAoDYihPQqlUSjpU5oH j5ABzfVt/bLIF3UMhT5eHbP8oLy0imbIAllEvF4yayVe1q+emTqRmTBzMtYedYRi1GZGVE/bL nMGd1b+gaG4kXrah7X7ywyw/3nveir8Fd5YCjdYoJOOwuMWuzWqiZ9q8FNpBKrdiiqrPvphiL hg65Y3qujjOQz0MH+Q/Ic5qL+XKFt3q0xEn6sbrwa1Hh/xQSbonZ2Ai4KIaSgPuEw8z+p1hFk WpnUsfGnJXA9um/i1RsJz4j4uMHXnjFxaGim3LL8Ydvtnt5QVWYTDfR3iM7AUWcbXjjJ9cGYO YHIbLZQEQQJCcTbVPc2MigHe1534Zwd1gzYXErpQFIS+Z92iqc7VNv+Q26ajxaEhxpTDhjhMB F6FRQUbo7wfEvObTWj60WyscE9NDrrDt8LSKxda0wMFoYnaXJRhC7ZT/fVhhzFoPnBO21EtNK GIHBdM744+QBcyLkMR4S92zYLC/J0P4nTDmMBGkI7QD1QtPl+YeWuit8UQHg1H1IvcUYr1tV4 ZAe7HFozz9lw5T6J X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 28.11.2016 15:15, npostavs@users.sourceforge.net wrote: > Andreas Röhler writes: >> Executing Python code via a shell might produce subtle bugs. See >> https://bugs.launchpad.net/python-mode/+bug/550661 > We're talking about executing the python executable via a shell, not > python code via a "python shell", which is something different. Seeing the example was not clear, sorry. Just tried to you give a piece of code which would fail doing shell-commend-on-region. Try print(u'\xA9') with python2. With python3 it works here. AFAIU the current python.el doesn't pipe to Python-code to exec through a shell - for related reasons. > >> Following the OP's suggestion seems reasonable. Just drop it at place >> and see if something gets broken - wouldn't expect it. > See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25025#8 for why it > would break. Only see a question there, not a statement. BTW have no system of the OP's kind, can't check that. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 19:35:26 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 00:35:26 +0000 Received: from localhost ([127.0.0.1]:46644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBsrt-0006R3-VI for submit@debbugs.gnu.org; Tue, 29 Nov 2016 19:35:26 -0500 Received: from mail-io0-f169.google.com ([209.85.223.169]:35862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBsrs-0006Qq-Nw for 25025@debbugs.gnu.org; Tue, 29 Nov 2016 19:35:25 -0500 Received: by mail-io0-f169.google.com with SMTP id m5so183952170ioe.3 for <25025@debbugs.gnu.org>; Tue, 29 Nov 2016 16:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=H5dq2efqH86Fk36OcFtK1v6WoqZm12i0Vg9ce7qvay0=; b=AEw+hhulus2ux4fhkdSOE33I5RHsRZr9qpoRoCygGOpFmm39xwDDUuQ5nDnd4Ai9si WbekbcAWACHjnWW+5gEHV3N6H38d7Wwc68ZLQKOMVk17MZiDpaUxIKyg8SyMa/0DgFdH 237t4aOK2f+WZTUZ6Wh6qDIlDgMkcpvKhcWoqU10XwrcqXJgap+lWmpXW2Xe3im24ogW SxTML2rhBtcltcd20rPUHTRhBSieP6DAojw2hMhil8oK0LmzQ/HBtWyypYCmPk69clO2 6KtVTqzvSclTz+Hnxxfnq6iehRAFna0+ucjVMQtaNY7DqydmCPFILKVpLhXA1WYUbugP aUxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=H5dq2efqH86Fk36OcFtK1v6WoqZm12i0Vg9ce7qvay0=; b=R2XkwMpZ12veigKqtfCzW5eOb5yy0Qpk4wrWQfMaMaBBGqxAFJ6TSRazLErcuIJpmv 8d9zCKYyv4LY7dFPh28ffjMjneIvkI++vXr983R8ZPAGKcao6WFqpt2vw3JDAcjwD9xT OtShGhGQ5iF/W5HIqH/S6rqni9cN5cI7aCQUoyrKDKk47GxBiL19APgUHoQAudLlSoxM rm7mu608PBQLd1vqOWy+h+BSMatzJyv6V45UGUiIPHZ7+0NDbd2zfm0kuPpYAnFNXr1D u2IT6LnO/RPcK84dgO/r165gI3J0xdSPyZ7Ff3H8bs71HA3MBaqmINznplbIwmlTt8eY QWhA== X-Gm-Message-State: AKaTC03SPKbhXWnlIUCc0I8TQSB3eEUVM27evo5KcFnNjbWETwSV96qA/DyXCyeRf+ILqQ== X-Received: by 10.36.107.151 with SMTP id v145mr26383758itc.17.1480466118836; Tue, 29 Nov 2016 16:35:18 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id v75sm1755020ita.12.2016.11.29.16.35.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Nov 2016 16:35:18 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> Date: Tue, 29 Nov 2016 19:36:15 -0500 In-Reply-To: <83zikkzytf.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 27 Nov 2016 18:12:44 +0200") Message-ID: <8737i9iz28.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: npostavs@users.sourceforge.net >> Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com >> Date: Sun, 27 Nov 2016 11:06:03 -0500 >> >> > Why does it need to be split? A shell command can (even should) be >> > handed to the shell as a single string. >> >> Currently it's not a shell command, because a shell isn't being used. >> My other suggestion was to use a shell: >> >> >> It might be more intuitive to actually use a shell and then the user >> >> would enter a shell command (though inserting a shell into things >> >> might bring more complications). > > If it doesn't use a shell, then it has no business quoting commands or > their parts using shell-related APIs. > > So yes, I think using a shell would be TRT here. Can someone please > work on a patch in that direction? This problem exists for a long > time, so I hope we could solve it soon. Hmm, the difficulty in using a shell is that the current code wants to parse the command into interpreter and arguments in order to match against `python-shell-completion-native-disabled-interpreters'. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 19:38:34 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 00:38:34 +0000 Received: from localhost ([127.0.0.1]:46648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBsuw-0006VM-D6 for submit@debbugs.gnu.org; Tue, 29 Nov 2016 19:38:34 -0500 Received: from mail-io0-f180.google.com ([209.85.223.180]:33973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBsuu-0006V9-PE for 25025@debbugs.gnu.org; Tue, 29 Nov 2016 19:38:33 -0500 Received: by mail-io0-f180.google.com with SMTP id c21so303728185ioj.1 for <25025@debbugs.gnu.org>; Tue, 29 Nov 2016 16:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=qbQ6Q3K8mfSdTPmzcJr0B3aODmSJLcwxyN17O0+8Wj8=; b=CWzRRBLbdgN/rryXWjCDLEXOAvxutoIkbZaRjJkoql1C92VY6ezHkgiKsiFHuNq9ni IsO1KTbjc0/KqrGkiluOn1anmK1bA7AfF9vtT8poSneIt3esSNNwu8O3tUOXFcDOQqRC wHID9kvSZ2/caZCop6zd82/b3dulq53+yAdaSFtoBgQygUOjR3xO+HMc/FjZNz+0kXWx R2i9GOqYCtrbFpMv0K2BQhIMI71ErzWRy6ZSLy70uX+W/c9IJhyyZi3r6iqi57nCmDlo U3Qsy11M2s+GdXZQzB45q90LaCIBgB12ovLDhG66SYJc1LhKAG2rd6DO6/WU3vgBOCJv cElA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=qbQ6Q3K8mfSdTPmzcJr0B3aODmSJLcwxyN17O0+8Wj8=; b=L4Ha/RBmm9JmHyGrroGOmqaLQQtArr4YsmKPI5jfZ5wYGUbSwMnI7Zr9XInjqPES3v THLG6O4QBasEG+L7sx4IO1UX8yZcGvX1NPS5L+iIaBypDBH/G/0ZTH5SqqMwV9pHsEtA kPZbbTXeyVOuCJfI/2kQu3PLez+4JD/X8l2nojwlgywXBFIbQjFFKaowZ48RJ0z2ElFe AWFHJlJPnfx3YXt1wbZsMBz1EJXoXDN3y0g3vQnpV1MpVynfNFq4rB7DXBXjl57ntnN6 97pcXPIjkXMZSSn+5OO4P9NArWwtCKlEiOcCpaCRviRF1mA1alZ++QGZdntcH1ACFwlq 8K2g== X-Gm-Message-State: AKaTC007fy5FRAyoqb9z+vIArJlIlldYrS/nbOXl0/vJt3dhv6pa9aF0Hp/jfgypcSbQ7Q== X-Received: by 10.36.93.210 with SMTP id w201mr26036466ita.26.1480466307170; Tue, 29 Nov 2016 16:38:27 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p140sm463446itc.22.2016.11.29.16.38.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Nov 2016 16:38:26 -0800 (PST) From: npostavs@users.sourceforge.net To: Andreas =?utf-8?Q?R=C3=B6hler?= Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> <87bmwzitbb.fsf@users.sourceforge.net> Date: Tue, 29 Nov 2016 19:39:24 -0500 In-Reply-To: ("Andreas \=\?utf-8\?Q\?R\=C3\=B6hler\=22's\?\= message of "Mon, 28 Nov 2016 17:43:43 +0100") Message-ID: <87zikhhkcj.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Andreas R=C3=B6hler writes: >>> Following the OP's suggestion seems reasonable. Just drop it at place >>> and see if something gets broken - wouldn't expect it. >> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25025#8 for why it >> would break. > > Only see a question there, not a statement. BTW have no system of the > OP's kind, can't check that. You don't need a Windows system, just imagine what would happen if `python-shell-interpreter' had a space in it, and it wasn't quoted as suggested in OP. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 20:36:14 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 01:36:14 +0000 Received: from localhost ([127.0.0.1]:46691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBtok-0007u4-Gj for submit@debbugs.gnu.org; Tue, 29 Nov 2016 20:36:14 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:52522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBtoi-0007to-Pc for 25025@debbugs.gnu.org; Tue, 29 Nov 2016 20:36:13 -0500 Received: from [18.189.106.208] ([18.189.106.208]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.184]) with ESMTPSA (Nemesis) id 0M09nw-1czaYI21K0-00uKEY; Wed, 30 Nov 2016 02:35:54 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: npostavs@users.sourceforge.net, Eli Zaretskii References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> Date: Tue, 29 Nov 2016 20:35:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <8737i9iz28.fsf@users.sourceforge.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nN0wNDNeHuIOp6hKSmaavGHKX4MHi0UlP" X-Provags-ID: V03:K0:/KzlNr59yDzxOoSQJ6A81L0UBjVTsmYKDLAZJkAQdsMl7O+oA6N 2ch0beOZ9IMV5mfj7fHe0K0bI7LPcQP0BJy6Hr6eVtXcji2BtRdbks7LHMeJF0iuhHijCLw i0kJ4ZTNsoZA/IM1T2WfHhD/D2TwNcDzzrWNfG5OF3hSxSc+rYY3W30CITGTRp0uYFUiZdj rb32ZKlCaY3OmR8O0U5JQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:1SrZl51Dpmk=:Fg3QGa6KS4O0mPawM1SiMh tmQdgsq6Yt3M9S1LzU5ojYjNOhqrnH/3y7kJzry6iOiMD4FUnOUuEAs95p9uDNC4DuyEJFRA6 toCahST4XHErzRCFMRs3DfbR8sbNo4vhK+eVSsoGEbWdZ+7dioFWZLW4VnMG3Y5gwg30CBjEa 74KQ4l2cheSeFg8uVkcBkth+ChbEgjhgCbHPKn1VYcnXwUcA7lzaEoHy8bbwgsoq5lbWe97OO oQsRWJoFF2bjs3qrA+C50EmCC4InhObe0aL4IjcDdmKE8/ahnkOQYwqUFDAotIs9UaRI2wdnA VKyS/AnKAKCt/wtRgF8Q4t6c15UhUpeKCwLxmr9DWIj+W+t6v5StWF/mhtWF987onscD5qiU+ E5IEx8cLKtcUR3sDBSPCypZvKu3R7zDsKaE06tB35qCeMamw5RuWJpvbjs3dGB69ZZRdvfztE hUIIcQAcNOw5CBhHlaVZTHw1fnsnUAO4AslkJQ7J0FyJwqu+NczgZZwaFGXMDRPZObqeyAtl0 gADOgSiW+hczUxWwJD5F8iigNrRCFBLiDmHDJeydranCKtkvb9sksgmOndEy0ZcSCGtW9QfYN 4KTwStlr4wxYbqVigbQuRykIKTe4R/uxcuSW8e1e70yi2dyy4cBoENio/KVaYiPqjV6ByebGp fJghVS6IvzEih99zVBg7FJIAq48aVJhHQy0D1RMP9woRtqve0rz0hJeq4BcXE+8Anowg= X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nN0wNDNeHuIOp6hKSmaavGHKX4MHi0UlP Content-Type: multipart/mixed; boundary="vNSFdnr2Nd1TE2w82h54ikMEIx8Ohw7JR"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: npostavs@users.sourceforge.net, Eli Zaretskii Cc: 25025@debbugs.gnu.org Message-ID: <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> In-Reply-To: <8737i9iz28.fsf@users.sourceforge.net> --vNSFdnr2Nd1TE2w82h54ikMEIx8Ohw7JR Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2016-11-29 19:36, npostavs@users.sourceforge.net wrote: > Eli Zaretskii writes: >=20 >>> From: npostavs@users.sourceforge.net >>> Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com >>> Date: Sun, 27 Nov 2016 11:06:03 -0500 >>> >>>> Why does it need to be split? A shell command can (even should) be >>>> handed to the shell as a single string. >>> >>> Currently it's not a shell command, because a shell isn't being used.= >>> My other suggestion was to use a shell: >>> >>>>> It might be more intuitive to actually use a shell and then the use= r >>>>> would enter a shell command (though inserting a shell into things >>>>> might bring more complications). >> >> If it doesn't use a shell, then it has no business quoting commands or= >> their parts using shell-related APIs. >> >> So yes, I think using a shell would be TRT here. Can someone please >> work on a patch in that direction? This problem exists for a long >> time, so I hope we could solve it soon. >=20 > Hmm, the difficulty in using a shell is that the current code wants to > parse the command into interpreter and arguments in order to match > against `python-shell-completion-native-disabled-interpreters'. That doesn't prevent us from using a shell. We run the command unmodifie= d through a shell, and we split it and analyze it separately to decide wh= ether to enable completion. But we don't split and reassemble it before = running it. Cl=E9ment. --vNSFdnr2Nd1TE2w82h54ikMEIx8Ohw7JR-- --nN0wNDNeHuIOp6hKSmaavGHKX4MHi0UlP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYPiz3AAoJEPqg+cTm90wjSaYP/ihGVozLiIXst+IYXefwYmSM tuHarYz7N52gYBp8fkktwJynMgw6eXVnZYEtKB3mM8E4pk72QeaQj7S+mcvafrmO cADIuJrSIaH6y10M7ANDC3mtE19H+HiZTiRXkJjo5sgNBd1yHvHgAbGLt4HloRFm ootk36kiHXgSek/bY3M6upyCpc/K1DycUuUGA4GLYxklmHCzrD9SC+gain0kr1A3 ucZnbVPNXupEZ2yiSv6SMUVEqaVqrre5Yld4LoAzC3xi4/x1JKtNdbuGt8RA59DA XeIgiZKwFcoZHmjtQQV2nk13BsCFnfLnEyG997PB5a8XlH3n7iNlmLe++sJmvZSE FyI9h3cBdDXA5Q058pLtpSoZNn3+EqYyEbG4LwGGkALSHoSMU8rkyvhYj//8XXno AkdlMQJLoErON+RTGu5ISL5bxt6qrInE4O4fJDclg2wLN7UwO/sr/dbnDLl0gJVy iJNkczqgF/DDKnnSkHnlUxTuG1Peo3nhqeOrLY2mpJn2DWtlLupDRcjBdzpzX+wU KZSgpeawSEl6foxpu2P/WI5sFMFWCGucrOEriMsG01JCK92k/c1xzuNVI8MEjnkn FKxJk7OJGGWAHDuQwcxjjSiLZ+Io9h9XhR7J3ZAsCvh3ThmMy37JHFx2ywDpuJ1c nsRVhPQhtxXnFjKTa+gr =Jzkt -----END PGP SIGNATURE----- --nN0wNDNeHuIOp6hKSmaavGHKX4MHi0UlP-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 20:55:28 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 01:55:28 +0000 Received: from localhost ([127.0.0.1]:46700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBu7M-0008Ni-5X for submit@debbugs.gnu.org; Tue, 29 Nov 2016 20:55:28 -0500 Received: from mail-io0-f182.google.com ([209.85.223.182]:33816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBu7J-0008NU-Uc for 25025@debbugs.gnu.org; Tue, 29 Nov 2016 20:55:26 -0500 Received: by mail-io0-f182.google.com with SMTP id c21so306289631ioj.1 for <25025@debbugs.gnu.org>; Tue, 29 Nov 2016 17:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=dNknytu0VvJ/vb7m1RwEHvFK9l6gsIS96KkjZTmgxPc=; b=lp3Mj/Bw7BE115Tk4IZbZhx5OrGN+bc7BU0VF+9XhxvoGMaAgpNjz4S/7TyN6lWzU9 NfS8Y4nt9OUzfI2QfDAjsCsYmPvrrv02TuG6PAvbEu3hlUczpLAg7Moz0BBtxMHKktD7 H2GwrfuDjIlmUbmSnMtrggux3lDdpZoxX8rekAF8hI3RWz9XdX+06iQyroQ1roLGDCcL BRztfMd5fb+eqn58MvoG7DwWMATAt/1C1p62HWwfnJN1VbE49lJBIDfymh12VRIKoqqT 3lthCK0LZJ51AvBhY1PKfzct5Ebj7+fsaY1oHPq4AhP7e77/NYn+FnxqDjqyQpBjogHa YcVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=dNknytu0VvJ/vb7m1RwEHvFK9l6gsIS96KkjZTmgxPc=; b=bDWGzN16dVK1dXn9+smeuxU1xD8zOV8VhTbYehoORuqIUyKFMvJ25dbwiUX9nova9Y doGFjsNc75M9Hn0QCw3OnLenQ5s4pC35ygquymt9bRDzjCGXlz477LQMU6Vv9Jy35JSe WI6KjTFmdW1rdoENhn8mnIF8BKiZZE1NW5ISUz168Pb9qvyTpcXmZ4k5Mb7NFuasjlzV D0GvhdzXpR6+A7jqsywcngT+7e/T2zLwTLggzu7Nnl/VPbPk1ZcvuxXCjT1jX9WPW1Oj cGbuqXX9XkIH9ucpkenaVDEFJc68o4oKaXtD56Vo/r0a3nqoRLCMeMK2mCVByy0qJbnU +T2Q== X-Gm-Message-State: AKaTC02FssMQaWlFvWat/2rFYMtjdlCYvhZvPlAHcGI3oFI2c5gUPXOG0lq+PhaQVsoefQ== X-Received: by 10.36.184.194 with SMTP id m185mr26274754ite.3.1480470919173; Tue, 29 Nov 2016 17:55:19 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l203sm1877256ita.6.2016.11.29.17.55.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Nov 2016 17:55:18 -0800 (PST) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> Date: Tue, 29 Nov 2016 20:56:16 -0500 In-Reply-To: <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> (=?utf-8?Q?=22Cl=C3=A9ment?= Pit--Claudel"'s message of "Tue, 29 Nov 2016 20:35:46 -0500") Message-ID: <87wpflhgsf.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Cl=C3=A9ment Pit--Claudel writes: > On 2016-11-29 19:36, npostavs@users.sourceforge.net wrote: >> Eli Zaretskii writes: >>=20 >>>> From: npostavs@users.sourceforge.net >>>> Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com >>>> Date: Sun, 27 Nov 2016 11:06:03 -0500 >>>> >>>>> Why does it need to be split? A shell command can (even should) be >>>>> handed to the shell as a single string. >>>> >>>> Currently it's not a shell command, because a shell isn't being used. >>>> My other suggestion was to use a shell: >>>> >>>>>> It might be more intuitive to actually use a shell and then the user >>>>>> would enter a shell command (though inserting a shell into things >>>>>> might bring more complications). >>> >>> If it doesn't use a shell, then it has no business quoting commands or >>> their parts using shell-related APIs. >>> >>> So yes, I think using a shell would be TRT here. Can someone please >>> work on a patch in that direction? This problem exists for a long >>> time, so I hope we could solve it soon. >>=20 >> Hmm, the difficulty in using a shell is that the current code wants to >> parse the command into interpreter and arguments in order to match >> against `python-shell-completion-native-disabled-interpreters'. > > That doesn't prevent us from using a shell. We run the command > unmodified through a shell, and we split it and analyze it separately > to decide whether to enable completion. But we don't split and > reassemble it before running it. Yes, but then we need to parse a shell quoted command, which is quite a bit more difficult. That gets back to your suggestion about getting an elisp equivalent to shlex I suppose. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25025#28 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 01:30:38 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 06:30:38 +0000 Received: from localhost ([127.0.0.1]:46792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cByPd-00086K-OX for submit@debbugs.gnu.org; Wed, 30 Nov 2016 01:30:37 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:64918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cByPb-000865-3D for 25025@debbugs.gnu.org; Wed, 30 Nov 2016 01:30:35 -0500 Received: from [192.168.178.35] ([77.12.119.56]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.183]) with ESMTPSA (Nemesis) id 0LkhLo-1ckDEA1yuC-00aS5Y; Wed, 30 Nov 2016 07:30:14 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: npostavs@users.sourceforge.net References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> <87bmwzitbb.fsf@users.sourceforge.net> <87zikhhkcj.fsf@users.sourceforge.net> From: =?UTF-8?Q?Andreas_R=c3=b6hler?= Message-ID: <5e22b5f1-787b-7847-0aa7-d3dc90ac356e@easy-emacs.de> Date: Wed, 30 Nov 2016 07:39:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <87zikhhkcj.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:xf9yswAN89E1zp72PYRpoAzXyeprTWRP3GqCxS4i0uC7epKQCgU xi6q8viw6H0nZLA557RKrcgapULsTrEu21dEPCz53Q2LwALdw3EC7K+ancg4GiJnUUlY/B9 sotOxrJ0dP2Dg59+lQb/uBt3v8u/TcpvViwqwEIu/bZa6Du4Kam/mr8pXd0cuKXSRZ22zYW AMywKCvc8ZllKDWdMIfCg== X-UI-Out-Filterresults: notjunk:1;V01:K0:KE/rr7vxsyw=:xG7QpitEZCMdIwxT7Gsf4V brpvnV7yLZyeqQheQVwBd1+iJMvsUQsQt57JPr94bODs5bjSXVCUdsFnrptXNboY4QOzzue0X QaFMMRvo7OdA+qLu8B5nCn4QufiroOJz6M/ymgBHoQ4Mdou1K7zsRuw2SI/0D/oZ6rcFmi7IC R9R/+jkTftLsXkWOivpm6UTgGMvVcgS6lMEslmEPvPuW/ogA9ys766s8a/iYOJWqmmvsuvQok OofnRAWv7t0m87s5LDoJf9EexTBzMN9LAPJswYl/TO6xwkVhN1Bk7IGI1JsY0wdQt9GgES82k glC5r16pvwxncea/e50TzZOfZITxu6SCsIENImc/YgrQGaYU9lHytV5xTcxFzOTN4T2xkf5d6 Gv/2BFE/bKMzJObthi4YDOzNNcUUqdmTV4M6hTJvMt3+GBBy/nA8fQ0C3Uub/QtwuD2qx/fZ8 lJ99tSv/p6UqCseqVo8tBiX0uoaREb/WihmPwrfmhorJesAILaIAUPowp1ztmQReEXqW60LA7 D7zNeZzgKIXNf3FcdRYC5AVL0OXXvULKPlLUceH5cFnIeEnAOHuOB5IQvMqS/PpitXtqWGMU/ I7L5mb0vtenPzvTdQh2pIMCMYAcS27oT4litqKnaP+cVmXCx+kUWYjHINfYwNP1fd2jeP9z/k HsnvxVTPNZn1kQhABvuWAbZ00tVggHGIMfFUaZd5tpmvojxDyXxmGjToeN3wi0pwcTvo40kSD JyEsErcSDB4WWgkG X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 30.11.2016 01:39, npostavs@users.sourceforge.net wrote: > Andreas Röhler writes: > >>>> Following the OP's suggestion seems reasonable. Just drop it at place >>>> and see if something gets broken - wouldn't expect it. >>> See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25025#8 for why it >>> would break. >> Only see a question there, not a statement. BTW have no system of the >> OP's kind, can't check that. > You don't need a Windows system, just imagine what would happen if > `python-shell-interpreter' had a space in it, and it wasn't quoted as > suggested in OP. An executable with a space in its name? Hmm, didn't notice such thing. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 10:55:27 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 15:55:27 +0000 Received: from localhost ([127.0.0.1]:47664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC7EF-0001Wk-4H for submit@debbugs.gnu.org; Wed, 30 Nov 2016 10:55:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC7ED-0001WW-NN for 25025@debbugs.gnu.org; Wed, 30 Nov 2016 10:55:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC7E3-0003Yy-OX for 25025@debbugs.gnu.org; Wed, 30 Nov 2016 10:55:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC7E3-0003Yr-LW; Wed, 30 Nov 2016 10:55:15 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2162 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cC7E1-0000u3-3N; Wed, 30 Nov 2016 10:55:15 -0500 Date: Wed, 30 Nov 2016 17:55:17 +0200 Message-Id: <83a8chq7x6.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87wpflhgsf.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Cc: Eli Zaretskii , 25025@debbugs.gnu.org > Date: Tue, 29 Nov 2016 20:56:16 -0500 > > ClĂ©ment Pit--Claudel writes: > > > On 2016-11-29 19:36, npostavs@users.sourceforge.net wrote: > >> Eli Zaretskii writes: > >> > >>>> From: npostavs@users.sourceforge.net > >>>> Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com > >>>> Date: Sun, 27 Nov 2016 11:06:03 -0500 > >>>> > >>>>> Why does it need to be split? A shell command can (even should) be > >>>>> handed to the shell as a single string. > >>>> > >>>> Currently it's not a shell command, because a shell isn't being used. > >>>> My other suggestion was to use a shell: > >>>> > >>>>>> It might be more intuitive to actually use a shell and then the user > >>>>>> would enter a shell command (though inserting a shell into things > >>>>>> might bring more complications). > >>> > >>> If it doesn't use a shell, then it has no business quoting commands or > >>> their parts using shell-related APIs. > >>> > >>> So yes, I think using a shell would be TRT here. Can someone please > >>> work on a patch in that direction? This problem exists for a long > >>> time, so I hope we could solve it soon. > >> > >> Hmm, the difficulty in using a shell is that the current code wants to > >> parse the command into interpreter and arguments in order to match > >> against `python-shell-completion-native-disabled-interpreters'. > > > > That doesn't prevent us from using a shell. We run the command > > unmodified through a shell, and we split it and analyze it separately > > to decide whether to enable completion. But we don't split and > > reassemble it before running it. > > Yes, but then we need to parse a shell quoted command, which is quite a > bit more difficult. That gets back to your suggestion about getting an > elisp equivalent to shlex I suppose. > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25025#28 Confused: how does python-shell-completion-native-disabled-interpreters get into this picture? The function which uses it, python-shell-completion-native-interpreter-disabled-p, looks at python-shell-interpreter, which isn't affected by quoting or by how the command is treated. What am I missing? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 12:12:23 2016 Received: (at submit) by debbugs.gnu.org; 30 Nov 2016 17:12:23 +0000 Received: from localhost ([127.0.0.1]:47721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC8Qg-0003P1-Qz for submit@debbugs.gnu.org; Wed, 30 Nov 2016 12:12:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cC8Qf-0003Oq-HD for submit@debbugs.gnu.org; Wed, 30 Nov 2016 12:12:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC8QZ-00056X-QS for submit@debbugs.gnu.org; Wed, 30 Nov 2016 12:12:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_40,FREEMAIL_FROM, RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36696) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cC8QZ-00056E-Ma for submit@debbugs.gnu.org; Wed, 30 Nov 2016 12:12:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cC8QY-0007la-Qx for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 12:12:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cC8QV-000545-I1 for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 12:12:14 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:49629) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cC8QV-00052a-7e for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2016 12:12:11 -0500 Received: from [18.26.2.123] ([18.26.2.123]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.184]) with ESMTPSA (Nemesis) id 0MFcKD-1bxcMO2QzN-00EcJ1 for ; Wed, 30 Nov 2016 18:12:09 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: bug-gnu-emacs@gnu.org References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> <87bmwzitbb.fsf@users.sourceforge.net> <87zikhhkcj.fsf@users.sourceforge.net> <5e22b5f1-787b-7847-0aa7-d3dc90ac356e@easy-emacs.de> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <258fd3e5-7a36-cadc-8c57-3b3613c98015@gmail.com> Date: Wed, 30 Nov 2016 12:12:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5e22b5f1-787b-7847-0aa7-d3dc90ac356e@easy-emacs.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vvOSxdePq3itVm9OaOtl3sLDj4MeNtpI9" X-Provags-ID: V03:K0:TgqANRUSqmTOG7MtyyXWu93o4NfJxfqpAzRiDGCS71KTyqffBIQ 9gaslAc1m+9U9tJFsUNNPTh9sdkpOr2hnnm+XB5ke9+mFCnrOd7dTmUJULggcuURI1PcgFA jqjofet+tbJj0D29Cp4j/QaZLsZpW604BVPw8wD5AtkUChi8wMl08MslQrPpxNID29E2FKh jCPPJfzJG2w8hrmrCf0VA== X-UI-Out-Filterresults: notjunk:1;V01:K0:TKIGI1BOZe4=:PjgyD6hR19od8QYxYoa3Zb N73yXkGUtbkXNSQVB7UC/Pzsx6bgCTdg8tJ2GVdjTERG0lZpowMvCHC8p5XBjzXWwvmlwQZLF 0x8h62YQnYz2weT7h4pMd1k2JKFJaN3scoILxjMXWwCvL7e1x1sDB4MlPxol0Ks+PiutIZscA Omp8NNocWXWNdEbS2Yy9m4NDhZ4d8t4YQWCp5SLs/wGsrLSCdzKg8HaZ1oApc5ySGnMW80auJ oEJirHUaROqgvYogka1yv1u+Z1NGVDvYyS4bECAxHQqb/w7yUH3I9slJiHu7pDYMieUNOzXiy nPojnZ0eWjI1Su/x4oR1brTstxyjGRSEn+5JCgnN7blo+vBVeJ7kzAkGUmPKBo01sN8tKJ4FZ DEKVpFhY/FWmsdXKN1isBUa3k4Nd0ikJrqmf1fsH9Pl5duXUEerSI2xEhZ8KMRwZr3B0ruVGn +E/KIBzrh7tk76RwbgKUySiOgvNU9A5utyw0Pun3PX2wJNaoslPHWHynCmbI/BqW4yBqemCqc 2Y1udUP1mJ/W/P7OnuhobUIbA/yfwoIdXcsYVfUTtuuy3YGh2wfZKB8UAFdblUiy7NYm+zE0k Du7KE0wjv37ZAoxXn32p1+c9kQsd7yr6tPRnH8VYKelnZ8iFt8CdpivDlDcsAt3M9EW4ArrFw 8ODe0RYr19W+gJYdVurUKSppZpJidWT+eD6WBSHo+r3uTIdI6uZv3gmNAPRWJE7eyPh8= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vvOSxdePq3itVm9OaOtl3sLDj4MeNtpI9 Content-Type: multipart/mixed; boundary="M1De7uBIUMbDxwvoQ1c9gBx4j1SrrRH2f"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: <258fd3e5-7a36-cadc-8c57-3b3613c98015@gmail.com> Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <7e617ffe-0f2e-a193-8b7f-b5ccf73da6d6@easy-emacs.de> <87bmwzitbb.fsf@users.sourceforge.net> <87zikhhkcj.fsf@users.sourceforge.net> <5e22b5f1-787b-7847-0aa7-d3dc90ac356e@easy-emacs.de> In-Reply-To: <5e22b5f1-787b-7847-0aa7-d3dc90ac356e@easy-emacs.de> --M1De7uBIUMbDxwvoQ1c9gBx4j1SrrRH2f Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-11-30 01:39, Andreas R=C3=B6hler wrote: > An executable with a space in its name? Hmm, didn't notice such thing. "C:\Program Files\Python\python.exe" ? --M1De7uBIUMbDxwvoQ1c9gBx4j1SrrRH2f-- --vvOSxdePq3itVm9OaOtl3sLDj4MeNtpI9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYPwhoAAoJEPqg+cTm90wjPycP/jO/Y0GRXjsIP++3WsP9s/7l Ejm9a9J8PEcTsmw1Eq5nogXG2cR3umDOd6Lk8u51FuLbuJZjb8rta7MTCyfYGYh1 OqRh8ZsKuBUrSochSKpt8GjgFlATwvMH0Gf4SwhoY5M8FvBYEhXxrc9V7Vn2wMJ7 Maw5vvN4FL2qwwsT658M+yUyMEL7JbIHuXiOnTQz9bkVGROuDPV1nVadLR4s8Hy4 WCw6rc56TnyjuhXu2+m+8VQXu+pMqqZcfvz/R+kFB0edcTfG3ZI90R2Mpvo+fzGe aFW5BqDCVX7+AwYZDOdOxNCPaSIwjwKxpbhhu6teAbmGdBAiqdG1BrqF7Ui/Z9BW 9WnXIvRIo68IV3k19jZCpamThV0fhapgOLutIxjRqDNY6LDfvUj0R4aysFaSnqpQ woEYmzu5IWUzg1cpD9OkzLimmlG+6Td8uFKgyLFEIQecezl33aZwKUPXSUwpZ12n TD0GoOQnJ98BZ1OcxnQKHtU3vG/U6aGBl+yvSoi3jPwKXDD+IaCeptZU7E5mtc3V cm5esAzv8/8gG18S76l6b8eKnxCNH/7JaCYg17JmKrc2OmGxoyofwuT7nWg16uyk 5xnmQfcCd0rtiEW8nHKwhnFyI4wCVdUtjOx1Gb8PluiiZcMlyUvS5kzJUJLHafUX PrAZ7Ja/QPt3wwndQpNa =DMj/ -----END PGP SIGNATURE----- --vvOSxdePq3itVm9OaOtl3sLDj4MeNtpI9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 17:10:42 2016 Received: (at 25025) by debbugs.gnu.org; 30 Nov 2016 22:10:42 +0000 Received: from localhost ([127.0.0.1]:47822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCD5O-00027z-9Z for submit@debbugs.gnu.org; Wed, 30 Nov 2016 17:10:42 -0500 Received: from mail-yw0-f174.google.com ([209.85.161.174]:33485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCD5M-00027j-D1 for 25025@debbugs.gnu.org; Wed, 30 Nov 2016 17:10:40 -0500 Received: by mail-yw0-f174.google.com with SMTP id r204so169719066ywb.0 for <25025@debbugs.gnu.org>; Wed, 30 Nov 2016 14:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=ufeujWoZupv7n+9eM9AiRKIjQZ9bP8GhuoJS15fQh2I=; b=vt1QdD9fWwf8wiuUyNbTXH4gOT1CsVrAhwp2qZnmWxVop6Zc8Fz6VeicweTCDHkpbk HC5U5SkImf4IfU/Y9cxYj/to4W58D5Iusc1viohj74u7EH8dAMJ5V8ebtUa8eEaL8oV1 t3n5bC++kpHXmZbwksfSh5y34pPnJLGwU+Fu2SIV0ZyDQK2AMTEZs0p1QPgMKOBBuipj VS8RJ6AkLVwzCCw/YvS5onbzh8pSnedJH2n0Ryram+vEk6zmcq+/H8UCIIg516TXwtex RgspJPAuVyWeYIIv60f8XN8FEqcOpPwAOPRfMtlIrwsH1WEUmEcEOktGtNy/VKhD01E0 IhwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=ufeujWoZupv7n+9eM9AiRKIjQZ9bP8GhuoJS15fQh2I=; b=h5MjLrgVbvdItI5v6Moy9bUaCY0gUen8rdrrtbv6nQQrdBCcjRYWT/qhQJypVkYuVs 26/gPf0//MqQ+yCq8ku0s+9981lTmO33SGv6eLl9R8sy9/LfhQji5BTUQ7NlqHArZ7w3 BtRBNR5TvWmn3S+ZOgfWYfBoC9ltXlvgl1XABzN7BCoSfXKQxdAzO9KxIJB1RaZgfl+W G5fFWnI2+3ez+UiH8JoBYEZl6ny4PpEtCgDGS3nXUvJo4RMP/CY7vBcXj+X3AVCXXN7f afX7X1jpT6z5loomlDGurm2yKuCMThNjAVZqdZFRDxWnyzxnPcBFCXJL2NZ2584cN5oX xGWw== X-Gm-Message-State: AKaTC010oKRCtf+aMSM83T8SqtzeNSUzr2w/m5GITAEpWdwmKp+B5fAT38CQ+JgJDytN1J/IJAHeD4gvVofoYA== X-Received: by 10.157.54.245 with SMTP id s50mr19293813otd.181.1480543834892; Wed, 30 Nov 2016 14:10:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.6.234 with HTTP; Wed, 30 Nov 2016 14:10:34 -0800 (PST) In-Reply-To: <83a8chq7x6.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> From: Noam Postavsky Date: Wed, 30 Nov 2016 17:10:34 -0500 X-Google-Sender-Auth: SGotm5EeR8whscHLrpocvRR87h8 Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Wed, Nov 30, 2016 at 10:55 AM, Eli Zaretskii wrote: >> From: npostavs@users.sourceforge.net >> Cc: Eli Zaretskii , 25025@debbugs.gnu.org >> Date: Tue, 29 Nov 2016 20:56:16 -0500 >> >> Cl=C3=A9ment Pit--Claudel writes: >> >> > On 2016-11-29 19:36, npostavs@users.sourceforge.net wrote: >> >> Eli Zaretskii writes: >> >> >> >>>> From: npostavs@users.sourceforge.net >> >>>> Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com >> >>>> Date: Sun, 27 Nov 2016 11:06:03 -0500 >> >>>> >> >>>>> Why does it need to be split? A shell command can (even should) b= e >> >>>>> handed to the shell as a single string. >> >>>> >> >>>> Currently it's not a shell command, because a shell isn't being use= d. >> >>>> My other suggestion was to use a shell: >> >>>> >> >>>>>> It might be more intuitive to actually use a shell and then the u= ser >> >>>>>> would enter a shell command (though inserting a shell into things >> >>>>>> might bring more complications). >> >>> >> >>> If it doesn't use a shell, then it has no business quoting commands = or >> >>> their parts using shell-related APIs. >> >>> >> >>> So yes, I think using a shell would be TRT here. Can someone please >> >>> work on a patch in that direction? This problem exists for a long >> >>> time, so I hope we could solve it soon. >> >> >> >> Hmm, the difficulty in using a shell is that the current code wants t= o >> >> parse the command into interpreter and arguments in order to match >> >> against `python-shell-completion-native-disabled-interpreters'. >> > >> > That doesn't prevent us from using a shell. We run the command >> > unmodified through a shell, and we split it and analyze it separately >> > to decide whether to enable completion. But we don't split and >> > reassemble it before running it. >> >> Yes, but then we need to parse a shell quoted command, which is quite a >> bit more difficult. That gets back to your suggestion about getting an >> elisp equivalent to shlex I suppose. >> >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D25025#28 > > Confused: how does python-shell-completion-native-disabled-interpreters > get into this picture? The function which uses it, > python-shell-completion-native-interpreter-disabled-p, looks at > python-shell-interpreter, which isn't affected by quoting or by how > the command is treated. What am I missing? This? (defun run-python (&optional cmd dedicated show) ... (python-shell-make-comint (or cmd (python-shell-calculate-command)) ... (defun python-shell-make-comint (cmd proc-name &optional show internal) ... (let* ((cmdlist (split-string-and-unquote cmd)) (interpreter (car cmdlist)) (args (cdr cmdlist)) (buffer (apply #'make-comint-in-buffer proc-name proc-buffer-name interpreter nil args)) ... ;; Users can override the interpreter and args ;; interactively when calling `run-python', let-binding ;; these allows having the new right values in all ;; setup code that is done in `inferior-python-mode', ;; which is important, especially for prompt detection. (python-shell--interpreter interpreter) (python-shell--interpreter-args (mapconcat #'identity args " "))) (with-current-buffer buffer (inferior-python-mode)) ... (define-derived-mode inferior-python-mode comint-mode "Inferior Python" ... ;; Users can interactively override default values for ;; `python-shell-interpreter' and `python-shell-interpreter-args' ;; when calling `run-python'. This ensures values let-bound in ;; `python-shell-make-comint' are locally set if needed. (set (make-local-variable 'python-shell-interpreter) (or python-shell--interpreter python-shell-interpreter)) (set (make-local-variable 'python-shell-interpreter-args) (or python-shell--interpreter-args python-shell-interpreter-args)) ... From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 12:10:54 2016 Received: (at 25025) by debbugs.gnu.org; 1 Dec 2016 17:10:54 +0000 Received: from localhost ([127.0.0.1]:48942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCUsn-0005JU-Qb for submit@debbugs.gnu.org; Thu, 01 Dec 2016 12:10:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCUsm-0005JI-K0 for 25025@debbugs.gnu.org; Thu, 01 Dec 2016 12:10:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCUse-0008MX-1h for 25025@debbugs.gnu.org; Thu, 01 Dec 2016 12:10:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUsd-0008MO-Mu; Thu, 01 Dec 2016 12:10:43 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3802 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCUsc-0001qj-VL; Thu, 01 Dec 2016 12:10:43 -0500 Date: Thu, 01 Dec 2016 19:10:50 +0200 Message-Id: <83d1hbpobp.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Wed, 30 Nov 2016 17:10:34 -0500) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Noam Postavsky > Date: Wed, 30 Nov 2016 17:10:34 -0500 > Cc: ClĂ©ment Pit--Claudel , > 25025@debbugs.gnu.org > > > Confused: how does python-shell-completion-native-disabled-interpreters > > get into this picture? The function which uses it, > > python-shell-completion-native-interpreter-disabled-p, looks at > > python-shell-interpreter, which isn't affected by quoting or by how > > the command is treated. What am I missing? > > This? > > (defun run-python (&optional cmd dedicated show) > ... > (python-shell-make-comint > (or cmd (python-shell-calculate-command)) > ... > > (defun python-shell-make-comint (cmd proc-name &optional show internal) > ... > (let* ((cmdlist (split-string-and-unquote cmd)) > (interpreter (car cmdlist)) > (args (cdr cmdlist)) > (buffer (apply #'make-comint-in-buffer proc-name > proc-buffer-name > interpreter nil args)) > ... > ;; Users can override the interpreter and args > ;; interactively when calling `run-python', let-binding > ;; these allows having the new right values in all > ;; setup code that is done in `inferior-python-mode', > ;; which is important, especially for prompt detection. > (python-shell--interpreter interpreter) > (python-shell--interpreter-args > (mapconcat #'identity args " "))) > (with-current-buffer buffer > (inferior-python-mode)) > ... > > (define-derived-mode inferior-python-mode comint-mode "Inferior Python" > ... > ;; Users can interactively override default values for > ;; `python-shell-interpreter' and `python-shell-interpreter-args' > ;; when calling `run-python'. This ensures values let-bound in > ;; `python-shell-make-comint' are locally set if needed. > (set (make-local-variable 'python-shell-interpreter) > (or python-shell--interpreter python-shell-interpreter)) > (set (make-local-variable 'python-shell-interpreter-args) > (or python-shell--interpreter-args python-shell-interpreter-args)) > ... Thanks. So the problematic scenario is that the user sets python-shell-interpreter to something we already checked, and then manually feeds us with a command that invokes a different Python interpreter, is that it? Is that a frequent use case, which we should care about? Just to produce a warning? Even if we do want to care about, we could try matching the beginning of the command, perhaps after an optional quote character, and if we don't recognize the interpreter, do nothing. Would that be sufficient? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 20:11:23 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 01:11:23 +0000 Received: from localhost ([127.0.0.1]:49251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCcNn-0002z5-61 for submit@debbugs.gnu.org; Thu, 01 Dec 2016 20:11:23 -0500 Received: from mail-io0-f175.google.com ([209.85.223.175]:35610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCcNl-0002yt-Js for 25025@debbugs.gnu.org; Thu, 01 Dec 2016 20:11:21 -0500 Received: by mail-io0-f175.google.com with SMTP id a124so456533414ioe.2 for <25025@debbugs.gnu.org>; Thu, 01 Dec 2016 17:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+tpQxBjNywXw9HsAOGeJrTl4POoN/WY2WlY7LOK/RRs=; b=OLhbEqqNyQ6mVRR3tPo/Lp7fzgq6vm5tlyx5YdkA7CNE8XMVc4OiDhMiQHP65t8kbg dD7JsCfgqSyER0j8ReRojqmQXNFZrQyVeyBYFHpT+GhY6fFzhutA3b8Qi2aiJKXFRnAV 3dzdSVccTTusyvkKydLNhdytIqDdkFZYDjh8DdgkLGIWin6aWdRuLods8DIdLOe8ryrA DrVLWeRHInliVEkJ3igdGG6cE0STyX/moML6UDXtVMAFZWM2qLjrShKOoOi6vzPbEObr 9KJ55wCHhK9ItZEqcpTL1ceMRLbiGAdk3co7w+zF7UANhro3tFqBdZYb8WnEkraB+8Hx b+FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+tpQxBjNywXw9HsAOGeJrTl4POoN/WY2WlY7LOK/RRs=; b=Xbw+eKbxtaUu2ACMoagmf4i4yPUNiQ9n8LiuUNl6py53BL9XkLzV51k3+01IkJH3Ch V/y2s1YfGRBU26lIcxgWHo3lM4ZA9yvHUMxMf+FwFr3OSVbAALnwkAw4zdSJUjJGCpKg IGNu33dIuif5yvqTaMY4S+TORA/8gDPWn3904RpuA1UXLMlV2NDjKgN39wRsBn82bKOk xoVAjENGXNXUEBrGghzaAnLxfNaYEy0P+HPxOe3IYLHRHGhHOyuqStAmkPYEDrpG9zop 3SljNH4tNnDqUulhLcZe3nIhi8Uf7cE86bO+NNltcleRl+8lPc6eSBgs/stgAIfqlUkV lrYA== X-Gm-Message-State: AKaTC01O861G2laTR8QAbQ1UdGM+qSpnuHu9A4hbbz1zjLtcDwH4hajU/eFYw3uIoV7xbA== X-Received: by 10.107.6.10 with SMTP id 10mr3776757iog.78.1480641076149; Thu, 01 Dec 2016 17:11:16 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f24sm1203096iod.21.2016.12.01.17.11.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Dec 2016 17:11:15 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> Date: Thu, 01 Dec 2016 20:12:13 -0500 In-Reply-To: <83d1hbpobp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 01 Dec 2016 19:10:50 +0200") Message-ID: <87h96ngmmq.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: > > So the problematic scenario is that the user sets > python-shell-interpreter to something we already checked, and then > manually feeds us with a command that invokes a different Python > interpreter, is that it? Is that a frequent use case, which we > should care about? Just to produce a warning? > > Even if we do want to care about, we could try matching the beginning > of the command, perhaps after an optional quote character, and if we > don't recognize the interpreter, do nothing. Would that be > sufficient? To be honest, I don't use python enough to say what the best fix is here. I can say that the easiest way to solve this bug is: --- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name (defun python-shell-calculate-command () "Calculate the string used to execute the inferior Python process." (format "%s %s" - (shell-quote-argument python-shell-interpreter) + (combine-and-quote-strings (list python-shell-interpreter)) python-shell-interpreter-args)) From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 02:35:43 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 07:35:43 +0000 Received: from localhost ([127.0.0.1]:49431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCiNj-0003Wt-IU for submit@debbugs.gnu.org; Fri, 02 Dec 2016 02:35:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCiNi-0003Wh-9F for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 02:35:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCiNc-0002rJ-DY for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 02:35:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCiNW-0002qy-FK; Fri, 02 Dec 2016 02:35:30 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1177 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCiNU-0000Fi-DA; Fri, 02 Dec 2016 02:35:29 -0500 Date: Fri, 02 Dec 2016 09:35:38 +0200 Message-Id: <83k2biokad.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87h96ngmmq.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com > Date: Thu, 01 Dec 2016 20:12:13 -0500 > > Eli Zaretskii writes: > > > > So the problematic scenario is that the user sets > > python-shell-interpreter to something we already checked, and then > > manually feeds us with a command that invokes a different Python > > interpreter, is that it? Is that a frequent use case, which we > > should care about? Just to produce a warning? > > > > Even if we do want to care about, we could try matching the beginning > > of the command, perhaps after an optional quote character, and if we > > don't recognize the interpreter, do nothing. Would that be > > sufficient? > > To be honest, I don't use python enough to say what the best fix is > here. Me neither. > I can say that the easiest way to solve this bug is: > > --- a/lisp/progmodes/python.el > +++ b/lisp/progmodes/python.el > @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name > (defun python-shell-calculate-command () > "Calculate the string used to execute the inferior Python process." > (format "%s %s" > - (shell-quote-argument python-shell-interpreter) > + (combine-and-quote-strings (list python-shell-interpreter)) > python-shell-interpreter-args)) Isn't combine-and-quote-strings wrong for quoting shell commands? AFAIR, it doesn't DTRT with some special characters that can appear in file names on Unix. Am I mistaken? But if my fears are unjustified, sure, why not? Clément, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 09:16:13 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 14:16:13 +0000 Received: from localhost ([127.0.0.1]:49634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCodI-0006JG-PY for submit@debbugs.gnu.org; Fri, 02 Dec 2016 09:16:12 -0500 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCodG-0006J3-HY for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 09:16:10 -0500 Received: by mail-oi0-f54.google.com with SMTP id y198so267478311oia.1 for <25025@debbugs.gnu.org>; Fri, 02 Dec 2016 06:16:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=5t4+ZNIDAptO8K+/YR0dkt9bgb3qeLGdbJoyf/3mjJQ=; b=Mwnar/9i88PtdKf33M3b37YkU4ee4uU9WIkKDyvPqzlE80RiL0OnNoq6dw7UP32m/j K7mPV5qPAngBWNZf3JeC6A3C4liFEgIal7B7HU0UUnxjOr5FmJgTawQt1V2ERwzpTxOr 5tm2U8RNMVybFTPob34pHLngJM7CtiqJ7AFR64xybVzv5fWsz8xZ2AREF9awpXnqE1Y9 UTtxN36dTD2zn0CyRUVXSjE5V08ncOsxa7Pog+vgSbH+2Edk6M/YLcMIPi7i7CdhvxbT TRbT1Ah+Uo1bXsowZBtPK5TGqKA13jOa/teldZiWY25pou5uszMeUxPMRg38mZ6dS85d UIWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=5t4+ZNIDAptO8K+/YR0dkt9bgb3qeLGdbJoyf/3mjJQ=; b=Gyz/ms2pDlZiRh/FzljZY6fT/D89hvUt5HGjqD3Z7whSfQT30Uwo0uG22oD4FfuONn hHScejaQetOk4phr8DHOuF3G+59YoTMti9JDwPCX1gxyx8qlAAT8tk0JPJHHA6aQBl/m HAZWeqXoRj8/eLOF0a0u9KRrEner07fYugfmlEmgbYcj2oMlKCXjmaXSVlW1woBr/kyL CJnQ8ah9CJsioOZYW6GudtNJGJjHj3U9BzQpoZ5gUcAfLtrcALx/d50TSDam8M6tE7o1 iwXTdVMfaa6VHERGgI0e8HfOYcsN7Pl1ldaeZxmYVx8Nug1GP/5kyt330ggpNmlsm2z3 55Nw== X-Gm-Message-State: AKaTC03emJXTFVJh6xRjr+VU7dwT9WLyv7eBjtjRKC4bkeh5+dMyjs0fCmfy6QUehsCTyCEAnKYPJ/fxY/mGMA== X-Received: by 10.202.244.214 with SMTP id s205mr21214914oih.70.1480688164834; Fri, 02 Dec 2016 06:16:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.6.234 with HTTP; Fri, 2 Dec 2016 06:16:04 -0800 (PST) In-Reply-To: <83k2biokad.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> From: Noam Postavsky Date: Fri, 2 Dec 2016 09:16:04 -0500 X-Google-Sender-Auth: jJwJsDOkcKM6YrF-poVf25nY-9A Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Fri, Dec 2, 2016 at 2:35 AM, Eli Zaretskii wrote: >> --- a/lisp/progmodes/python.el >> +++ b/lisp/progmodes/python.el >> @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name >> (defun python-shell-calculate-command () >> "Calculate the string used to execute the inferior Python process." >> (format "%s %s" >> - (shell-quote-argument python-shell-interpreter) >> + (combine-and-quote-strings (list python-shell-interpreter)) >> python-shell-interpreter-args)) > > Isn't combine-and-quote-strings wrong for quoting shell commands? > AFAIR, it doesn't DTRT with some special characters that can appear in > file names on Unix. Am I mistaken? It's not a shell command though, hence this bug. > > But if my fears are unjustified, sure, why not? Cl=C3=A9ment, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 09:51:19 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 14:51:19 +0000 Received: from localhost ([127.0.0.1]:49663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpBH-00077U-Cg for submit@debbugs.gnu.org; Fri, 02 Dec 2016 09:51:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpBF-00077H-Kh for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 09:51:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCpB9-0000xZ-Ir for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 09:51:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCpB5-0000wW-4z; Fri, 02 Dec 2016 09:51:07 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1715 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCpB4-00021G-D3; Fri, 02 Dec 2016 09:51:06 -0500 Date: Fri, 02 Dec 2016 16:51:15 +0200 Message-Id: <83r35qmljw.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Fri, 2 Dec 2016 09:16:04 -0500) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Noam Postavsky > Date: Fri, 2 Dec 2016 09:16:04 -0500 > Cc: 25025@debbugs.gnu.org, ClĂ©ment Pit--Claudel > > On Fri, Dec 2, 2016 at 2:35 AM, Eli Zaretskii wrote: > >> --- a/lisp/progmodes/python.el > >> +++ b/lisp/progmodes/python.el > >> @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name > >> (defun python-shell-calculate-command () > >> "Calculate the string used to execute the inferior Python process." > >> (format "%s %s" > >> - (shell-quote-argument python-shell-interpreter) > >> + (combine-and-quote-strings (list python-shell-interpreter)) > >> python-shell-interpreter-args)) > > > > Isn't combine-and-quote-strings wrong for quoting shell commands? > > AFAIR, it doesn't DTRT with some special characters that can appear in > > file names on Unix. Am I mistaken? > > It's not a shell command though, hence this bug. No, but the code in question generates a shell command, from the file name of the interpreter and its arguments. Right? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 10:07:09 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 15:07:09 +0000 Received: from localhost ([127.0.0.1]:50464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpQa-0007g0-QH for submit@debbugs.gnu.org; Fri, 02 Dec 2016 10:07:08 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:33333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCpQZ-0007fo-DF for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 10:07:07 -0500 Received: by mail-io0-f170.google.com with SMTP id j65so485710457iof.0 for <25025@debbugs.gnu.org>; Fri, 02 Dec 2016 07:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=K2R8i/fEXpPPTFL4dpByCE0a5JYjlo56EVbdV4IXakA=; b=DmgVFK7/W8gX8sDHBqVI5RNXBHPERCN0K+TozGam/R6DxY0xc6aY3laQ02luVYEwEF CCsUvPlEY/HMrcHiNb5tskLPqcbC9uxbqY/77otwD+I29YagOJ8xGP5xMi1Iq2C5Kn0K QUKOaWBvZlsmq2wg3SDZYtC50yqbAv4hC95g/AD23kGxQHBRp5QC9k8CYp8qqLfgUSMh OslyNGe46T+Tp+UXdRfV8PhfmmepJqtQ8hdTdpYgmnCZ44mDYuV+aw6SJtxnHCPN3s76 owvbfWmYawiFGga7XOL+m9BU/UVNJlXdScJgiHwBZtm+4oVoJP73RbO262cv5Jow/88A JpEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=K2R8i/fEXpPPTFL4dpByCE0a5JYjlo56EVbdV4IXakA=; b=SSEqzDbEMetBLFT5GLt6gkZclnViXApQ4M+UqYKT0dCkzUMt8o659y6huAFYjSzSy0 1GYXfFR30DLPA0qVokn9O1dIInKkS4hebssENK8V3CmPPZsxXgxvsMuNzvx82ZUUnLTC TDFJcQ8GfsS+z+QkbcYVfyKVhQ3MSAlzpqZOYI10WbRZeiyPXcmBfr0nyi2s0YWWIE4M TkuYu1K+0rUQ7j5CJVtF1EI9/HAjxOlC0k1aivY5Xio+19QNVidfPvx3RkNQyRsXDY/y tviaLcIA+q7rSctrmeoKUb3ZvG04MY17kjUh7/X0FG0Wbx2kjxp+oEFHDFyqY4wBvoPM XI8Q== X-Gm-Message-State: AKaTC00ClH3iQmFxTF/FWgLdsmJur2HZncvF1D2QlAwGoTmBSp4piaFHAIv7O+0kaLhAvw== X-Received: by 10.36.108.17 with SMTP id w17mr2897139itb.108.1480691220626; Fri, 02 Dec 2016 07:07:00 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id i62sm1200706itb.12.2016.12.02.07.06.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Dec 2016 07:06:59 -0800 (PST) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <83r35qmljw.fsf@gnu.org> Date: Fri, 02 Dec 2016 10:07:57 -0500 In-Reply-To: <83r35qmljw.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Dec 2016 16:51:15 +0200") Message-ID: <87bmwugyia.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: >> From: Noam Postavsky >> Date: Fri, 2 Dec 2016 09:16:04 -0500 >> Cc: 25025@debbugs.gnu.org, Cl=C3=A9ment Pit--Claudel >>=20 >> On Fri, Dec 2, 2016 at 2:35 AM, Eli Zaretskii wrote: >> >> --- a/lisp/progmodes/python.el >> >> +++ b/lisp/progmodes/python.el >> >> @@ -2379,7 +2379,7 @@ python-shell-internal-get-process-name >> >> (defun python-shell-calculate-command () >> >> "Calculate the string used to execute the inferior Python process." >> >> (format "%s %s" >> >> - (shell-quote-argument python-shell-interpreter) >> >> + (combine-and-quote-strings (list python-shell-interpreter)) >> >> python-shell-interpreter-args)) >> > >> > Isn't combine-and-quote-strings wrong for quoting shell commands? >> > AFAIR, it doesn't DTRT with some special characters that can appear in >> > file names on Unix. Am I mistaken? >>=20 >> It's not a shell command though, hence this bug. > > No, but the code in question generates a shell command, from the file > name of the interpreter and its arguments. Right? Okay, let me rephrase. `python-shell-calculate-command' currently generates a shell command, but none of its callers treat the result as a shell command (they don't pass it to a shell, they parse it with `split-string-and-unquote'). Therefore, the easiest fix is to change `python-shell-calculate-command' to no longer generate a shell command. The other possiblity is to change the callers to treat `python-shell-calculate-command's result as a shell command, but that looks more difficult (though it may be the better solution overall). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 10:46:44 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 15:46:44 +0000 Received: from localhost ([127.0.0.1]:50486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCq2u-00009D-0A for submit@debbugs.gnu.org; Fri, 02 Dec 2016 10:46:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCq2s-00008z-0r for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 10:46:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCq2m-0007Ay-3b for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 10:46:36 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCq2k-0007AC-Pt; Fri, 02 Dec 2016 10:46:34 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1777 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCq2j-0005tg-W5; Fri, 02 Dec 2016 10:46:34 -0500 Date: Fri, 02 Dec 2016 17:46:44 +0200 Message-Id: <83inr2mizf.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87bmwugyia.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <83r35qmljw.fsf@gnu.org> <87bmwugyia.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: npostavs@users.sourceforge.net > Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com > Date: Fri, 02 Dec 2016 10:07:57 -0500 > > Okay, let me rephrase. `python-shell-calculate-command' currently > generates a shell command, but none of its callers treat the result as a > shell command (they don't pass it to a shell, they parse it with > `split-string-and-unquote'). Therefore, the easiest fix is to change > `python-shell-calculate-command' to no longer generate a shell command. Fine with me (and maybe also change the function's name while you are at it). From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 11:15:46 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 16:15:46 +0000 Received: from localhost ([127.0.0.1]:50511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCqUz-0000qD-PS for submit@debbugs.gnu.org; Fri, 02 Dec 2016 11:15:45 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:63669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCqUy-0000py-71 for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 11:15:44 -0500 Received: from [18.189.73.191] ([18.189.73.191]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.184]) with ESMTPSA (Nemesis) id 0MDgeU-1cTtf03guU-00H5Fk; Fri, 02 Dec 2016 17:15:25 +0100 From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii , npostavs@users.sourceforge.net References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> Message-ID: Date: Fri, 2 Dec 2016 11:15:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <83k2biokad.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lrBC0wutRvkgK0g4RsCkUPMQSgTl6osf8" X-Provags-ID: V03:K0:UB2ZZ2j/fcKf1mpnMTCGXuOSpwiBW8JH//GNbO6FfUWo8MAxrc9 /k5DBU4E2ssXv1OAJmyh14P5D7YN2uxShceW8Epg3gexlxO04q0JKpCWxmvcDmGwt61JOYH Q33snLmBYAVzYMBzECQ8gcILnnCLqdLFWL43BVs9wy8npKGXAA1LlgF04B8ufBsltTuiHLo N5PlYKXCyMCCHs9m3vz5Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:RRASbh11KNo=:DgiCYRtQI8A3ukh758LGQp LYPauhVe6M2HnfGT448ocSYJ7YutJf8Zy1JJ6dC4/blYUnvNX7D+HKA9pq0g8GcvwDEZAdJMH OJgbauLO9GQ+lkoP//RfeXMQrqbHHAU4Quqe2uiYEX/ZUor2HczkbbsI95R7veAk/jQjW6rPL vLVEjPVCPY+cyYV9Z7udc329yV1jMdX4f9UkFsW0bNX42rb4ABYaSc+2k7qx809ksThC2K1U3 UBIwj3zPACuv7+6OsUBPXpURHkL5+Cy4nx2U3OBqu9LnTfhTEcH2oDnQjk0DvFb57km9Z7Mm6 nP2sy48+/+dRqOSk6HsTipskR5ns/5JeFPl1DrQwdeiuhZQ/LrMmsonHD8j954xrgOYfXqhZG Mxjk18pxb0kOWHyXqYrwNxW+Kj5rBmE46+jPGKwJcX0pQKeYxhgbAkynqHLtfmK7pWSIwsCoR o4lFx6Ks8PmQ6zvREo+S0A6ElSUB/IwBZtn353YLIZThEBFkY1NE2cXFiYw2z2BVuidoMnaRV x3Svpv41ELK5ZrAUB2asKaL0RodFzjcxYBgAGmx+RSpgz09szLAZ4OL7soKNWUv6nRXAdjohT RxFatA/vN6q0JDcY7YiVxrz69l17gaavRi0jSmhq7CAcpq2yH2AlW1E3wBVSf+NlTr31GGbVu F3hbi2CicSRIsogjIgSxhDIzwDTa3pS3D4Gi2/4I5H/ydC/W/1+3H5BbJlUpKdsRYA1s= X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lrBC0wutRvkgK0g4RsCkUPMQSgTl6osf8 Content-Type: multipart/mixed; boundary="fV2Ohj7sWupFHDXvLdnfMo0lsfKEQcIUC"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Eli Zaretskii , npostavs@users.sourceforge.net Cc: 25025@debbugs.gnu.org Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> In-Reply-To: <83k2biokad.fsf@gnu.org> --fV2Ohj7sWupFHDXvLdnfMo0lsfKEQcIUC Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 2016-12-02 02:35, Eli Zaretskii wrote: > Isn't combine-and-quote-strings wrong for quoting shell commands? > AFAIR, it doesn't DTRT with some special characters that can appear in > file names on Unix. Am I mistaken? >=20 > But if my fears are unjustified, sure, why not? Cl=E9ment, WDYT? On 2016-12-02 10:07, npostavs@users.sourceforge.net wrote: > Okay, let me rephrase. `python-shell-calculate-command' currently > generates a shell command, but none of its callers treat the result as = a > shell command (they don't pass it to a shell, they parse it with > `split-string-and-unquote'). Therefore, the easiest fix is to change > `python-shell-calculate-command' to no longer generate a shell command.= >=20 > The other possiblity is to change the callers to treat > `python-shell-calculate-command's result as a shell command, but that > looks more difficult (though it may be the better solution overall). Currently, run-python can read a shell command; do we want to remove this= feature? If not, then we do need a shell, don't we? As far as I understand we have two conflicting requirements: * One part of the code wants access to switches passed to python, as a li= st of switches. * One part of the code wants to read a python command, including switches= , from the user. I'm not sure that we can get these two to both work in all cases, unless = we come up with a robust way to parse shell commands given by the user. = I see multiple solutions: 1. Use a shell to run python. Then the part of the code that wants to kno= w which switches are being passed can use the possibly-incorrect split-st= ring-and-unquote to split user-supplied strings, but the user-supplied co= mmand is run as-is through a shell. 2. Keep running python as a subprocess, without a shell; in that case, us= er-supplied commands (in C-u M-x run-python) need to be "parsed" back int= o command + switches before running them, which introduces a small potent= ial for incorrect parsing. Noam, your approach is (2), right? I like the simplicity. In the long run, it would be nice to offer a read-shell-command-as-list f= unction, probably based on eshell. Cheers, Cl=E9ment. --fV2Ohj7sWupFHDXvLdnfMo0lsfKEQcIUC-- --lrBC0wutRvkgK0g4RsCkUPMQSgTl6osf8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYQZ4ZAAoJEPqg+cTm90wjr00P/1uYM80YKP7BWQuf/mpaJl/s N/rjcA9V5CCAxSOPEZ6kJIkImF4Rv7OHTZSGqo/Qr0pIsEA24UadxdK/LwyMtHdb BWLSGyyVfviN9ha4/cUqGx0tKrNeJ7uD8JLyDxKi7mr1uJ3FXzFbi0WBnMZDWLwB ALCjEXfHowVseMqxWjGrsXAjRhNMcZ0HXDpXsnSzhZ+8WDibD0dDxJFvCSiH1Z4K fyDNbt5g1YQ3OdC/+4KyEr0eLClfyf1WYrIaSXsMLnCEKPaJdT/nH9yYjOShIQaK oBZG+R2bwxB2vEPlCaOwEP2v4rwg6KZRsS90GWCIYVXFwdvKJErJZ/k4cpUOQx3F y3PL4P/3j+jMEZkB6MWzUpyIvhcLzaca6Eeks2eyMsXZWxssXVqyfblt9VuLv80L 6CIW8mUSK7ukQj+TFAV+Q2MqugVhQbp62rFEdypBn6OT6GRYy1SzJQY+5ywwJuQD dtWgFvxRR6O4X5ofUDAuBTvPk9oS0O6m/7RTxVJNU+vJjXWv90ehcggLKup/9tVK Wv1GHtdzfKmAKbcWRe2l50jxUECby3PQ/eNEZChS9x1DZJyH4YEwn1vDXGbpi9/P Jvch4PnVNwMIaFGUSVs1BM/WGPqdyE275IP42PPEbjlN+SNApa5dVGSiT/wfTPBR tS9oLfPC+q6C8lGt0y74 =ctjT -----END PGP SIGNATURE----- --lrBC0wutRvkgK0g4RsCkUPMQSgTl6osf8-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 11:42:02 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 16:42:02 +0000 Received: from localhost ([127.0.0.1]:50558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCquQ-0001VB-Ix for submit@debbugs.gnu.org; Fri, 02 Dec 2016 11:42:02 -0500 Received: from mail-oi0-f41.google.com ([209.85.218.41]:34080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCquO-0001Ug-GG for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 11:42:00 -0500 Received: by mail-oi0-f41.google.com with SMTP id y198so272456889oia.1 for <25025@debbugs.gnu.org>; Fri, 02 Dec 2016 08:42:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=ca5XT6MKVyKi6Dz+djZOGEDAuZTa/PHNRFYtfMBfsJw=; b=SXKhhdATDlUO93/2qdKuJPM132T5KJu77G18x/E+HTDdvXwgl7m793bQJ2pGBnaH1i ZKF2rkr5mdItAfyU7YmMemME67BhTood5cd0+9n0eW6yT/3QYKkosz2PKonId71Htv7z H/uYhzjvAdW5bFtR2aE7oW4DwWM2+4+npfTz6BPpAXSdCWlnE48MI8tcFUNufvaHKosT aTz6+IAL/k65GRo9bIW8ky6hqJTVPMcdW+6/6QyYXrPHAlabc4jlHbXCAeV691WHo2pO ffonzZ7mn7KY8xiSB8vcstlE1MSAe9SNGOEsdpwPMk0lriqO1ZoUEnIqb5j5pE0q57cU yZSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=ca5XT6MKVyKi6Dz+djZOGEDAuZTa/PHNRFYtfMBfsJw=; b=SAQj9rbzOt80TRrmLXV/OVPDvh9d9eU7WI/mYI0aiPxnhk/0d+ZSRKuLlIOJvW6Gxh NG1bx1F2sIqhWdfd2RScpiM0KZ9McGTB17GPhV5HFDc0OS6NNe4b9FQTB/zfW0Ikxmg7 uLW8TxEZbhD712NU/0cAiuPoMenvULvQ0XYK3yF4ZoeWUNzL16sYLQ/ALRX/CCY3LTsY MCTfpsf5pEmUZIH+Zh832rMQuNR4QRktTrZxgROufKAk+DPanHbbhZm87HsrBVMBRxfk JlEatXTKaLPENsXpVqN9+dedMHtqsCU9ZLwiE+34V1rl0WJ0lMA8mKoUZQAr0iVU+Til fFcQ== X-Gm-Message-State: AKaTC03hrXwqFbrrdw8wDyO5awE3mElufqreyP35AFgsDd1H/7WuKV6pZQxyE0LD/S1eZaQNt8UawCZ5xGms/w== X-Received: by 10.157.53.50 with SMTP id o47mr23414136otc.19.1480696914650; Fri, 02 Dec 2016 08:41:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.6.234 with HTTP; Fri, 2 Dec 2016 08:41:54 -0800 (PST) In-Reply-To: References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> From: Noam Postavsky Date: Fri, 2 Dec 2016 11:41:54 -0500 X-Google-Sender-Auth: G1HisMtz2cXQRd3e81_yMoP7tg8 Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, Dec 2, 2016 at 10:46 AM, Eli Zaretskii wrote: > > Fine with me (and maybe also change the function's name while you are > at it). If you meant to remove the "shell" from `python-shell-calculate-command', I think that refers to the "python shell" (which would be called REPL in Lisp speak). There are quite a few other functions and variables with the python-shell prefix. On Fri, Dec 2, 2016 at 11:15 AM, Cl=C3=A9ment Pit--Claudel wrote: > On 2016-12-02 02:35, Eli Zaretskii wrote: >> Isn't combine-and-quote-strings wrong for quoting shell commands? >> AFAIR, it doesn't DTRT with some special characters that can appear in >> file names on Unix. Am I mistaken? >> >> But if my fears are unjustified, sure, why not? Cl=C3=A9ment, WDYT? > > On 2016-12-02 10:07, npostavs@users.sourceforge.net wrote: >> Okay, let me rephrase. `python-shell-calculate-command' currently >> generates a shell command, but none of its callers treat the result as a >> shell command (they don't pass it to a shell, they parse it with >> `split-string-and-unquote'). Therefore, the easiest fix is to change >> `python-shell-calculate-command' to no longer generate a shell command. >> >> The other possiblity is to change the callers to treat >> `python-shell-calculate-command's result as a shell command, but that >> looks more difficult (though it may be the better solution overall). > > Currently, run-python can read a shell command; do we want to remove this= feature? If not, then we do need a shell, don't we? It can "read" a shell command, but won't be able to *run* it unless it's parseable with split-string-and-unquote, so I don't think we're removing any feature here. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20744#53 > > As far as I understand we have two conflicting requirements: > > * One part of the code wants access to switches passed to python, as a li= st of switches. > * One part of the code wants to read a python command, including switches= , from the user. > > I'm not sure that we can get these two to both work in all cases, unless = we come up with a robust way to parse shell commands given by the user. I = see multiple solutions: > > 1. Use a shell to run python. Then the part of the code that wants to kno= w which switches are being passed can use the possibly-incorrect split-stri= ng-and-unquote to split user-supplied strings, but the user-supplied comman= d is run as-is through a shell. > > 2. Keep running python as a subprocess, without a shell; in that case, us= er-supplied commands (in C-u M-x run-python) need to be "parsed" back into = command + switches before running them, which introduces a small potential = for incorrect parsing. > > Noam, your approach is (2), right? I like the simplicity. Yes, my approach keeps the status quo, it just stops introducing shell-quoting which could be parsed incorrectly. > > In the long run, it would be nice to offer a read-shell-command-as-list f= unction, probably based on eshell. > > Cheers, > Cl=C3=A9ment. > From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 11:58:42 2016 Received: (at 25025) by debbugs.gnu.org; 2 Dec 2016 16:58:42 +0000 Received: from localhost ([127.0.0.1]:50562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCrAY-0001tt-4N for submit@debbugs.gnu.org; Fri, 02 Dec 2016 11:58:42 -0500 Received: from mout.kundenserver.de ([212.227.17.13]:59796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCrAW-0001td-6T for 25025@debbugs.gnu.org; Fri, 02 Dec 2016 11:58:40 -0500 Received: from [18.189.73.191] ([18.189.73.191]) by mrelayeu.kundenserver.de (mreue103 [212.227.15.184]) with ESMTPSA (Nemesis) id 0M9N4I-1cPT8f1Rmg-00ChpF; Fri, 02 Dec 2016 17:58:19 +0100 Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Noam Postavsky References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Message-ID: <999da53a-7095-f8d1-1ce9-1282f052a887@gmail.com> Date: Fri, 2 Dec 2016 11:58:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="urFTHdnU8xhpWrPBSeimm2JJValhE1l9V" X-Provags-ID: V03:K0:qIp6428PvXlZKL8qVseJXdRILAgU5KL92sHcxqXufBDN9VzQoIa OPhRvh+hFweMnnIZpAJnyxRI0SV+VVKWhpKUu8D2nqz0L9KZlYvTFlxkePshADAOEIes6WJ NLywVG9vv9hIogwWks6PxYE7D+VnIaUmqqLGhopONTn3HN+pZlDBLIUtwFNzv2ziDshjLIT A7T6SoFbW00pqRP+EdU8g== X-UI-Out-Filterresults: notjunk:1;V01:K0:YBtB0Eagtqg=:b2c3zsepjlpQHWJEXWn63Q 4hVPJauEzp2U3bFo9nnwDXQ7KtYjG5UzVThgPVercTW+Ctc7vT3b3ydTitLXPtAXRpVVIGfiF FH1Pj9payhiWLb62gWE87L4HWixw97SR0VlciNdXk41+FWhs55tdBfZWCl9qXqxLTW4hnxwIt qb9QohHDNozQZ9e1fhuKtLSMMXtbijZDOp89yXQMwCj/USY9QoIBqamrejOjUWx9oZLQ2zr0C h3DFMryFJ9iMzk4xN6DZGgfBdNhaQYl/padxqqZgbGhxJpwDQnba6zupELn3jmBrnfc1TxjAD 05o48U0z0fOSu2wMFdSIZpcQLgtGEpOmKjUtaWTaZ5ViP+qx3a2JQKjpv002wvKY+tP6kzIB5 ZmXo8VXb+ipjbPpQ3ZKHNSSMR9651YkJITqwi+2D4KpKBF0OEs9IkETlgYOD/00FQ7qkgdwwC DaPnNL5axOe30hwR53+eg7+gT0yCPPOEKBPrWVotZrF2nXetnwzXtV5+uoPWMcAHgNT03tX05 geB1M8vULmhPRKbtImTs3BdFJWPc8QXlXB90lfQGV3kE0q6sg5kp1d6CjFl3vVjVZGGjF+CWF yvZsKXIPPSb/KqkDgKS2KMhfULiXviLCqPs+GcEP3xAuhLOlxNcDbQ+wi0Kclfwpf98+kpTmI M4KfpqztJVBaphlUWk+GSEBFBITcUCRTz9wbgAEtwoZ2fETjZvXo6t8tFNYtujDxqppM= X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --urFTHdnU8xhpWrPBSeimm2JJValhE1l9V Content-Type: multipart/mixed; boundary="95uVjKs83GKV1vsFeI5FXKS63K4HkUEbs"; protected-headers="v1" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: Noam Postavsky Cc: Eli Zaretskii , 25025@debbugs.gnu.org Message-ID: <999da53a-7095-f8d1-1ce9-1282f052a887@gmail.com> Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> In-Reply-To: --95uVjKs83GKV1vsFeI5FXKS63K4HkUEbs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-12-02 11:41, Noam Postavsky wrote: >> Noam, your approach is (2), right? I like the simplicity. > > Yes, my approach keeps the status quo, it just stops introducing > shell-quoting which could be parsed incorrectly. Thanks for clarifying! --95uVjKs83GKV1vsFeI5FXKS63K4HkUEbs-- --urFTHdnU8xhpWrPBSeimm2JJValhE1l9V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYQagiAAoJEPqg+cTm90wj9UIP/A3DdFubpoZ4fHd51VxjoRRg mdH6NQWauko5s7xIzp0hZ+BoQPiZhC1i1LWmxm8lTkDn/hrj0jlgvp7od6O+KAeR /aSkYD4tFiSoF8kqyzUOghBf/UvpEcAgJ7I0jkON3/IZc7B+LyGygMBx+DhlD/L9 AaN2v3Twi/gEUKQ/umayYX8tW+OdW5vC5ZpD7QALyiavMxvKNErtUA+iFkQohm6E P/qW+FkFhAJxiEpzg3VgWBzJX6qdV3x3wmeb/BiugHeyDbtwFt0wHOZKbuo2VLs0 tfMv0VnylbPuTHPdOVkpV5Ar6AsqxxkrI6nhJIENJWZ07nFAAtr1hgZW/m82JXXi h4EssJOstg1JcdoKxRJ2I/dbenpzk4U7URElMUB26BvAV6kBS5KCdUjj446Tc0Wl sT0VFalSyICG6JNgyuvRNorOD1Ry/t6U+e1c1ztdmv89O4u2cm3J9dBTxRc4xQRk V1RFWAH3pbVI1cRRPrk2ZMp0YK0h5Qx1HKeC0s10tIRieWnQUGyvow4izsZmN5xs kfRiqjo3Agh9aoUwLeO+yyHapIpqjcsSEur911PetNrEZqQ6UY0R/Oq32a6DnYPg RnJG2RhTQtX0B3x8WDfyek/KC9JCvkxCOHsp0Dq3neupO1VW0Or6JemSIYG4acXT z0tZgi1t7Z/HuIwTIS1E =YoA4 -----END PGP SIGNATURE----- --urFTHdnU8xhpWrPBSeimm2JJValhE1l9V-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 00:29:08 2016 Received: (at 25025) by debbugs.gnu.org; 9 Dec 2016 05:29:08 +0000 Received: from localhost ([127.0.0.1]:35090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFDk4-0000rO-7T for submit@debbugs.gnu.org; Fri, 09 Dec 2016 00:29:08 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:34664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFDk1-0000qn-IG; Fri, 09 Dec 2016 00:29:06 -0500 Received: by mail-io0-f193.google.com with SMTP id y124so4682493iof.1; Thu, 08 Dec 2016 21:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4Fs1d4GwTh5GrtVmaAiiDvSM3wqIZJcraKeM2GxxgV8=; b=gRp9tA9WGWDfVbFDKU0VHXfE+Spn3GzSLR1klLk36WUfqlBsFaEGS/cmoxBCpsB0vi P79gCl5hVD6lOQs3Dufe1fjr03v9QoOyz0EYydnsHKHB4OBerJmMG0EsMcvFWg8TNsQ0 ZSzQgaTEGKI9AUfiD156QxYrr2CABl5egF9Im5QAzzZ1VjK31AGbFqHG9Osnf3XaUUy0 4w/Sb4PjFpOjCuQtDH7AonFM8Ne3pZcmsQ5LBLOvb5OTjqwbLa3mIQBFJBS5tL4gN4DE 0vocVAZ4hnHoj2iy0m7H/QSza/fql99PMsu2Kgg03eg9FmeAw4C7AQSsSmu3wiSojU9V gYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=4Fs1d4GwTh5GrtVmaAiiDvSM3wqIZJcraKeM2GxxgV8=; b=LDATZ5vYhtIqSm0j/RmJXj8m8qSJyQgPn+0zC4bIv4RklECHDHhhDL+oXJd2mrVAvN xgCVtvwBXWKaJe7tZ8wvonUKO9LrLPyDW9bWNOD/uRgQSl5EMk1mbqaykzPkZ4+S2S92 tTEjKosybNecot99U+pw0QXGHFKuiuwtgJobB0UeGgYOkfGJEEKcam9b0BOeq5eu76oN qfH4ycrcxepifred8NC/BXE4fPDch4j+CxdWshkbFkR/rZ+vVA/9oNJXgPPSODEv8m23 ARBQoCojM6ytyNA4fvByvPYvSdvQc5BJPHO9dhifmldxT48DqgLVStM+QeSdL7eDLkM/ T52Q== X-Gm-Message-State: AKaTC03Rh/tcKItURT8HvhzWBEao4ZKlUvBSTGXyHNs1AtomGEcmqGQqiGWo4wEvuYcLSw== X-Received: by 10.107.161.78 with SMTP id k75mr69713844ioe.39.1481261339936; Thu, 08 Dec 2016 21:28:59 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 9sm2931829itv.0.2016.12.08.21.28.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 08 Dec 2016 21:28:59 -0800 (PST) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> Date: Fri, 09 Dec 2016 00:29:59 -0500 In-Reply-To: (Noam Postavsky's message of "Fri, 2 Dec 2016 11:41:54 -0500") Message-ID: <87pol1ekko.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 25025 fixed close 25025 26.1 quit Noam Postavsky writes: > On Fri, Dec 2, 2016 at 10:46 AM, Eli Zaretskii wrote: >> >> Fine with me (and maybe also change the function's name while you are >> at it). > > If you meant to remove the "shell" from > `python-shell-calculate-command', I think that refers to the "python > shell" (which would be called REPL in Lisp speak). There are quite a > few other functions and variables with the python-shell prefix. > On Fri, Dec 2, 2016 at 11:15 AM, Cl=C3=A9ment Pit--Claudel wrote: >> 2. Keep running python as a subprocess, without a shell; in that >> case, user-supplied commands (in C-u M-x run-python) need to be >> "parsed" back into command + switches before running them, which >> introduces a small potential for incorrect parsing. >> >> Noam, your approach is (2), right? I like the simplicity. > > Yes, my approach keeps the status quo, it just stops introducing > shell-quoting which could be parsed incorrectly. > >> >> In the long run, it would be nice to offer a read-shell-command-as-list = function, probably based on eshell. Okay, it looks like the consensus is that we should apply the `combine-and-quote-strings' fix for now, and possibly in future switch to something more shell based. I've pushed it to master as 8f611e5e2309 "Fix bad quoting of python-shell-interpreter", and I'm closing this bug. From unknown Fri Jun 20 05:29:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 06 Jan 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 07:01:48 2017 Received: (at control) by debbugs.gnu.org; 16 Aug 2017 11:01:48 +0000 Received: from localhost ([127.0.0.1]:40252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhw55-0006Sn-O8 for submit@debbugs.gnu.org; Wed, 16 Aug 2017 07:01:47 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:32842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhw54-0006SY-C5 for control@debbugs.gnu.org; Wed, 16 Aug 2017 07:01:46 -0400 Received: by mail-io0-f170.google.com with SMTP id j32so11819414iod.0 for ; Wed, 16 Aug 2017 04:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=g3NO2gZdeTfEbli1QX9IjNKeM5EaW191TYSLKxKC8t8=; b=sp5jPGRl9skbqlk/PSlwtf6om8Q4Pck6LHpqVulVJ1KzNycNR73D/ycqhs8ocbw6Ul 1BC5SJXG1Q/TtTE+aB1UF8hLwy5E2oVTsEKw5ErnJS07yOZbDm8qF6sdlx8C+oz2DOds Ad33WA9Wj4nz0BS2AujYVd4bxxpKMhZijb9/uf1Ogda5QNFmNCKMjQ0baPzyLIttmvsm Z40Z87BqaKNvzHyt4aI1jU2aBZSZ42E8n49J876DNWVflaBQZY43CGozkHziR0OfYI3T nugEEP/nT+RjxpHFhSoz/5tL0/Esh1hOVBwlSL6wLmO8V1Frqb0PLTybMqQXLpFIPcdO KQjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=g3NO2gZdeTfEbli1QX9IjNKeM5EaW191TYSLKxKC8t8=; b=lb7u5VbT8WExkxQdQenDnxNmAxSiwTsNrmKUfbihR2qxK5FLoN1IKQb2kyZ8J9s7oi /xb+W543wXZdkjVIUViM2lPXe4u8DvsurT/tcCBiMSJQuUovANwS6v1LuM6ThuD1+lGy YIliTukJtUhjVd0IcySc1kA7637/GUNkbcgO5rIY38WO2BxlWgNgMmJ6sTGZeYHmvA/G 4yu92drz0WayLLiXhiLHkEhM28d0vjSC9GJaj4wKwbfleCGtc08zPnMh/1OO4HSOEVzs BDi4wwq1GVmhCJj/kI+ObEDWNHLTLV9EKiJXzCOrUGkisdvhM18wz7jmgYctBfT44qlt ghKw== X-Gm-Message-State: AHYfb5jhdBQjxVwRKX8g4ob7rTg0+bn0kiCwJkmZRR/yMB7OSvREbzih iSOdxwp7/h1FTGlu X-Received: by 10.107.202.133 with SMTP id a127mr1118694iog.54.1502881300307; Wed, 16 Aug 2017 04:01:40 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id y28sm4843420ita.2.2017.08.16.04.01.39 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Aug 2017 04:01:39 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #25025 Date: Wed, 16 Aug 2017 07:03:18 -0400 Message-ID: <87lgmjzseh.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) unarchive 25025 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 07:07:25 2017 Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 11:07:25 +0000 Received: from localhost ([127.0.0.1]:40257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhwAX-0006bY-DZ for submit@debbugs.gnu.org; Wed, 16 Aug 2017 07:07:25 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:34062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhwAW-0006bK-Bs for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 07:07:24 -0400 Received: by mail-io0-f173.google.com with SMTP id o9so11932119iod.1 for <25025@debbugs.gnu.org>; Wed, 16 Aug 2017 04:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=4wqeDQrtixnWXBRDzpWKhejEgT//KztJ9ravlqtqlwY=; b=iQjshzPxZ8L/TKi4KrYys3ki/ckI4RPRZh2O/Ra4JouUpeKmaRUiS0Dqe2ZuuPGgQt SyLmXWr7o3wz3Rt5USqI5r9rsXFaw8Og0Cwz8Vj/zbPvv/ti7h9qRkCGw4AOMhmX8hYp 1AueZ7a46J4lIsvkPhcVGcXfn8+kjonG6cuTE3DN4fVGnL3ftUy3ATVF9ZU/8PDIe6RR gPN0hY3om60XJZUVezM65VsSTpfysiF/Kp7H2/TDTE4gIBs43ES8Dz0+S2dxjH9ix9Xf 7aUPG0O8ImJBq+JZ6VTD5vNhLvbYrf0G5+z1JWXr4dxGAwfi7gtg2rAdqhjcMnObrihY m1Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=4wqeDQrtixnWXBRDzpWKhejEgT//KztJ9ravlqtqlwY=; b=o6SkTFJfUxILKn1M5kn33NUoMTFFTIjzhS6Za3qywJY7y5zT/0OPcs4eF0nYS+0qoa G/FiYv61J2RGcxkQNTPe4xreWnlbnWDQLFd4ZxrRePImRgpt2teoAVu87NVvJTFPOwg6 bFSQSh+sJw5g547oGjyoOLg2V2IqN9OY3PaOLmGjiKQ9bdbIHZstFXpaDNXqCuWlxlMP UQ6Ug2d3a1juRsLcMOCD5ZScyrOU70rwQGoXkyLWLJwBWc/UWoRN2fzWZv2nQMtEtS43 8wEOoVz0Z6DF9YTGm8Fj57tEyO19QTVwbJAzqLVuFkg7chxrPe00uckiWM5I2I1wf2nP PRaw== X-Gm-Message-State: AHYfb5gs07UencS+lfT2iAVwhvbVTjUyjLiLeBT5LeQNnUa8Q07GJBsb tsXR3MXHO3tRCA== X-Received: by 10.107.128.85 with SMTP id b82mr1144601iod.179.1502881637936; Wed, 16 Aug 2017 04:07:17 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id y72sm217015iod.40.2017.08.16.04.07.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Aug 2017 04:07:16 -0700 (PDT) From: npostavs@users.sourceforge.net To: =?utf-8?Q?Cl=C3=A9ment?= Pit--Claudel Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> Date: Wed, 16 Aug 2017 07:08:55 -0400 In-Reply-To: <87pol1ekko.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Fri, 09 Dec 2016 00:29:59 -0500") Message-ID: <87inhnzs54.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain npostavs@users.sourceforge.net writes: > Okay, it looks like the consensus is that we should apply the > `combine-and-quote-strings' fix for now, and possibly in future switch > to something more shell based. > > I've pushed it to master as 8f611e5e2309 "Fix bad quoting of > python-shell-interpreter", and I'm closing this bug. This broke the test python-shell-calculate-command-1 on Windows. We could update the test to match the new python-shell-calculate-command implementation, but since the test body is basically just a copy of that function, it looks pretty useless to me. I think we should just remove that test. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Remove-python-shell-calculate-command-1-test.patch Content-Description: patch >From 1173da346a388a7258a8b462ef5a5d9416781245 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Wed, 16 Aug 2017 07:06:38 -0400 Subject: [PATCH] ; Remove python-shell-calculate-command-1 test * test/lisp/progmodes/python-tests.el (python-shell-calculate-pythonpath-1): Remove, it merely reprises the body of `python-shell-calculate-command' and it has been broken on w32 since the fix for Bug#25025 was applied. --- test/lisp/progmodes/python-tests.el | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/lisp/progmodes/python-tests.el b/test/lisp/progmodes/python-tests.el index 8795da4ef4..1a8c6a4e8c 100644 --- a/test/lisp/progmodes/python-tests.el +++ b/test/lisp/progmodes/python-tests.el @@ -2546,20 +2546,6 @@ python-tests-shell-interpreter (should (string= (python-shell-internal-get-process-name) (format "%s[%s]" python-shell-internal-buffer-name (buffer-name)))))) -(ert-deftest python-shell-calculate-command-1 () - "Check the command to execute is calculated correctly. -Using `python-shell-interpreter' and -`python-shell-interpreter-args'." - (skip-unless (executable-find python-tests-shell-interpreter)) - (let ((python-shell-interpreter (executable-find - python-tests-shell-interpreter)) - (python-shell-interpreter-args "-B")) - (should (string= - (format "%s %s" - (shell-quote-argument python-shell-interpreter) - python-shell-interpreter-args) - (python-shell-calculate-command))))) - (ert-deftest python-shell-calculate-pythonpath-1 () "Test PYTHONPATH calculation." (let ((process-environment '("PYTHONPATH=/path0")) -- 2.14.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 10:32:37 2017 Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 14:32:37 +0000 Received: from localhost ([127.0.0.1]:41264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzN6-0000c6-VE for submit@debbugs.gnu.org; Wed, 16 Aug 2017 10:32:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhzN4-0000bt-Ka for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 10:32:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhzMv-0004Xb-Ij for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 10:32:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57468) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhzMv-0004XB-Ek; Wed, 16 Aug 2017 10:32:25 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dhzMu-0007wz-QM; Wed, 16 Aug 2017 10:32:25 -0400 Date: Wed, 16 Aug 2017 17:32:10 +0300 Message-Id: <83r2wbfus5.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87inhnzs54.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Cc: 25025@debbugs.gnu.org, Eli Zaretskii > Date: Wed, 16 Aug 2017 07:08:55 -0400 > > > Okay, it looks like the consensus is that we should apply the > > `combine-and-quote-strings' fix for now, and possibly in future switch > > to something more shell based. > > > > I've pushed it to master as 8f611e5e2309 "Fix bad quoting of > > python-shell-interpreter", and I'm closing this bug. > > This broke the test python-shell-calculate-command-1 on Windows. We > could update the test to match the new python-shell-calculate-command > implementation, but since the test body is basically just a copy of that > function, it looks pretty useless to me. I think we should just remove > that test. Could you please elaborate about the reason(s) for the breakage of the test? I'm not sure I follow, and so cannot make up my mind whether I agree with removing the test. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 12:50:33 2017 Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 16:50:33 +0000 Received: from localhost ([127.0.0.1]:41410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1Wb-0000yC-Cm for submit@debbugs.gnu.org; Wed, 16 Aug 2017 12:50:33 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:36273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1WZ-0000xy-Ey for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 12:50:32 -0400 Received: by mail-oi0-f51.google.com with SMTP id g131so41742642oic.3 for <25025@debbugs.gnu.org>; Wed, 16 Aug 2017 09:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TXe5IGmceGtX8Nx1Q6mNesbRo8KTGsobUrKfoZf6NYg=; b=ShZTEt4pkmrETxRozEiGl4xPlaqwH+/8HyNnpC3vj/9qq19wNZ9MXP6Z7JzSpNerEo yBu36Xe9L5mdqvrHvJ8VF5GzhuRA30YHZO+JrqVg15LCep5+ZOBZ7c9F50sn6ZRYZRlB bZsCojmmvy2ajdhm93c+dTRgOuOlnsEpAsAp4AcoJfbo7V54FgzELS2H3zIUnpvvhBRl /783LUHzlRdGCX79kNG8rd64I+LVifNT2zciP2ChEzdjjpY/bDyydU8HniDbfTNQn/i8 sJx9HCCyS+iD2c2lrym6BWkzbtre8Wo17JF1oW6UaZKwftf/mSx+Hxs4r8qeH4TexzrO SkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=TXe5IGmceGtX8Nx1Q6mNesbRo8KTGsobUrKfoZf6NYg=; b=WbArGz5c7Truv0eodFd15mHRcXc4H9R+GQN7d5ovyQQHC6Y3Td1ybSadQ9/jV7+Sc2 PcDeETFeE+p9SLirPIceGwKUGNSXYBc4io2iG7WXW4gsXU77ir+oWRD0rhYhV0w/P+ah UzMXwRYHCKODpi2zWdTJXQCZE0xHHmNd5tV0T1bLnQOLZwVwR2ONZ8JIusAoS5cRR+jl JHcoe4bGEOO6wl+xek5QcyJ6AZ1FtjBm8W7TVQULWvRs3CulgWeLfwA+1O9WQSVEDzKQ IEbVaAX71HaFeejX8gh9rjZa1sC4chfY4t7Mr8wKZr1fqUQgY02XY1GIU9S6+z+YDTGw qK6A== X-Gm-Message-State: AHYfb5gHJaFq94ly4xneLRK7VK0AM8qhQ5ws0GaPtQLP1bQvN5zQzk0d 2hP76c3XBNmPsegNkZr7cUWSgj31AQ== X-Received: by 10.202.49.134 with SMTP id x128mr2858622oix.18.1502902225792; Wed, 16 Aug 2017 09:50:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.18.129 with HTTP; Wed, 16 Aug 2017 09:50:25 -0700 (PDT) In-Reply-To: <83r2wbfus5.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> <83r2wbfus5.fsf@gnu.org> From: Noam Postavsky Date: Wed, 16 Aug 2017 12:50:25 -0400 X-Google-Sender-Auth: feZBmc-h9kdWgZWjn3Zg1fJUm1w Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Wed, Aug 16, 2017 at 10:32 AM, Eli Zaretskii wrote: > Could you please elaborate about the reason(s) for the breakage of the > test? I'm not sure I follow, and so cannot make up my mind whether I > agree with removing the test. > > Thanks. Certainly; this is the test: (ert-deftest python-shell-calculate-command-1 () "Check the command to execute is calculated correctly. Using `python-shell-interpreter' and `python-shell-interpreter-args'." (skip-unless (executable-find python-tests-shell-interpreter)) (let ((python-shell-interpreter (executable-find python-tests-shell-interpreter)) (python-shell-interpreter-args "-B")) (should (string= (format "%s %s" (shell-quote-argument python-shell-interpreter) python-shell-interpreter-args) (python-shell-calculate-command))))) This is the old version of python-shell-calculate-command: (defun python-shell-calculate-command () "Calculate the string used to execute the inferior Python process." (format "%s %s" (shell-quote-argument python-shell-interpreter) python-shell-interpreter-args)) As you can see, the test just repeats the function body and checks for equality. The new version of python-shell-calculate-command is (defun python-shell-calculate-command () "Calculate the string used to execute the inferior Python process." (format "%s %s" ;; `python-shell-make-comint' expects to be able to ;; `split-string-and-unquote' the result of this function. (combine-and-quote-strings (list python-shell-interpreter)) python-shell-interpreter-args)) Which is no longer the same code as what is in the test. On Unixish hosts it passes because the default value of 'python-shell-interpreter' "python" doesn't need any escaping to be shell-quoted. combine-and-quote-strings likewise doesn't do anything to arguments without spaces, so it gives the same thing. But on w32 shell-quote-argument always puts double quotes around its argument, causing the test to fail. We could update the test to use combine-and-quote-strings too, but just having a second copy of the implementation doesn't seem like a useful test to me. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 12:57:58 2017 Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 16:57:58 +0000 Received: from localhost ([127.0.0.1]:41423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1dl-00018Q-QE for submit@debbugs.gnu.org; Wed, 16 Aug 2017 12:57:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1dk-00018D-88 for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 12:57:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1di1da-0001KF-5I for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 12:57:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di1da-0001K9-1d; Wed, 16 Aug 2017 12:57:46 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2872 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1di1dZ-0003Jn-Fg; Wed, 16 Aug 2017 12:57:45 -0400 Date: Wed, 16 Aug 2017 19:57:30 +0300 Message-Id: <83h8x7fo1x.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Wed, 16 Aug 2017 12:50:25 -0400) Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> <83r2wbfus5.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Noam Postavsky > Date: Wed, 16 Aug 2017 12:50:25 -0400 > Cc: ClĂ©ment Pit--Claudel , > 25025@debbugs.gnu.org > > (ert-deftest python-shell-calculate-command-1 () > "Check the command to execute is calculated correctly. > Using `python-shell-interpreter' and > `python-shell-interpreter-args'." > (skip-unless (executable-find python-tests-shell-interpreter)) > (let ((python-shell-interpreter (executable-find > python-tests-shell-interpreter)) > (python-shell-interpreter-args "-B")) > (should (string= > (format "%s %s" > (shell-quote-argument python-shell-interpreter) > python-shell-interpreter-args) > (python-shell-calculate-command))))) > > This is the old version of python-shell-calculate-command: > > (defun python-shell-calculate-command () > "Calculate the string used to execute the inferior Python process." > (format "%s %s" > (shell-quote-argument python-shell-interpreter) > python-shell-interpreter-args)) > > As you can see, the test just repeats the function body and checks for > equality. I see, thanks. So I guess all it (maybe) tests is that python-shell-interpreter and what executable-find returns are identical? Is that something that could somehow fail and would be useful to verify? If not, I agree to removing the test. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 16 15:27:33 2017 Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 19:27:33 +0000 Received: from localhost ([127.0.0.1]:41510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di3yW-0007T3-VK for submit@debbugs.gnu.org; Wed, 16 Aug 2017 15:27:33 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di3yV-0007Sq-23 for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 15:27:31 -0400 Received: by mail-oi0-f54.google.com with SMTP id x3so46103407oia.1 for <25025@debbugs.gnu.org>; Wed, 16 Aug 2017 12:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=WDs0ZQS2eUVuRjesGzBdc06oFOVD6zCjp2VzJNWDwks=; b=oXQcl2D1bTXlR5h1V0E2Z4+4JXvmZhdp1IS8Ikf07YwnKgyiDarbw/VeTDm2MzhYVh RjIz1nSBPSFqZNRp3gx199BJVweNn4JZ1jn3VWu3LY9zCElsRr01MphBofvZZ2sL/P1X OsGgxqKhGxcGN0R+jDqgrCNq3O6VfW2pESIGpwSYRd+3GaIN4yTQsSB2OB4451V57I0t v/q0o4ZKRZVTAgsxEcIYtIDJfVn1YvXRBXJMu6zh8ucXC5OTmD030tuWrm5dl+O9buw4 zBCmoHb8YwMXoG/fLPmvNP6T85j5zL3yOx8A7pnVu8Qo8F8qbB1QenuqyU1KZk7w5YFO 2wAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=WDs0ZQS2eUVuRjesGzBdc06oFOVD6zCjp2VzJNWDwks=; b=dLFOXOg0yk6aOAXKtvKVKD5r/be27hhDfEniOHcHLeCVmADCLGXGHloTP04zKnFl51 jGbtleJ4YYsEvExmWZNpuf9syhGrf44dVHcksiAe0In9UCc/HgYgyzqQKMP5ryDb+wcY TqmmWmu/VnQM5kPjvlkuV7rIAPy6vKI6f7iJV4Qp8U+LlxYAF8FypsaWILVJtF8HH1A/ MkGzr1Y8XZ/35SFrA0Bz16JVKOXg75wgYgGZbViz9+idB7KtyT70oCt3wzmXJUXKp5IF ZbI45NF7iCr3AbdAzQ4d4rj18J9eoNOzuKOHtkB219ZryesuRScBEusE6EZtRso7kATw Wu3g== X-Gm-Message-State: AHYfb5gFlxuTfzi4ZtNObZOK10Dci3mglxNDvKidMQdn2buDpKBCmHfe s2u1AzpEq1DV0RLtlf0gbtuC0XZwLA== X-Received: by 10.202.10.1 with SMTP id 1mr3675751oik.67.1502911645356; Wed, 16 Aug 2017 12:27:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.18.129 with HTTP; Wed, 16 Aug 2017 12:27:24 -0700 (PDT) In-Reply-To: <83h8x7fo1x.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> <83r2wbfus5.fsf@gnu.org> <83h8x7fo1x.fsf@gnu.org> From: Noam Postavsky Date: Wed, 16 Aug 2017 15:27:24 -0400 X-Google-Sender-Auth: D8rLmbM3cSLqQFUo349HFx4XmOg Message-ID: Subject: Re: bug#25025: python-shell-calculate-command is wrong To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 25025 Cc: 25025@debbugs.gnu.org, =?UTF-8?B?Q2zDqW1lbnQgUGl0LS1DbGF1ZGVs?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On Wed, Aug 16, 2017 at 12:57 PM, Eli Zaretskii wrote: > > I see, thanks. So I guess all it (maybe) tests is that > python-shell-interpreter and what executable-find returns are > identical? Is that something that could somehow fail and would be > useful to verify? No, python-shell-interpreter is by default just "python", not an absolute filename, so it shouldn't match with executable-find. The test is let-binding python-shell-interpreter anyway: (defvar python-tests-shell-interpreter "python") ... (ert-deftest python-shell-calculate-command-1 () ... (skip-unless (executable-find python-tests-shell-interpreter)) (let ((python-shell-interpreter (executable-find python-tests-shell-interpreter)) ... > If not, I agree to removing the test. Okay, I'll push in a few days. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 16:44:24 2017 Received: (at 25025-quiet) by debbugs.gnu.org; 20 Aug 2017 20:44:24 +0000 Received: from localhost ([127.0.0.1]:46991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djX55-0008OR-SR for submit@debbugs.gnu.org; Sun, 20 Aug 2017 16:44:24 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:38119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djX54-0008OF-Ku for 25025-quiet@debbugs.gnu.org; Sun, 20 Aug 2017 16:44:23 -0400 Received: by mail-io0-f169.google.com with SMTP id g71so46607939ioe.5 for <25025-quiet@debbugs.gnu.org>; Sun, 20 Aug 2017 13:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+57fYGYDDtHuJsD8lsBdm15av6DSPllevG6ePGmigdQ=; b=NyOgYd74Jjn7E8Q8ZwcgXH+EjEi6weFmnOLyg2DdKRGS+v8MnPZ6uCu2NuGP2bM3xX 7iuLjmV3xBo5pMq4/dRRbD771E0jLurC4mUNok2HPpW635EBJRs1qKSDEcK6HbcDuvRu aSQSdLm/s7xkyKqCYiHPLPj8NFJKlfIplZNUXLEorb1sFGrHMrPoeg8qR6PtxIuFNnk9 MSZjX5E5+gMeP+3VmzAuEiH1gLkeryLzvWtQ22/B0hLOWAhVd/npdj1lvBLS0+yM/XIu g6hcJUkd5qQqp3d6Eq1/vxUSnBc0cNPkrHxXmfa3l+06WbVIuBPMRKSbIibAb9rIDowx BWoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=+57fYGYDDtHuJsD8lsBdm15av6DSPllevG6ePGmigdQ=; b=MdUXgeN1YNkUeqYyd/mQ/gmdKwLgwVhqNtluCjEECXLpKIa77SoSEtN2zZRc4MP34m oCb3G+9Qut39EYf1F4PPQ20J+i15Zi34oRAwfYTIYDKGSw/tqC570jSxtUQ/01GdFAT8 9oMdPq6FP2HXWywhjowCuIjwbFpzEg1bWnTIVI+oLV9mG6EPDzpnpIIcaBGGzc/29g57 jE/Cm224lVMzITWSNg4jEZZLgNCtziNcPyWMwAfQ/iY6zk9OAlCupBBAm68qlTd4t3Nh xKYpbCKVKzALMC054Ss5dGpJ7Vqpg1NynJjyWyl/OpHZvSwuipwskH7N9PEGdYLx2jAz PEDw== X-Gm-Message-State: AHYfb5hAafsYzPdbxRzLfnKBNOsKfT5jkVDmshG+OXihE+lmdrBGdBvO 3bf2WqrdU6sriJes X-Received: by 10.107.169.193 with SMTP id f62mr15433733ioj.205.1503261856871; Sun, 20 Aug 2017 13:44:16 -0700 (PDT) Received: from zony ([45.2.119.49]) by smtp.googlemail.com with ESMTPSA id f11sm2505916itf.1.2017.08.20.13.44.15 for <25025-quiet@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Aug 2017 13:44:16 -0700 (PDT) From: npostavs@users.sourceforge.net To: 25025-quiet@debbugs.gnu.org Subject: Re: bug#25025: python-shell-calculate-command is wrong References: <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> <83r2wbfus5.fsf@gnu.org> <83h8x7fo1x.fsf@gnu.org> Date: Sun, 20 Aug 2017 16:45:53 -0400 In-Reply-To: (Noam Postavsky's message of "Wed, 16 Aug 2017 15:27:24 -0400") Message-ID: <87wp5y9ddq.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 25025-quiet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) > Okay, I'll push in a few days. [1: cdfe1cbca7]: 2017-08-20 16:42:15 -0400 ; Remove python-shell-calculate-command-1 test http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cdfe1cbca73925800c7be8e7e8073ef86374e654> From unknown Fri Jun 20 05:29:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 18 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator