GNU bug report logs - #25022
25.1.50; Different highlighting for different citation level in message-mode

Previous Next

Package: emacs;

Reported by: Hong Xu <hong <at> topbug.net>

Date: Thu, 24 Nov 2016 23:23:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 25124

Found in version 25.1.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #33 received at 25022 <at> debbugs.gnu.org (full text, mbox):

From: Hong Xu <hong <at> topbug.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 25022 <at> debbugs.gnu.org
Subject: Re: bug#25022: 25.1.50;
 Different highlighting for different citation level in message-mode
Date: Tue, 06 Dec 2016 11:57:27 -0800
[Message part 1 (text/plain, inline)]
On 2016-12-06 Tue 07:51 GMT-0800, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> If you change the condition to be true for any mode derived from
>> message-mode, then all of them will inherit this feature.  Are we sure
>> those other modes all want that?  For example, gnus-art.el defines one
>> such mode; up until now, that mode didn't use this feature, maybe that
>> was for a good reason?
>
> No, I don't think that was on purpose.  I probably just didn't know
> about derived-mode-p at the time...

I've already proposed the one-line change in #25124. You can commit
directly since this is just one line...

I saw a comment "FIXME: use derived-mode-p" but I'm not sure why it
wasn't changed directly on the code itself.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 5 years and 239 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.