GNU bug report logs - #25022
25.1.50; Different highlighting for different citation level in message-mode

Previous Next

Package: emacs;

Reported by: Hong Xu <hong <at> topbug.net>

Date: Thu, 24 Nov 2016 23:23:02 UTC

Severity: minor

Tags: fixed, patch

Merged with 25124

Found in version 25.1.50

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hong Xu <hong <at> topbug.net>
Subject: bug#25022: closed (Re: bug#25022: 25.1.50; Different highlighting
 for different citation level in message-mode)
Date: Tue, 06 Dec 2016 09:19:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#25022: 25.1.50; Different highlighting for different citation level in message-mode

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 25022 <at> debbugs.gnu.org.

-- 
25022: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=25022
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Hong Xu <hong <at> topbug.net>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: 25022-done <at> debbugs.gnu.org
Subject: Re: bug#25022: 25.1.50;
 Different highlighting for different citation level in message-mode
Date: Tue, 06 Dec 2016 01:17:35 -0800
[Message part 3 (text/plain, inline)]
On 2016-12-05 Mon 23:39 GMT-0800, Katsumi Yamaoka <yamaoka <at> jpl.org> wrote:

> On Mon, 05 Dec 2016 22:08:46 -0800, Hong Xu wrote:
>> On 2016-11-24 Thu 15:22 GMT-0800, Hong Xu <hong <at> topbug.net> wrote:
>>> Currently in message-mode all cited texts are highlighted in the same
>>> way. It would be nicer if the highlighting of different citation levels
>>> can be easily customized.
>
>> Here is a patch and a screenshot. The default colors I chose may not be
>> optimal -- but I guess I'll leave that part to professionals.
>
>> Add support for different faces for different citation levels in message-mode.
>
> Isn't it redundant as there is this already? ;-)
>
> (defcustom gnus-message-highlight-citation
>   t ;; gnus-treat-highlight-citation ;; gnus-cite dependency
>   "Enable highlighting of different citation levels in message-mode."
>   :version "23.1" ;; No Gnus
>   :group 'gnus-cite
>   :group 'gnus-message
>   :type 'boolean)
>
> Here is my message-mode view:

I see the reason: gnus-message-citation-mode should see whether the
current major mode is derived from message-mode, rather than equal. I'll
probably find another fix later.
[signature.asc (application/pgp-signature, inline)]
[Message part 5 (message/rfc822, inline)]
From: Hong Xu <hong <at> topbug.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50;
 Different highlighting for different citation level in message-mode
Date: Thu, 24 Nov 2016 15:22:15 -0800
Currently in message-mode all cited texts are highlighted in the same
way. It would be nicer if the highlighting of different citation levels
can be easily customized.

In GNU Emacs 25.1.50.13 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5)
 of 2016-11-24 built on home
Repository revision: 7f43d7c0101256b120ead3ddae6ee47327d231c9
Windowing system distributor 'The X.Org Foundation', version 11.0.11604000
System Description:	Debian GNU/Linux 8.6 (jessie)

Configured using:
 'configure --with-modules --with-xwidgets
 --prefix=/home/hong/.local/opt/emacs/
 '--program-transform-name=s/^ctags$/ctags.emacs/''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES XWIDGETS




This bug report was last modified 5 years and 240 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.