From unknown Wed Aug 20 06:40:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#25000 <25000@debbugs.gnu.org> To: bug#25000 <25000@debbugs.gnu.org> Subject: Status: 26.0.50; Ibuffer might compare marks case insensitively Reply-To: bug#25000 <25000@debbugs.gnu.org> Date: Wed, 20 Aug 2025 13:40:23 +0000 retitle 25000 26.0.50; Ibuffer might compare marks case insensitively reassign 25000 emacs submitter 25000 Tino Calancha severity 25000 normal tag 25000 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 23 07:11:51 2016 Received: (at submit) by debbugs.gnu.org; 23 Nov 2016 12:11:52 +0000 Received: from localhost ([127.0.0.1]:38940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9WP1-0007JJ-Lg for submit@debbugs.gnu.org; Wed, 23 Nov 2016 07:11:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9WP0-0007J8-Mn for submit@debbugs.gnu.org; Wed, 23 Nov 2016 07:11:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9WOu-0006OJ-F8 for submit@debbugs.gnu.org; Wed, 23 Nov 2016 07:11:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59211) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9WOu-0006OB-Bg for submit@debbugs.gnu.org; Wed, 23 Nov 2016 07:11:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9WOs-0001Jf-VO for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2016 07:11:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9WOo-0006KU-0I for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2016 07:11:42 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:33286) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c9WOn-0006Jv-Q0 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2016 07:11:37 -0500 Received: by mail-pf0-x244.google.com with SMTP id 144so662437pfv.0 for ; Wed, 23 Nov 2016 04:11:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=hnRJUcXPVticgRLTm6mgJVig3HfVZ1a+1kLiQYMNylU=; b=s5g9c1u0Dy9uJAcfeYRqQYxhLjhwA3gSWz5EqILvLoYcdTmxDTGxPkjfWbg+dbWd1Z 63EJU8q3hd875rW+6dPaiADXUGMi0aZ/OcczmCL8YEr5Us54t9rFFoFXtO8216selbUA gZ5JrFAKDClzTnxdUwLJForA6EjkjjYFt8kfk99nOzKVLRyJr/NOOF+nTyJ9Ycd5eRDn BS56V7qJJhc1HovV813/k7aI3RSAejUNLknkyLlowfR1gE0XKOVFS+14CiADa5fY6HIb 3gmdb3qo6Di660pFaGKn47/x0qiMizUnUBnspPTEGb2+6GtFeLpJBvvNxUWb4mmfNJN3 KtYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=hnRJUcXPVticgRLTm6mgJVig3HfVZ1a+1kLiQYMNylU=; b=h65c0jJBaxHKCnlGHKn497xwCfGFzKsMdD6GxbhgDUW1+ZlpUAFnvWWuazkZK0xJaA E7VQyWLG0HDhw7a3+9RFUoO8ujy9Qx4SeVkGdhxtMyYSKJru7mfI/u11NxbrJl0V2W40 U++d4308HOtDM4LfiG/2yh23Qy/JAMDF2RbfvhQViVUKWQNow6Oy7lzjVTkRVNn9IPKN rwlUIRwE3qdZt54zr+VJlX91s3gH0PNvRGZWVlQLcpDOzq4IywbsxdUbw1FOrjuCuR/z 5ypU8MkZqnVTl0vncepIMSWSFLL7goBQ8pfNGHEt4KDQ9HAQHu1mS9ZYBXxSzAFEuh7q YbjQ== X-Gm-Message-State: AKaTC015vjz89aHeTIVc9krPa9L3/FNYs21sGzGR8Q27OVfOfZzU8sXFJ8ZpKa8VM35tZw== X-Received: by 10.84.129.131 with SMTP id b3mr5952066plb.54.1479903096425; Wed, 23 Nov 2016 04:11:36 -0800 (PST) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id 189sm34605681pgh.5.2016.11.23.04.11.34 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 23 Nov 2016 04:11:36 -0800 (PST) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Ibuffer might compare marks case insensitively Date: Wed, 23 Nov 2016 21:11:21 +0900 Message-ID: <87eg22gzva.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) In Ibuffer mark comparisons should be case _sensitive_. emacs -Q: ;; eval following form: (let ((case-fold-search t)) (ibuffer) (ibuffer-mark-by-name-regexp "scratch") (ibuffer-change-marks ibuffer-marked-char ?L) (ibuffer-mark-by-name-regexp "Messages") (ibuffer-change-marks ibuffer-marked-char ?l) (null (cdr (ibuffer-buffer-names-with-mark ?l)))) => nil ;; It doesn't distinguish between mark "L" and "l". ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From a6275e8e966c4f58e30f7aa3787557961385c6dc Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 23 Nov 2016 21:04:31 +0900 Subject: [PATCH] ibuffer: compare marks with EQ * lisp/ibuffer (ibuffer-update-title-and-summary, ibuffer-redisplay-current) (ibuffer-buffer-name-face, ibuffer-unmark-all) (ibuffer-count-deletion-lines, ibuffer-buffer-names-with-mark): Use 'eq' instead of 'char-equal' when comparing mark characters (Bug#25000). --- lisp/ibuffer.el | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el index 51d7cb9..4268be3 100644 --- a/lisp/ibuffer.el +++ b/lisp/ibuffer.el @@ -1236,7 +1236,7 @@ ibuffer-buffer-names-with-mark (let ((ibuffer-buffer-names-with-mark-result nil)) (ibuffer-map-lines-nomodify (lambda (buf mk) - (when (char-equal mark mk) + (when (eq mark mk) (push (buffer-name buf) ibuffer-buffer-names-with-mark-result)))) ibuffer-buffer-names-with-mark-result)) @@ -1251,15 +1251,15 @@ ibuffer-count-marked-lines (if all (ibuffer-map-lines-nomodify (lambda (_buf mark) - (not (char-equal mark ?\s)))) + (not (eq mark ?\s)))) (ibuffer-map-lines-nomodify (lambda (_buf mark) - (char-equal mark ibuffer-marked-char))))) + (eq mark ibuffer-marked-char))))) (defsubst ibuffer-count-deletion-lines () (ibuffer-map-lines-nomodify (lambda (_buf mark) - (char-equal mark ibuffer-deletion-char)))) + (eq mark ibuffer-deletion-char)))) (defsubst ibuffer-map-deletion-lines (func) (ibuffer-map-on-mark ibuffer-deletion-char func)) @@ -1338,26 +1338,26 @@ ibuffer-unmark-all (if (= (ibuffer-count-marked-lines t) 0) (message "No buffers marked; use 'm' to mark a buffer") (cond - ((char-equal mark ibuffer-marked-char) + ((eq mark ibuffer-marked-char) (ibuffer-map-marked-lines (lambda (_buf _mark) (ibuffer-set-mark-1 ?\s) t))) - ((char-equal mark ibuffer-deletion-char) + ((eq mark ibuffer-deletion-char) (ibuffer-map-deletion-lines (lambda (_buf _mark) (ibuffer-set-mark-1 ?\s) t))) - ((not (char-equal mark ?\r)) + ((not (eq mark ?\r)) (ibuffer-map-lines (lambda (_buf cmark) - (when (char-equal cmark mark) + (when (eq cmark mark) (ibuffer-set-mark-1 ?\s)) t))) (t (ibuffer-map-lines (lambda (_buf mark) - (when (not (char-equal mark ?\s)) + (when (not (eq mark ?\s)) (ibuffer-set-mark-1 ?\s)) t))))) (ibuffer-redisplay t)) @@ -1908,9 +1908,9 @@ ibuffer-format-column (_ (concat str left right))))) (defun ibuffer-buffer-name-face (buf mark) - (cond ((char-equal mark ibuffer-marked-char) + (cond ((eq mark ibuffer-marked-char) ibuffer-marked-face) - ((char-equal mark ibuffer-deletion-char) + ((eq mark ibuffer-deletion-char) ibuffer-deletion-face) (t (let ((level -1) @@ -1954,7 +1954,7 @@ ibuffer-redisplay-current (defun ibuffer-map-on-mark (mark func) (ibuffer-map-lines (lambda (buf mk) - (if (char-equal mark mk) + (if (eq mark mk) (funcall func buf mark) nil)))) @@ -2181,8 +2181,8 @@ ibuffer-update-title-and-summary (buffer-substring (point) (line-end-position))))) (apply #'insert (mapcar (lambda (c) - (if (not (or (char-equal c ?\s) - (char-equal c ?\n))) + (if (not (or (eq c ?\s) + (eq c ?\n))) ?- ?\s)) str))) -- 2.10.2 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.7 (x86_64-pc-linux-gnu, GTK+ Version 3.22.3) of 2016-11-23 built on calancha-pc Repository revision: c542fab20f53374dd0c71dce949ef370fc76fa48 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 23 10:53:37 2016 Received: (at 25000) by debbugs.gnu.org; 23 Nov 2016 15:53:37 +0000 Received: from localhost ([127.0.0.1]:39438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Zrd-0005im-BG for submit@debbugs.gnu.org; Wed, 23 Nov 2016 10:53:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9Zrc-0005ib-Eu for 25000@debbugs.gnu.org; Wed, 23 Nov 2016 10:53:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9ZrT-0005zT-BE for 25000@debbugs.gnu.org; Wed, 23 Nov 2016 10:53:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56355) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9ZrT-0005zJ-7i; Wed, 23 Nov 2016 10:53:27 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2477 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c9ZrS-0004Ns-I3; Wed, 23 Nov 2016 10:53:27 -0500 Date: Wed, 23 Nov 2016 17:53:11 +0200 Message-Id: <83d1hm6vmg.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87eg22gzva.fsf@gmail.com> (message from Tino Calancha on Wed, 23 Nov 2016 21:11:21 +0900) Subject: Re: bug#25000: 26.0.50; Ibuffer might compare marks case insensitively References: <87eg22gzva.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: 25000 Cc: 25000@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) > From: Tino Calancha > Date: Wed, 23 Nov 2016 21:11:21 +0900 > > >From a6275e8e966c4f58e30f7aa3787557961385c6dc Mon Sep 17 00:00:00 2001 > From: Tino Calancha > Date: Wed, 23 Nov 2016 21:04:31 +0900 > Subject: [PATCH] ibuffer: compare marks with EQ > > * lisp/ibuffer (ibuffer-update-title-and-summary, ibuffer-redisplay-current) > (ibuffer-buffer-name-face, ibuffer-unmark-all) > (ibuffer-count-deletion-lines, ibuffer-buffer-names-with-mark): > Use 'eq' instead of 'char-equal' when comparing mark characters (Bug#25000). > --- > lisp/ibuffer.el | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) Thanks, but please add a test for this. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 06:42:27 2016 Received: (at 25000-done) by debbugs.gnu.org; 7 Dec 2016 11:42:27 +0000 Received: from localhost ([127.0.0.1]:58887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEacF-0001AJ-FQ for submit@debbugs.gnu.org; Wed, 07 Dec 2016 06:42:27 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cEacE-0001A1-6r for 25000-done@debbugs.gnu.org; Wed, 07 Dec 2016 06:42:26 -0500 Received: by mail-pg0-f67.google.com with SMTP id x23so23282326pgx.3 for <25000-done@debbugs.gnu.org>; Wed, 07 Dec 2016 03:42:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=7mQTnDqVrsBk1UrSm4wMjw/ydbGCD9SuUANQCUdsLo8=; b=FglzM6TSiC8iJ9vieJk2kayiUQHxWkc2D72hsYMSzFRneeSnSOnqkv9NUOf4NecP/N p7HydrCLAUxaVsFC6qdIHgw8ogj9TW1T+2QT5mUu3lvtObdaVTC/K/e91GJGv8k8GYSo 9X/oast2k0899r/wS2WYiLpKS14cHtdrxXnly6/KF3/VqJrlSTE1+R1mHVmUntwb4qIf kfBXuXM6Q52w3mEpsEIuQS1j+O1tMbOCMPvFBz34w1ARHEo0gXNQ3Stzz/lEO72vE9Wx g1hOxq/FfbhmeqyBsS0T4GwHrjGObOD1QuZvE6gR44OeWjUL2KyOu7KN37E9nXeQ648Y JUjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7mQTnDqVrsBk1UrSm4wMjw/ydbGCD9SuUANQCUdsLo8=; b=bXfDVB3soWEsOiZOGeUg6t45zuB2r9qs232rTb2GAXzYHunUmOW6obGR6+dS/BqX9/ BZFuZIJl8dKX/DX2jNvYL1cPp2z1yQ0kVPj+I8khKLjf5iR0DiDBk5rRk67kjK6uK1yS BER5I+OQYDwcvRoDd9A/jLxXsGokQAbGm1iXzYp6y79VgipTW26n4/oS+DTA0nRk+TQP MCGnevwbo7wLbaS2XEUKl+EXjRiLuzzmJNL3dNyBiTV9Qxrmsb7JXBWZw/o2QjkhkLb5 TwLA69O7Ip/03yzYe0dJU+ANjfB4E7vcijpfKTjjFybs/Y7OoFqlzljP8rCjQdpVIkvD cAYA== X-Gm-Message-State: AKaTC03Fsdrk2P2z0zebyEqYYqTzEQYNli5mPXTguk2ZzZZ2S5lcMjAxDRZ0YHBIZAzA6A== X-Received: by 10.99.157.129 with SMTP id i123mr120107591pgd.148.1481110940294; Wed, 07 Dec 2016 03:42:20 -0800 (PST) Received: from calancha-pc (pl676.nas813.p-iwate.nttpc.ne.jp. [124.154.237.164]) by smtp.gmail.com with ESMTPSA id f3sm5304322pga.45.2016.12.07.03.42.18 for <25000-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Dec 2016 03:42:19 -0800 (PST) From: Tino Calancha To: 25000-done@debbugs.gnu.org Subject: Re: bug#25000: 26.0.50; Ibuffer might compare marks case insensitively References: <87eg22gzva.fsf@gmail.com> <83d1hm6vmg.fsf@gnu.org> Date: Wed, 07 Dec 2016 20:42:04 +0900 In-Reply-To: <83d1hm6vmg.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Nov 2016 17:53:11 +0200") Message-ID: <87mvg8hsoj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 25000-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Eli Zaretskii writes: > Thanks, but please add a test for this. Added test and pushed to master as commit 586867e From unknown Wed Aug 20 06:40:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Jan 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator