GNU bug report logs - #24985
Add missing provide statements

Previous Next

Full log

View this message in rfc822 format

From: Philippe Vaucher <philippe.vaucher <at> gmail.com>
To: 24985 <at> debbugs.gnu.org
Subject: bug#24985: Add missing provide statements
Date: Tue, 22 Nov 2016 11:42:18 +0100

[Message part 1 (text/plain, inline)]

Hello,

While correcting misuse of `eval-after-load' in some libraries, we
discovered that `text-mode' does not `provide' itself as a feature.

That forces people to use `eval-after-load' with a string (filename),
instead of a symbol (feature), which is the better form. It is the better
form because with a string, any file named the same way triggers the
eval-after-load which is problematic for custom configurations named after
packages.

Original thread at https://github.com/magnars/expand-region.el/pull/212

I used the following command to figure out which other files might need
additional `provide' statements:

grep -rL '(provide' ~/work/emacs/lisp | xargs egrep 'define-[^ ]+-mode' |
grep -v ChangeLog

Thanks,
Philippe

[Message part 2 (text/html, inline)]

[0001-Add-missing-provide-statements.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.