GNU bug report logs - #24985
Add missing provide statements

Previous Next

Full log

Message #11 received at 24985 <at> debbugs.gnu.org (full text, mbox):

From: Philippe Vaucher <philippe.vaucher <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 24985 <at> debbugs.gnu.org
Subject: Re: bug#24985: Add missing provide statements
Date: Tue, 22 Nov 2016 14:58:19 +0100

[Message part 1 (text/plain, inline)]

>
> >  (defalias 'toggle-auto-composition 'auto-composition-mode)
> >
> > +(provide 'auto-composition-mode)
>
> Why that? I would expect (provide 'composite) here.
>

I thought that the most interesting thing in composite was
auto-composition-mode... same reasoning for replace.el which provided
'occur in my first patch.

Anyway, you're right, it's not very consistent. Here attached is a new
patch that simply follows the file name.

In the future, I think we should consider renaming/splitting these files so
each mode provide its feature (e.g occur provides 'occur, etc).

Best regards,
Philippe

[Message part 2 (text/html, inline)]

[0001-Add-missing-provide-statements.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.