From unknown Tue Jun 24 05:12:18 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2495: 23.0.91; regression in M-x flush-lines Reply-To: Andreas Seltenreich , 2495@debbugs.gnu.org Resent-From: Andreas Seltenreich Original-Sender: Andreas Seltenreich Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 27 Feb 2009 13:25:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 2495 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123574084425689 (code B ref -1); Fri, 27 Feb 2009 13:25:07 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 27 Feb 2009 13:20:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1RDKeoM025678 for ; Fri, 27 Feb 2009 05:20:42 -0800 Received: from mx10.gnu.org ([199.232.76.166]:53949) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Ld2bd-0006xy-SY for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 08:18:22 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ld2dr-0001cd-FN for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 08:20:39 -0500 Received: from smtp2.rz.uni-karlsruhe.de ([129.13.185.218]:49242) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ld2dr-0001c7-4D for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 08:20:39 -0500 Received: from rzstud2.stud.uni-karlsruhe.de (rzstud2.stud.uni-karlsruhe.de [193.196.41.42]) by smtp2.rz.uni-karlsruhe.de with esmtps (Exim 4.63 #1) id 1Ld2do-0003fF-8V; Fri, 27 Feb 2009 14:20:36 +0100 Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.63) (envelope-from ) id 1Ld2dn-0003N6-Vd for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 14:20:36 +0100 From: Andreas Seltenreich To: emacs-pretest-bug@gnu.org User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.91 (gnu/linux) X-Hashcash: 1:26:090227:emacs-pretest-bug@gnu.org::6kcSqzDccKPnC/+O:00000000kOUk Date: Fri, 27 Feb 2009 14:20:35 +0100 Message-ID: <874oyg8198.fsf@gate450.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Andreas Seltenreich X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. > Please describe exactly what actions triggered the bug emacs -Q M-< ; beginning of *scratch* buffer M-x flush-lines RET RET > and the precise symptoms of the bug: Lines matching the empty regexp are not flushed. This used to work in older releases. Thanks, andreas > If Emacs crashed, and you have the Emacs process in the gdb debugger, > please include the output from the following gdb commands: > `bt full' and `xbacktrace'. > If you would like to further debug the crash, please read the file > /home/andreas/ext/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.91.2 (x86_64-unknown-linux-gnu, X toolkit) of 2009-02-26 on tengen configured using `configure '--enable-debug' --enable-ltdl-convenience' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t gnus-topic-mode: t gnus-undo-mode: t global-hi-lock-mode: t hi-lock-mode: t show-paren-mode: t rcirc-track-minor-mode: t display-time-mode: t savehist-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t abbrev-mode: t From unknown Tue Jun 24 05:12:18 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Andreas Seltenreich Subject: bug#2495 closed by Chong Yidong (Re: 23.0.91; regression in M-x flush-lines) Message-ID: References: <87fxhzzygm.fsf@cyd.mit.edu> <874oyg8198.fsf@gate450.dyndns.org> X-Emacs-PR-Message: they-closed 2495 X-Emacs-PR-Package: emacs Reply-To: 2495@debbugs.gnu.org Date: Fri, 27 Feb 2009 15:35:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1235748904-31331-1" This is a multi-part message in MIME format... ------------=_1235748904-31331-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #2495: 23.0.91; regression in M-x flush-lines It has been closed by Chong Yidong . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Chong Yidong by replying to this email. --=20 2495: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2495 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1235748904-31331-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2495-done) by emacsbugs.donarmstrong.com; 27 Feb 2009 15:32:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1RFWQEi031167 for <2495-done@emacsbugs.donarmstrong.com>; Fri, 27 Feb 2009 07:32:27 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 343F357E20C; Fri, 27 Feb 2009 10:33:29 -0500 (EST) From: Chong Yidong To: Andreas Seltenreich Cc: 2495-done@debbugs.gnu.org Subject: Re: 23.0.91; regression in M-x flush-lines Date: Fri, 27 Feb 2009 10:33:29 -0500 Message-ID: <87fxhzzygm.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > emacs -Q > M-< ; beginning of *scratch* buffer > M-x flush-lines RET RET > > Lines matching the empty regexp are not flushed. This used to work in > older releases. Thanks for spotting this. I've checked in a fix to CVS. ------------=_1235748904-31331-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 27 Feb 2009 13:20:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1RDKeoM025678 for ; Fri, 27 Feb 2009 05:20:42 -0800 Received: from mx10.gnu.org ([199.232.76.166]:53949) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Ld2bd-0006xy-SY for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 08:18:22 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Ld2dr-0001cd-FN for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 08:20:39 -0500 Received: from smtp2.rz.uni-karlsruhe.de ([129.13.185.218]:49242) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Ld2dr-0001c7-4D for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 08:20:39 -0500 Received: from rzstud2.stud.uni-karlsruhe.de (rzstud2.stud.uni-karlsruhe.de [193.196.41.42]) by smtp2.rz.uni-karlsruhe.de with esmtps (Exim 4.63 #1) id 1Ld2do-0003fF-8V; Fri, 27 Feb 2009 14:20:36 +0100 Received: from uwi7 by rzstud2.stud.uni-karlsruhe.de with local (Exim 4.63) (envelope-from ) id 1Ld2dn-0003N6-Vd for emacs-pretest-bug@gnu.org; Fri, 27 Feb 2009 14:20:36 +0100 From: Andreas Seltenreich To: emacs-pretest-bug@gnu.org Subject: 23.0.91; regression in M-x flush-lines User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.91 (gnu/linux) X-Hashcash: 1:26:090227:emacs-pretest-bug@gnu.org::6kcSqzDccKPnC/+O:00000000kOUk Date: Fri, 27 Feb 2009 14:20:35 +0100 Message-ID: <874oyg8198.fsf@gate450.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Andreas Seltenreich X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > Please write in English if possible, because the Emacs maintainers > usually do not have translators to read other languages for them. > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. > Please describe exactly what actions triggered the bug emacs -Q M-< ; beginning of *scratch* buffer M-x flush-lines RET RET > and the precise symptoms of the bug: Lines matching the empty regexp are not flushed. This used to work in older releases. Thanks, andreas > If Emacs crashed, and you have the Emacs process in the gdb debugger, > please include the output from the following gdb commands: > `bt full' and `xbacktrace'. > If you would like to further debug the crash, please read the file > /home/andreas/ext/emacs/etc/DEBUG for instructions. In GNU Emacs 23.0.91.2 (x86_64-unknown-linux-gnu, X toolkit) of 2009-02-26 on tengen configured using `configure '--enable-debug' --enable-ltdl-convenience' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: diff-auto-refine-mode: t shell-dirtrack-mode: t gnus-topic-mode: t gnus-undo-mode: t global-hi-lock-mode: t hi-lock-mode: t show-paren-mode: t rcirc-track-minor-mode: t display-time-mode: t savehist-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t abbrev-mode: t ------------=_1235748904-31331-1-- From unknown Tue Jun 24 05:12:18 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2495: 23.0.91; regression in M-x flush-lines Reply-To: Glenn Morris , 2495@debbugs.gnu.org Resent-From: Glenn Morris Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 27 Feb 2009 21:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2495 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 2495-submit@emacsbugs.donarmstrong.com id=B2495.12357710168103 (code B ref 2495); Fri, 27 Feb 2009 21:50:03 +0000 Received: (at 2495) by emacsbugs.donarmstrong.com; 27 Feb 2009 21:43:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1RLhUGu008097 for <2495@emacsbugs.donarmstrong.com>; Fri, 27 Feb 2009 13:43:32 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LdASF-0004Bf-1z; Fri, 27 Feb 2009 16:41:11 -0500 From: Glenn Morris To: Andreas Seltenreich Cc: 2495@debbugs.gnu.org References: <874oyg8198.fsf@gate450.dyndns.org> X-Spook: pre-emptive Roswell Watergate infowar BLU-114/B gamma X-Ran: 23SmM!36s=iszG`Z-\~:~]|gV>""v=NKd (Andreas Seltenreich's message of "Fri, 27 Feb 2009 14:20:35 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Andreas Seltenreich wrote: > emacs -Q > M-< ; beginning of *scratch* buffer > M-x flush-lines RET RET In 22.3, this used read-from-minibuffer, which returns the empty string in case of no input. Now it used read-regexp, which returns nil in case of no input (if no default is supplied). That doesn't seem right. Perhaps this: *** replace.el 9 Jan 2009 05:01:00 -0000 1.282 --- replace.el 27 Feb 2009 21:41:59 -0000 *************** *** 556,562 **** (format "%s: " prompt)) nil nil nil 'regexp-history defaults t))) (if (equal input "") ! default-value (prog1 input (add-to-history 'regexp-history input))))) --- 556,562 ---- (format "%s: " prompt)) nil nil nil 'regexp-history defaults t))) (if (equal input "") ! (or default-value input) (prog1 input (add-to-history 'regexp-history input))))) From juri@jurta.org Wed Aug 5 13:16:48 2009 Received: (at control) by emacsbugs.donarmstrong.com; 5 Aug 2009 20:16:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from mx1.starman.ee (smtp-out1.starman.ee [85.253.0.3]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n75KGc1i014883; Wed, 5 Aug 2009 13:16:40 -0700 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.69.104.cable.starman.ee [82.131.69.104]) by mx1.starman.ee (Postfix) with ESMTP id DA8993F401F; Wed, 5 Aug 2009 23:16:32 +0300 (EEST) From: Juri Linkov To: Glenn Morris Cc: 2495@debbugs.gnu.org, Andreas Seltenreich Subject: Re: bug#2495: 23.0.91; regression in M-x flush-lines Organization: JURTA References: <874oyg8198.fsf@gate450.dyndns.org> Date: Wed, 05 Aug 2009 23:14:18 +0300 In-Reply-To: (Glenn Morris's message of "Fri, 27 Feb 2009 16:41:10 -0500") Message-ID: <87tz0mf279.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii unarchive 2495 thanks >> emacs -Q >> M-< ; beginning of *scratch* buffer >> M-x flush-lines RET RET > > In 22.3, this used read-from-minibuffer, which returns the empty > string in case of no input. > > Now it used read-regexp, which returns nil in case of no input (if no > default is supplied). That doesn't seem right. > > Perhaps this: > > *** replace.el 9 Jan 2009 05:01:00 -0000 1.282 > --- replace.el 27 Feb 2009 21:41:59 -0000 > *************** > *** 556,562 **** > (format "%s: " prompt)) > nil nil nil 'regexp-history defaults t))) > (if (equal input "") > ! default-value > (prog1 input > (add-to-history 'regexp-history input))))) > > --- 556,562 ---- > (format "%s: " prompt)) > nil nil nil 'regexp-history defaults t))) > (if (equal input "") > ! (or default-value input) > (prog1 input > (add-to-history 'regexp-history input))))) Currently flush-lines always displays the misleading prompt Flush lines containing match for regexp (default ): ========== where default is empty that makes no sense without a real default value. I think Glenn provided the correct patch (seen above). -- Juri Linkov http://www.jurta.org/emacs/