GNU bug report logs - #2495
23.0.91; regression in M-x flush-lines

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2495 in the body.
You can then email your comments to 2495 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Andreas Seltenreich <seltenreich <at> gmx.de>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.91; regression in M-x flush-lines
Date: Fri, 27 Feb 2009 14:20:35 +0100

> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.

> Your bug report will be posted to the emacs-pretest-bug <at> gnu.org mailing list.

> Please describe exactly what actions triggered the bug

emacs -Q
M-< ; beginning of *scratch* buffer
M-x flush-lines RET RET

> and the precise symptoms of the bug:

Lines matching the empty regexp are not flushed.  This used to work in
older releases.

Thanks,
andreas

> If Emacs crashed, and you have the Emacs process in the gdb debugger,
> please include the output from the following gdb commands:
>     `bt full' and `xbacktrace'.
> If you would like to further debug the crash, please read the file
> /home/andreas/ext/emacs/etc/DEBUG for instructions.

In GNU Emacs 23.0.91.2 (x86_64-unknown-linux-gnu, X toolkit)
 of 2009-02-26 on tengen
configured using `configure  '--enable-debug' --enable-ltdl-convenience'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: C
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Group

Minor modes in effect:
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  show-paren-mode: t
  rcirc-track-minor-mode: t
  display-time-mode: t
  savehist-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  abbrev-mode: t

Message #10 received at 2495-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Andreas Seltenreich <seltenreich <at> gmx.de>
Cc: 2495-done <at> debbugs.gnu.org
Subject: Re: 23.0.91; regression in M-x flush-lines
Date: Fri, 27 Feb 2009 10:33:29 -0500

> emacs -Q
> M-< ; beginning of *scratch* buffer
> M-x flush-lines RET RET
>
> Lines matching the empty regexp are not flushed.  This used to work in
> older releases.

Thanks for spotting this.  I've checked in a fix to CVS.

Message #13 received at 2495 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Andreas Seltenreich <seltenreich <at> gmx.de>
Cc: 2495 <at> debbugs.gnu.org
Subject: Re: bug#2495: 23.0.91; regression in M-x flush-lines
Date: Fri, 27 Feb 2009 16:41:10 -0500

Andreas Seltenreich wrote:

> emacs -Q
> M-< ; beginning of *scratch* buffer
> M-x flush-lines RET RET

In 22.3, this used read-from-minibuffer, which returns the empty
string in case of no input.

Now it used read-regexp, which returns nil in case of no input (if no
default is supplied). That doesn't seem right.

Perhaps this:


*** replace.el	9 Jan 2009 05:01:00 -0000	1.282
--- replace.el	27 Feb 2009 21:41:59 -0000
***************
*** 556,562 ****
  	     (format "%s: " prompt))
  	   nil nil nil 'regexp-history defaults t)))
      (if (equal input "")
! 	default-value
        (prog1 input
  	(add-to-history 'regexp-history input)))))
  
--- 556,562 ----
  	     (format "%s: " prompt))
  	   nil nil nil 'regexp-history defaults t)))
      (if (equal input "")
! 	(or default-value input)
        (prog1 input
  	(add-to-history 'regexp-history input)))))

Message #22 received at 2495 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: 2495 <at> debbugs.gnu.org
Subject: Re: bug#2495: 23.0.91; regression in M-x flush-lines
Date: Wed, 05 Aug 2009 23:14:18 +0300

>> emacs -Q
>> M-< ; beginning of *scratch* buffer
>> M-x flush-lines RET RET
>
> In 22.3, this used read-from-minibuffer, which returns the empty
> string in case of no input.
>
> Now it used read-regexp, which returns nil in case of no input (if no
> default is supplied). That doesn't seem right.
>
> Perhaps this:
>
> *** replace.el	9 Jan 2009 05:01:00 -0000	1.282
> --- replace.el	27 Feb 2009 21:41:59 -0000
> ***************
> *** 556,562 ****
>   	     (format "%s: " prompt))
>   	   nil nil nil 'regexp-history defaults t)))
>       (if (equal input "")
> ! 	default-value
>         (prog1 input
>   	(add-to-history 'regexp-history input)))))
>   
> --- 556,562 ----
>   	     (format "%s: " prompt))
>   	   nil nil nil 'regexp-history defaults t)))
>       (if (equal input "")
> ! 	(or default-value input)
>         (prog1 input
>   	(add-to-history 'regexp-history input)))))

Currently flush-lines always displays the misleading prompt

  Flush lines containing match for regexp (default ):
                                          ==========

where default is empty that makes no sense without a real
default value.

I think Glenn provided the correct patch for this bug (seen above).

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #23 received at 2495-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: 2495-done <at> debbugs.gnu.org
Subject: Re: bug#2495: 23.0.91; regression in M-x flush-lines
Date: Wed, 12 Aug 2009 23:58:11 +0300

> Currently flush-lines always displays the misleading prompt
>
>   Flush lines containing match for regexp (default ):
>                                           ==========
>
> where default is empty that makes no sense without a real
> default value.
>
> I think Glenn provided the correct patch for this bug (seen above).

Fixed.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.