GNU bug report logs - #24944
[PATCH] Skip test-seq-random-elt-take-all on Emacs 24

Previous Next

Full log

Message #8 received at 24944 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 24944 <at> debbugs.gnu.org
Subject: Re: bug#24944: [PATCH] Skip test-seq-random-elt-take-all on Emacs 24
Date: Tue, 15 Nov 2016 17:20:36 +0200

> From: Sean Whitton <spwhitton <at> spwhitton.name>
> Date: Mon, 14 Nov 2016 21:00:50 -0700
> Cc: Sean Whitton <spwhitton <at> spwhitton.name>
> 
> The function `map-length' is not available.
> ---
>  packages/seq/tests/seq-tests.el | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/packages/seq/tests/seq-tests.el b/packages/seq/tests/seq-tests.el
> index 53930fa..7a9a452 100644
> --- a/packages/seq/tests/seq-tests.el
> +++ b/packages/seq/tests/seq-tests.el
> @@ -351,6 +351,7 @@ Evaluate BODY for each created sequence.
>                     ["xxx" "xx" "x"]))))
>  
>  (ert-deftest test-seq-random-elt-take-all ()
> +  (skip-unless (version> emacs-version "25"))
>    (let ((seq '(a b c d e))
>          (count '()))
>      (should (= 0 (map-length count)))

A better test is to use fboundp (after requiring the package that
should define it) to probe whether the function exists or not, instead
of relying on the version.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.