GNU bug report logs - #24941
Early termination bug in grep 2.26

Previous Next

Package: grep;

Reported by: Gary Johnson <garyjohn <at> spocom.com>

Date: Mon, 14 Nov 2016 02:42:01 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


Message #40 received at 24941-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>
Cc: Gary Johnson <garyjohn <at> spocom.com>, Norihiro Tanaka <noritnk <at> kcn.ne.jp>,
 24941-done <at> debbugs.gnu.org
Subject: Re: bug#24941: Early termination bug in grep 2.26
Date: Sat, 19 Nov 2016 01:47:48 -0800
[Message part 1 (text/plain, inline)]
This turned into more work than I expected, as I kept finding performance 
glitches and/or correctness bugs in the neighborhood. I installed the attached 
set of patches. Patch 03 is the crucial one. Patch 10 trivially fixes an earlier 
test of mine and I'm too lazy to write a separate email for it.

This fixes the problem for me, so I'm taking the liberty of closing this bug report.
[0001-grep-avoid-unnecessary-isatty-calls.patch (text/x-diff, attachment)]
[0002-grep-improve-diagnostic-on-lseek-failure.patch (text/x-diff, attachment)]
[0003-grep-scale-back-dev-null-speedup.patch (text/x-diff, attachment)]
[0004-grep-drain-the-input-pipe-faster.patch (text/x-diff, attachment)]
[0005-grep-avoid-unnecessary-gettext-call.patch (text/x-diff, attachment)]
[0006-grep-avoid-O-N-2-buffer-reallocation.patch (text/x-diff, attachment)]
[0007-grep-treat-f-dev-null-like-m0.patch (text/x-diff, attachment)]
[0008-grep-tune-f-dev-null.patch (text/x-diff, attachment)]
[0009-grep-f-dev-null-L-PAT-FILE-outputs-FILE.patch (text/x-diff, attachment)]
[0010-tests-use-returns_-rather-than.patch (text/x-diff, attachment)]

This bug report was last modified 8 years and 278 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.