GNU bug report logs - #24941
Early termination bug in grep 2.26

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 24941 <at> debbugs.gnu.org
Subject: bug#24941: Early termination bug in grep 2.26
Date: Tue, 15 Nov 2016 15:13:27 -0800

On Tue, Nov 15, 2016 at 2:13 PM, Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
>
> On Tue, 15 Nov 2016 11:35:15 -0800
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> I suppose you mean in addition to the S_ISFIFO test? That sounds good.
>> We should retain the optimization when reading from stdin that is a
>> non-pipe.
>
> This can also happen in stdin.  If we redirect stdout to /dev/null,
> grep-2.26 exits immediately and prompt is returned.
>
> - grep-2.25
>
> $ grep . >/dev/null
> a  <<input a and newline
> b  <<input b and newline
> c  <<input c and newline
>
> - grep-2.26
>
> $ src/grep . >/dev/null
> a  <<input a and newline
> $

Good point. While I suspect that would be much less likely to cause
trouble in practice, I would now rephrase:

  We should retain the optimization when reading from stdin that is
neither a pipe nor a tty.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.