GNU bug report logs - #24939
[PATCH] Add tests for lisp/kmacro.el

Previous Next

Full log

Message #20 received at 24939 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24939 <at> debbugs.gnu.org
Subject: Re: bug#24939: [PATCH] Add tests for lisp/kmacro.el
Date: Wed, 30 Nov 2016 10:08:46 +0100

Gemini Lasswell <gazally <at> runbox.com> writes:

Hi,

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> > I don't like this implementation.
>>>
>>> This strategy is used in autorevert-tests.el and filenotify-tests.el,
>>> which is where I copied it from. So those should be changed too.
>>
>> Most probably.  But let's first see what better implementation we
>> could come up with.
>>
> Let me know what you think.

At first glance, looks OK to me. However, I didn't understand why the
existing implementation (watching messages in *Messages*) is bad.

Eli?

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.