GNU bug report logs - #24935
[PATCH] Add tests for rot13.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> gmail.com>
Subject: bug#24935: closed (Re: bug#24935: [PATCH] Add tests for rot13.el)
Date: Thu, 17 Nov 2016 18:24:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#24935: [PATCH] Add tests for rot13.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 24935 <at> debbugs.gnu.org.

-- 
24935: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24935
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24935-done <at> debbugs.gnu.org
Subject: Re: bug#24935: [PATCH] Add tests for rot13.el
Date: Thu, 17 Nov 2016 19:23:17 +0100

Sounds good to me, thanks.

Installed with your suggested change.

-- Simen

On Tue, Nov 15, 2016 at 9:23 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>  Date: Tue, 15 Nov 2016 19:43:55 +0100
>>  From: Simen Heggestøyl <simenheg <at> gmail.com>
>>  Cc: 24935 <at> debbugs.gnu.org
>> 
>>    "ROT13 encrypt OBJECT, a buffer or string.
>>  Return the ROT13 encrypted string when OBJECT is a string,
>>  ignoring START and END.  ROT13 encrypt the region between
>>  positions START and END when OBJECT is a buffer; all three
>>  arguments are then required."
> 
> It sounds strange to describe first the use case where the arguments
> are ignored.  I suggest this instead:
> 
>   ROT13 encrypt OBJECT, a buffer or string.
> If OBJECT is a buffer, encrypt the region between START and END.
> If OBJECT is a string, encrypt it in its entirety, ignoring START
> and END, and return the encrypted string.
> 
> 
> 

[Message part 3 (message/rfc822, inline)]

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add tests for rot13.el
Date: Sun, 13 Nov 2016 12:07:36 +0100

[Message part 4 (text/plain, inline)]

Hello,

I saw that there weren't any tests for rot13.el yet, so I wrote
some. I also made a docstring correction along the way.

Unless there are any objections, I'll install the patch within a few
days.

I also plan to turn on lexical binding for rot13.el in a follow-up
commit.

-- Simen

[0001-Add-tests-for-rot13.el.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.