GNU bug report logs - #24932
[PATCH] Update module function signature

Previous Next

Full log

Message #8 received at 24932 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: Syohei YOSHIDA <syohex <at> gmail.com>, 24932 <at> debbugs.gnu.org
Subject: Re: bug#24932: [PATCH] Update module function signature
Date: Sun, 13 Nov 2016 13:02:31 -0800

On 11/12/2016 06:06 PM, Syohei YOSHIDA wrote:
> Second argument of module function is ptrdiff_t, not int.
> This fixes a compile warning.

That's an ABI break. We should find another way to fix the warning or 
add a new function.

> ---
>  modules/modhelp.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/modhelp.py b/modules/modhelp.py
> index 5d8f89b..445cb3b 100755
> --- a/modules/modhelp.py
> +++ b/modules/modhelp.py
> @@ -154,7 +154,7 @@ def main():
>  int plugin_is_GPL_compatible;
>
>  static emacs_value
> -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data)
> +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void *data)
>  {
>    return env->intern (env, "t");
>  }
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.