From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 21:08:05 2016 Received: (at submit) by debbugs.gnu.org; 13 Nov 2016 02:08:05 +0000 Received: from localhost ([127.0.0.1]:55280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kDE-00053Y-QF for submit@debbugs.gnu.org; Sat, 12 Nov 2016 21:08:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kDC-000534-Gi for submit@debbugs.gnu.org; Sat, 12 Nov 2016 21:08:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5kD5-0007Y3-Uh for submit@debbugs.gnu.org; Sat, 12 Nov 2016 21:07:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c5kD5-0007Xy-Qv for submit@debbugs.gnu.org; Sat, 12 Nov 2016 21:07:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5kD4-0000V0-Nq for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:07:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5kD1-0007XG-Jg for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:07:54 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:35225) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c5kD1-0007Ws-DR for bug-gnu-emacs@gnu.org; Sat, 12 Nov 2016 21:07:51 -0500 Received: by mail-pg0-f68.google.com with SMTP id p66so5351296pga.2 for ; Sat, 12 Nov 2016 18:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=p6LgPTS1DmUBJCNDLfPzObb1olZ2o+Iq53Mte+U0Hh8=; b=EQ0LHM2ZRIKP7I7cci7Baq7Q15eTbdrXQ990kHDu5bAwQtDyE4V+HMxOuUHOgYL+Cm csNOWNplfvPMSQVX0Vn5QvjQz5cn+5mFzIlvAy0Zfe0hvzE341c32NkUAXdaKYs9KcCU /nkNpl/1fxk8FDGRALKOACgEhh8PlI2VroUVV1LX+hFlUie1BZG8/pCfYNZ8wNVlUQPl GngZVn1wjGtk+AVWFoHBu0vuBlynyI8B2XwZAaRYijyqGgbGHdg9a8kyPaDZkHOAhR2X zuimgwlNnZUGodbaIumd5LC/Q+KMWKnxM6zs4qzfLnD0KwNx6M5KrJUaqd1TxKsnLaTP nOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=p6LgPTS1DmUBJCNDLfPzObb1olZ2o+Iq53Mte+U0Hh8=; b=O8nmJqTGGGCNKLWaLyMwkl8i/h8adCbIaUWWOlRxtBSq7irPoElXQp/e8UlJDcfHIp rXkg42BUKzUNYja9SSZ11Wa0DXvAL/1m4V+56lfqBrbQlQ7FhtuUTxEGoCthp+L5UHU7 7Of3RPfm0N0QCbRCWKN++Il/kYP/Rb8BOObw3AlACOooDgNXA26jmrXux6Achf+y48zW tY5dTtZXKfLehmEecRyjSbQiIbCGNRQ7ZpbE7LFwTRrukg4Nm0TacuvQOofKUKIGwjRX gW0+ct/q+2yWTDlosHNidLg7h1/75L1SP+j8Tai09vTC/gaipWzTzhZvQpKGDd/dmsbk qbSQ== X-Gm-Message-State: ABUngvfYp9B2kZquBih0FA4Yr4hfbohDmdXyF3GiSQJyDFSaMqUsu9QtelpLU3QUec5TSQ== X-Received: by 10.99.154.9 with SMTP id o9mr43869857pge.19.1479002808554; Sat, 12 Nov 2016 18:06:48 -0800 (PST) Received: from localhost.localdomain (www12378ue.sakura.ne.jp. [49.212.151.152]) by smtp.gmail.com with ESMTPSA id h10sm20723952paw.37.2016.11.12.18.06.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 18:06:48 -0800 (PST) From: Syohei YOSHIDA To: bug-gnu-emacs@gnu.org Subject: [PATCH] Update module function signature Date: Sun, 13 Nov 2016 11:06:18 +0900 Message-Id: <20161113020618.22644-1-syohex@gmail.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit Cc: Syohei YOSHIDA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Second argument of module function is ptrdiff_t, not int. This fixes a compile warning. --- modules/modhelp.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/modhelp.py b/modules/modhelp.py index 5d8f89b..445cb3b 100755 --- a/modules/modhelp.py +++ b/modules/modhelp.py @@ -154,7 +154,7 @@ def main(): int plugin_is_GPL_compatible; static emacs_value -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data) +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void *data) { return env->intern (env, "t"); } -- 2.9.3 From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 16:02:39 2016 Received: (at 24932) by debbugs.gnu.org; 13 Nov 2016 21:02:39 +0000 Received: from localhost ([127.0.0.1]:56125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c61vC-0008W2-Py for submit@debbugs.gnu.org; Sun, 13 Nov 2016 16:02:38 -0500 Received: from dancol.org ([96.126.100.184]:35704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c61vB-0008Vu-O5 for 24932@debbugs.gnu.org; Sun, 13 Nov 2016 16:02:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=HbeSGvPaZ9G57SZ1j0Ayc9mG0/9ahjus4ctUWyOOu4M=; b=Jf3jDPZvJL2ef0KkBxjDMFL1XrN13+q+q5sj/i+YUuGrrms+hEtqvvwAC6i5pZ/7QI/9Vv7iu1DHMShuXvE0NQQyvw4owOH2B1yCPmUXl8bNbjJhzirzZIyjmTBOVwcY1arVjtuZXfyI3ySejE7eRXe2KgplA6ueNp/gjk4qxr3fqwATgWWo9RPq7IzCAct4dh8VjL3BuhLBFfPAAQ81nkNqlEUdKOxP+5IqcMEyyyaM3cI7GKQrANLo2mXsEYx06ydHQ219M3iFM9oVN2788UzfmBiXEj6nInwA93W1ry5Zgvne9kRx1JU31n4JxC8LXNVPMLJPriCYXxx2CzXgXQ==; Received: from c-73-97-199-232.hsd1.wa.comcast.net ([73.97.199.232] helo=[192.168.1.173]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1c61vA-0004df-JO; Sun, 13 Nov 2016 13:02:36 -0800 Subject: Re: bug#24932: [PATCH] Update module function signature To: Syohei YOSHIDA , 24932@debbugs.gnu.org References: <20161113020618.22644-1-syohex@gmail.com> From: Daniel Colascione Message-ID: <83e6fbf4-13ba-edac-5a06-072643f5c0f7@dancol.org> Date: Sun, 13 Nov 2016 13:02:31 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161113020618.22644-1-syohex@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 24932 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 11/12/2016 06:06 PM, Syohei YOSHIDA wrote: > Second argument of module function is ptrdiff_t, not int. > This fixes a compile warning. That's an ABI break. We should find another way to fix the warning or add a new function. > --- > modules/modhelp.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/modules/modhelp.py b/modules/modhelp.py > index 5d8f89b..445cb3b 100755 > --- a/modules/modhelp.py > +++ b/modules/modhelp.py > @@ -154,7 +154,7 @@ def main(): > int plugin_is_GPL_compatible; > > static emacs_value > -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data) > +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void *data) > { > return env->intern (env, "t"); > } > From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 13 16:05:55 2016 Received: (at 24932) by debbugs.gnu.org; 13 Nov 2016 21:05:55 +0000 Received: from localhost ([127.0.0.1]:56129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c61yN-00009i-8V for submit@debbugs.gnu.org; Sun, 13 Nov 2016 16:05:55 -0500 Received: from dancol.org ([96.126.100.184]:35710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c61yL-00009a-UL for 24932@debbugs.gnu.org; Sun, 13 Nov 2016 16:05:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=x1Bua6SaWkB/0FbfwnRgjJJq3IpQhWd4sGjlKJOQNoo=; b=mudHGUhOdZrrzLzGwZLtWvbHv3OpONW7EelBgl4GWxuSppFgBH4jk8bKYp9rSmzqr2OWa3TfBZHlqFXVG8KRLGnFU5URblFoN+t0juNHF5YC9MuI7NXMUBoZvQfQ6umjhk4b0N80oU7ZbIKd8c8ONr4Xs2BiyVVVU8i2pIsenT28Aj4r3sXMOUfsEUHCZdjlcEa7FDRmTJ5CiizLsmd0FDHnNmGZL2AhCBqR4XVfkTsO/qqKCYucYRvENnMmVGjt2HxcUe80q+aT0Akmak9HShaqwsZ7LJHeaPN8b4k8dH89eK4uOUL2/LdJLKcd1a9nKaohNg8f7bQBZaJI+oMv+g==; Received: from c-73-97-199-232.hsd1.wa.comcast.net ([73.97.199.232] helo=[192.168.1.173]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1c61yL-0004eb-Jg; Sun, 13 Nov 2016 13:05:53 -0800 Subject: Re: bug#24932: [PATCH] Update module function signature To: Syohei YOSHIDA , 24932@debbugs.gnu.org References: <20161113020618.22644-1-syohex@gmail.com> <83e6fbf4-13ba-edac-5a06-072643f5c0f7@dancol.org> From: Daniel Colascione Message-ID: <46bc4be5-c355-f47f-cb22-445a91d0bfc5@dancol.org> Date: Sun, 13 Nov 2016 13:05:49 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <83e6fbf4-13ba-edac-5a06-072643f5c0f7@dancol.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 24932 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 11/13/2016 01:02 PM, Daniel Colascione wrote: > On 11/12/2016 06:06 PM, Syohei YOSHIDA wrote: >> Second argument of module function is ptrdiff_t, not int. >> This fixes a compile warning. > > That's an ABI break. We should find another way to fix the warning or > add a new function. Err, never mind. The patch is fine. I just read it too fast. > >> --- >> modules/modhelp.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/modules/modhelp.py b/modules/modhelp.py >> index 5d8f89b..445cb3b 100755 >> --- a/modules/modhelp.py >> +++ b/modules/modhelp.py >> @@ -154,7 +154,7 @@ def main(): >> int plugin_is_GPL_compatible; >> >> static emacs_value >> -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data) >> +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void >> *data) >> { >> return env->intern (env, "t"); >> } >> > > > > From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 10:51:21 2016 Received: (at 24932-done) by debbugs.gnu.org; 28 Nov 2016 15:51:21 +0000 Received: from localhost ([127.0.0.1]:45083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBODB-0004A3-ND for submit@debbugs.gnu.org; Mon, 28 Nov 2016 10:51:21 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cBOD9-00049q-Fb for 24932-done@debbugs.gnu.org; Mon, 28 Nov 2016 10:51:19 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A40E9160060; Mon, 28 Nov 2016 07:51:12 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id eEPoYPYzKgOh; Mon, 28 Nov 2016 07:51:08 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E9C11160061; Mon, 28 Nov 2016 07:51:07 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sRo1-avcpxCK; Mon, 28 Nov 2016 07:51:07 -0800 (PST) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D1843160060; Mon, 28 Nov 2016 07:51:07 -0800 (PST) To: Syohei YOSHIDA From: Paul Eggert Subject: Re: [PATCH] Update module function signature Organization: UCLA Computer Science Department Message-ID: <7c6bdba0-03bb-108b-49c1-893b18b57216@cs.ucla.edu> Date: Mon, 28 Nov 2016 07:51:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 24932-done Cc: 24932-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Thanks for reporting the problem. I installed the fix and am closing the bug report. From unknown Sat Aug 09 12:59:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Dec 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator