GNU bug report logs - #24913
25.1.50; Emacs accepts undocumented and confusing combinations of &optional and &rest in argument lists

Previous Next

Package: emacs;

Reported by: Philipp Stephani <p.stephani2 <at> gmail.com>

Date: Wed, 9 Nov 2016 21:19:02 UTC

Severity: minor

Found in version 25.1.50

Done: Philipp Stephani <p.stephani2 <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#24913: closed (25.1.50; Emacs accepts undocumented and
 confusing combinations of &optional and &rest in argument lists)
Date: Fri, 18 Nov 2016 17:38:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 18 Nov 2016 17:37:26 +0000
with message-id <CAArVCkS+nDPUt+U=GPn4pEpo9YXZoXZu2ij0Hc3Xta2JG=hVhw <at> mail.gmail.com>
and subject line Re: bug#24913: 25.1.50; Emacs accepts undocumented and confusing combinations of &optional and &rest in argument lists
has caused the debbugs.gnu.org bug report #24913,
regarding 25.1.50; Emacs accepts undocumented and confusing combinations of &optional and &rest in argument lists
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
24913: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24913
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50;
 Emacs accepts undocumented and confusing combinations of &optional
 and &rest in argument lists
Date: Wed, 09 Nov 2016 22:17:54 +0100
For example:

(funcall (lambda (&optional &rest &rest &optional x) (list x)) 'a)
=> ((a))

Obviously here the &rest keyword "wins", but I think that's overly
confusing.  Such an argument list is most likely a programmer mistake,
and should signal an error to make the programmer aware of the mistake.



In GNU Emacs 25.1.50.13 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8)
 of 2016-11-09 built on localhost
Repository revision: eb364fddec1431f459166cebb36f09f6b371dd71
Windowing system distributor 'The X.Org Foundation', version 11.0.11501000
System Description:	Ubuntu 14.04 LTS

Configured using:
 'configure --with-modules --enable-checking
 --enable-check-lisp-object-type 'CFLAGS=-ggdb3 -O0''

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 88939 12159)
 (symbols 48 19888 0)
 (miscs 40 343 148)
 (strings 32 14757 5052)
 (string-bytes 1 440451)
 (vectors 16 12779)
 (vector-slots 8 446082 5011)
 (floats 8 166 60)
 (intervals 56 209 0)
 (buffers 976 24)
 (heap 1024 23753 956))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich.  Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen
Sie die E-Mail und alle Anhänge.  Vielen Dank.

This e-mail is confidential.  If you are not the right addressee please do not
forward it, please inform the sender, and please erase this e-mail including
any attachments.  Thanks.


[Message part 3 (message/rfc822, inline)]
From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24913-done <at> debbugs.gnu.org
Subject: Re: bug#24913: 25.1.50; Emacs accepts undocumented and confusing
 combinations of &optional and &rest in argument lists
Date: Fri, 18 Nov 2016 17:37:26 +0000
[Message part 4 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> schrieb am Fr., 18. Nov. 2016 um 10:06 Uhr:

> > From: Philipp Stephani <p.stephani2 <at> gmail.com>
> > Date: Thu, 10 Nov 2016 12:58:39 +0000
> >
> > Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Mi., 9. Nov. 2016
> um 22:19 Uhr:
> >
> >  For example:
> >
> >  (funcall (lambda (&optional &rest &rest &optional x) (list x)) 'a)
> >  => ((a))
> >
> >  Obviously here the &rest keyword "wins", but I think that's overly
> >  confusing. Such an argument list is most likely a programmer mistake,
> >  and should signal an error to make the programmer aware of the mistake.
> >
> > Here's a patch that detects such argument lists.
>
> Thanks, please push to master.
>

Done.
[Message part 5 (text/html, inline)]

This bug report was last modified 8 years and 240 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.