GNU bug report logs - #24893
26.0.50; shr doesn't parse srcset <img> correctly

Previous Next

Package: emacs;

Reported by: Lars Ingebrigtsen <larsi <at> gnus.org>

Date: Mon, 7 Nov 2016 11:16:02 UTC

Severity: normal

Tags: fixed

Found in version 26.0.50

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 24893 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 24893 <at> debbugs.gnu.org
Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset <img> correctly
Date: Wed, 09 Nov 2016 10:55:01 +0100
On Nov 09 2016, Katsumi Yamaoka <yamaoka <at> jpl.org> wrote:

> On Tue, 08 Nov 2016 09:39:46 +0100, Andreas Schwab wrote:
>> On Nov 08 2016, Katsumi Yamaoka <yamaoka <at> jpl.org> wrote:
>>> -                     (let ((spec (split-string elem " ")))
>>> +                     (let ((spec (split-string elem "[\t\n ]+")))
>
>> Shouldn't this ignore leading and trailing whitespace as well?
>
> It's done by the second part?
>
> -                   (split-string srcset ", "))
> +                   (split-string (replace-regexp-in-string
> +				  "\\`[\t\n ]+\\|[\t\n ]+\\'" "" srcset)
> +				 "[\t\n ]*,[\t\n ]*"))

Looks like.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."




This bug report was last modified 8 years and 122 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.