GNU bug report logs - #24893
26.0.50; shr doesn't parse srcset <img> correctly

Previous Next

Full log

View this message in rfc822 format

From: Andreas Schwab <schwab <at> suse.de>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 24893 <at> debbugs.gnu.org
Subject: bug#24893: 26.0.50; shr doesn't parse srcset <img> correctly
Date: Tue, 08 Nov 2016 09:39:46 +0100

On Nov 08 2016, Katsumi Yamaoka <yamaoka <at> jpl.org> wrote:

> On Mon, 07 Nov 2016 12:11:51 +0100, Lars Ingebrigtsen wrote:
>> (shr--preferred-image
> [...]
>> => "
>> "
>> I'm guessing it's the newlines or something that's the problem.  Or the
>> protocol-less URLs?  I haven't examined.
>
> Though this is no more than a workaround:
>
> --- shr.el~	2016-11-04 10:32:58.932040100 +0000
> +++ shr.el	2016-11-08 05:54:35.912122700 +0000
> @@ -1529,7 +1529,7 @@
>        (setq srcset
>              (sort (mapcar
>                     (lambda (elem)
> -                     (let ((spec (split-string elem " ")))
> +                     (let ((spec (split-string elem "[\t\n ]+")))

Shouldn't this ignore leading and trailing whitespace as well?

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.