From unknown Sun Jun 22 20:55:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24893 <24893@debbugs.gnu.org> To: bug#24893 <24893@debbugs.gnu.org> Subject: Status: 26.0.50; shr doesn't parse srcset correctly Reply-To: bug#24893 <24893@debbugs.gnu.org> Date: Mon, 23 Jun 2025 03:55:52 +0000 retitle 24893 26.0.50; shr doesn't parse srcset correctly reassign 24893 emacs submitter 24893 Lars Ingebrigtsen severity 24893 normal tag 24893 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 06:15:02 2016 Received: (at submit) by debbugs.gnu.org; 7 Nov 2016 11:15:02 +0000 Received: from localhost ([127.0.0.1]:47543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3htG-0004gX-BT for submit@debbugs.gnu.org; Mon, 07 Nov 2016 06:15:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3htE-0004fh-Dr for submit@debbugs.gnu.org; Mon, 07 Nov 2016 06:15:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3ht7-0004hi-Mm for submit@debbugs.gnu.org; Mon, 07 Nov 2016 06:14:55 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41694) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3ht7-0004he-Iv for submit@debbugs.gnu.org; Mon, 07 Nov 2016 06:14:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3ht5-0003qb-Li for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 06:14:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3ht0-0004eG-Lf for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 06:14:51 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:38546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3ht0-0004W0-C2 for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 06:14:46 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1c3hsm-00065a-0X for bug-gnu-emacs@gnu.org; Mon, 07 Nov 2016 12:14:36 +0100 From: Lars Ingebrigtsen To: bug-gnu-emacs@gnu.org Subject: 26.0.50; shr doesn't parse srcset correctly Date: Mon, 07 Nov 2016 12:11:51 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) (shr--preferred-image '(img ((src . "http://s3.amazonaws.com/ledejs/resized/allegiant/600/alle_wi= nglede.jpg") (srcset . " //s3.amazonaws.com/ledejs/resized/allegiant/480/alle_winglede.jpg 480= w, //s3.amazonaws.com/ledejs/resized/allegiant/480/alle_winglede-2x.jpg = 960w, //s3.amazonaws.com/ledejs/resized/allegiant/600/alle_winglede.jpg 600= w, //s3.amazonaws.com/ledejs/resized/allegiant/1024/alle_winglede.jpg 10= 24w, //s3.amazonaws.com/ledejs/resized/allegiant/600/alle_winglede-2x.jpg = 1200w, //s3.amazonaws.com/ledejs/resized/allegiant/1500/alle_winglede.jpg 15= 00w, //s3.amazonaws.com/ledejs/resized/allegiant/1024/alle_winglede-2x.jpg= 2048w, //s3.amazonaws.com/ledejs/resized/allegiant/1500/alle_winglede-2x.jpg= 3000w ") (sizes . " (max-width: 479px) 480px, (min-width: 480px) and (max-width: 599px) 600px, (min-width: 600px) and (max-width: 1023px) 1024px, (min-width: 1024px) 1500px, 100vw ")))) =3D> " " I'm guessing it's the newlines or something that's the problem. Or the protocol-less URLs? I haven't examined. In GNU Emacs 26.0.50.13 (x86_64-unknown-linux-gnu, GTK+ Version 3.14.5) of 2016-11-01 built on stories Repository revision: c3640fcc96ed80368209c73d7ac9a0f0d1833d93 Windowing system distributor 'The X.Org Foundation', version 11.0.11604000 System Description: Debian GNU/Linux 8.6 (jessie) Recent messages: " [2 times] Entering debugger... nil Quit " [2 times] debugger-eval-expression: Symbol=E2=80=99s value as variable is void: base nil Back to top level Quit Making completion list... [2 times] Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t global-whitespace-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t Load-path shadows: /home/larsi/src/cddb.el/expect hides /home/larsi/lisp/expect /home/larsi/src/cddb.el/captitle hides /home/larsi/lisp/captitle /home/larsi/src/clock.el/clock hides /home/larsi/lisp/clock ~/pgnus/contrib/vcard hides /home/larsi/lisp/vcard /home/larsi/src/pvr.el/pvr hides /home/larsi/lisp/pvr ~/lisp/zenirc-2.112/src/zenirc-example hides /home/larsi/lisp/zenirc-example ~/pgnus/contrib/compface hides /home/larsi/src/emacs/trunk/lisp/image/compf= ace Features: (shadow emacsbug pulse xref project org-element org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint comint ring ob-core ob-eval org-compat org-macs org-loaddefs perl-mode sh-script smie executable dired-aux jukebox id3 humanely-sort lyric-wiki discogs json dae musicbrainz scan scrobble tellstick wave cddb captitle expect vc-annotate thingatpt cal-move cal-menu calendar cal-loaddefs mailalias smtpmail sendmail eieio-opt speedbar sb-image ezimage dframe find-func ecomplete misearch multi-isearch log-view pcvs-util vc vc-dispatcher vc-git pp canlock map diff-mode shr-color color eww flow-fill copyright vc-cvs gnus-html url-queue help-fns radix-tree url-cache qp sort gnus-cite smiley ansi-color mm-archive gnus-async gnus-dup gnus-ml gmane spam-gmane dns mm-url disp-table gnus-fun gnus-mdrtn gnus-topic pop3 nndoc nnmbox utf-7 nnml nnfolder network-stream starttls nnir spam-report spam spam-stat gnus-uu yenc gnus-delay gnus-draft gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum nndraft nnmh gnus-group gnus-undo gnus-start gnus-cloud nnimap utf7 netrc nnoo parse-time gnus-spec gnus-win nnmail gnus-int gnus-range mail-source message format-spec rfc822 mml mml-sec epa epg mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs mail-utils whitespace movie mkv shr svg imdb dom pvr debug debbugs-gnu easy-mmode derived debbugs soap-client mm-decode mm-bodies mm-encode url-http tls gnutls url-auth mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr url-gw nsm puny url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap warnings rng-xsd rng-dt rng-util xsd-regexp xml ido flyspell ispell benchmark w3m browse-url doc-view subr-x dired dired-loaddefs image-mode timezone w3m-hist w3m-fb w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util add-log mail-extr jka-compr cl finder-inf package epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cl-extra help-mode easymenu cconv cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 7241253 564715) (symbols 48 181511 479) (miscs 40 2567 3353) (strings 32 499022 79531) (string-bytes 1 52214498) (vectors 16 54970) (vector-slots 8 1927348 186360) (floats 8 7817 13807) (intervals 56 1603036 13249) (buffers 976 145) (heap 1024 556677 241444)) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 00:56:00 2016 Received: (at 24893) by debbugs.gnu.org; 8 Nov 2016 05:56:00 +0000 Received: from localhost ([127.0.0.1]:48941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3zO4-0003sm-IH for submit@debbugs.gnu.org; Tue, 08 Nov 2016 00:56:00 -0500 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:57125 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3zO2-0003sZ-H4 for 24893@debbugs.gnu.org; Tue, 08 Nov 2016 00:55:59 -0500 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1c3zNu-000Dcb-5d; Mon, 07 Nov 2016 23:55:51 -0600 Date: Tue, 08 Nov 2016 14:55:49 +0900 Message-ID: From: Katsumi Yamaoka To: Lars Ingebrigtsen Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset correctly References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:umdEVKJBBGOWBSISDrRAfdcWqEY= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24893 Cc: 24893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= On Mon, 07 Nov 2016 12:11:51 +0100, Lars Ingebrigtsen wrote: > (shr--preferred-image [...] > => " > " > I'm guessing it's the newlines or something that's the problem. Or the > protocol-less URLs? I haven't examined. Though this is no more than a workaround: --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- shr.el~ 2016-11-04 10:32:58.932040100 +0000 +++ shr.el 2016-11-08 05:54:35.912122700 +0000 @@ -1529,7 +1529,7 @@ (setq srcset (sort (mapcar (lambda (elem) - (let ((spec (split-string elem " "))) + (let ((spec (split-string elem "[\t\n ]+"))) (cond ((= (length spec) 1) ;; Make sure it's well formed. @@ -1543,7 +1543,9 @@ (t (list (car spec) (string-to-number (cadr spec))))))) - (split-string srcset ", ")) + (split-string (replace-regexp-in-string + "\\`[\t\n ]+\\|[\t\n ]+\\'" "" srcset) + "[\t\n ]*,[\t\n ]*")) (lambda (e1 e2) (> (cadr e1) (cadr e2))))) ;; Choose the smallest picture that's bigger than the current --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 03:39:50 2016 Received: (at 24893) by debbugs.gnu.org; 8 Nov 2016 08:39:50 +0000 Received: from localhost ([127.0.0.1]:49015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c41wc-0007sN-Ew for submit@debbugs.gnu.org; Tue, 08 Nov 2016 03:39:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:55645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c41wa-0007sF-QJ for 24893@debbugs.gnu.org; Tue, 08 Nov 2016 03:39:49 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E0D42AC48; Tue, 8 Nov 2016 08:39:46 +0000 (UTC) From: Andreas Schwab To: Katsumi Yamaoka Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset correctly References: X-Yow: MMM-MM!! So THIS is BIO-NEBULATION! Date: Tue, 08 Nov 2016 09:39:46 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 08 Nov 2016 14:55:49 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 24893 Cc: Lars Ingebrigtsen , 24893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) On Nov 08 2016, Katsumi Yamaoka wrote: > On Mon, 07 Nov 2016 12:11:51 +0100, Lars Ingebrigtsen wrote: >> (shr--preferred-image > [...] >> => " >> " >> I'm guessing it's the newlines or something that's the problem. Or the >> protocol-less URLs? I haven't examined. > > Though this is no more than a workaround: > > --- shr.el~ 2016-11-04 10:32:58.932040100 +0000 > +++ shr.el 2016-11-08 05:54:35.912122700 +0000 > @@ -1529,7 +1529,7 @@ > (setq srcset > (sort (mapcar > (lambda (elem) > - (let ((spec (split-string elem " "))) > + (let ((spec (split-string elem "[\t\n ]+"))) Shouldn't this ignore leading and trailing whitespace as well? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 20:17:07 2016 Received: (at 24893) by debbugs.gnu.org; 9 Nov 2016 01:17:07 +0000 Received: from localhost ([127.0.0.1]:50193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4HVi-0003M1-Rp for submit@debbugs.gnu.org; Tue, 08 Nov 2016 20:17:06 -0500 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:41147 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4HVh-0003LS-5b for 24893@debbugs.gnu.org; Tue, 08 Nov 2016 20:17:05 -0500 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1c4HVV-003k8k-FX; Tue, 08 Nov 2016 19:16:58 -0600 Date: Wed, 09 Nov 2016 10:16:44 +0900 Message-ID: From: Katsumi Yamaoka To: Andreas Schwab Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset correctly References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:McdqNpqEL7zcPIX3a5nCtd+xRok= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-1.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24893 Cc: Lars Ingebrigtsen , 24893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 08 Nov 2016 09:39:46 +0100, Andreas Schwab wrote: > On Nov 08 2016, Katsumi Yamaoka wrote: >> - (let ((spec (split-string elem " "))) >> + (let ((spec (split-string elem "[\t\n ]+"))) > Shouldn't this ignore leading and trailing whitespace as well? It's done by the second part? - (split-string srcset ", ")) + (split-string (replace-regexp-in-string + "\\`[\t\n ]+\\|[\t\n ]+\\'" "" srcset) + "[\t\n ]*,[\t\n ]*")) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 04:55:04 2016 Received: (at 24893) by debbugs.gnu.org; 9 Nov 2016 09:55:04 +0000 Received: from localhost ([127.0.0.1]:50401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Pay-0008QR-I0 for submit@debbugs.gnu.org; Wed, 09 Nov 2016 04:55:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:41726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Paw-0008QH-VB for 24893@debbugs.gnu.org; Wed, 09 Nov 2016 04:55:03 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 24D98ABC7; Wed, 9 Nov 2016 09:55:02 +0000 (UTC) From: Andreas Schwab To: Katsumi Yamaoka Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset correctly References: X-Yow: I'd like some JUNK FOOD... and then I want to be ALONE -- Date: Wed, 09 Nov 2016 10:55:01 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Wed, 09 Nov 2016 10:16:44 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -5.2 (-----) X-Debbugs-Envelope-To: 24893 Cc: Lars Ingebrigtsen , 24893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) On Nov 09 2016, Katsumi Yamaoka wrote: > On Tue, 08 Nov 2016 09:39:46 +0100, Andreas Schwab wrote: >> On Nov 08 2016, Katsumi Yamaoka wrote: >>> - (let ((spec (split-string elem " "))) >>> + (let ((spec (split-string elem "[\t\n ]+"))) > >> Shouldn't this ignore leading and trailing whitespace as well? > > It's done by the second part? > > - (split-string srcset ", ")) > + (split-string (replace-regexp-in-string > + "\\`[\t\n ]+\\|[\t\n ]+\\'" "" srcset) > + "[\t\n ]*,[\t\n ]*")) Looks like. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 13:10:09 2016 Received: (at 24893) by debbugs.gnu.org; 10 Nov 2016 18:10:10 +0000 Received: from localhost ([127.0.0.1]:52602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4tnd-0002xq-8D for submit@debbugs.gnu.org; Thu, 10 Nov 2016 13:10:09 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4tna-0002xg-RD for 24893@debbugs.gnu.org; Thu, 10 Nov 2016 13:10:07 -0500 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1c4tnT-0007tK-6H; Thu, 10 Nov 2016 19:10:01 +0100 From: Lars Ingebrigtsen To: Katsumi Yamaoka Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset correctly References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAHlBMVEWAnsb++d1zk75XdJhp irNjg6k5VHUVITBtjrvd2clKgQaxAAACL0lEQVQ4jW3UzY+TQBQA8Cetpr0VzZr0VqfV1JtmhLY3 hcHgbbMD616VdtqezYJHQ1szR5pNNPy3vhkYqN2+hADzm2HeMB8Qm6AYTv3MuQPVU1DdImYqxaDe dERYEErCakPAQqkEH8KckKmmCNSrlHK/VyYRiMhUQKTLVYQIkhCZVRBQn3LfmfvOzlnReMf5uoIJ 5Zz6d/Pd/EAdyg/jQw3MOYSBJJR/2AcRe324M0BMTLEbMgKA7BJgOXRqGNUgDRSzCt6IpbqmDcBX Axu8Vi3016ew1H2MdB+iAUuBNECTtYapzC2s/R/cZymm2y+b0H3zBNPqIBztJgoFsYJnOI5z4AL7 ACDjZGFf0UUDIy5EndXWfomXgV9cpBch5+qXpOA9gmBWfWrSP9pDeNKA99TVA/TO083BrefjDLxb VX4P3vk4iCswluCNoy/2gLxqxwF6Vh9nhWERuAxEAftdw6Bfgk+vuxFO1eSGQDi+eWs/Z5/sv5iL ENvblX0l+AbBpKsgFdtiMaCCf8dP5Q2sMc0VwCz70VEgGxCuw+lDxmny56cEFuB/GpZH+4E611BC QcFNk3kO7LPO6hu2SFORvBuK0qHuRkJkAMdg8fgjjjyO+Jy1oFZJT62hHPddiODjfL+g7+2i7Jdd LMU9F8SqBSvb39sjxCJTRMZw156AVW0U3PIaytMWaqPg0RBpaNooyPE7gT4Z9KpFwjXRy7E+M0dG u6Z1uqwBaKGrzxQd/wCXYDhiJFrqIQAAAABJRU5ErkJggg== Date: Thu, 10 Nov 2016 19:09:58 +0100 In-Reply-To: (Katsumi Yamaoka's message of "Tue, 08 Nov 2016 14:55:49 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24893 Cc: 24893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Katsumi Yamaoka writes: >> I'm guessing it's the newlines or something that's the problem. Or the >> protocol-less URLs? I haven't examined. > > Though this is no more than a workaround: I haven't tested the code, but it looks reasonable to me. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 19:28:16 2016 Received: (at 24893) by debbugs.gnu.org; 11 Nov 2016 00:28:16 +0000 Received: from localhost ([127.0.0.1]:52839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4zhY-000535-1s for submit@debbugs.gnu.org; Thu, 10 Nov 2016 19:28:16 -0500 Received: from mail-hampton.hostforweb.net ([205.234.186.191]:55986 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4zhX-00052r-2R for 24893@debbugs.gnu.org; Thu, 10 Nov 2016 19:28:15 -0500 Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1c4zhP-001w9P-3G; Thu, 10 Nov 2016 18:28:07 -0600 Date: Fri, 11 Nov 2016 09:28:04 +0900 Message-ID: From: Katsumi Yamaoka To: Lars Ingebrigtsen Subject: Re: bug#24893: 26.0.50; shr doesn't parse srcset correctly References: Organization: Emacsen advocacy group X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:xrr1OU7tM4mDnFloYU3eZcNpaFY= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 24893 Cc: 24893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, 10 Nov 2016 19:09:58 +0100, Lars Ingebrigtsen wrote: > I haven't tested the code, but it looks reasonable to me. :-) Committed. Thanks. P.S. I'm trying improving the bug#24831 code so as to render not only strings but also another invalid table form such as: ...no tr/td/th...
... Jidanni mailed me an example in which such an unseen table contains vital links. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 15:34:47 2017 Received: (at control) by debbugs.gnu.org; 24 Jan 2017 20:34:47 +0000 Received: from localhost ([127.0.0.1]:40804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW7nj-0003G7-Cf for submit@debbugs.gnu.org; Tue, 24 Jan 2017 15:34:47 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:49119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cW7nh-0003Fz-S8 for control@debbugs.gnu.org; Tue, 24 Jan 2017 15:34:46 -0500 Received: from 2.150.49.21.tmi.telenormobil.no ([2.150.49.21] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cW7nf-0004eR-Ki for control@debbugs.gnu.org; Tue, 24 Jan 2017 21:34:45 +0100 Date: Tue, 24 Jan 2017 21:34:37 +0100 Message-Id: <874m0onqn6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #24893 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 24893 fixed close 24893 From unknown Sun Jun 22 20:55:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 22 Feb 2017 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator