From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 14:54:50 2016 Received: (at submit) by debbugs.gnu.org; 6 Nov 2016 19:54:50 +0000 Received: from localhost ([127.0.0.1]:47150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3TWk-0004eO-91 for submit@debbugs.gnu.org; Sun, 06 Nov 2016 14:54:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3TWi-0004e9-Hn for submit@debbugs.gnu.org; Sun, 06 Nov 2016 14:54:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3TWc-0007af-DL for submit@debbugs.gnu.org; Sun, 06 Nov 2016 14:54:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50588) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3TWc-0007aF-Ai for submit@debbugs.gnu.org; Sun, 06 Nov 2016 14:54:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3TWa-0003is-VI for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:54:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3TWX-0007W9-Pr for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:54:41 -0500 Received: from mail-it0-x22e.google.com ([2607:f8b0:4001:c0b::22e]:37801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3TWX-0007Vh-KA for bug-gnu-emacs@gnu.org; Sun, 06 Nov 2016 14:54:37 -0500 Received: by mail-it0-x22e.google.com with SMTP id u205so80498295itc.0 for ; Sun, 06 Nov 2016 11:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=OmVIkF4QAwmsBdlyyr6AXRFkOp+ZIJDXTucfmRABShQ=; b=o1xIJO9H1hJdQyq72L/x0anVZJOQLPhkbLZagz4+0B/6tJAPlkmLy0sYYjh9BbSwGn 5nG7diSzHphGLKRoLtsyS/Msq6kGmzmi9qAMRDRKKtSx7zokeq7YO8AVtlcljcTsdO17 8aCHJTPKftkAmVm6KE0YzyB5dhv3P9VGd/kfQhI2NcactuNT83dv6At/wlUYsoTeVqJl Mfwt+xXPLIwwrI7g+W+RhpVH0iDWJMzfv2yHdjp2y/sztATP/CRrs/MVj7dYBTDN6jhJ naqyp9EBdbmQ1002KRVRoKP6bJgDE3R19Azh5+4WGrEAFZTNNkYpZvruRvmssbmTIu3R 5jsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=OmVIkF4QAwmsBdlyyr6AXRFkOp+ZIJDXTucfmRABShQ=; b=cn11vsufWZeOoSZq7qec4f8jDX5PhlUloPgmxcnKpaRnDTtnIr/GEPlISQYacK93eC J1sx15t4IM3qdVa1uM15IwaqyqTysdtTVX3U296hkGTFo/l1ah0iDNBXm1HiXWj8vK7x nsqhxleLxvhJD6RcdSv8t8xmpSvUaCG76Uw4a2DPQGsmbliUvpPM+8Xw8wcBQ+/Hbiuh CBJJuhD+Yz6Btu52pXlpCmRnbkHRQZenA1kauGSGsevZGvCZhbjCF6wi8YhHH2lBrdjs oFdLhBAB4zf1OvxAA5FiHqhkFr29zHbQzXmyv0IUenapYRTnG1mJbXX+DQBywph7H0DK ZdNA== X-Gm-Message-State: ABUngverRf2wP9eAsEkoLh28jttNBA8dLIRW16nK+exATE6lDxhlnT/NNYAW2lmog7rr4Q== X-Received: by 10.107.156.75 with SMTP id f72mr4215307ioe.9.1478462075366; Sun, 06 Nov 2016 11:54:35 -0800 (PST) Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id k198sm2835339itb.18.2016.11.06.11.54.34 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Nov 2016 11:54:34 -0800 (PST) From: Alex To: bug-gnu-emacs@gnu.org Subject: 25.1; tramp-dissect-file-name signals a user-error for some invalid files Date: Sun, 06 Nov 2016 13:54:30 -0600 Message-ID: <87twbkqt8p.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This user-error affects commands such as file-remote-p and ffap. I believe that these should just return nil or no valid file instead of signalling an error. Backtrace of (file-remote-p "/uref{http://test.com}": Debugger entered--Lisp error: (user-error "Not a Tramp file name: \"/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}\"") signal(user-error ("Not a Tramp file name: \"/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}\"")) tramp-error(nil user-error "Not a Tramp file name: \"%s\"" "/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}") apply(tramp-error nil user-error "Not a Tramp file name: \"%s\"" "/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}") tramp-dissect-file-name("/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}" t) tramp-find-foreign-file-name-handler("/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}") tramp-file-name-handler(file-remote-p "/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}" nil nil) file-remote-p("/uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}") Note that when the point is in @uref in the following: @uref{http://test.com} then in Emacs 25.1+ ffap will signal the user-error as well. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 04:08:07 2016 Received: (at 24889) by debbugs.gnu.org; 8 Nov 2016 09:08:07 +0000 Received: from localhost ([127.0.0.1]:49029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c42Ny-0008WO-WA for submit@debbugs.gnu.org; Tue, 08 Nov 2016 04:08:07 -0500 Received: from mout.gmx.net ([212.227.15.18]:57542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c42Nx-0008Vu-9n for 24889@debbugs.gnu.org; Tue, 08 Nov 2016 04:08:05 -0500 Received: from detlef.gmx.de ([93.209.66.244]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M2ckv-1cvaH23yzd-00sPSc; Tue, 08 Nov 2016 10:07:58 +0100 From: Michael Albinus To: Thierry Volpiatto Subject: Re: file-remote-p should not return user-error on some strings References: <87ins1nmcs.fsf@gmail.com> Date: Tue, 08 Nov 2016 10:07:56 +0100 In-Reply-To: <87ins1nmcs.fsf@gmail.com> (Thierry Volpiatto's message of "Sun, 06 Nov 2016 07:39:15 +0100") Message-ID: <87eg2me3v7.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:UQFJyJO6SyL1yAtinmteJ4iimC7adTDRYjBjMW5zbJAkUAwwRqa H3UTEpKkTG6IoTbbQefDE9fWB+3GXtPDedwlmQ875LeKDIgXA6g+Tcq03DILA/qIo1f+na/ 422dpMhOHSxrRABUGT5Ryy0eN+/0lJQiyhN5u4rni6O+ExVWZ8Vm8ESMtW2TiK3WEMZjqil k6d7BDYJwGOgCC6s1dWzQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:ge1t4thL/5Y=:gMnZD9Wkj0x4zuz/dEF0zZ EwXWIgdl2m8X9vuPD7HvCrlR0R2ByFmoeksGjwmcr0p/DQ1Rpja8ZoB/dDVgA02NF5Vlb+jIj na1UqZEBmip0cif+eHMbn3MGIr3cnvRiNXpEhN5HauD0M3+b0fOO3Fv9QB5/nids2LHl1pYH+ x6HAbwai80vtD5ZQ/Ouaeh+XVwUgH+tu5LYf0i5W2W8C9NuzdeEIqy2HVRWFcdCiDe+PYF13a Yg0gpYqB3bstgC1wrEQbS3oldurn11sKmRvOoaHjNjnFnIFhixO0tV9SP4B2bDVRWeTntnd25 no+sTNcsp44P7yT371+fUMBrrwK9jX42q96JIt4rGjLSTnCkVRyj4FT/6t1deJUSE5LShEaLm ucKbCPxQKPVP4N/Yto64lrB0eMaoLj6sglGq6PQOOQ0eOVrOIKSjdXrs3ZXKuPCtwrhtAPKn9 Qo7bqp0NyJI/P9AoBYGamTEmmi2vUpzRAgUaBbAAFsSlgfldDabW0mVR1Mc0mqlVgRXE0A4GJ OrU9ujLsJPNQzwGTPVBo3BxNVbiqnoApRtF8wSYhppdvOYQ3xHDcS5PNLn8c7b5NjH/xqDSMa byuHHSaK8XDoemO8BwsfNTEG3gcbmTRqeCqzFx1dWaGy81OErrwQ6sSb09Ngwbv44BpHBmO5F 7L9Kw7As/j3g/sZG7xUZTvxLZ6v1834XzvCtROtn18OJkYYW8s4aiwq7Fw3gZPRE7uIJPDbpX lTVyw3CvjKaTChY/0+SmA3FwYgLXUZET5Yf4w9UvJqeiayLY9qRkQNTXcAMsqb7soZamI3cMY kG3XXv1 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 24889 Cc: 24889@debbugs.gnu.org, tramp-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Thierry Volpiatto writes: > Hi Michael, Hi Thierry, > I have a bug report at helm about an error when calling helm-find-files > on a string like `@uref{http://www.doc.ic.ac.uk/lab/cplus/c++.rules/}`. > Seeing the backtrace, it looks it comes from `file-remote-p` which > return a user-error in such case, perhaps it should return nil ? > > See https://github.com/emacs-helm/helm/issues/1638 Sorry that I come that late to you; I have been offline for a couple of days. > Note that this is not reproductible on emacs-24.5. I could reproduce it also on Emacs 24.5. Anyway, I've started yesterday working on this. Not trivial to fix, I fear. As consequence, any fix will go into the master branch (Emacs 26) only. There is also the bug report #24889 about this. Further communication shall happen there. > Thanks. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 12:18:49 2016 Received: (at 24889) by debbugs.gnu.org; 8 Nov 2016 17:18:49 +0000 Received: from localhost ([127.0.0.1]:49886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4A2r-0005Ep-5W for submit@debbugs.gnu.org; Tue, 08 Nov 2016 12:18:49 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4A2p-0005Ed-MG for 24889@debbugs.gnu.org; Tue, 08 Nov 2016 12:18:48 -0500 Received: by mail-wm0-f48.google.com with SMTP id t79so252828140wmt.0 for <24889@debbugs.gnu.org>; Tue, 08 Nov 2016 09:18:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=P8sMj3zzHsjLk4H0JbBJhXXKbzlsk56w0G0DgBkJsdE=; b=XkMBhW8daqv7pXxFNzJJkYW6pbFD4oNoxvDr9U0v/ac0znGPSSQl7kRtFs6VYzThLZ RqTFMA7J4ltY3rIUWRHhWT1f2fNXLO5jYbVoSFpjkm8czZbATYoQ5pdg6TDAAmdeeISs TiQhNtXy2iHS1eXB8214D19PF/R2o1xBb3EU99kOOIkj6QUggLtE2Gw9l/g27VhaTCt+ XJ0bt3VBPeMAbVUkoNaDnD2QRL1rXjMjeqZNMvIhApsQUETEDGM2SaoDsFfRpID+WkGE 1YcUMnOo2xx0qAcLjTSdRtG2wyyeCN9cDcosqFYw1+Yg67DAvnCt8JljZ/fephHbEnS/ 8axQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=P8sMj3zzHsjLk4H0JbBJhXXKbzlsk56w0G0DgBkJsdE=; b=T/hxrl+MBBk5eeu5HJU96/f9O6mXekhaoBe7YUc2KHqspmz5/U+I60GnoAYNvySt8M KobxiQOY27dYkf/nGo1SX0dPyPzfrJl94bpjz0aQk6t9Pg4Y1n3TnjmcZRgPbaX4cdI2 nbXCCR+E3Rmzi0gzxNY0wPJGgSF43atHye+egL3HSH/ybLBIiy1z43XCmSfwV3itPuOI COPcfBJxEYT5JXlyzSOPvTNfS/+ZioWWvxkUoJ5HYSahYIdXVo1LLcm4i86o9VeoE9Rs Ps3IaMAGS7+g6a7zWF6mbsXe+bxwologkvNys64N5r8dfMd6+qZgR1LZpZtLJ9F3cpnk XBRA== X-Gm-Message-State: ABUngvdQXRTwHWe2BHBKXnFuWSSJL61f3a2paPjWdRJfMbWhYUGd0XsijzuL9SPTdaTZMA== X-Received: by 10.28.113.197 with SMTP id d66mr16886158wmi.77.1478625522056; Tue, 08 Nov 2016 09:18:42 -0800 (PST) Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by smtp.gmail.com with ESMTPSA id wh3sm38074036wjb.49.2016.11.08.09.18.40 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 08 Nov 2016 09:18:40 -0800 (PST) References: <87ins1nmcs.fsf@gmail.com> <87eg2me3v7.fsf@gmx.de> User-agent: mu4e 0.9.17; emacs 24.5.1 From: Thierry Volpiatto To: Michael Albinus Subject: Re: file-remote-p should not return user-error on some strings In-reply-to: <87eg2me3v7.fsf@gmx.de> Date: Tue, 08 Nov 2016 18:18:38 +0100 Message-ID: <87a8d9gaa9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24889 Cc: 24889@debbugs.gnu.org, tramp-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Michael Albinus writes: > Sorry that I come that late to you; I have been offline for a couple of days. No urgency ;-). >> Note that this is not reproductible on emacs-24.5. > > I could reproduce it also on Emacs 24.5. Hmm, I will try again there to reproduce. > Anyway, I've started yesterday working on this. Great thanks. > Not trivial to fix, I fear. Yes, I saw the tramp-file-name-structure regexp is not trivial! > As consequence, any fix will go into the master branch (Emacs 26) > only. Ok. > There is also the bug report #24889 about this. Further communication > shall happen there. Ah, I see, probably it is the same user. Thanks. -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 14:47:30 2016 Received: (at 24889) by debbugs.gnu.org; 8 Nov 2016 19:47:30 +0000 Received: from localhost ([127.0.0.1]:49998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4CMk-00023D-Fb for submit@debbugs.gnu.org; Tue, 08 Nov 2016 14:47:30 -0500 Received: from mout.gmx.net ([212.227.17.22]:53390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4CMi-000230-UT for 24889@debbugs.gnu.org; Tue, 08 Nov 2016 14:47:29 -0500 Received: from detlef.gmx.de ([93.209.66.244]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MTfZc-1cD23F3dWS-00QS52; Tue, 08 Nov 2016 20:47:22 +0100 From: Michael Albinus To: Alex Subject: Re: bug#24889: 25.1; tramp-dissect-file-name signals a user-error for some invalid files References: <87twbkqt8p.fsf@gmail.com> Date: Tue, 08 Nov 2016 20:47:20 +0100 In-Reply-To: <87twbkqt8p.fsf@gmail.com> (Alex's message of "Sun, 06 Nov 2016 13:54:30 -0600") Message-ID: <87zil94uuv.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:/l+vxgqUifnCFNY9RtVRR5EIL4wnUdQTbxFIPFSJo65XxfsHwyw xd3lJkVpQfsp2Cl6I1ha9Crb5aG3qMdbZKuUuEpoNDjPy8GUX+tXibAR9Ea+4XID4LARNO/ 4GNwfft1I5RDDig/npb9aNbNbsr1gX/hknhgZLFrWM8ezQ6kwtUl10iF72xMkQA2mHWAkI0 0Ei/Q/0/+90CCxGTr91jQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:+HMNvQwq46g=:xXQcwOlUvu5k6VQ4aPKeCL gnTWSqPreDYMFns/oF1aRJuXZbfEj0/W8MUGy1jtr0QUTE7LnwjDC/ZdUqzC9xFFWtzl/S+jb uFCgaM0fPWH9CvBtiIQhHXHui/z6LkmHvVsmt+gQn1neC6IxTJAvoFhmNr0KyZVDOaRyPSuPn JQ6QdYcQrmUFukTEQg7AOQFmAHN/8QM2drUzaWB+dE2AvOriyO5nn8ZYjeiFA+/ETp8xsS/Rj U1D4fImMj9rKSf22pwqLsO2U9y+Rm7/GnuWuExgYm5sReKJir64UBXBICnVpEK2hKQuD1xAg5 AoaecmhFGu9k8qsi/ZxeG6extyM0HQ8EyA+R+oPV2jykezV80pdtE6uKjZRL3yODD3whXmHz+ qvBQzum1VqbXnx4VnVLpMrJk1YzAlZXPTcI1y8Wu8GYRFq4MVAJWHkh5GBIZyDZFKTQws4VSI DtaRrx/CmuoNkQULHpqPdLO7w7s0ToNvb1+UDTFhm27hxHuXr1y6lTIWzzPIXkX1MKQVBShfE 43YS4jjnVlcmQrKwwfq4o8z5pJoSG6aXH5tqHMi2HQrqGVJVPpZY15aU8WSMPPOjacayF6vdX 4ezSxzKXHXJBxJe6kw9sPUxI5A7cO2Zj/vvRDd4UiB94NQw1q+lrbhlh+4rKffjLLP/lAiXGD PQiHaLde0PDDbobYe8eQex1PMwJe5Y9OY2we9hQSaxSkzxMxWgiWF2TmHaJp6A1B1zoAmJSdN pDtUZ9kHllQYbtP8M4E3vXVCZL7FTQeQGje0qmP97uo01TpKhkfV/uBSeSLhFihCB6eno7tR1 FCKpnjM X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 24889 Cc: 24889@debbugs.gnu.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Alex writes: Hi Alex, > This user-error affects commands such as file-remote-p and ffap. I > believe that these should just return nil or no valid file instead of > signalling an error. > > Backtrace of (file-remote-p "/uref{http://test.com}": Thanks for the report. I could reproduce it also with Emacs 24.5. I've committed the following patch to the master branch, could you pls check whether this fixes the problem for you? --8<---------------cut here---------------start------------->8--- *** /home/albinus/src/emacs/lisp/net/tramp.el.~3424c27abb7c8ea64c32eaf54cf53fc58323e5ce~ 2016-11-08 20:22:58.382424617 +0100 --- /home/albinus/src/emacs/lisp/net/tramp.el 2016-11-08 20:21:39.625098305 +0100 *************** *** 867,890 **** See `tramp-file-name-structure' for more explanations.") ;;;###autoload ! (defconst tramp-file-name-regexp (cond ((equal tramp-syntax 'ftp) tramp-file-name-regexp-unified) ((equal tramp-syntax 'sep) tramp-file-name-regexp-separate) (t (error "Wrong `tramp-syntax' defined"))) "Regular expression matching file names handled by Tramp. ! This regexp should match Tramp file names but no other file names. ! When tramp.el is loaded, this regular expression is prepended to ! `file-name-handler-alist', and that is searched sequentially. Thus, ! if the Tramp entry appears rather early in the `file-name-handler-alist' ! and is a bit too general, then some files might be considered Tramp ! files which are not really Tramp files. ! ! Please note that the entry in `file-name-handler-alist' is made when ! this file \(tramp.el) is loaded. This means that this variable must be set ! before loading tramp.el. Alternatively, `file-name-handler-alist' can be ! updated after changing this variable. ! ! Also see `tramp-file-name-structure'.") ;;;###autoload (defconst tramp-completion-file-name-regexp-unified --- 867,880 ---- See `tramp-file-name-structure' for more explanations.") ;;;###autoload ! (defvar tramp-file-name-regexp (cond ((equal tramp-syntax 'ftp) tramp-file-name-regexp-unified) ((equal tramp-syntax 'sep) tramp-file-name-regexp-separate) (t (error "Wrong `tramp-syntax' defined"))) "Regular expression matching file names handled by Tramp. ! This regexp should match Tramp file names but no other file ! names. When calling `tramp-register-file-name-handlers', the ! initial value is overwritten by the car of `tramp-file-name-structure'.") ;;;###autoload (defconst tramp-completion-file-name-regexp-unified *************** *** 1055,1063 **** . tramp-completion-handle-file-name-all-completions) (file-name-completion . tramp-completion-handle-file-name-completion)) "Alist of completion handler functions. ! Used for file names matching `tramp-file-name-regexp'. Operations ! not mentioned here will be handled by Tramp's file name handler ! functions, or the normal Emacs functions.") ;; Handlers for foreign methods, like FTP or SMB, shall be plugged here. ;;;###tramp-autoload --- 1045,1053 ---- . tramp-completion-handle-file-name-all-completions) (file-name-completion . tramp-completion-handle-file-name-completion)) "Alist of completion handler functions. ! Used for file names matching `tramp-completion-file-name-regexp'. ! Operations not mentioned here will be handled by Tramp's file ! name handler functions, or the normal Emacs functions.") ;; Handlers for foreign methods, like FTP or SMB, shall be plugged here. ;;;###tramp-autoload *************** *** 2192,2197 **** --- 2182,2191 ---- tramp-autoload-file-name-handler)) (let ((a1 (rassq fnh file-name-handler-alist))) (setq file-name-handler-alist (delq a1 file-name-handler-alist)))) + ;; The initial value of `tramp-file-name-regexp' is too simple + ;; minded, but we cannot give it the real value in the autoload + ;; pattern. See Bug#24889. + (setq tramp-file-name-regexp (car tramp-file-name-structure)) ;; Add the handlers. (add-to-list 'file-name-handler-alist (cons tramp-file-name-regexp 'tramp-file-name-handler)) --8<---------------cut here---------------end--------------->8--- Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 15:18:43 2016 Received: (at 24889) by debbugs.gnu.org; 8 Nov 2016 20:18:44 +0000 Received: from localhost ([127.0.0.1]:50025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Cqx-0002oH-MP for submit@debbugs.gnu.org; Tue, 08 Nov 2016 15:18:43 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:36735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4Cqw-0002o1-T7 for 24889@debbugs.gnu.org; Tue, 08 Nov 2016 15:18:43 -0500 Received: by mail-it0-f48.google.com with SMTP id q124so122256714itd.1 for <24889@debbugs.gnu.org>; Tue, 08 Nov 2016 12:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=luRNb/qS1rnEWCSd34UhBdrA+IRqAZ5Blsd8Z19B5rE=; b=DFrMmj9zeejGCFLqJPM3r6fzXUlvgdveoQ45Ojv80nii27mH6xa7SuGXtkhSRNngAi FGbp25lit6ul0yrPKPHowU5JU5lKOcvvLuwOoam96KtJjVCYysBzdL8OSrAcZKtVRhkT m7yUhfxNAWbg4Z6+arAzcZDMWBRvzNIhO0xKu94U2Z58elEZkcfzG6pmcklU/Iit2jbE VLUJGPHp6Acb3nmwtrHdHde5fnFT1DQinYeZMYPRHCy9cPAizxt5LrIbkJaPz8K02G4H AAyVVtV0SZviN+qTKVKfFC9mSGgfe+MUbsMr4w8JeOIuxBcw3DCLw/oUdhaveUs6kGWq JdPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=luRNb/qS1rnEWCSd34UhBdrA+IRqAZ5Blsd8Z19B5rE=; b=Mq12gwrbF8EWOHcd6z11Xqxv/ayQS0EWNUAFv+JkMHft2494x1lIkmckQtR4v6O0RM 04ETV73OH6+1cuNGh1gSHcdR41bcFqXPuQmbp/LCuVxaeytUUz56FMdsDdLDYzCLJmlO glGPFWcKC4VmuvjoF83RR7tlTQggs3NLBkwLthOr1q5Hh9hmFdAGGMW6i4cfsB2UQoCw lqdk1SuJ5W8LCs4kmqX00QReD3zyv7kVoIMu4ogJDh4lGgYE86EIYqs1aRHnwJdR3JhS oJqd+lsLrK4WE7Q7nT57oTE1x6GGtV4fsV3rIgByM8PFWC7EZRJKId2ktYEn5DbsogXT AdYg== X-Gm-Message-State: ABUngveENbhg80IMXzVc/QB8FRKEHhTorCVPugLSilN4UxClCNJ6FogEZtY6FLIL5HFqsw== X-Received: by 10.107.57.135 with SMTP id g129mr14143853ioa.178.1478636315648; Tue, 08 Nov 2016 12:18:35 -0800 (PST) Received: from lylat (S01061859339e9903.ss.shawcable.net. [174.2.107.88]) by smtp.gmail.com with ESMTPSA id r3sm5730130iod.24.2016.11.08.12.18.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Nov 2016 12:18:35 -0800 (PST) From: Alex To: Michael Albinus Subject: Re: bug#24889: 25.1; tramp-dissect-file-name signals a user-error for some invalid files References: <87twbkqt8p.fsf@gmail.com> <87zil94uuv.fsf@gmx.de> Date: Tue, 08 Nov 2016 14:18:33 -0600 In-Reply-To: <87zil94uuv.fsf@gmx.de> (Michael Albinus's message of "Tue, 08 Nov 2016 20:47:20 +0100") Message-ID: <87fun1n2sm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24889 Cc: 24889@debbugs.gnu.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Michael Albinus writes: > Alex writes: > > Hi Alex, > >> This user-error affects commands such as file-remote-p and ffap. I >> believe that these should just return nil or no valid file instead of >> signalling an error. >> >> Backtrace of (file-remote-p "/uref{http://test.com}": > > Thanks for the report. I could reproduce it also with Emacs 24.5. > > I've committed the following patch to the master branch, could you pls > check whether this fixes the problem for you? With the latest master it seems to have fixed the problem, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 08 15:22:10 2016 Received: (at 24889-done) by debbugs.gnu.org; 8 Nov 2016 20:22:10 +0000 Received: from localhost ([127.0.0.1]:50031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4CuI-0002tz-5t for submit@debbugs.gnu.org; Tue, 08 Nov 2016 15:22:10 -0500 Received: from mout.gmx.net ([212.227.15.19]:49809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4CuG-0002tm-0u for 24889-done@debbugs.gnu.org; Tue, 08 Nov 2016 15:22:08 -0500 Received: from detlef.gmx.de ([93.209.66.244]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MC4y8-1bvNCT1pku-008t58; Tue, 08 Nov 2016 21:22:01 +0100 From: Michael Albinus To: Alex Subject: Re: bug#24889: 25.1; tramp-dissect-file-name signals a user-error for some invalid files References: <87twbkqt8p.fsf@gmail.com> <87zil94uuv.fsf@gmx.de> <87fun1n2sm.fsf@gmail.com> Date: Tue, 08 Nov 2016 21:22:00 +0100 In-Reply-To: <87fun1n2sm.fsf@gmail.com> (Alex's message of "Tue, 08 Nov 2016 14:18:33 -0600") Message-ID: <87shr14t93.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:7/783g1/IblLqIntuRJHOOG6nWDTNkf9NO04ncFd1BuWSmyLZNn Hi+fkEUqNHh8QfhkWOFTLN+BufUIq5Z/+h/FGSYVnXecKU4figQgxlGcC901BB7his5qun0 KZhbl2yfNhg3RHP6f2F280F6PbQxr8dsQFUfok788WcnNPrUV9HSiSmInp7D/R8px75p3s/ p7d1se0CRb0vGmcP8tVPw== X-UI-Out-Filterresults: notjunk:1;V01:K0:l0juPmJ+dQs=:AehjI63OhPaPP/6lCI6UVP LHs6LDWNlszmxwX9Pn5pExsp993zWNdZSx8zpN441/Ti/xyEBs75/niEQixSMI4zT1ZKHe8ew YyLq7k0cldWOUmjvd5KArX3cQiaP+QNCFYkNcupWVSYIEHHhwYmRcasPvZce6rbIWCWqFAUpx 5XXXiQyC4lL/rayRAEdrPpL9aXo+mb+JBJgbzZbdHmgutzRHdBobo/BtgwROG+4Pr2LRfqRVs QN5FqmL08wHM1CJf436J78JLU5OjozHEUWPO4gmflH1zd6tjGQoBP5Woh0vX5bGp+x9mOcAKt T7e/ClEIflyLXA3IXn9cuqMQIYmm8KmM66jXuG38jVQyHmHxYGmTdM6xifkgNMRYDExRZquu/ ePZC8UX0a/NZWoWMI7m4EIZUNcNeuJo216+xlgMJ6Ea7h7GfobhVNRT587wGyc48CCKn3q5fr nMgEJLcTX2821Ln7im+TQa1R/ADOLUD/6aHnDUbKH6s0MlOyn/mUXxW1LYg37uSrV+5ncKNV8 slJhMOMl/22cC+qKjLJ7TBRzgG28sV7D/+72KMGFS1LQKEi6LSGdc8TiVWVQs+l6iyP+AgR30 yMO9sBB6FHj1TeuX8jOf22rDcG4/tfUjaNwwXePSjjDI04mYtA9EsIM+LCAU5bVjShGDLoXNl BtdsKJ0v1aF/LSCbSS4Z7dvxVKIE/enpVCDthxziJ5o81g0cQQcY3Be82TI9w5u3B2+KYkMEd vAL9aPCbqQuil+6LUjQuZPSKWDS473LY+BOVe7d4UIXG+pmEP4q9ALBFw9xzm0MWj4+/+TpKn CqllLdm X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24889-done Cc: 24889-done@debbugs.gnu.org, Thierry Volpiatto X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Version: 26.1 Alex writes: Hi Alex, >> I've committed the following patch to the master branch, could you pls >> check whether this fixes the problem for you? > > With the latest master it seems to have fixed the problem, thanks. Thanks for checking. I'm closing the bug. Best regards, Michael. From unknown Mon Aug 11 18:19:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Dec 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator