From unknown Wed Jun 25 05:36:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#24879 <24879@debbugs.gnu.org> To: bug#24879 <24879@debbugs.gnu.org> Subject: Status: [PATCH] Point out the default value of FRAME in the `set-face-*' functions. Reply-To: bug#24879 <24879@debbugs.gnu.org> Date: Wed, 25 Jun 2025 12:36:37 +0000 retitle 24879 [PATCH] Point out the default value of FRAME in the `set-face= -*' functions. reassign 24879 emacs submitter 24879 Hong Xu severity 24879 normal tag 24879 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 16:29:28 2016 Received: (at submit) by debbugs.gnu.org; 4 Nov 2016 20:29:28 +0000 Received: from localhost ([127.0.0.1]:45119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2l7A-0006Eq-3s for submit@debbugs.gnu.org; Fri, 04 Nov 2016 16:29:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2l78-0006Ee-ME for submit@debbugs.gnu.org; Fri, 04 Nov 2016 16:29:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2l72-0001hR-J5 for submit@debbugs.gnu.org; Fri, 04 Nov 2016 16:29:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52317) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2l72-0001hE-Fr for submit@debbugs.gnu.org; Fri, 04 Nov 2016 16:29:20 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2l71-00066M-BV for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 16:29:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2l6y-0001by-8e for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 16:29:19 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21330) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2l6y-0001YA-0r for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 16:29:16 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1478291351688532.6576345469533; Fri, 4 Nov 2016 13:29:11 -0700 (PDT) From: Hong Xu To: bug-gnu-emacs@gnu.org Subject: [PATCH] Point out the default value of FRAME in the `set-face-*' functions. Date: Fri, 4 Nov 2016 13:29:10 -0700 Message-Id: <1478291350-19807-1-git-send-email-hong@topbug.net> X-Mailer: git-send-email 2.1.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) --- Feel free to make changes. doc/lispref/ChangeLog.1 | 5 +++++ doc/lispref/display.texi | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/lispref/ChangeLog.1 b/doc/lispref/ChangeLog.1 index 610e7541e7de..e492a607368d 100644 --- a/doc/lispref/ChangeLog.1 +++ b/doc/lispref/ChangeLog.1 @@ -1,3 +1,8 @@ +2016-11-04 Hong Xu + + * display.texi (Attribute Functions): Point out the default value + of FRAME in the various `set-face-*` functions. + 2015-03-29 Glenn Morris * objects.texi (Equality Predicates): Fix typo in example. diff --git a/doc/lispref/display.texi b/doc/lispref/display.texi index 2e316f8a532c..b19bfa9ef5c2 100644 --- a/doc/lispref/display.texi +++ b/doc/lispref/display.texi @@ -2644,8 +2644,8 @@ Attribute Functions The following commands and functions mostly provide compatibility with old versions of Emacs. They work by calling -@code{set-face-attribute}. Values of @code{t} and @code{nil} for -their @var{frame} argument are handled just like +@code{set-face-attribute}. Values of @code{t} and @code{nil} +(default) for their @var{frame} argument are handled just like @code{set-face-attribute} and @code{face-attribute}. The commands read their arguments using the minibuffer, if called interactively. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 17:31:38 2016 Received: (at 24879) by debbugs.gnu.org; 4 Nov 2016 21:31:38 +0000 Received: from localhost ([127.0.0.1]:45148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2m5K-0007eq-LB for submit@debbugs.gnu.org; Fri, 04 Nov 2016 17:31:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2m5I-0007eb-TX for 24879@debbugs.gnu.org; Fri, 04 Nov 2016 17:31:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2m58-000543-HA for 24879@debbugs.gnu.org; Fri, 04 Nov 2016 17:31:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2m58-00053u-Di; Fri, 04 Nov 2016 17:31:26 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c2m57-0002O4-O5; Fri, 04 Nov 2016 17:31:26 -0400 Date: Fri, 04 Nov 2016 23:31:50 +0200 Message-Id: <83k2cjj5ix.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: <1478291350-19807-1-git-send-email-hong@topbug.net> (message from Hong Xu on Fri, 4 Nov 2016 13:29:10 -0700) Subject: Re: bug#24879: [PATCH] Point out the default value of FRAME in the `set-face-*' functions. References: <1478291350-19807-1-git-send-email-hong@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.3 (-------) X-Debbugs-Envelope-To: 24879 Cc: 24879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.3 (-------) > From: Hong Xu > Date: Fri, 4 Nov 2016 13:29:10 -0700 > > The following commands and functions mostly provide compatibility > with old versions of Emacs. They work by calling > -@code{set-face-attribute}. Values of @code{t} and @code{nil} for > -their @var{frame} argument are handled just like > +@code{set-face-attribute}. Values of @code{t} and @code{nil} > +(default) for their @var{frame} argument are handled just like > @code{set-face-attribute} and @code{face-attribute}. The commands > read their arguments using the minibuffer, if called interactively. Do we really need to tell people that an omitted argument defaults to nil? And if we do, why in this section? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 04:17:52 2016 Received: (at 24879) by debbugs.gnu.org; 5 Nov 2016 08:17:52 +0000 Received: from localhost ([127.0.0.1]:45370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2wAi-0002eH-4J for submit@debbugs.gnu.org; Sat, 05 Nov 2016 04:17:52 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2wAe-0002e7-Uo for 24879@debbugs.gnu.org; Sat, 05 Nov 2016 04:17:49 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1478333862423339.0811797038881; Sat, 5 Nov 2016 01:17:42 -0700 (PDT) References: <1478291350-19807-1-git-send-email-hong@topbug.net> <83k2cjj5ix.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 25.1.50.1 From: Hong Xu To: Eli Zaretskii Subject: Re: bug#24879: [PATCH] Point out the default value of FRAME in the `set-face-*' functions. In-reply-to: <83k2cjj5ix.fsf@gnu.org> Date: Sat, 05 Nov 2016 01:17:38 -0700 Message-ID: <878tsyjq71.fsf@topbug.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 24879 Cc: 24879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.6 (/) --=-=-= Content-Type: text/plain On 2016-11-04 Fri 14:31 GMT-0700, Eli Zaretskii wrote: > Do we really need to tell people that an omitted argument defaults to > nil? And if we do, why in this section? Hmm, I didn't notice that we don't say optional args are default to nil in the doc. Never mind, we should close this bug. Despite that, I sort of see some confusion in the doc when mentioning optional args: Sometimes we say "omitted or nil" (e.g., face-all-attributes FRAME arg), sometimes we just say "nil" (e.g., face-attribute FRAME arg). Perhaps more consistency is less confusing. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYHZWiAAoJECZsfTOCL4R4FMwQANniZ2qFJoQ6IuRnmRSuVdQl PFQluLyWKJcESo3haZs4LOdAAWIFonqcRALmHLkLnQOSLsJmgfXfTLtPWCqxR0O+ 5LPNQEG0Uya+k1KZQnFYXjI/Nrlpd9EqebYtq1/0iq8KF93+jmB50fxyWft9tl+L dgc+UQrgd6YeWBePEinnxZdGs4++jkqRl0BgzMdYZe5m9rZD4pSkhaUJ2VWzRaVX 8Bi2SO9plliK3WIWUnkEmp75kl91N/oXY8tSZBisBRpHPyMNgVYYdw5GwQhxRx0+ fckphRxi0eMZtklpTmV8Kh3RAhSuFK2M4PHiJx++RBL+6iZ7NbwrNfw6LEG0Mg7P oZEl96uE/ObVlgTBwN9NGMQoGpAJ3+b2PZHmYHP7FxgTy8DGDbkFa4ZnklVaRO1Z eL3aMfzes+wP710bNa3iYjh6bFFv8K+1aMxUG320KxXuqu0luKYenndfJDJb2rmv LXNUP6MLcxDzmnMmCg3jnMlfT4JZKLhbuMPLi0DLI3xEIf/ZuPOL8LhxXufcW+ib ncCKpn2au8Sf5UVeySQAjGpkCoHpfNyFw0+sam1EFRlJlkpvUOmFQ9CcE2WMxaDY Pcn3gCVkhaQCbUuOAMX93Xp4UuPBhBEHhO/YUgKYJovatCJjjEtAsWjw8s40WSWv Yn/x5OTMpGM9CjKp0JmW =ygP3 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 04:55:46 2016 Received: (at 24879-done) by debbugs.gnu.org; 5 Nov 2016 08:55:46 +0000 Received: from localhost ([127.0.0.1]:45385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2wlO-0003XX-7E for submit@debbugs.gnu.org; Sat, 05 Nov 2016 04:55:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2wlL-0003XI-SX for 24879-done@debbugs.gnu.org; Sat, 05 Nov 2016 04:55:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2wlD-0005Kn-GI for 24879-done@debbugs.gnu.org; Sat, 05 Nov 2016 04:55:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2wlD-0005Kd-Ci; Sat, 05 Nov 2016 04:55:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2951 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c2wlC-0005Ht-LK; Sat, 05 Nov 2016 04:55:35 -0400 Date: Sat, 05 Nov 2016 10:56:00 +0200 Message-Id: <83d1iajof3.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: <878tsyjq71.fsf@topbug.net> (message from Hong Xu on Sat, 05 Nov 2016 01:17:38 -0700) Subject: Re: bug#24879: [PATCH] Point out the default value of FRAME in the `set-face-*' functions. References: <1478291350-19807-1-git-send-email-hong@topbug.net> <83k2cjj5ix.fsf@gnu.org> <878tsyjq71.fsf@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.3 (-------) X-Debbugs-Envelope-To: 24879-done Cc: 24879-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.3 (-------) > From: Hong Xu > Cc: 24879@debbugs.gnu.org > Date: Sat, 05 Nov 2016 01:17:38 -0700 > > Despite that, I sort of see some confusion in the doc when mentioning > optional args: Sometimes we say "omitted or nil" (e.g., > face-all-attributes FRAME arg), sometimes we just say "nil" (e.g., > face-attribute FRAME arg). Perhaps more consistency is less confusing. Thanks, I made sure we mention this consistently in that node. From unknown Wed Jun 25 05:36:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 Dec 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator