From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 06:54:47 2016 Received: (at submit) by debbugs.gnu.org; 4 Nov 2016 10:54:47 +0000 Received: from localhost ([127.0.0.1]:43436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2c90-00046s-PP for submit@debbugs.gnu.org; Fri, 04 Nov 2016 06:54:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2c8z-00046h-Iy for submit@debbugs.gnu.org; Fri, 04 Nov 2016 06:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2c8t-0008DN-91 for submit@debbugs.gnu.org; Fri, 04 Nov 2016 06:54:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c2c8t-0008D5-4o for submit@debbugs.gnu.org; Fri, 04 Nov 2016 06:54:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2c8r-0000z4-Jf for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 06:54:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2c8n-00083V-GN for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 06:54:37 -0400 Received: from mail-vk0-x231.google.com ([2607:f8b0:400c:c05::231]:34623) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2c8n-000817-8Z for bug-gnu-emacs@gnu.org; Fri, 04 Nov 2016 06:54:33 -0400 Received: by mail-vk0-x231.google.com with SMTP id x186so63569022vkd.1 for ; Fri, 04 Nov 2016 03:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=QPYJaXUHJ2c3QU1iKK2ystnQynnQXjkeI5wqoEnuPgM=; b=MTlIZ0Xa++hWS0NjHC5TsXObGEcE016L0yleZpwfttgriGiZ+gs/aQDbkGsea0P+aU S3S5imR/VQg6IT6HXGUyV5fG/xVz45HpSfRrB0ENjYneq0UQnJ7a2e23vCIAiStDxaFI ahGWChGhCgUmZ7ywdcmg/6pzm5viLahwx8wgZXJyhREsy8yRERhk4Jp7srSbNSqwTJO3 xf2yAQZP4ISSk9euEtSyLxQxf5Jhj8bUFBLROnACyeY/bt7W/uR6lQrOxl4HlduSjB9m 2hBMFsknjwc8P1vF6K+Zmu3aaIjFzmhGt/OLL+qdUW95k87w/CYSlRHz5IEcihRaAIoW SkYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QPYJaXUHJ2c3QU1iKK2ystnQynnQXjkeI5wqoEnuPgM=; b=LomDJhMxrXOKeaTBAaGGsMR7y+5l86XyhbbWi3BklISYmgSzxF7Ht2rLkfey7XaCgp w/jLe3MY7N0DE3rgvWeGtWGLBlOMR60pS2eok0N/l1uXN1NFShSWoo3SbaGD5Fg+w4Uc +ubHJoNzTPJCcEUtsNxQfL7l3kIkuDynnGuPj+5fPCks4arx+72oExxBC1O6X6CZmt3D GietqhOr7ts5nAZQEzrKoIjJXZFCFDaSC7Wgh0294AQsTboTtn/Bes3NmcXrbBF/Vevo cy/OMomVIkuaSb6rXAcR14bcxpbwExcyGOCRKali6WjcBLVEQHQXlxp2+nSlfiRsEyBn r/FA== X-Gm-Message-State: ABUngvd6f1hs4kGoXdJJ49ppa/OwfZniZGQJC+G6BENula+xsYMiYo+B6k7RiHKuWfM93VziBvmPZcP5GAPzhA== X-Received: by 10.31.4.210 with SMTP id 201mr10921693vke.105.1478256871008; Fri, 04 Nov 2016 03:54:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.66 with HTTP; Fri, 4 Nov 2016 03:54:00 -0700 (PDT) From: Richard Copley Date: Fri, 4 Nov 2016 10:54:00 +0000 Message-ID: Subject: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list To: "bug-gnu-emacs@gnu.org" Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Recipe from emacs -Q: M-< ;; beginning-of-buffer C-M-s text ;; isearch-forward-regexp M-% xxx RET ! ;; isearch-query-replace C-M-% ;; query-replace-regexp M-p ;; previous-history-element Expected result: selects the previous replace operation "text -> xxx" from the history list. Actual result: signals "user-error: Beginning of history; no preceding item". The bug affects isearch-query replace when invoked during isearch-forward-regexp but not when invoked during isearch-forward. The bug was introduced in the master branch between these two revisions (not tight bounds, just builds I have lying around): GOOD: commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 Author: Paul Eggert Date: Sat Sep 17 15:06:24 2016 -0700 BAD: commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 Author: Tino Calancha Date: Tue Oct 11 11:47:32 2016 +0900 In GNU Emacs 26.0.50.1 (x86_64-w64-mingw32) of 2016-10-11 built on 60678UHB Repository revision: 9640e9f4e95cd95c04875e90a4ff638e1e51f977 Windowing system distributor 'Microsoft Corp.', version 6.1.7601 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Mark set [2 times] Replaced 2 occurrences user-error: Beginning of history; no preceding item Quit Configured using: 'configure --prefix /C/emacs/emacs-20161011-024732 --with-modules --without-imagemagick --disable-dependency-tracking --enable-locallisppath=%emacs_dir%/../site-lisp CFLAGS=-O3 CPPFLAGS=-D_WIN32_WINNT=_WIN32_WINNT_WIN7' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES Important settings: value of $LANG: ENG locale-coding-system: cp1252 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt misearch multi-isearch time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify dbusbind w32 multi-tty make-network-process emacs) Memory information: ((conses 16 99599 14680) (symbols 56 20290 0) (miscs 48 45 149) (strings 32 19347 4182) (string-bytes 1 591428) (vectors 16 13522) (vector-slots 8 442624 4747) (floats 8 181 146) (intervals 56 247 16) (buffers 976 11)) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 07:02:14 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 11:02:14 +0000 Received: from localhost ([127.0.0.1]:43451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2cGC-0004KA-Ls for submit@debbugs.gnu.org; Fri, 04 Nov 2016 07:02:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43205) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2cGA-0004Jw-HG for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 07:02:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2cG2-0000Xa-8Q for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 07:02:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55385) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2cG2-0000XS-55; Fri, 04 Nov 2016 07:02:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2275 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c2cG1-0002Cf-9Q; Fri, 04 Nov 2016 07:02:01 -0400 Date: Fri, 04 Nov 2016 13:02:23 +0200 Message-Id: <831syrld8g.fsf@gnu.org> From: Eli Zaretskii To: Richard Copley In-reply-to: (message from Richard Copley on Fri, 4 Nov 2016 10:54:00 +0000) Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.3 (-------) X-Debbugs-Envelope-To: 24873 Cc: 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.3 (-------) > From: Richard Copley > Date: Fri, 4 Nov 2016 10:54:00 +0000 > > The bug was introduced in the master branch between these two revisions > (not tight bounds, just builds I have lying around): > > GOOD: > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > Author: Paul Eggert > Date: Sat Sep 17 15:06:24 2016 -0700 > > BAD: > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > Author: Tino Calancha > Date: Tue Oct 11 11:47:32 2016 +0900 Is this the result of turning on lexical-binding in iserach.el? From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 07:17:03 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 11:17:03 +0000 Received: from localhost ([127.0.0.1]:43459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2cUZ-0004em-HQ for submit@debbugs.gnu.org; Fri, 04 Nov 2016 07:17:03 -0400 Received: from mail-ua0-f180.google.com ([209.85.217.180]:36798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2cUX-0004eF-Nx for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 07:17:02 -0400 Received: by mail-ua0-f180.google.com with SMTP id b35so63202232uaa.3 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 04:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2zAUbKGYjsfy7fGco13m/LNStouIREcn2/vWcNOZIJE=; b=CQWTif1SgJId1OtJB4NBtHxBua33XzEZJFAsMXJwUVS3Ph6cmths1xek5WKlWMXSjS B9qhh8PoHWuC6zTUHdBFpWmEMpbjjphl771qEzVM9MgYIBImh65cuHiMtgAwtzaoTWhh tBIveETgpLh0q6DmB6kmkIzl+cdTgV4qh3v/UWwa9cz6vQez+ChqHJM+rbL5VwRt40im JavWnw7EKRXxrKP7e3dnhBcJV+2e3Tp/n6CxWTAC06ij/J9YawgFaW6kKSQerfL20zJy +iFnCEzozc3kC71IOGBEmGdeUhBisN7ls6rXr1f40QYUoPaq+aRNbHPZvNOwy/mjMVq0 5gXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2zAUbKGYjsfy7fGco13m/LNStouIREcn2/vWcNOZIJE=; b=mA26woCIku/QkHE07w6Yk3vVEafg1Dym4JUts33bi0aM+/1WeDT1TrYI8AS9Knu6zt ePhALJbgYb0HSUIXkCd/osEO95OmEnIukxHXKw56tJl1+MkiZBW8B5YyRPgGltPQvLDF 2Zg5Z6Ng9J+DfPqA/ksG9hUMt32PzvuEnB/35caUgr6tAU3jcIG/s3g+jEjIusNS5Eae GcI7vhtBKCDHzosIHUc5g3PSX94vbHWsDlsRmC4ufzDK6BmNyrvqi0TZ7PJXgIdhaDbT ERrRw6CmVDp7deCxFu2ASh9disgjWAcX3c+ps1/6ns54boKbMTPTE1Tb9FIYy8y9UHQu ZU2w== X-Gm-Message-State: ABUngvcIT4ONDsQ+A4z81sJC3cjUl3HV6GkOjhCc77N8mdvXAEmmowrtBHgvnn1yfa54y/9iqTjGhWDPTcXKrw== X-Received: by 10.176.82.157 with SMTP id v29mr9566079uav.123.1478258216093; Fri, 04 Nov 2016 04:16:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.66 with HTTP; Fri, 4 Nov 2016 04:16:55 -0700 (PDT) Received: by 10.176.16.66 with HTTP; Fri, 4 Nov 2016 04:16:55 -0700 (PDT) In-Reply-To: <831syrld8g.fsf@gnu.org> References: <831syrld8g.fsf@gnu.org> From: Richard Copley Date: Fri, 4 Nov 2016 11:16:55 +0000 Message-ID: Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list To: Eli Zaretskii Content-Type: multipart/alternative; boundary=94eb2c18f88adb4b45054077cf71 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24873 Cc: 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --94eb2c18f88adb4b45054077cf71 Content-Type: text/plain; charset=UTF-8 Thanks, I'll check, but I can't do it now. In about 8 hours unless someone beats me to it. On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: > > From: Richard Copley > > Date: Fri, 4 Nov 2016 10:54:00 +0000 > > > > The bug was introduced in the master branch between these two revisions > > (not tight bounds, just builds I have lying around): > > > > GOOD: > > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > > Author: Paul Eggert > > Date: Sat Sep 17 15:06:24 2016 -0700 > > > > BAD: > > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > > Author: Tino Calancha > > Date: Tue Oct 11 11:47:32 2016 +0900 > > Is this the result of turning on lexical-binding in iserach.el? > --94eb2c18f88adb4b45054077cf71 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Thanks, I'll check, but I can't do it now. In about = 8 hours unless someone beats me to it.


On 4 Nov 2016 11:= 02, "Eli Zaretskii" <eliz@gnu.= org> wrote:
&= gt; From: Richard Copley <rcopley@g= mail.com>
> Date: Fri, 4 Nov 2016 10:54:00 +0000
>
> The bug was introduced in the master branch between these two revision= s
> (not tight bounds, just builds I have lying around):
>
> GOOD:
> commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
> Author: Paul Eggert <eggert@c= s.ucla.edu>
> Date:=C2=A0 =C2=A0Sat Sep 17 15:06:24 2016 -0700
>
> BAD:
> commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
> Author: Tino Calancha <t= ino.calancha@gmail.com>
> Date:=C2=A0 =C2=A0Tue Oct 11 11:47:32 2016 +0900

Is this the result of turning on lexical-binding in iserach.el?
--94eb2c18f88adb4b45054077cf71-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 15:03:57 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 19:03:57 +0000 Received: from localhost ([127.0.0.1]:45053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2jmP-0004DJ-9O for submit@debbugs.gnu.org; Fri, 04 Nov 2016 15:03:57 -0400 Received: from mail-vk0-f54.google.com ([209.85.213.54]:33950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2jmO-0004D7-Aq for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 15:03:56 -0400 Received: by mail-vk0-f54.google.com with SMTP id x186so75029626vkd.1 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 12:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vbe8O2wIKA+6nkkjX3dFEyP3qGC82pFF7QJGfC51FSs=; b=cjF72IZlXHoBEnibTzvnFZFmfgEXx3YPY7Ek8+143Ah3aq5O4QtDU2BamY4MV1XkVn dgCiyB+/NVwGzs8r1AXdfm1PlESAWKhw+hZKK5VcuxtfoVtMPoEswUIIE0Y+yzpoF5W7 vTDdSvCufD357dqjEHokkkcomx5JTEABO04Rsj45yQHROf7insAcPxd/HGQLN6mUwo7m 4LaCs4wd+gXeFYB0ddRoOCn9kdmjPVaYDytKYNfIE67EBYUaRYWj+AO3st4bKcJhlBJo Af9Afm0fz9xZH3crG0+QLbfKzYD53WZg7JGzbrdAXg8Oc6K79RWXt8/BmGTnXCZN9mZH 3qEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vbe8O2wIKA+6nkkjX3dFEyP3qGC82pFF7QJGfC51FSs=; b=TyuoDBXiSb2tgPJTSGvYWgr0CG1dvgL1rh+v6kNH4B6DjmG4TWLBZ/SDuZsqbjuqvt Ii92nQbiEI5PbpZOhnqcnnnYZkBvLqrLpGMFGQcuQGlcoMAUhygqUEcvQVoM+W8cO7GU ERDK2N4mKRVbonolVj2cYVcDAUnBCzE7ajmIZDqb0qrvcuVSQSsc4fu6tSEfolCQQw1P pFdU3nnR9iChmZgiLNhd8sw96G6LCrzFXzmQsDWQ0QHhG0X+ZT7g9tF4Z6hgjZoiC90Z sjPSVOC2AhmqvEBXGfY2QKzHyZUH3Q8dQCXG7y0+H952tlkRE0D5D4iBbflryslw7XNz Pp4g== X-Gm-Message-State: ABUngvfuk8Zr+U7nIG1PJYWaDSjbeWrbWodbhpwNCDAAZ/VFYnqMrjT+D/odIafP1gvtAkfHCK6jEcIy8003Tw== X-Received: by 10.31.205.1 with SMTP id d1mr12352124vkg.18.1478286230819; Fri, 04 Nov 2016 12:03:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.66 with HTTP; Fri, 4 Nov 2016 12:03:20 -0700 (PDT) In-Reply-To: References: <831syrld8g.fsf@gnu.org> From: Richard Copley Date: Fri, 4 Nov 2016 19:03:20 +0000 Message-ID: Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list To: Eli Zaretskii , Mark Oteiza Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24873 Cc: 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 4 November 2016 at 11:16, Richard Copley wrote: > On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: >> >> > From: Richard Copley >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> > >> > The bug was introduced in the master branch between these two revisions >> > (not tight bounds, just builds I have lying around): >> > >> > GOOD: >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> > Author: Paul Eggert >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> > >> > BAD: >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> > Author: Tino Calancha >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> Is this the result of turning on lexical-binding in iserach.el? > > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone > beats me to it. Yep, you nailed it. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 15:35:23 2016 Received: (at 24873-done) by debbugs.gnu.org; 4 Nov 2016 19:35:23 +0000 Received: from localhost ([127.0.0.1]:45066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2kGp-0004yR-0f for submit@debbugs.gnu.org; Fri, 04 Nov 2016 15:35:23 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:36477) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2kGm-0004yD-KM for 24873-done@debbugs.gnu.org; Fri, 04 Nov 2016 15:35:21 -0400 Received: by mail-qk0-f172.google.com with SMTP id o68so110344856qkf.3 for <24873-done@debbugs.gnu.org>; Fri, 04 Nov 2016 12:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jOuzqzFYOepLLcafrbu55/+YQkFj/vpv9ucjBpvtKlA=; b=2TsclbgsGafXlDxTFsVqj7e7C2VO3jiY+FWpjZKVvkZoKF+K7fJNnghggkS9/p24fz xy8AdQSZ/evO4SZ/ABDh3YHm1ylrQHrVA2u6vdEMrfiTuevQ/3UMLRYHLnH6/4Y1lNHk 5/77pjclftWNzrwqC+1YZrJZi/bGGOSe7qNiBkNoWTXgWEH/s4tqQFPssXkF68q80Ivn i7bKelrqZXTbrs6jScYVbmXoe17121dnWLitT4x8NkCeBa/12yy25SwqrCe1A8QGNQ1G LGa2ss8V+sZ2YZpsf92gqRJrHAoZpvVlBgx6OSEmpQo7MWVrGAj+MzESp/VAU6DtLUdX i22Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jOuzqzFYOepLLcafrbu55/+YQkFj/vpv9ucjBpvtKlA=; b=ii98HShhwls7zBSlav8pILKCgwG0AwLPJU4xgiFMambdvi+UaStM4J4+tSC6I2UezZ KaG8m09Th8YjoAEp7vqjrhwGPPcKkufyLohOjWJ2nMsFW24nG9Q0d5skTBAi1oOZw1T4 KrSPFR1QLroX5MgJuUNbLnfIoiwCJb6u4ZEzHaH5Ira3jX32QSqPPr8MJ/l+tJdrmaHd ao6uwPyT48oPrh/MfVKPotUSAc3QVnAsbPSc+4p6AR1w4511mt7F5O8SA8SDLe8YJ5zL iBOyIpM5dxAaSvFbBiT5JobRM9JkrUJ2Gsee0s39PSQ6+WKr5ZSGd2lGmVQ7hM2vGCeW bzZQ== X-Gm-Message-State: ABUngvfDEQm82DjEneyLwrdiHHwaeOBBgyzyzVr+DND9Avzro7Nn+xVeOPVz0iBUba/hPJgK X-Received: by 10.55.10.7 with SMTP id 7mr14034546qkk.162.1478288114877; Fri, 04 Nov 2016 12:35:14 -0700 (PDT) Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id l135sm8431636qke.13.2016.11.04.12.35.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Nov 2016 12:35:14 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 3717866231; Fri, 4 Nov 2016 15:35:13 -0400 (EDT) Date: Fri, 4 Nov 2016 15:35:13 -0400 From: Mark Oteiza To: Richard Copley Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Message-ID: <20161104193513.GA22185@holos.localdomain> References: <831syrld8g.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24873-done Cc: Eli Zaretskii , 24873-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On 04/11/16 at 07:03pm, Richard Copley wrote: > On 4 November 2016 at 11:16, Richard Copley wrote: > > On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: > >> > >> > From: Richard Copley > >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 > >> > > >> > The bug was introduced in the master branch between these two revisions > >> > (not tight bounds, just builds I have lying around): > >> > > >> > GOOD: > >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > >> > Author: Paul Eggert > >> > Date: Sat Sep 17 15:06:24 2016 -0700 > >> > > >> > BAD: > >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > >> > Author: Tino Calancha > >> > Date: Tue Oct 11 11:47:32 2016 +0900 > >> > >> Is this the result of turning on lexical-binding in iserach.el? > > > > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone > > beats me to it. > > Yep, you nailed it. This was fixed already--your recipe works as expected for me. See bug#24580 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 15:59:55 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 19:59:55 +0000 Received: from localhost ([127.0.0.1]:45086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2keY-0005X2-UL for submit@debbugs.gnu.org; Fri, 04 Nov 2016 15:59:55 -0400 Received: from mout.gmx.net ([212.227.15.19]:64349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2keW-0005Wp-UE for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 15:59:53 -0400 Received: from rosalinde ([89.245.89.33]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0McmFl-1cKYeP2TWT-00HvGU; Fri, 04 Nov 2016 20:59:44 +0100 From: Stephen Berman To: 24873@debbugs.gnu.org Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> Date: Fri, 04 Nov 2016 20:59:43 +0100 In-Reply-To: <20161104193513.GA22185@holos.localdomain> (Mark Oteiza's message of "Fri, 4 Nov 2016 15:35:13 -0400") Message-ID: <87lgwzc8y8.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:I5wa5pn2sxdeTw/15TPeQoSJoFQPiSDVaNiw9IjRQ7StaiRQvuV nyBl98ymmUSI1zFTY4gG0DPvDgGgjgbteN8O8zhl+nErM2g9bl1dXGd3KpYfGI4IcG6b2KW epz5253eB3+310CPZ5VgVJcCKEB/liHwtAI4NxQYkXay1+8wUHRinI8f0jegag83DQF5Mqm mrAXI9Yq5m++rPjAqZLEg== X-UI-Out-Filterresults: notjunk:1;V01:K0:+vrgmDZ4qv8=:ChPKtiNrAfvAPO+a0YvjXM 5PWpE9X4mID7rvN+hyF3L/9lNRwTnrVZ+yfQNUlqGKZXBYKgJRwZpgcXec/NODhdeKPCE1HNh t08RQUz49B/80+9ki/FKSS2O0aFgKIBg8zyJQTX9w9FH1nvZQmYQJCD8GPR602LP9ncPTtitb DWbEBCJw19wnKeIExSsH5Ror9yu9ziGyMqW2agUfhHQFBNMpWPxjo8aIhau3ethvuj2Eyjo2V DBwyHHwcCEhSBx2m+Kwo2B8DrBBzuR8Pu5h3P+P0FKYq7tUcOw+41quk2ZNwVMpUPPthT9ylD vMwXwOQY+eiZeymr3WzX6e2hqxrsWZVICaXFmcmwoeEoZFTkZ4kZdkzHsHWtd/VW8KF2eEbW/ rHdzHRSA2MeHUuI57SZ50Nbhmrtcn0w1iT+E/XTnozRl6GUCMGfqBbvfOpAMI8eIl0vCg3oes aNiFTpZkJtR5rIT6Gmw331PUKbqUEyQTTPRvQj+JqMGyEt1lM05ARSg2G01mI3+O4RzSRLmHN oWXhzfTt7jotzXfT9O0zOdeoTruGmGNzPwSXSMeQS8Aj/6jBZgRVmdwdQoeYG8YWU4ByU2XYU oLXq4Ryqi/+Bw5BALwEI204TGRNVyZiHJOIEPa33cLVDPBxA14lVCuVYaSaigZr9TKr4Xb5rH 3j8HfK7YTGdhvQg5mqfuVFZokFOUDNSNSkkpQ52VygpugGj2WuQljRlRowLoqVvAliekwsbUF LDIqu50CIiba9mTFsoV6+yEjzIydjvB3zP9IMVZ26nz3rWTxW9yphHN7pj/m6+NtRcwVSw+6J jJ7nbiQ X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 24873 Cc: mvoteiza@udel.edu, rcopley@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza wrote: > On 04/11/16 at 07:03pm, Richard Copley wrote: >> On 4 November 2016 at 11:16, Richard Copley wrote: >> > On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: >> >> >> >> > From: Richard Copley >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> >> > >> >> > The bug was introduced in the master branch between these two revisions >> >> > (not tight bounds, just builds I have lying around): >> >> > >> >> > GOOD: >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> >> > Author: Paul Eggert >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> >> > >> >> > BAD: >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> > Author: Tino Calancha >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> >> >> Is this the result of turning on lexical-binding in iserach.el? >> > >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone >> > beats me to it. >> >> Yep, you nailed it. > > This was fixed already--your recipe works as expected for me. See bug#24580 My build contains the commit referenced in bug#24580 as fixing it, but I can still reproduce the problem with the OP's recipe (i.e. with -Q). Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 16:53:38 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 20:53:38 +0000 Received: from localhost ([127.0.0.1]:45136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2lUY-0006o1-5N for submit@debbugs.gnu.org; Fri, 04 Nov 2016 16:53:38 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:33376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2lUW-0006nl-JR for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 16:53:37 -0400 Received: by mail-qk0-f177.google.com with SMTP id x190so111240487qkb.0 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 13:53:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=he+PPa7hgVAB8xmWdN0sYwWY4nJmRSrQg/iIIT9p0g8=; b=iIv8kCxxS7VVQcfJMv3jpZV37ZXzs2fYnAnrZnZmWX0soEuIYuNHMMXe+B9/6pmBDt D1zovLibfoMscZHhmB1IFCxEBKKhoea8SG40Gn8A+LHxy1Tx2KkZkBW0rAHvfmwkhLK4 V1AhjvzVegEcIS5A79MKBb+3qBYP9fjPZjE4m88HkOd4BcjUKDtIk+Pshd2G9aNFVTlm AlTAKUYbOz+hu8IOzN1y60ZWHUGHCM3de49d2cpQlrEqat2y3CPwrRd3RFCknFHm5RF4 O5l9lHstU1XHf67435vI9WjdybhGMaaRFXtlBdQd+QxGNDFQirLwLUuAPD3joZDrgR9z jr8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=he+PPa7hgVAB8xmWdN0sYwWY4nJmRSrQg/iIIT9p0g8=; b=lrsXAnF32ZyOcoBBq5nJb6dX75UuoGIiRKcoiJ2TOa9Q78++qC3PS0w2avT4SERZ29 ZdQ2afCBNayhIO+no/Wo/7zjQ6bZXily/yQ+DJyEjdo2nt81Ge1areQXUjwSbos7sre7 v47yqKO9m2NcZ2o3ALuZae0s73I6LPzTOknqRtIsfj5zYwlxqqHjGM+9ySz9dy9bWXeQ EnEDoQb99kvXpcn7cP6oufJrHNhZl4HJs2VQtrrINRU59kFEfK5LdZmcnHm08aqTNwjw xWiU7vjVEJu1AMdQC7TrdEQamoebNHsXGifdi9eXmZaKArlcneHNKVRB7TL68B5Wt8J4 aHsw== X-Gm-Message-State: ABUngvcpj/NhqUCJLnLrUvMQE7PR3RoGFsDOxGg+48+fANN+KWnGkyPP9vUav/GWneQ3kzfO X-Received: by 10.55.183.3 with SMTP id h3mr16992337qkf.33.1478292811045; Fri, 04 Nov 2016 13:53:31 -0700 (PDT) Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id x13sm8622506qkb.45.2016.11.04.13.53.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Nov 2016 13:53:29 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 2860B66231; Fri, 4 Nov 2016 16:53:29 -0400 (EDT) Date: Fri, 4 Nov 2016 16:53:29 -0400 From: Mark Oteiza To: Stephen Berman Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Message-ID: <20161104205329.GA24042@holos.localdomain> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lgwzc8y8.fsf@gmx.net> User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24873 Cc: rcopley@gmail.com, 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 04/11/16 at 08:59pm, Stephen Berman wrote: > On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza wrote: > > > On 04/11/16 at 07:03pm, Richard Copley wrote: > >> On 4 November 2016 at 11:16, Richard Copley wrote: > >> > On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: > >> >> > >> >> > From: Richard Copley > >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 > >> >> > > >> >> > The bug was introduced in the master branch between these two revisions > >> >> > (not tight bounds, just builds I have lying around): > >> >> > > >> >> > GOOD: > >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 > >> >> > Author: Paul Eggert > >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 > >> >> > > >> >> > BAD: > >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > >> >> > Author: Tino Calancha > >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 > >> >> > >> >> Is this the result of turning on lexical-binding in iserach.el? > >> > > >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone > >> > beats me to it. > >> > >> Yep, you nailed it. > > > > This was fixed already--your recipe works as expected for me. See bug#24580 > > My build contains the commit referenced in bug#24580 as fixing it, but I > can still reproduce the problem with the OP's recipe (i.e. with -Q). Sorry if I jumped the gun closing. I'm on 2955936 (master HEAD at the moment) and can't reproduce. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 17:17:35 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 21:17:35 +0000 Received: from localhost ([127.0.0.1]:45143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2lrj-0007L0-8X for submit@debbugs.gnu.org; Fri, 04 Nov 2016 17:17:35 -0400 Received: from mail-ua0-f181.google.com ([209.85.217.181]:36234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2lrh-0007Kn-Dl for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 17:17:33 -0400 Received: by mail-ua0-f181.google.com with SMTP id b35so76818983uaa.3 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 14:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2eRko04uiXDPXCXD3jqY7xTNHmcaZCGlqwGc6dof/TE=; b=WOzu6vTsDMtVm8Ei6Jm4mLWDZx1wzL/OpsKUZkXfiTBw/xyR4lIDwDp8byrgAnEZoF j41pW3B3w3LfHh4voOPVk4INhSsTX3aFc1ys+M8/g47TvLbzNA6JS/hVXif3EN7g7+YG bYpEbDbUWNUJoG68vkY9oKHuQToRMuC0rQP6y78j7XbdMmWySmbDM2W4wGeH6eD7JJKA qJlvZ6ArKiZWmCiOnogih1gqd6VtsGhJUtHaYPKXINXIAzn9YsR2Z6dXI+QlSWfj5zTd +bvs5R/Vh3EflDgQEa9Bez9ypORR0wuaVQaGNBd6ra+rM1fnUlVbyA9pp+PVYHqXg6vl AwwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2eRko04uiXDPXCXD3jqY7xTNHmcaZCGlqwGc6dof/TE=; b=WN0rk/Tjc/47Y5wqIBLZqPg3gZdYrfORwsbifrU4QyBMDOP/eolnHhYLfJX43Mi8X9 Jczd23D+vgY4i4qGxfjRuSy9lMB320vfT/b9ClFz3z/PuB0M+lTvlbMW4ARYCr/b3dpC MyCGG+B4O764jGY4eMaxPfUF104hidtOa0opxgHpFq609wE9VmtJPRNzTu8g2Ey8K9YQ l1oT6dtGmJOCi7k8KpWdH5JvNYtYhOtZFte80oQwlH9G+zchpuzrOZ+zCgnUH9HMpYPG TU3wxO12n90KjZMcScjZK8XZ61Mzw0tJMoY4SRrNtPqWEpinPpuWjssNb/fOogp8hdRN zSsA== X-Gm-Message-State: ABUngvex+GUp9sUQ4K8sddpQuFqyC4lSoDSpzNF/ji+6v8l0QVVKmTA2Zlqv80hJw0MtTFDBe2uBwnqJap/Uyg== X-Received: by 10.159.36.244 with SMTP id 107mr11142625uar.51.1478294247751; Fri, 04 Nov 2016 14:17:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.66 with HTTP; Fri, 4 Nov 2016 14:16:57 -0700 (PDT) In-Reply-To: <20161104205329.GA24042@holos.localdomain> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> From: Richard Copley Date: Fri, 4 Nov 2016 21:16:57 +0000 Message-ID: Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list To: Mark Oteiza Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24873 Cc: Stephen Berman , 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 4 November 2016 at 20:53, Mark Oteiza wrote: > On 04/11/16 at 08:59pm, Stephen Berman wrote: >> On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza wrote: >> >> > On 04/11/16 at 07:03pm, Richard Copley wrote: >> >> On 4 November 2016 at 11:16, Richard Copley wrote: >> >> > On 4 Nov 2016 11:02, "Eli Zaretskii" wrote: >> >> >> >> >> >> > From: Richard Copley >> >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000 >> >> >> > >> >> >> > The bug was introduced in the master branch between these two revisions >> >> >> > (not tight bounds, just builds I have lying around): >> >> >> > >> >> >> > GOOD: >> >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79 >> >> >> > Author: Paul Eggert >> >> >> > Date: Sat Sep 17 15:06:24 2016 -0700 >> >> >> > >> >> >> > BAD: >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> >> > Author: Tino Calancha >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 >> >> >> >> >> >> Is this the result of turning on lexical-binding in iserach.el? >> >> > >> >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone >> >> > beats me to it. >> >> >> >> Yep, you nailed it. >> > >> > This was fixed already--your recipe works as expected for me. See bug#24580 >> >> My build contains the commit referenced in bug#24580 as fixing it, but I >> can still reproduce the problem with the OP's recipe (i.e. with -Q). > > Sorry if I jumped the gun closing. > > I'm on 2955936 (master HEAD at the moment) and can't reproduce. I can reproduce the issue with the given recipe in that revision. To summarize, here are the test results stated so far in this thread, plus a few more that I'm stating now, in chronological order: Good [RC] (before lexical binding in isearch.el): commit 329e0274ec6a4ae82f86905b8cf844971b943085 Author: Mark Oteiza Date: Tue Sep 27 13:34:29 2016 -0400 Bad [RC] (turn on lexical binding in isearch.el) commit cbb2e845187bfbcc62e2accc9df7891a2326608a Author: Mark Oteiza Date: Wed Sep 28 13:08:12 2016 -0400 Good?? [MO] (this is the revision mentioned in #24580) commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 Author: Mark Oteiza Date: Tue Oct 4 10:17:53 2016 -0400 Bad [SB] (unspecified, but containing the above). >> >> >> > BAD [RC]: >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 >> >> >> > Author: Tino Calancha >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 Good [MO], Bad [RC]: commit 29559361f56c9398dcb69db7396dcfc0887843a2 Author: Mark Oteiza Date: Fri Nov 4 14:22:05 2016 -0400 Mark, it seems rude to ask, sorry, but are you sure you weren't testing a slightly different recipe? Otherwise it must be some difference in our environment which seems less likely. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 18:04:03 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 22:04:03 +0000 Received: from localhost ([127.0.0.1]:45168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2mag-0008Pn-Ml for submit@debbugs.gnu.org; Fri, 04 Nov 2016 18:04:03 -0400 Received: from mout.gmx.net ([212.227.15.19]:64529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2maf-0008PI-2t for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 18:04:02 -0400 Received: from rosalinde ([89.245.89.33]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MhQxO-1cGcTy3RSs-00MaMt; Fri, 04 Nov 2016 23:03:52 +0100 From: Stephen Berman To: Richard Copley Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> Date: Fri, 04 Nov 2016 23:03:52 +0100 In-Reply-To: (Richard Copley's message of "Fri, 4 Nov 2016 21:16:57 +0000") Message-ID: <87d1iadhrr.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:zN6ldVdaA6QT7ex6bV9ANazlEQ0vQMb8LUMzXy8Hq8qiV+Kh/A1 0XuMfY0j1+HmcrYKDkzlGmXaYLp/hPue22k3/vZEm2WxBim+Ck1fcF1j41iU6qxdKtqNETF auOPlg9fYZOL6J19lyy0FIPSi3tASdyoo9IuN2RVfKYeM5J5v6yF3HJsL/hkDmRzMuXywMz R3LAa3ZNtf6knMDdGgkCQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:YTOnUct6TZ8=:DW41aaSZPrSPJRFSSi10fK akneue/EozcqEt6LNxcJtYC4WtWTCH/h7p8qz/hB8ZKE5uiiwpKFg8koYqMDcVGuYkmOW5h8q rfikrYfawEbCY4QZdwNrknm/86zzjr7B9403/zuE1UFFWKRgcKt5B2JYkCD5cVU55d1dUd+K0 Xcb9x5FUJhYL4E7q7Fzi+GFZkzD5pADuEGnQkllMFDmta6LgF/5Gqs8PuTXv8w3PC6aQg52aV f4tRb56GIYsLeShUSSMyWCFSJnKHCcroGvkEQb6v2+ahAadPj8QK2ValMtO0MTPg03pIaqis4 H/QWpcvdXtXaIFNWbSBhIzD8g6sl7flbL7KS1a6qPEyINTwYuANEKI+Q6skn1gQBYQZAByBQX kmX1Q462wtkgEjuv7IvJ7+nP4xtc3HbE2R3t0OGcQvKW0Hvg1rPRxCz07q76YNdjzyw7X3gT1 KJXuRPiyXhvsmuAew1qbl+Ka0kMdCHCuoIb8LzG5gYHO/ysluVfJyU6lV8FTVmNkhMOtaHQbP HM5VjWkpKjO2A3zNnXvOMJ43OEjksZVg+6ShsN07oayacqL4QkjOg5ev9EKdgW8FTA6SOq7JN dcy747lOeFnfx3kuWNNNGf+rQWaIfXUkNiPhk9DEj250m4g5KIm96HSzn7HTh2RectHaMxPx+ g+zT0K0Y3O3eg+KvnfX71xb4YdUh5CDSaAcimkRM2fgliMcNuKaSsqqzaVDKQ1Oi45GX3f99m yANZYKNjXwdlQ5bnBURxEEZEppznDVKym2dWXjWmJTAJxBJmqeh/9ha9sUzpNa4TDRL35lN/R EtqrLDK X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 24873 Cc: Mark Oteiza , 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On Fri, 4 Nov 2016 21:16:57 +0000 Richard Copley wrote: > On 4 November 2016 at 20:53, Mark Oteiza wrote: >> >> I'm on 2955936 (master HEAD at the moment) and can't reproduce. > > I can reproduce the issue with the given recipe in that revision. > > To summarize, here are the test results stated so far in this thread, > plus a few more that I'm stating now, in chronological order: > > Good [RC] (before lexical binding in isearch.el): > commit 329e0274ec6a4ae82f86905b8cf844971b943085 > Author: Mark Oteiza > Date: Tue Sep 27 13:34:29 2016 -0400 > > Bad [RC] (turn on lexical binding in isearch.el) > commit cbb2e845187bfbcc62e2accc9df7891a2326608a > Author: Mark Oteiza > Date: Wed Sep 28 13:08:12 2016 -0400 > > Good?? [MO] (this is the revision mentioned in #24580) > commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 > Author: Mark Oteiza > Date: Tue Oct 4 10:17:53 2016 -0400 > > Bad [SB] (unspecified, but containing the above). For the recond, my current [BAD] build is from: commit 51558effdc453d359b4a174bf72db787dc0114d1 Author: Noah Friedman Date: Thu Oct 6 18:32:59 2016 -0700 Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 19:35:49 2016 Received: (at 24873) by debbugs.gnu.org; 4 Nov 2016 23:35:49 +0000 Received: from localhost ([127.0.0.1]:45189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2o1V-000261-3o for submit@debbugs.gnu.org; Fri, 04 Nov 2016 19:35:49 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:33363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2o1T-00025m-78 for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 19:35:47 -0400 Received: by mail-qk0-f173.google.com with SMTP id x190so115009382qkb.0 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 16:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EXLUYqwCmqrPkQX8qxT3iwNdJ4vRQ8LHW4hE+INpvLU=; b=m4ORbLgvgpfwzgbaLuaW9Pxdd61rfRy5/c4JdN7AAuR7sibi87Z14q7jv0UtNcAtFZ 4vyQFYXMSw/Lx1nzrk4lR4xu+lPbSYfOmGPEavNpiLmM2KHFWEza8WZPP0L4yQ2kqVZC 1CiY0hDe2B4lVTw8SvS11OUjU3NlZOof/pqu8caSExD7lKuGWLhlRw9P2iIhKfu0bGRA RMH6UiWGFQ9LNomryB5cM5ZqSqJtYBvvTs9cN8r2SQ3PZNjOv9Imvg5SW/6cDl56RZT2 DOVI7pl50hU9V10rvFsnwOAjUsghDdg20Y8z4XthZ84ZjXLXT8yo7SKxzyNp6IBw1k27 SyCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EXLUYqwCmqrPkQX8qxT3iwNdJ4vRQ8LHW4hE+INpvLU=; b=F9l40QjbgGlfvEoP/MFc6gUxU3tKphdA32wEXn1hmmUziBrjRu+PGDgVvTtWx9hjKt GIpzgGe5OzFrue567qLHYMBwUb+K7pyxbgHiYoEzeUHX3mJwtEy7+42K5uA70Bpe80/g iJ149t49uv3eE1QBMruT+5l1gFFh7DbXlGNkJTIhg+yUlMs4IDXZRGcVnpyU+677esaB cRlWnbM2PL+MW0rSQVx7vXA6r/utMicQThDZK7N2535yGiR1M3dH3fEgTltkXlFyuTRq MIX/Io92Px6yBqk4euwr8m++9dnJsUipAuTfVIWoH8c8C8MYTVfSE5RzkPXrqfUxFnNG wGiA== X-Gm-Message-State: ABUngvdEQlYvZgbUU3wLCOY6pjOK/P562u1wPucsnupPTNd6a5OqWfHDVPf3+r/p5yJeHWcs X-Received: by 10.55.191.135 with SMTP id p129mr18093812qkf.279.1478302541607; Fri, 04 Nov 2016 16:35:41 -0700 (PDT) Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id d81sm9089680qke.15.2016.11.04.16.35.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Nov 2016 16:35:40 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 2AFD666231; Fri, 4 Nov 2016 19:35:40 -0400 (EDT) Date: Fri, 4 Nov 2016 19:35:40 -0400 From: Mark Oteiza To: Richard Copley Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Message-ID: <20161104233540.GA26298@holos.localdomain> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24873 Cc: Stephen Berman , 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On 04/11/16 at 09:16pm, Richard Copley wrote: > On 4 November 2016 at 20:53, Mark Oteiza wrote: > > Sorry if I jumped the gun closing. > > > > I'm on 2955936 (master HEAD at the moment) and can't reproduce. > > I can reproduce the issue with the given recipe in that revision. > > To summarize, here are the test results stated so far in this thread, > plus a few more that I'm stating now, in chronological order: > > Good [RC] (before lexical binding in isearch.el): > commit 329e0274ec6a4ae82f86905b8cf844971b943085 > Author: Mark Oteiza > Date: Tue Sep 27 13:34:29 2016 -0400 > > Bad [RC] (turn on lexical binding in isearch.el) > commit cbb2e845187bfbcc62e2accc9df7891a2326608a > Author: Mark Oteiza > Date: Wed Sep 28 13:08:12 2016 -0400 > > Good?? [MO] (this is the revision mentioned in #24580) > commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14 > Author: Mark Oteiza > Date: Tue Oct 4 10:17:53 2016 -0400 > > Bad [SB] (unspecified, but containing the above). > > >> >> >> > BAD [RC]: > >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977 > >> >> >> > Author: Tino Calancha > >> >> >> > Date: Tue Oct 11 11:47:32 2016 +0900 > > Good [MO], Bad [RC]: > commit 29559361f56c9398dcb69db7396dcfc0887843a2 > Author: Mark Oteiza > Date: Fri Nov 4 14:22:05 2016 -0400 > > Mark, it seems rude to ask, sorry, but are you sure you weren't testing > a slightly different recipe? Otherwise it must be some difference in our > environment which seems less likely. No worries, I think I erred here (M-% instead of C-M-% I think is what I was doing). Sorry for the confusion! :( From unknown Sat Aug 16 10:43:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Fri, 04 Nov 2016 23:39:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 20:34:11 2016 Received: (at 24873) by debbugs.gnu.org; 5 Nov 2016 00:34:11 +0000 Received: from localhost ([127.0.0.1]:45211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2ovy-00056u-SJ for submit@debbugs.gnu.org; Fri, 04 Nov 2016 20:34:11 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:32799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2ovx-00056h-Sa for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 20:34:10 -0400 Received: by mail-qk0-f195.google.com with SMTP id x190so7029963qkb.0 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 17:34:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7Sh77urMDCWeXG3QseN92TD4m6SyTjO7AAk6JgUvRXA=; b=0N84BXGDSkUdR6uq2Vg2itFv9vnXNyW/rd6rHDuKsLUV6x/08ighAj/yLmUb+FWHXi js6mpAwuqI/LZPVR9Pz18xYTX1q5dYtRf7mwPln1pdSvQUt+UzTrDjTNanizPFAAlJO9 Ixm0mpY3yiQoUgM3d5g8b6ajCHg83BYI42+XG7+wmjDe2dGtJzjA9AX0mjokduYeTjFk /+jmNXJYu0emhMmUooE/bjLH0wcgUAuQePGXQlONEF34iNGtVpp7MWr55P+hMeejYCYi nU1gChoFT0su1/WG0HEynP+ffhFOaeliSw4UFGMpiGBSkVx0eYCQKOiJTULOki23aeq+ RIhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7Sh77urMDCWeXG3QseN92TD4m6SyTjO7AAk6JgUvRXA=; b=Wj37b+6zqxalOxKmKCXjrLKxVrn5r07mGUQU15ZE15HoI58MFWiKY42SVJNRkE46JX vwnzQd7/94argTd9qvb4x3HlC+z8yWm4lNEw4HhHej/Tw9l7Aar/3DRaST54rXkVxctK KizM4ScgECBHfYZ+jCTS0MnhhK7uFMqxS5q9e4nlhSD6U5hjQGvk7WDNC3Vfdd+q1Ctr OdFVQf641SOLutDa8r9sPrB3MGOWsSvCPuP50jhE/2k79RffQlQ/+HBwRC6WRT49kQHV 2GEKNtHfPKDMrQwr2MH7KxPDHJYZTGtsce8Lz9B0bQqsRbmow6hPuqHBRjrEImw4b3hT W5/w== X-Gm-Message-State: ABUngvegU7qkGA0ZP7f8yQCWachXfYnGK5GrPDQhMKQXs9msLBaNlAk2bPnerva7YUeEdMue X-Received: by 10.55.162.79 with SMTP id l76mr15886853qke.17.1478306044194; Fri, 04 Nov 2016 17:34:04 -0700 (PDT) Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id a187sm9252936qkg.25.2016.11.04.17.34.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Nov 2016 17:34:03 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id B981266231; Fri, 4 Nov 2016 20:34:02 -0400 (EDT) Date: Fri, 4 Nov 2016 20:34:02 -0400 From: Mark Oteiza To: Richard Copley Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list Message-ID: <20161105003402.GA30846@holos.localdomain> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> <20161104233540.GA26298@holos.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161104233540.GA26298@holos.localdomain> User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 24873 Cc: Stephen Berman , 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Does the following fix it for you? diff --git a/lisp/replace.el b/lisp/replace.el index 4fc48d4..60948ef 100644 --- a/lisp/replace.el +++ b/lisp/replace.el @@ -198,7 +198,7 @@ query-replace-read-from (setq-local text-property-default-nonsticky (cons '(separator . t) text-property-default-nonsticky))) (if regexp-flag - (read-regexp prompt) + (read-regexp prompt nil 'minibuffer-history) (read-from-minibuffer prompt nil nil nil nil (car (if regexp-flag regexp-search-ring search-ring)) t))))) From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 20:58:35 2016 Received: (at 24873) by debbugs.gnu.org; 5 Nov 2016 00:58:35 +0000 Received: from localhost ([127.0.0.1]:45228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2pJb-0005fO-2m for submit@debbugs.gnu.org; Fri, 04 Nov 2016 20:58:35 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:36584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2pJZ-0005fC-HV for 24873@debbugs.gnu.org; Fri, 04 Nov 2016 20:58:33 -0400 Received: by mail-oi0-f46.google.com with SMTP id v84so185615785oie.3 for <24873@debbugs.gnu.org>; Fri, 04 Nov 2016 17:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=yBtT1SZKceVnYo+rEJuxiC6aOo7EL7xP4HhKdgUFkA8=; b=DVaqvIGwGHDHpgaMOmtwmJocqf830UFPJUa0p3WpFIFPvewemQ+XvTP7+LZWuciFXs 5yxfnSaVb7zVpmQ/AMqoY92LjVvjX5BNrfqBo7wOaerCkgVHjQ+OIa0iyTf9ZXQFolrv sSJ8sA5kIbTXwgeD8RYNm+hNN+7i0olaTHssn4v4VZcL5i1FCOn5oVKeh5uLMB6V5fIB rU934iDRtG1E7u5W52mNHcMVseDFYMNFlCGV+0pmias85qIJgzVy4VEDSkqa5rlxAJP+ eOH/TUWUgDsezfuoxT4j3dRXZi8MZSb4gu++e4Kjg8gWw6SFnqnS5VBOd3+nkur0awiP 5o+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=yBtT1SZKceVnYo+rEJuxiC6aOo7EL7xP4HhKdgUFkA8=; b=TKaNaxdb7MbyDc5iKdwNj6djYuExYnKmjT9WbZF9LIFdCkVlp1N1IZLC0DcFc7bx8o x2Xtarkz5bKnw8NgNPtQtBCckmE4r5qEv+CfufzbUnhr6G/IZaVa9J4+QvHKMDF91iQT 4/iWqrbvcX0Sn0yHeVRU8ZFyBwue1nhA1IXb0ffa4kV7FuxenD+70tkHrDXt4SsgxzoJ SWiKF2aA5fkbwfSpfamTaJkd9Wa8+naq8EMVKNu8K1F7h2T9iHj52kjaIx49AZtt8/F2 Y90ZBgNQfmj38JdzsVVufhApGUjvDO8wiOjeL/H6XLhs2NgvpTmxy3WwMkT8AwDzujm5 UjxA== X-Gm-Message-State: ABUngvd8dOif3uplNKEBjVzhnz114KBHn8mYVdGrKh++bRuwma3+zGKfQS9E6AaozOGmGcF3tjFpdlXlgYv/Yg== X-Received: by 10.157.20.176 with SMTP id d45mr13224143ote.2.1478307508029; Fri, 04 Nov 2016 17:58:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.4.86 with HTTP; Fri, 4 Nov 2016 17:58:27 -0700 (PDT) In-Reply-To: <20161105003402.GA30846@holos.localdomain> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> <20161104233540.GA26298@holos.localdomain> <20161105003402.GA30846@holos.localdomain> From: Noam Postavsky Date: Fri, 4 Nov 2016 20:58:27 -0400 X-Google-Sender-Auth: YKlSKxC1bHbvgoqFjS5zhEd-MFU Message-ID: Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list To: Mark Oteiza Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24873 Cc: Richard Copley , Stephen Berman , 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza wrote: > Does the following fix it for you? > > diff --git a/lisp/replace.el b/lisp/replace.el > index 4fc48d4..60948ef 100644 > --- a/lisp/replace.el > +++ b/lisp/replace.el > @@ -198,7 +198,7 @@ query-replace-read-from > (setq-local text-property-default-nonsticky > (cons '(separator . t) text-property-default-nonsticky))) > (if regexp-flag > - (read-regexp prompt) > + (read-regexp prompt nil 'minibuffer-history) I think you need make minibuffer-history into a dynamic variable for this to work. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 08:19:26 2016 Received: (at 24873) by debbugs.gnu.org; 5 Nov 2016 12:19:26 +0000 Received: from localhost ([127.0.0.1]:45476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2zwU-0003Im-4H for submit@debbugs.gnu.org; Sat, 05 Nov 2016 08:19:26 -0400 Received: from mail-vk0-f42.google.com ([209.85.213.42]:34584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2zwS-0003IZ-78 for 24873@debbugs.gnu.org; Sat, 05 Nov 2016 08:19:24 -0400 Received: by mail-vk0-f42.google.com with SMTP id x186so87850054vkd.1 for <24873@debbugs.gnu.org>; Sat, 05 Nov 2016 05:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SkXifRCooAxTA6WaUP11sUkFR6An580/ETdYxAz3bNQ=; b=TiR9AGAD2ScTcLgxwuHMvL9CajhkIXPmu9aB15bUhot6yC2xTVPutQNwU8WWthbF1e FXlUfM4BXtI+YgvqYLqVk4Us0rRXj7J/Z9bn4qV8ozCZYNl5Xj2OwE7CKRgD5pNieB7f Xo+k6zGcHOT/3OnuC5I76qdndG3La5FSoy5HYOIyCH6EQ7kohTU5AzTvwm24g2zaoq8+ tbqeofRjNL08SkgZHHF3HdiTlVvKYEmh+08kkG5caiS9pdwuzFPCioyhh8FP48lBip+0 JZydfcziVjH4PQSVu1G/l+T1BS8NhK986kiFwkZ2X1vDGF0eY/xg9iSs9WOnkCu5Z29Q sQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SkXifRCooAxTA6WaUP11sUkFR6An580/ETdYxAz3bNQ=; b=gbEctoD5E6B42hUusAqWxCdUhJBC14q0l7BuTg/UX3gtIRCdwhzyTt2jKp+eU3RnTq B0lXhi3ONQYh4RHYiHtZMnCLSlnYRynwuvo3/ya5lMUzQBZ4JVt1HjxN2gYt8snTQt5J i3TOp+YffSmMSWLGlx60aXGo0yZ5gWxVagWC1LOY2iuMYa0agjPPhrNDiJdxUe9jFLUl xxVKOCfJbv37LSxvmK4/g6yTzjgEHmlOl5JoNl91YGNFLyN4y1wAz8BheVsARQxj/djD PgAhBa0m3FC6Fm+iKN4zD4EYKStF/cJKijapuqwuuvjbnxV5bYzJ6rtCLd4LcBGZvUti 7+Jg== X-Gm-Message-State: ABUngvc6M2WGkqq/Bmew5aOpTQpLZMQRGTCv1yKJ9bSJPUrUYXHzYa2mHJb8Gbqm1t/t5oZLhyPWJRbVM1fTLQ== X-Received: by 10.31.174.147 with SMTP id x141mr14786082vke.73.1478348358793; Sat, 05 Nov 2016 05:19:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.16.66 with HTTP; Sat, 5 Nov 2016 05:18:48 -0700 (PDT) In-Reply-To: <20161105003402.GA30846@holos.localdomain> References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> <20161104233540.GA26298@holos.localdomain> <20161105003402.GA30846@holos.localdomain> From: Richard Copley Date: Sat, 5 Nov 2016 12:18:48 +0000 Message-ID: Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list To: Mark Oteiza Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 24873 Cc: Stephen Berman , 24873@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 5 November 2016 at 00:34, Mark Oteiza wrote: > Does the following fix it for you? > > diff --git a/lisp/replace.el b/lisp/replace.el > index 4fc48d4..60948ef 100644 > --- a/lisp/replace.el > +++ b/lisp/replace.el > @@ -198,7 +198,7 @@ query-replace-read-from > (setq-local text-property-default-nonsticky > (cons '(separator . t) text-property-default-nonsticky))) > (if regexp-flag > - (read-regexp prompt) > + (read-regexp prompt nil 'minibuffer-history) > (read-from-minibuffer > prompt nil nil nil nil > (car (if regexp-flag regexp-search-ring search-ring)) t))))) Yes. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 21:41:47 2016 Received: (at 24873) by debbugs.gnu.org; 13 Nov 2016 02:41:47 +0000 Received: from localhost ([127.0.0.1]:55303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kjq-0005w5-VK for submit@debbugs.gnu.org; Sat, 12 Nov 2016 21:41:47 -0500 Received: from mail-it0-f51.google.com ([209.85.214.51]:35974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5kjp-0005vj-5p; Sat, 12 Nov 2016 21:41:46 -0500 Received: by mail-it0-f51.google.com with SMTP id q124so41650018itd.1; Sat, 12 Nov 2016 18:41:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=eOeo+6tfLZnGpxx38iqxtu4VQhUTjg/CCMHhvycQT+g=; b=QLGelQD5S3xWmYS3bQFH7Y1f7TBtjjXImk5LDCwCDAz8MTyiqnk7OekSsCCfgS4YS+ peMZGyuZA8bJwCq4H/Zihc3HMu73+0WqveaHC7tmurZ0tR8EcKO/aB6LxVe7E4h9tvKV tvX9Nhmgv2OePAsZyoEg5own3QzY0YdA00XE2H8jRefYW9RxzrblUPDk4kRBlZ7ZeHGc R2n15zD5q0SA5b3wUN85pWMU/xPGZfLs2QJi16MU/q5cwvcJSQNTCumA4s/LhYK8/8Fb qtH3fu/Lwv/2IurAAbYKHNokwbSeUV8WUcpP+b0eVw5uzP9bFyXGWCVgoNCskkl6bet2 dR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=eOeo+6tfLZnGpxx38iqxtu4VQhUTjg/CCMHhvycQT+g=; b=KdwVe/Nil4lRlNNbTGg5cujFHtrtUiDOVipOZp/YZNNM75krBgP3PX/yWLpfWeUZ5G tBUBU+pIz1zyzMwvtMXDUrN53TVTMO9gXihRfdq7tyf7A8Qal0jzMlI5+c85Kakfxh0j Sn5iKdQxOddrgVITezCTUQ6z9QjA/8FNxXufXGYotMhPZ2nv5smu7S/42tYx4tshKvKg DiK6inlmuWjznm8DstdrXhlqrzWku/NwvR8xYSk5wYMAQuIT7sukgcv6sVS7bwssUtKh zIcE8EOUIyy3A8Ya+Kk1wW1AiXaEl9shzwa4DsZj8uZqiC2Z7PNqyucK2ck4rPqkoGdJ e0dg== X-Gm-Message-State: ABUngvfhf+GJc1mmknhV8XXFl5DTTQJVe82GVsxGagH254W9r6G1ly5RD43n8iM38um0ww== X-Received: by 10.107.58.195 with SMTP id h186mr21234567ioa.117.1479004899353; Sat, 12 Nov 2016 18:41:39 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id r3sm6744622iod.24.2016.11.12.18.41.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 12 Nov 2016 18:41:38 -0800 (PST) From: npostavs@users.sourceforge.net To: Mark Oteiza Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list References: <831syrld8g.fsf@gnu.org> <20161104193513.GA22185@holos.localdomain> <87lgwzc8y8.fsf@gmx.net> <20161104205329.GA24042@holos.localdomain> <20161104233540.GA26298@holos.localdomain> <20161105003402.GA30846@holos.localdomain> Date: Sat, 12 Nov 2016 21:42:26 -0500 In-Reply-To: (Noam Postavsky's message of "Fri, 4 Nov 2016 20:58:27 -0400") Message-ID: <87d1i0m771.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 24873 Cc: Richard Copley , 24873@debbugs.gnu.org, Stephen Berman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) tags 24873 fixed close 24873 quit Noam Postavsky writes: > On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza wrote: >> Does the following fix it for you? >> >> diff --git a/lisp/replace.el b/lisp/replace.el >> index 4fc48d4..60948ef 100644 >> --- a/lisp/replace.el >> +++ b/lisp/replace.el >> @@ -198,7 +198,7 @@ query-replace-read-from >> (setq-local text-property-default-nonsticky >> (cons '(separator . t) text-property-default-nonsticky))) >> (if regexp-flag >> - (read-regexp prompt) >> + (read-regexp prompt nil 'minibuffer-history) > > I think you need make minibuffer-history into a dynamic variable for > this to work. Ah, minibuffer-history is defined in simple.el, so it's fine. From unknown Sat Aug 16 10:43:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 11 Dec 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator