GNU bug report logs - #24873
26.0.50; isearch-query-replace from regexp isearch doesn't add to replace-regexp history list

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 24873 in the body.
You can then email your comments to 24873 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 26.0.50; isearch-query-replace from regexp isearch doesn't add to
 replace-regexp history list
Date: Fri, 4 Nov 2016 10:54:00 +0000

Recipe from emacs -Q:

 M-<            ;; beginning-of-buffer
 C-M-s text     ;; isearch-forward-regexp
 M-% xxx RET !  ;; isearch-query-replace
 C-M-%          ;; query-replace-regexp
 M-p            ;; previous-history-element

Expected result: selects the previous replace operation "text -> xxx"
from the history list.

Actual result: signals "user-error: Beginning of history; no preceding
item".

The bug affects isearch-query replace when invoked during
isearch-forward-regexp but not when invoked during isearch-forward.

The bug was introduced in the master branch between these two revisions
(not tight bounds, just builds I have lying around):

GOOD:
commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
Author: Paul Eggert <eggert <at> cs.ucla.edu>
Date:   Sat Sep 17 15:06:24 2016 -0700

BAD:
commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
Author: Tino Calancha <tino.calancha <at> gmail.com>
Date:   Tue Oct 11 11:47:32 2016 +0900


In GNU Emacs 26.0.50.1 (x86_64-w64-mingw32)
 of 2016-10-11 built on 60678UHB
Repository revision: 9640e9f4e95cd95c04875e90a4ff638e1e51f977
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Mark set [2 times]
Replaced 2 occurrences
user-error: Beginning of history; no preceding item
Quit
Configured using:
 'configure --prefix /C/emacs/emacs-20161011-024732 --with-modules
 --without-imagemagick --disable-dependency-tracking
 --enable-locallisppath=%emacs_dir%/../site-lisp CFLAGS=-O3
 CPPFLAGS=-D_WIN32_WINNT=_WIN32_WINNT_WIN7'

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS MODULES

Important settings:
  value of $LANG: ENG
  locale-coding-system: cp1252

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib
dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec
password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils thingatpt misearch multi-isearch time-date mule-util tooltip
eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel
dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win
tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment
elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev
obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face
macroexp files text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget hashtable-print-readable backquote
w32notify dbusbind w32 multi-tty make-network-process emacs)

Memory information:
((conses 16 99599 14680)
 (symbols 56 20290 0)
 (miscs 48 45 149)
 (strings 32 19347 4182)
 (string-bytes 1 591428)
 (vectors 16 13522)
 (vector-slots 8 442624 4747)
 (floats 8 181 146)
 (intervals 56 247 16)
 (buffers 976 11))

Message #8 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Copley <rcopley <at> gmail.com>
Cc: 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50;
 isearch-query-replace from regexp isearch doesn't add to
 replace-regexp history list
Date: Fri, 04 Nov 2016 13:02:23 +0200

> From: Richard Copley <rcopley <at> gmail.com>
> Date: Fri, 4 Nov 2016 10:54:00 +0000
> 
> The bug was introduced in the master branch between these two revisions
> (not tight bounds, just builds I have lying around):
> 
> GOOD:
> commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
> Author: Paul Eggert <eggert <at> cs.ucla.edu>
> Date:   Sat Sep 17 15:06:24 2016 -0700
> 
> BAD:
> commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
> Author: Tino Calancha <tino.calancha <at> gmail.com>
> Date:   Tue Oct 11 11:47:32 2016 +0900

Is this the result of turning on lexical-binding in iserach.el?

Message #11 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 11:16:55 +0000

[Message part 1 (text/plain, inline)]

Thanks, I'll check, but I can't do it now. In about 8 hours unless someone
beats me to it.

On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz <at> gnu.org> wrote:

> > From: Richard Copley <rcopley <at> gmail.com>
> > Date: Fri, 4 Nov 2016 10:54:00 +0000
> >
> > The bug was introduced in the master branch between these two revisions
> > (not tight bounds, just builds I have lying around):
> >
> > GOOD:
> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
> > Author: Paul Eggert <eggert <at> cs.ucla.edu>
> > Date:   Sat Sep 17 15:06:24 2016 -0700
> >
> > BAD:
> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
> > Author: Tino Calancha <tino.calancha <at> gmail.com>
> > Date:   Tue Oct 11 11:47:32 2016 +0900
>
> Is this the result of turning on lexical-binding in iserach.el?
>

[Message part 2 (text/html, inline)]

Message #14 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Mark Oteiza <mvoteiza <at> udel.edu>
Cc: 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 19:03:20 +0000

On 4 November 2016 at 11:16, Richard Copley <rcopley <at> gmail.com> wrote:
> On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
>>
>> > From: Richard Copley <rcopley <at> gmail.com>
>> > Date: Fri, 4 Nov 2016 10:54:00 +0000
>> >
>> > The bug was introduced in the master branch between these two revisions
>> > (not tight bounds, just builds I have lying around):
>> >
>> > GOOD:
>> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
>> > Author: Paul Eggert <eggert <at> cs.ucla.edu>
>> > Date:   Sat Sep 17 15:06:24 2016 -0700
>> >
>> > BAD:
>> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
>> > Author: Tino Calancha <tino.calancha <at> gmail.com>
>> > Date:   Tue Oct 11 11:47:32 2016 +0900
>>
>> Is this the result of turning on lexical-binding in iserach.el?
>
> Thanks, I'll check, but I can't do it now. In about 8 hours unless someone
> beats me to it.

Yep, you nailed it.

Message #19 received at 24873-done <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Richard Copley <rcopley <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 24873-done <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 15:35:13 -0400

On 04/11/16 at 07:03pm, Richard Copley wrote:
> On 4 November 2016 at 11:16, Richard Copley <rcopley <at> gmail.com> wrote:
> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
> >>
> >> > From: Richard Copley <rcopley <at> gmail.com>
> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000
> >> >
> >> > The bug was introduced in the master branch between these two revisions
> >> > (not tight bounds, just builds I have lying around):
> >> >
> >> > GOOD:
> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
> >> > Author: Paul Eggert <eggert <at> cs.ucla.edu>
> >> > Date:   Sat Sep 17 15:06:24 2016 -0700
> >> >
> >> > BAD:
> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
> >> > Author: Tino Calancha <tino.calancha <at> gmail.com>
> >> > Date:   Tue Oct 11 11:47:32 2016 +0900
> >>
> >> Is this the result of turning on lexical-binding in iserach.el?
> >
> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone
> > beats me to it.
> 
> Yep, you nailed it.

This was fixed already--your recipe works as expected for me. See bug#24580

Message #22 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: 24873 <at> debbugs.gnu.org
Cc: mvoteiza <at> udel.edu, rcopley <at> gmail.com
Subject: Re: bug#24873: 26.0.50;
 isearch-query-replace from regexp isearch doesn't add to
 replace-regexp history list
Date: Fri, 04 Nov 2016 20:59:43 +0100

On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza <mvoteiza <at> udel.edu> wrote:

> On 04/11/16 at 07:03pm, Richard Copley wrote:
>> On 4 November 2016 at 11:16, Richard Copley <rcopley <at> gmail.com> wrote:
>> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
>> >>
>> >> > From: Richard Copley <rcopley <at> gmail.com>
>> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000
>> >> >
>> >> > The bug was introduced in the master branch between these two revisions
>> >> > (not tight bounds, just builds I have lying around):
>> >> >
>> >> > GOOD:
>> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
>> >> > Author: Paul Eggert <eggert <at> cs.ucla.edu>
>> >> > Date:   Sat Sep 17 15:06:24 2016 -0700
>> >> >
>> >> > BAD:
>> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
>> >> > Author: Tino Calancha <tino.calancha <at> gmail.com>
>> >> > Date:   Tue Oct 11 11:47:32 2016 +0900
>> >>
>> >> Is this the result of turning on lexical-binding in iserach.el?
>> >
>> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone
>> > beats me to it.
>> 
>> Yep, you nailed it.
>
> This was fixed already--your recipe works as expected for me. See bug#24580

My build contains the commit referenced in bug#24580 as fixing it, but I
can still reproduce the problem with the OP's recipe (i.e. with -Q).

Steve Berman

Message #25 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: rcopley <at> gmail.com, 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 16:53:29 -0400

On 04/11/16 at 08:59pm, Stephen Berman wrote:
> On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza <mvoteiza <at> udel.edu> wrote:
> 
> > On 04/11/16 at 07:03pm, Richard Copley wrote:
> >> On 4 November 2016 at 11:16, Richard Copley <rcopley <at> gmail.com> wrote:
> >> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
> >> >>
> >> >> > From: Richard Copley <rcopley <at> gmail.com>
> >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000
> >> >> >
> >> >> > The bug was introduced in the master branch between these two revisions
> >> >> > (not tight bounds, just builds I have lying around):
> >> >> >
> >> >> > GOOD:
> >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
> >> >> > Author: Paul Eggert <eggert <at> cs.ucla.edu>
> >> >> > Date:   Sat Sep 17 15:06:24 2016 -0700
> >> >> >
> >> >> > BAD:
> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
> >> >> > Author: Tino Calancha <tino.calancha <at> gmail.com>
> >> >> > Date:   Tue Oct 11 11:47:32 2016 +0900
> >> >>
> >> >> Is this the result of turning on lexical-binding in iserach.el?
> >> >
> >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone
> >> > beats me to it.
> >> 
> >> Yep, you nailed it.
> >
> > This was fixed already--your recipe works as expected for me. See bug#24580
> 
> My build contains the commit referenced in bug#24580 as fixing it, but I
> can still reproduce the problem with the OP's recipe (i.e. with -Q).

Sorry if I jumped the gun closing.

I'm on 2955936 (master HEAD at the moment) and can't reproduce.

Message #28 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: Stephen Berman <stephen.berman <at> gmx.net>, 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 21:16:57 +0000

On 4 November 2016 at 20:53, Mark Oteiza <mvoteiza <at> udel.edu> wrote:
> On 04/11/16 at 08:59pm, Stephen Berman wrote:
>> On Fri, 4 Nov 2016 15:35:13 -0400 Mark Oteiza <mvoteiza <at> udel.edu> wrote:
>>
>> > On 04/11/16 at 07:03pm, Richard Copley wrote:
>> >> On 4 November 2016 at 11:16, Richard Copley <rcopley <at> gmail.com> wrote:
>> >> > On 4 Nov 2016 11:02, "Eli Zaretskii" <eliz <at> gnu.org> wrote:
>> >> >>
>> >> >> > From: Richard Copley <rcopley <at> gmail.com>
>> >> >> > Date: Fri, 4 Nov 2016 10:54:00 +0000
>> >> >> >
>> >> >> > The bug was introduced in the master branch between these two revisions
>> >> >> > (not tight bounds, just builds I have lying around):
>> >> >> >
>> >> >> > GOOD:
>> >> >> > commit 7fa96cb5ef8c8464496688e88c1b97211a820d79
>> >> >> > Author: Paul Eggert <eggert <at> cs.ucla.edu>
>> >> >> > Date:   Sat Sep 17 15:06:24 2016 -0700
>> >> >> >
>> >> >> > BAD:
>> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
>> >> >> > Author: Tino Calancha <tino.calancha <at> gmail.com>
>> >> >> > Date:   Tue Oct 11 11:47:32 2016 +0900
>> >> >>
>> >> >> Is this the result of turning on lexical-binding in iserach.el?
>> >> >
>> >> > Thanks, I'll check, but I can't do it now. In about 8 hours unless someone
>> >> > beats me to it.
>> >>
>> >> Yep, you nailed it.
>> >
>> > This was fixed already--your recipe works as expected for me. See bug#24580
>>
>> My build contains the commit referenced in bug#24580 as fixing it, but I
>> can still reproduce the problem with the OP's recipe (i.e. with -Q).
>
> Sorry if I jumped the gun closing.
>
> I'm on 2955936 (master HEAD at the moment) and can't reproduce.

I can reproduce the issue with the given recipe in that revision.

To summarize, here are the test results stated so far in this thread,
plus a few more that I'm stating now, in chronological order:

Good [RC] (before lexical binding in isearch.el):
commit 329e0274ec6a4ae82f86905b8cf844971b943085
Author: Mark Oteiza <mvoteiza <at> udel.edu>
Date:   Tue Sep 27 13:34:29 2016 -0400

Bad [RC] (turn on lexical binding in isearch.el)
commit cbb2e845187bfbcc62e2accc9df7891a2326608a
Author: Mark Oteiza <mvoteiza <at> udel.edu>
Date:   Wed Sep 28 13:08:12 2016 -0400

Good?? [MO] (this is the revision mentioned in #24580)
commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14
Author: Mark Oteiza <mvoteiza <at> udel.edu>
Date:   Tue Oct 4 10:17:53 2016 -0400

Bad [SB] (unspecified, but containing the above).

>> >> >> > BAD [RC]:
>> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
>> >> >> > Author: Tino Calancha <tino.calancha <at> gmail.com>
>> >> >> > Date:   Tue Oct 11 11:47:32 2016 +0900

Good [MO], Bad [RC]:
commit 29559361f56c9398dcb69db7396dcfc0887843a2
Author: Mark Oteiza <mvoteiza <at> udel.edu>
Date:   Fri Nov 4 14:22:05 2016 -0400

Mark, it seems rude to ask, sorry, but are you sure you weren't testing
a slightly different recipe? Otherwise it must be some difference in our
environment which seems less likely.

Message #31 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Richard Copley <rcopley <at> gmail.com>
Cc: Mark Oteiza <mvoteiza <at> udel.edu>, 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50;
 isearch-query-replace from regexp isearch doesn't add to
 replace-regexp history list
Date: Fri, 04 Nov 2016 23:03:52 +0100

On Fri, 4 Nov 2016 21:16:57 +0000 Richard Copley <rcopley <at> gmail.com> wrote:

> On 4 November 2016 at 20:53, Mark Oteiza <mvoteiza <at> udel.edu> wrote:
>>
>> I'm on 2955936 (master HEAD at the moment) and can't reproduce.
>
> I can reproduce the issue with the given recipe in that revision.
>
> To summarize, here are the test results stated so far in this thread,
> plus a few more that I'm stating now, in chronological order:
>
> Good [RC] (before lexical binding in isearch.el):
> commit 329e0274ec6a4ae82f86905b8cf844971b943085
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Tue Sep 27 13:34:29 2016 -0400
>
> Bad [RC] (turn on lexical binding in isearch.el)
> commit cbb2e845187bfbcc62e2accc9df7891a2326608a
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Wed Sep 28 13:08:12 2016 -0400
>
> Good?? [MO] (this is the revision mentioned in #24580)
> commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Tue Oct 4 10:17:53 2016 -0400
>
> Bad [SB] (unspecified, but containing the above).

For the recond, my current [BAD] build is from:

commit 51558effdc453d359b4a174bf72db787dc0114d1
Author: Noah Friedman <friedman <at> splode.com>
Date:   Thu Oct 6 18:32:59 2016 -0700

Steve Berman

Message #34 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Richard Copley <rcopley <at> gmail.com>
Cc: Stephen Berman <stephen.berman <at> gmx.net>, 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 19:35:40 -0400

On 04/11/16 at 09:16pm, Richard Copley wrote:
> On 4 November 2016 at 20:53, Mark Oteiza <mvoteiza <at> udel.edu> wrote:
> > Sorry if I jumped the gun closing.
> >
> > I'm on 2955936 (master HEAD at the moment) and can't reproduce.
> 
> I can reproduce the issue with the given recipe in that revision.
> 
> To summarize, here are the test results stated so far in this thread,
> plus a few more that I'm stating now, in chronological order:
> 
> Good [RC] (before lexical binding in isearch.el):
> commit 329e0274ec6a4ae82f86905b8cf844971b943085
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Tue Sep 27 13:34:29 2016 -0400
> 
> Bad [RC] (turn on lexical binding in isearch.el)
> commit cbb2e845187bfbcc62e2accc9df7891a2326608a
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Wed Sep 28 13:08:12 2016 -0400
> 
> Good?? [MO] (this is the revision mentioned in #24580)
> commit 6d6c93f4cc02d5c03b2f0ec9e565d61a50677e14
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Tue Oct 4 10:17:53 2016 -0400
> 
> Bad [SB] (unspecified, but containing the above).
> 
> >> >> >> > BAD [RC]:
> >> >> >> > commit 9640e9f4e95cd95c04875e90a4ff638e1e51f977
> >> >> >> > Author: Tino Calancha <tino.calancha <at> gmail.com>
> >> >> >> > Date:   Tue Oct 11 11:47:32 2016 +0900
> 
> Good [MO], Bad [RC]:
> commit 29559361f56c9398dcb69db7396dcfc0887843a2
> Author: Mark Oteiza <mvoteiza <at> udel.edu>
> Date:   Fri Nov 4 14:22:05 2016 -0400
> 
> Mark, it seems rude to ask, sorry, but are you sure you weren't testing
> a slightly different recipe? Otherwise it must be some difference in our
> environment which seems less likely.

No worries, I think I erred here (M-% instead of C-M-% I think is what
I was doing).  Sorry for the confusion! :(

Message #39 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Mark Oteiza <mvoteiza <at> udel.edu>
To: Richard Copley <rcopley <at> gmail.com>
Cc: Stephen Berman <stephen.berman <at> gmx.net>, 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 20:34:02 -0400

Does the following fix it for you?

diff --git a/lisp/replace.el b/lisp/replace.el
index 4fc48d4..60948ef 100644
--- a/lisp/replace.el
+++ b/lisp/replace.el
@@ -198,7 +198,7 @@ query-replace-read-from
                     (setq-local text-property-default-nonsticky
                                 (cons '(separator . t) text-property-default-nonsticky)))
                 (if regexp-flag
-                    (read-regexp prompt)
+                    (read-regexp prompt nil 'minibuffer-history)
                   (read-from-minibuffer
                    prompt nil nil nil nil
                    (car (if regexp-flag regexp-search-ring search-ring)) t)))))

Message #42 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: Richard Copley <rcopley <at> gmail.com>, Stephen Berman <stephen.berman <at> gmx.net>,
 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Fri, 4 Nov 2016 20:58:27 -0400

On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza <mvoteiza <at> udel.edu> wrote:
> Does the following fix it for you?
>
> diff --git a/lisp/replace.el b/lisp/replace.el
> index 4fc48d4..60948ef 100644
> --- a/lisp/replace.el
> +++ b/lisp/replace.el
> @@ -198,7 +198,7 @@ query-replace-read-from
>                      (setq-local text-property-default-nonsticky
>                                  (cons '(separator . t) text-property-default-nonsticky)))
>                  (if regexp-flag
> -                    (read-regexp prompt)
> +                    (read-regexp prompt nil 'minibuffer-history)

I think you need make minibuffer-history into a dynamic variable for
this to work.

Message #45 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: Stephen Berman <stephen.berman <at> gmx.net>, 24873 <at> debbugs.gnu.org
Subject: Re: bug#24873: 26.0.50; isearch-query-replace from regexp isearch
 doesn't add to replace-regexp history list
Date: Sat, 5 Nov 2016 12:18:48 +0000

On 5 November 2016 at 00:34, Mark Oteiza <mvoteiza <at> udel.edu> wrote:
> Does the following fix it for you?
>
> diff --git a/lisp/replace.el b/lisp/replace.el
> index 4fc48d4..60948ef 100644
> --- a/lisp/replace.el
> +++ b/lisp/replace.el
> @@ -198,7 +198,7 @@ query-replace-read-from
>                      (setq-local text-property-default-nonsticky
>                                  (cons '(separator . t) text-property-default-nonsticky)))
>                  (if regexp-flag
> -                    (read-regexp prompt)
> +                    (read-regexp prompt nil 'minibuffer-history)
>                    (read-from-minibuffer
>                     prompt nil nil nil nil
>                     (car (if regexp-flag regexp-search-ring search-ring)) t)))))

Yes.

Message #48 received at 24873 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Mark Oteiza <mvoteiza <at> udel.edu>
Cc: Richard Copley <rcopley <at> gmail.com>, 24873 <at> debbugs.gnu.org,
 Stephen Berman <stephen.berman <at> gmx.net>
Subject: Re: bug#24873: 26.0.50;
 isearch-query-replace from regexp isearch doesn't add to
 replace-regexp history list
Date: Sat, 12 Nov 2016 21:42:26 -0500

tags 24873 fixed
close 24873 
quit

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> On Fri, Nov 4, 2016 at 8:34 PM, Mark Oteiza <mvoteiza <at> udel.edu> wrote:
>> Does the following fix it for you?
>>
>> diff --git a/lisp/replace.el b/lisp/replace.el
>> index 4fc48d4..60948ef 100644
>> --- a/lisp/replace.el
>> +++ b/lisp/replace.el
>> @@ -198,7 +198,7 @@ query-replace-read-from
>>                      (setq-local text-property-default-nonsticky
>>                                  (cons '(separator . t) text-property-default-nonsticky)))
>>                  (if regexp-flag
>> -                    (read-regexp prompt)
>> +                    (read-regexp prompt nil 'minibuffer-history)
>
> I think you need make minibuffer-history into a dynamic variable for
> this to work.

Ah, minibuffer-history is defined in simple.el, so it's fine.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.