From unknown Tue Jun 17 22:29:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2016 05:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24855@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.147806412326634 (code B ref -1); Wed, 02 Nov 2016 05:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Nov 2016 05:22:03 +0000 Received: from localhost ([127.0.0.1]:39696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1nzu-0006vW-Rz for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:22:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1nzt-0006uy-4y for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1nzn-0001JY-6w for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:21:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1nzn-0001JU-3u for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:21:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1nzm-0004On-4b for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 01:21:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1nzj-0001IA-1d for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 01:21:54 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:33124) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1nzi-0001Hy-RL for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 01:21:50 -0400 Received: by mail-pf0-x243.google.com with SMTP id a136so677954pfa.0 for ; Tue, 01 Nov 2016 22:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version; bh=SWI+/6NWc5CrfS9+DIjr5vG1zb52vro5YjIWm78gO7E=; b=pUfZBj6w4y7BeyzqCdiOIJfaEDThALsQz61duH6ZF0vD1xQBLZm1iDFCw4FXbja4Qu tVA71qy+EVeZiR7k0fIFtlIjZzj+oJx6NupuT8UjczuNUMKl5VSR0vX2oc92gRA8pOBH t/ZzvRc0lBjidSSvavnIiwzUIfe18k9Ih6+zy2/zNwIb8xaTU9MwdJ6K7GWEZk6AaJ9f Q+J2N7SRR8nP+oNEgJIXy3rnfpXYwGgREaME6HV8AwiyDSqDqj+XTraZZqFP8HPDJB7s BAXippgstfCPedobfVsFgiArcUpgBycgqix0+0YUOoUrBOPeVoN5uiXuORCEcoGwedXD EfCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:user-agent :mime-version; bh=SWI+/6NWc5CrfS9+DIjr5vG1zb52vro5YjIWm78gO7E=; b=dT1oPWvn9AQXzqPGEnyt8trmZJOcHgz9qnFgpf4vUQBGTaZaJpOtBOzqvDl2TuwMjJ NF1cgvU5y5jhg5SMH0yGZ0SUP7M3LQDfQSZV5B8spGawY4YguC3Nxubc79qL5cIUUPtQ xV6fGgwlR7AMboy1fhtG51ph+ed2L+gZ7hClGr0Eo8XAKip6JKjYqURvMdj06Y+YLQtI GQJ/fs8GakhspeJ/3RNR8ZY3yP9gylYr152mzAz7ddfylEme5kG+gkoXWIMO0DV/CiBe h+Dfdw5MYM6z7JsrbDPrpK16etkO4DKHxnS1BuoIAZvdLVChvPPig2NV3WS5H7w46vbc t3Yg== X-Gm-Message-State: ABUngvdsXfyT6rsavGFMwI2VltKVTUcjtAiXQLHnK+FtdafXprUGypJTmY9mlTVxRURSdw== X-Received: by 10.99.181.10 with SMTP id y10mr2816990pge.161.1478064109625; Tue, 01 Nov 2016 22:21:49 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id yp3sm780326pac.22.2016.11.01.22.21.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 22:21:49 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 2 Nov 2016 14:21:46 +0900 (JST) X-X-Sender: calancha@calancha-pc Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -r -Q -eval "(setq Buffer-menu-use-header-line nil)" C-x C-b C-x o M-: (Buffer-menu-no-header) RET => t ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 7385a0952923cc3ec435fe9097cd5c81da4c59eb Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 2 Nov 2016 14:14:58 +0900 Subject: [PATCH] Buffer-menu-no-header: Detect a fake header * lisp/buff-menu.el (Buffer-menu-no-header): Match fake headers starting with a white space (Bug#24855). --- lisp/buff-menu.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..41bcfab 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -328,7 +328,7 @@ Buffer-menu-buffer (defun Buffer-menu-no-header () (beginning-of-line) (if (or Buffer-menu-use-header-line - (not (eq (char-after) ?C))) + (not (looking-at-p "^ ?C"))) t (ding) (forward-line 1) -- 2.10.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-02 built on calancha-pc Repository revision: c3640fcc96ed80368209c73d7ac9a0f0d1833d93 From unknown Tue Jun 17 22:29:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2016 07:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 24855@debbugs.gnu.org Received: via spool by 24855-submit@debbugs.gnu.org id=B24855.14780728777122 (code B ref 24855); Wed, 02 Nov 2016 07:48:02 +0000 Received: (at 24855) by debbugs.gnu.org; 2 Nov 2016 07:47:57 +0000 Received: from localhost ([127.0.0.1]:39718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1qH7-0001qn-Lk for submit@debbugs.gnu.org; Wed, 02 Nov 2016 03:47:57 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:35112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1qH5-0001qa-Vj for 24855@debbugs.gnu.org; Wed, 02 Nov 2016 03:47:56 -0400 Received: by mail-pf0-f193.google.com with SMTP id i88so1025435pfk.2 for <24855@debbugs.gnu.org>; Wed, 02 Nov 2016 00:47:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version; bh=U5pvbryelAi9skVICupjZFeMUEOE9eWsoyjF3RJB0ps=; b=aEh7+J+ClVvjx2g7yggr9qI+J20phJqb1Tu5qsiG6Nslp7izMv9DlX98Fh2T7XWUPe f3rL/kv5mgByQn//OVaa0jkLYQLZVv3u1bV2IRcpEB55qAqUSh6h7dGPhmCjNN2FCM3u MI/1XeQCv+rk21jEzT6mwVrMHLshlLZ3T5VJKD8LqR87oIEL/hPE3Zs6kchAhlidcfQe I2wHJw+DUJttTRgEuBFcCqQDchN0xHeuP+42UpdrN4Rt4M01HG06Boun+Bxzzqmo0Jjf XXgKbkYwnVRmITOH5/zBQmfKJXhKNTuRkAlnid+GSOicVHvO2aYlINg1NqQoTtGPoYKD ih8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=U5pvbryelAi9skVICupjZFeMUEOE9eWsoyjF3RJB0ps=; b=OUGHylUPKQZft09h6E7ad7zBtd0nzM3KvbRuMEaU7nP9GTeNTw7QKEK8DiYbDk+Jqw AJDp/LXqPJpp4gec7p/5jWjXiLYRLJvTddI3KmOd/Vy5shFzwjkiDIzFp4fQYvlmiKK3 DpRuvoWjnJybCeMb2T7CnjBKtUtgk8EKI/R3bK/z6innAv3MSYX3sci5k/Z70UIQC1yK Iw8O0+boBdn5HpYr0JELTN3jJ0gdz0Ec2kA3KSnjZJpXDapYQchSC5ZGSw85CzqKIJ76 FyYVNi0bc5ahkAiXS40XfIiJXW3qmbkDwFzPIIOjFJzgCie/JCoylVepz0jkUo/xIYuF liRw== X-Gm-Message-State: ABUngveETYLfS7bc5L0YzAVqSN5ax0JBUVGpgtCnKYfDnOnozQRpucT+XYrviMkm6EteWQ== X-Received: by 10.98.31.154 with SMTP id l26mr4338682pfj.87.1478072869797; Wed, 02 Nov 2016 00:47:49 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id ak3sm2107359pad.19.2016.11.02.00.47.48 for <24855@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Nov 2016 00:47:49 -0700 (PDT) From: Tino Calancha In-Reply-To: (Tino Calancha's message of "Wed, 2 Nov 2016 14:21:46 +0900 (JST)") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Date: Wed, 02 Nov 2016 16:47:45 +0900 Message-ID: <87lgx2b9we.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Or we might add a new predicate `tabulated-list-no-header-p': ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 91c45beea1ea8bfc4931f03ef391ffbe15e99c64 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 2 Nov 2016 16:38:23 +0900 Subject: [PATCH] Buffer-menu-no-header: Detect a fake header * lisp/emacs-lisp/tabulated-list.el (tabulated-list-no-header-p): New predicate. * lisp/buff-menu.el (Buffer-menu-no-header): Use it (Bug#24855). --- lisp/buff-menu.el | 2 +- lisp/emacs-lisp/tabulated-list.el | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..22f7abe 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -328,7 +328,7 @@ Buffer-menu-buffer (defun Buffer-menu-no-header () (beginning-of-line) (if (or Buffer-menu-use-header-line - (not (eq (char-after) ?C))) + (tabulated-list-no-header-p (point))) t (ding) (forward-line 1) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 00b029d..415cd24 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -257,6 +257,9 @@ tabulated-list-print-fake-header (make-overlay (point-min) (point)))) (overlay-put tabulated-list--header-overlay 'face 'underline)))) +(defsubst tabulated-list-no-header-p (&optional pos) + (null (overlays-at (or pos (point-min))))) + (defun tabulated-list-revert (&rest ignored) "The `revert-buffer-function' for `tabulated-list-mode'. It runs `tabulated-list-revert-hook', then calls `tabulated-list-print'." @@ -312,7 +315,7 @@ tabulated-list-print method which is faster if most entries haven't changed since the last print. The only difference in outcome is that tags will not be removed from entries that haven't changed (see -`tabulated-list-put-tag'). Don't use this immediately after +(erase-buffer)`tabulated-list-put-tag'). Don't use this immediately after changing `tabulated-list-sort-key'." (let ((inhibit-read-only t) (entries (if (functionp tabulated-list-entries) -- 2.10.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.5 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-02 built on calancha-pc Repository revision: 126c879df42f741fe486236aea538290a8c2ed64 From unknown Tue Jun 17 22:29:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2016 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tino Calancha Cc: 24855@debbugs.gnu.org Received: via spool by 24855-submit@debbugs.gnu.org id=B24855.147807674012882 (code B ref 24855); Wed, 02 Nov 2016 08:53:02 +0000 Received: (at 24855) by debbugs.gnu.org; 2 Nov 2016 08:52:20 +0000 Received: from localhost ([127.0.0.1]:39752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1rHP-0003Li-Pf for submit@debbugs.gnu.org; Wed, 02 Nov 2016 04:52:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:54644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1rHO-0003LZ-0f for 24855@debbugs.gnu.org; Wed, 02 Nov 2016 04:52:18 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1739BAB03; Wed, 2 Nov 2016 08:52:17 +0000 (UTC) From: Andreas Schwab References: <87lgx2b9we.fsf@gmail.com> X-Yow: I'm DESPONDENT... I hope there's something DEEP-FRIED under this miniature DOMED STADIUM... Date: Wed, 02 Nov 2016 09:52:16 +0100 In-Reply-To: <87lgx2b9we.fsf@gmail.com> (Tino Calancha's message of "Wed, 02 Nov 2016 16:47:45 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.8 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.8 (----) On Nov 02 2016, Tino Calancha wrote: > @@ -312,7 +315,7 @@ tabulated-list-print > method which is faster if most entries haven't changed since the > last print. The only difference in outcome is that tags will not > be removed from entries that haven't changed (see > -`tabulated-list-put-tag'). Don't use this immediately after > +(erase-buffer)`tabulated-list-put-tag'). Don't use this immediately after Paste accident? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From unknown Tue Jun 17 22:29:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2016 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Andreas Schwab Cc: Tino Calancha , 24855@debbugs.gnu.org Received: via spool by 24855-submit@debbugs.gnu.org id=B24855.147808023318019 (code B ref 24855); Wed, 02 Nov 2016 09:51:02 +0000 Received: (at 24855) by debbugs.gnu.org; 2 Nov 2016 09:50:33 +0000 Received: from localhost ([127.0.0.1]:39776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1sBk-0004gY-SK for submit@debbugs.gnu.org; Wed, 02 Nov 2016 05:50:33 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1sBj-0004gJ-6C for 24855@debbugs.gnu.org; Wed, 02 Nov 2016 05:50:31 -0400 Received: by mail-pf0-f195.google.com with SMTP id a136so1340751pfa.0 for <24855@debbugs.gnu.org>; Wed, 02 Nov 2016 02:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WIK7FCIjU+ZPvuK8O4iO4Xaf8KGHfPB10mJwAhyt+ik=; b=zjozjZQ0TR7QFvScZSxfojAxnFhQ2L7DdjsgH/5IhXX0G20GTa2mj145JmqolI2ITz AdVGZoFoB/DYxqWrc3uFYseworP/9a/A2DD4ER34yrlphVdjXqh117MHkJMBvSP4Pc+j RryFrLEOe8s/kilsWTupBrve/fCbqTJNgN/0YDiOSrVziEhFrz4ciVTXzO53gLSjtIVF cNvyuxwrUTtjQ2hlQyXDxiyvzomngTeBInv6OEcxrHkyWUwk1dI2OcfT2Fvx+soo0rBG veMudsnvIGpm4kuuAsNX5OtZXGxCstHhpjbr/JnozOxEwvSixERCJQmy4cuBrMVHNrT6 7tQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=WIK7FCIjU+ZPvuK8O4iO4Xaf8KGHfPB10mJwAhyt+ik=; b=Z8sXXBQp0AN7jqo+iFoYtHEFAiSP93MtnxOq72yoTSqNz5pQDCoQlt9MpnB2uKB6DU /djSUcyeXuNeOyybFe7B8m5mcGFpgHBtfLv5BIrJRq786TemLMkHcIpWeP+uN5T4z1TZ n/O0HVjATdaYa9i8Dx/ZGAV4iAyMoXh4b9zr2tAxTo3GLBvSuP3kHcH1/CHhp8knxrEx LQsmPW+jAeIgAA4dvDd/T7a4DvPIQB6JFHxgz7d5TPvYjtNqopWNwQGdt2UB4whwd37G IviQtHVM+Rj90Pa5rK6W6+HDimhwxiBsRBNnFTar/XMAYtOK99CAKDqVCgpb2z5B7/Aw Wr2w== X-Gm-Message-State: ABUngvcQampbdv1dRTvsk/ksk535FFzX1Zt5lNqNfY0SDoeOQ2xwM6V7qCQlLwZqc1XS4g== X-Received: by 10.98.66.149 with SMTP id h21mr5299479pfd.32.1478080225182; Wed, 02 Nov 2016 02:50:25 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id w24sm3239758pfa.12.2016.11.02.02.50.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Nov 2016 02:50:24 -0700 (PDT) From: Tino Calancha References: <87lgx2b9we.fsf@gmail.com> Date: Wed, 02 Nov 2016 18:50:20 +0900 In-Reply-To: (Andreas Schwab's message of "Wed, 02 Nov 2016 09:52:16 +0100") Message-ID: <87zili6wir.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Andreas Schwab writes: > On Nov 02 2016, Tino Calancha wrote: > >> @@ -312,7 +315,7 @@ tabulated-list-print >> method which is faster if most entries haven't changed since the >> last print. The only difference in outcome is that tags will not >> be removed from entries that haven't changed (see >> -`tabulated-list-put-tag'). Don't use this immediately after >> +(erase-buffer)`tabulated-list-put-tag'). Don't use this immediately after > > Paste accident? Yes, thank you! That happens when i have long nails. Time to cut... Here is the corrected patch: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From da5331dbb415f0779e36b15cbe1c943ee00f8081 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 2 Nov 2016 18:43:44 +0900 Subject: [PATCH] Buffer-menu-no-header: Detect a fake header * lisp/emacs-lisp/tabulated-list.el (tabulated-list-no-header-p): New predicate. * lisp/buff-menu.el (Buffer-menu-no-header): Use it (Bug#24855). --- lisp/buff-menu.el | 2 +- lisp/emacs-lisp/tabulated-list.el | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..22f7abe 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -328,7 +328,7 @@ Buffer-menu-buffer (defun Buffer-menu-no-header () (beginning-of-line) (if (or Buffer-menu-use-header-line - (not (eq (char-after) ?C))) + (tabulated-list-no-header-p (point))) t (ding) (forward-line 1) diff --git a/lisp/emacs-lisp/tabulated-list.el b/lisp/emacs-lisp/tabulated-list.el index 00b029d..590bcbc 100644 --- a/lisp/emacs-lisp/tabulated-list.el +++ b/lisp/emacs-lisp/tabulated-list.el @@ -257,6 +257,9 @@ tabulated-list-print-fake-header (make-overlay (point-min) (point)))) (overlay-put tabulated-list--header-overlay 'face 'underline)))) +(defsubst tabulated-list-no-header-p (&optional pos) + (null (overlays-at (or pos (point-min))))) + (defun tabulated-list-revert (&rest ignored) "The `revert-buffer-function' for `tabulated-list-mode'. It runs `tabulated-list-revert-hook', then calls `tabulated-list-print'." -- 2.10.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.5 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-02 built on calancha-pc Repository revision: 126c879df42f741fe486236aea538290a8c2ed64 From unknown Tue Jun 17 22:29:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Tino Calancha Subject: bug#24855: closed (Re: bug#24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space) Message-ID: References: <87eg246lz0.fsf@gmail.com> X-Gnu-PR-Message: they-closed 24855 X-Gnu-PR-Package: emacs Reply-To: 24855@debbugs.gnu.org Date: Tue, 22 Nov 2016 06:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1479797882-15946-1" This is a multi-part message in MIME format... ------------=_1479797882-15946-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with whi= te space which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24855@debbugs.gnu.org. --=20 24855: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24855 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1479797882-15946-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24855-done) by debbugs.gnu.org; 22 Nov 2016 06:57:18 +0000 Received: from localhost ([127.0.0.1]:37730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9514-00048D-Au for submit@debbugs.gnu.org; Tue, 22 Nov 2016 01:57:18 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:34215) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9512-00047x-AE for 24855-done@debbugs.gnu.org; Tue, 22 Nov 2016 01:57:16 -0500 Received: by mail-pf0-f178.google.com with SMTP id c4so2662656pfb.1 for <24855-done@debbugs.gnu.org>; Mon, 21 Nov 2016 22:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=GmSDmeDyp6k38VV4qGPqiJ+QLw1tXH4VkAV7nzQcnv8=; b=V9YsifH8PmOaLyKKlh+MC4N/E9kby/feBNNja4qLIEShI9BRMVHQHN/RbZqB8qYa9s 0AuhN/dw/lj/HTi2yP81tR4Y+DKMpnN3LluxQQaaSEsIvZ5r6eHG+3sTN/I5/vgUnLm8 6G1qybNA3OFEDNwwG1+aJevv5RQ1OtSADcAmtWxGK3dVVrVEOHZnZWi8PGkMGiVSWb+f Beuj3Y2DORsEqUxAU4fz6wEa56JveWYDwS4G2YNnzW9hvfP7rJo/ONg1dfUimEuHl1PC Uz8cObEs7pysJu/q8qW4PRh/m2wvNedh7pIkFBB8db3g53v5Q1MpRHGr3OkX6TCDhhOJ Mr4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GmSDmeDyp6k38VV4qGPqiJ+QLw1tXH4VkAV7nzQcnv8=; b=ahuCWdJxplBKV08vqM6GIP1GAgrRxZ5UDbgb+j7ZHA5z/8WG0WG2aVIwt0mDRLx5ZV DjEW/wH6CoWGmZcMfkL9WYm9AHYmFMAUmDTKT6tt8gvVUOGANN6dMkEjK64MQdB9YxOu mVtkONfK80SoT2vBKf+2fUIsI+1tuzYR8KdbKNYr9/wjSDJzQBVAEVDS3Px/K28RTpSg SnIgQhp/cN4TSd+Cxa5q6zifW2DS/bmDunmBfAr2t1CRNkQgZDOgFtXKxGZxjqp+3TgO nPPiYEnyFC3A2WK8qlDZrIk9hfxQuySHwechVru1RuLmvfZ3Ip9JJ8atj8lkeksGO+0E WfYw== X-Gm-Message-State: AKaTC01miiq/1oGPcAHqPgGxdNwlUEgWdskMJtEoCcyPITVMPlEDXNdkQLmTRIE7U4/IWw== X-Received: by 10.99.45.134 with SMTP id t128mr39466656pgt.86.1479797830288; Mon, 21 Nov 2016 22:57:10 -0800 (PST) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id w16sm24167740pgc.30.2016.11.21.22.57.09 for <24855-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Nov 2016 22:57:09 -0800 (PST) From: Tino Calancha To: 24855-done@debbugs.gnu.org Subject: Re: bug#24855: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space References: Date: Tue, 22 Nov 2016 15:57:07 +0900 In-Reply-To: (Tino Calancha's message of "Wed, 2 Nov 2016 14:21:46 +0900 (JST)") Message-ID: <87eg246lz0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 24855-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Tino Calancha writes: > emacs -r -Q -eval "(setq Buffer-menu-use-header-line nil)" > C-x C-b C-x o > M-: (Buffer-menu-no-header) RET > => t Pushed fix to master branch as commit: 4940e0f ------------=_1479797882-15946-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Nov 2016 05:22:03 +0000 Received: from localhost ([127.0.0.1]:39696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1nzu-0006vW-Rz for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:22:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1nzt-0006uy-4y for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:22:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1nzn-0001JY-6w for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:21:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36119) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c1nzn-0001JU-3u for submit@debbugs.gnu.org; Wed, 02 Nov 2016 01:21:55 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1nzm-0004On-4b for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 01:21:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1nzj-0001IA-1d for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 01:21:54 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:33124) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c1nzi-0001Hy-RL for bug-gnu-emacs@gnu.org; Wed, 02 Nov 2016 01:21:50 -0400 Received: by mail-pf0-x243.google.com with SMTP id a136so677954pfa.0 for ; Tue, 01 Nov 2016 22:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version; bh=SWI+/6NWc5CrfS9+DIjr5vG1zb52vro5YjIWm78gO7E=; b=pUfZBj6w4y7BeyzqCdiOIJfaEDThALsQz61duH6ZF0vD1xQBLZm1iDFCw4FXbja4Qu tVA71qy+EVeZiR7k0fIFtlIjZzj+oJx6NupuT8UjczuNUMKl5VSR0vX2oc92gRA8pOBH t/ZzvRc0lBjidSSvavnIiwzUIfe18k9Ih6+zy2/zNwIb8xaTU9MwdJ6K7GWEZk6AaJ9f Q+J2N7SRR8nP+oNEgJIXy3rnfpXYwGgREaME6HV8AwiyDSqDqj+XTraZZqFP8HPDJB7s BAXippgstfCPedobfVsFgiArcUpgBycgqix0+0YUOoUrBOPeVoN5uiXuORCEcoGwedXD EfCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:user-agent :mime-version; bh=SWI+/6NWc5CrfS9+DIjr5vG1zb52vro5YjIWm78gO7E=; b=dT1oPWvn9AQXzqPGEnyt8trmZJOcHgz9qnFgpf4vUQBGTaZaJpOtBOzqvDl2TuwMjJ NF1cgvU5y5jhg5SMH0yGZ0SUP7M3LQDfQSZV5B8spGawY4YguC3Nxubc79qL5cIUUPtQ xV6fGgwlR7AMboy1fhtG51ph+ed2L+gZ7hClGr0Eo8XAKip6JKjYqURvMdj06Y+YLQtI GQJ/fs8GakhspeJ/3RNR8ZY3yP9gylYr152mzAz7ddfylEme5kG+gkoXWIMO0DV/CiBe h+Dfdw5MYM6z7JsrbDPrpK16etkO4DKHxnS1BuoIAZvdLVChvPPig2NV3WS5H7w46vbc t3Yg== X-Gm-Message-State: ABUngvdsXfyT6rsavGFMwI2VltKVTUcjtAiXQLHnK+FtdafXprUGypJTmY9mlTVxRURSdw== X-Received: by 10.99.181.10 with SMTP id y10mr2816990pge.161.1478064109625; Tue, 01 Nov 2016 22:21:49 -0700 (PDT) Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id yp3sm780326pac.22.2016.11.01.22.21.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 22:21:49 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 2 Nov 2016 14:21:46 +0900 (JST) X-X-Sender: calancha@calancha-pc To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Buffer-menu-no-header fails if fake header starts with white space Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -r -Q -eval "(setq Buffer-menu-use-header-line nil)" C-x C-b C-x o M-: (Buffer-menu-no-header) RET => t ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 7385a0952923cc3ec435fe9097cd5c81da4c59eb Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 2 Nov 2016 14:14:58 +0900 Subject: [PATCH] Buffer-menu-no-header: Detect a fake header * lisp/buff-menu.el (Buffer-menu-no-header): Match fake headers starting with a white space (Bug#24855). --- lisp/buff-menu.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 4742628..41bcfab 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -328,7 +328,7 @@ Buffer-menu-buffer (defun Buffer-menu-no-header () (beginning-of-line) (if (or Buffer-menu-use-header-line - (not (eq (char-after) ?C))) + (not (looking-at-p "^ ?C"))) t (ding) (forward-line 1) -- 2.10.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 26.0.50.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.2) of 2016-11-02 built on calancha-pc Repository revision: c3640fcc96ed80368209c73d7ac9a0f0d1833d93 ------------=_1479797882-15946-1--