Subject: bug#24843: closed (Re: bug#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 04 Nov 2016 09:27:02 +0000

Your bug report

#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
24843: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=24843
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#24843: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark
From: Eli Zaretskii <[email-masked]>
To: Tibor Csögör <[email-masked]>
Cc: [email-masked]
Date: Fri, 04 Nov 2016 11:26:58 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: Tibor Csögör <[email-masked]>
> Date: Tue, 01 Nov 2016 01:51:45 +0100
> 
> The docstring states: "This option is currently ignored on MS-Windows, since the
> necessary functionality is not available there."  However, this limitation was
> removed in commit 20c6b227ea69b9cd47f92d1a7e0935312e8ce83c.
> 
> Patch attached.

Thanks, pushed to the emacs-25 branch.

Subject: 25.1; docstring of 'browse-url-firefox-new-window-is-tab' contains obsolete remark
From: Tibor Csögör <[email-masked]>
To: [email-masked]
Date: Tue, 01 Nov 2016 01:51:45 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

The docstring states: "This option is currently ignored on MS-Windows, since the
necessary functionality is not available there."  However, this limitation was
removed in commit 20c6b227ea69b9cd47f92d1a7e0935312e8ce83c.

Patch attached.

Fix docstring of 'browse-url-firefox-new-window-is-tab'

* lisp/net/browse-url.el (browse-url-firefox-new-window-is-tab): Remove
obsolete remark from docstring (obsoleted by commit
20c6b227ea69b9cd47f92d1a7e0935312e8ce83c). (Bug#XXXXX)

>From 48df60f57a218b4c82eabbfa312141d5dc88d194 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tibor=20Cs=C3=B6g=C3=B6r?= <[email-masked]>
Date: Tue, 1 Nov 2016 01:38:07 +0100
Subject: [PATCH] Fix docstring of 'browse-url-firefox-new-window-is-tab'

* lisp/net/browse-url.el (browse-url-firefox-new-window-is-tab): Remove
obsolete remark from docstring (obsoleted by commit
20c6b227ea69b9cd47f92d1a7e0935312e8ce83c). (Bug#XXXXX)
---
 lisp/net/browse-url.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 1bb4831..15f6df7 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -365,10 +365,7 @@ If non-nil, then open the URL in a new tab rather than a new window if
 (defcustom browse-url-firefox-new-window-is-tab nil
   "Whether to open up new windows in a tab or a new window.
 If non-nil, then open the URL in a new tab rather than a new window if
-`browse-url-firefox' is asked to open it in a new window.
-
-This option is currently ignored on MS-Windows, since the necessary
-functionality is not available there."
+`browse-url-firefox' is asked to open it in a new window."
   :type 'boolean
   :group 'browse-url)
 
-- 
2.1.4