From unknown Sun Aug 17 04:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24833: Hydra ignores MIPS-specific patch for Mesa on core-updates Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 31 Oct 2016 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24833 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 24833@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14778947555745 (code B ref -1); Mon, 31 Oct 2016 06:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Oct 2016 06:19:15 +0000 Received: from localhost ([127.0.0.1]:37587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c15wB-0001Ub-Au for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c15wA-0001UM-AH for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c15w4-00067N-8Z for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c15w4-00067J-5Q for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c15w2-0005Jo-Vh for bug-guix@gnu.org; Mon, 31 Oct 2016 02:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c15vy-00063r-6e for bug-guix@gnu.org; Mon, 31 Oct 2016 02:19:06 -0400 Received: from world.peace.net ([50.252.239.5]:42678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c15vy-00063i-2o for bug-guix@gnu.org; Mon, 31 Oct 2016 02:19:02 -0400 Received: from [10.1.10.31] (helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c15vw-0002yl-TA; Mon, 31 Oct 2016 02:19:00 -0400 From: Mark H Weaver Date: Mon, 31 Oct 2016 02:17:35 -0400 Message-ID: <87shrdca9s.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 on core-updates added a patch to Mesa on MIPS only, in order to prevent unnecessary rebuilds on other systems. 'guix' running on a MIPS system generates a derivation that applies the patch, but the derivation generated for MIPS on Hydra omits the patch. The corresponding build page on Hydra is: https://hydra.gnu.org/build/1569732 The derivation for that build is: /gnu/store/vyqmm1zdhbzxjnaq0h6k312mm7ywi1bq-mesa-12.0.1.drv which uses a source derivation: /gnu/store/368ns1adxyv5zhnsn5rx40k6ghd9sr39-mesa-12.0.1.tar.xz.drv and this derivation simply downloads the source tarball. In contrast, corresponding derivations generated by 'guix' on a mips64el-linux machine are: /gnu/store/1r8m67dn07q2k75gl7rnw09i2kp4a0rd-mesa-12.0.1.drv /gnu/store/imyjp7sx1rzwpc9agvcnjvk28i4qcgis-mesa-12.0.1.tar.xz.drv and the latter derivation is a 'patch-and-repack' derivation that applies 'mesa-wayland-egl-symbols-check-mips.patch', as expected. Mark From unknown Sun Aug 17 04:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24833: Hydra ignores MIPS-specific patch for Mesa on core-updates Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 02 Nov 2016 22:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24833 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Cc: 24833@debbugs.gnu.org Received: via spool by 24833-submit@debbugs.gnu.org id=B24833.14781250638832 (code B ref 24833); Wed, 02 Nov 2016 22:18:02 +0000 Received: (at 24833) by debbugs.gnu.org; 2 Nov 2016 22:17:43 +0000 Received: from localhost ([127.0.0.1]:40933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c23qo-0002IO-N7 for submit@debbugs.gnu.org; Wed, 02 Nov 2016 18:17:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c23qn-0002IC-Ip for 24833@debbugs.gnu.org; Wed, 02 Nov 2016 18:17:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c23qf-0006Hk-8F for 24833@debbugs.gnu.org; Wed, 02 Nov 2016 18:17:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c23qf-0006He-4s; Wed, 02 Nov 2016 18:17:33 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:36648 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1c23qe-0004kG-Hi; Wed, 02 Nov 2016 18:17:32 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87shrdca9s.fsf@netris.org> Date: Wed, 02 Nov 2016 23:17:30 +0100 In-Reply-To: <87shrdca9s.fsf@netris.org> (Mark H. Weaver's message of "Mon, 31 Oct 2016 02:17:35 -0400") Message-ID: <87ins5le6d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.7 (-------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.7 (-------) Mark H Weaver skribis: > Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 on core-updates added a > patch to Mesa on MIPS only, in order to prevent unnecessary rebuilds on > other systems. 'guix' running on a MIPS system generates a derivation > that applies the patch, but the derivation generated for MIPS on Hydra > omits the patch. Did it turn out to be the same issue as , or is it something entirely different? Ludo=E2=80=99. From unknown Sun Aug 17 04:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#24833: Hydra ignores MIPS-specific patch for Mesa on core-updates Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 03 Nov 2016 02:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24833 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Cc: 24833@debbugs.gnu.org Received: via spool by 24833-submit@debbugs.gnu.org id=B24833.14781391613531 (code B ref 24833); Thu, 03 Nov 2016 02:13:02 +0000 Received: (at 24833) by debbugs.gnu.org; 3 Nov 2016 02:12:41 +0000 Received: from localhost ([127.0.0.1]:41045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c27WC-0000ut-Vs for submit@debbugs.gnu.org; Wed, 02 Nov 2016 22:12:41 -0400 Received: from world.peace.net ([50.252.239.5]:59383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c27WB-0000ug-Gl for 24833@debbugs.gnu.org; Wed, 02 Nov 2016 22:12:39 -0400 Received: from pool-71-174-35-171.bstnma.east.verizon.net ([71.174.35.171] helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c27W5-0005uM-FA; Wed, 02 Nov 2016 22:12:33 -0400 From: Mark H Weaver In-Reply-To: <87ins5le6d.fsf@gnu.org> References: <87ins5le6d.fsf@gnu.org> <87shrdca9s.fsf@netris.org> Date: Wed, 02 Nov 2016 22:10:50 -0400 Message-ID: <87eg2ttis5.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) ludo@gnu.org (Ludovic Court=C3=A8s) > Mark H Weaver skribis: > >> Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 on core-updates added a >> patch to Mesa on MIPS only, in order to prevent unnecessary rebuilds on >> other systems. 'guix' running on a MIPS system generates a derivation >> that applies the patch, but the derivation generated for MIPS on Hydra >> omits the patch. > > Did it turn out to be the same issue as , or > is it something entirely different? Bug 24833 is this bug, so yes, by reflexivity it's the same issue, but I suspect that's not what you meant to ask :) This bug still remains, and I'm not aware of another bug that's the same issue as this one. Thanks, Mark From unknown Sun Aug 17 04:18:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mark H Weaver Subject: bug#24833: closed (Re: bug#24833: Hydra ignores MIPS-specific patch for Mesa on core-updates) Message-ID: References: <87zilgx3ea.fsf@gnu.org> <87shrdca9s.fsf@netris.org> X-Gnu-PR-Message: they-closed 24833 X-Gnu-PR-Package: guix Reply-To: 24833@debbugs.gnu.org Date: Thu, 03 Nov 2016 10:30:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1478169002-20886-1" This is a multi-part message in MIME format... ------------=_1478169002-20886-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #24833: Hydra ignores MIPS-specific patch for Mesa on core-updates which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 24833@debbugs.gnu.org. --=20 24833: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D24833 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1478169002-20886-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 24833-done) by debbugs.gnu.org; 3 Nov 2016 10:29:47 +0000 Received: from localhost ([127.0.0.1]:41148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2FHH-0005QD-6J for submit@debbugs.gnu.org; Thu, 03 Nov 2016 06:29:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2FHF-0005Q1-OB for 24833-done@debbugs.gnu.org; Thu, 03 Nov 2016 06:29:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2FH5-0007CY-SO for 24833-done@debbugs.gnu.org; Thu, 03 Nov 2016 06:29:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2FH5-0007CU-Oo; Thu, 03 Nov 2016 06:29:35 -0400 Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:58296 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1c2FH5-0005RT-6F; Thu, 03 Nov 2016 06:29:35 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mark H Weaver Subject: Re: bug#24833: Hydra ignores MIPS-specific patch for Mesa on core-updates References: <87ins5le6d.fsf@gnu.org> <87shrdca9s.fsf@netris.org> <87eg2ttis5.fsf@netris.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Brumaire an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 03 Nov 2016 11:29:33 +0100 In-Reply-To: <87eg2ttis5.fsf@netris.org> (Mark H. Weaver's message of "Wed, 02 Nov 2016 22:10:50 -0400") Message-ID: <87zilgx3ea.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: 24833-done Cc: 24833-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.7 (-------) Mark H Weaver skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) >> Mark H Weaver skribis: >> >>> Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 on core-updates added a >>> patch to Mesa on MIPS only, in order to prevent unnecessary rebuilds on >>> other systems. 'guix' running on a MIPS system generates a derivation >>> that applies the patch, but the derivation generated for MIPS on Hydra >>> omits the patch. >> >> Did it turn out to be the same issue as , or >> is it something entirely different? > > Bug 24833 is this bug, so yes, by reflexivity it's the same issue, but I > suspect that's not what you meant to ask :) Arf, sorry, I meant to ask if this is related to . Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 doesn=E2=80=99t have the de= sired effect: the =E2=80=98patches=E2=80=99 field is voluntarily unthunked, so it= gets to see the =E2=80=98%current-system=E2=80=99 value that it gets when gl.scm is loa= ded, hence the problem we=E2=80=99re experiencing. This is fixed in 4c93fe83e89473b2d16b93900c87e0da0ceecd6e by making the patch an input depending on =E2=80=98%current-system=E2=80=99, within an = =E2=80=98inputs=E2=80=99 field. Thanks! Ludo=E2=80=99. ------------=_1478169002-20886-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Oct 2016 06:19:15 +0000 Received: from localhost ([127.0.0.1]:37587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c15wB-0001Ub-Au for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c15wA-0001UM-AH for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c15w4-00067N-8Z for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43786) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c15w4-00067J-5Q for submit@debbugs.gnu.org; Mon, 31 Oct 2016 02:19:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c15w2-0005Jo-Vh for bug-guix@gnu.org; Mon, 31 Oct 2016 02:19:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c15vy-00063r-6e for bug-guix@gnu.org; Mon, 31 Oct 2016 02:19:06 -0400 Received: from world.peace.net ([50.252.239.5]:42678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c15vy-00063i-2o for bug-guix@gnu.org; Mon, 31 Oct 2016 02:19:02 -0400 Received: from [10.1.10.31] (helo=yeeloong) by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c15vw-0002yl-TA; Mon, 31 Oct 2016 02:19:00 -0400 From: Mark H Weaver To: bug-guix@gnu.org Subject: Hydra ignores MIPS-specific patch for Mesa on core-updates Date: Mon, 31 Oct 2016 02:17:35 -0400 Message-ID: <87shrdca9s.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Commit f1267c872fcaed6c53d43b3ff51abb726f7418d6 on core-updates added a patch to Mesa on MIPS only, in order to prevent unnecessary rebuilds on other systems. 'guix' running on a MIPS system generates a derivation that applies the patch, but the derivation generated for MIPS on Hydra omits the patch. The corresponding build page on Hydra is: https://hydra.gnu.org/build/1569732 The derivation for that build is: /gnu/store/vyqmm1zdhbzxjnaq0h6k312mm7ywi1bq-mesa-12.0.1.drv which uses a source derivation: /gnu/store/368ns1adxyv5zhnsn5rx40k6ghd9sr39-mesa-12.0.1.tar.xz.drv and this derivation simply downloads the source tarball. In contrast, corresponding derivations generated by 'guix' on a mips64el-linux machine are: /gnu/store/1r8m67dn07q2k75gl7rnw09i2kp4a0rd-mesa-12.0.1.drv /gnu/store/imyjp7sx1rzwpc9agvcnjvk28i4qcgis-mesa-12.0.1.tar.xz.drv and the latter derivation is a 'patch-and-repack' derivation that applies 'mesa-wayland-egl-symbols-check-mips.patch', as expected. Mark ------------=_1478169002-20886-1--