GNU bug report logs - #24829
24.5; `easy-mmode-define-navigation': rename `define-...', per convention

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sun, 30 Oct 2016 22:51:01 UTC

Severity: wishlist

Found in version 24.5

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: 24829 <at> debbugs.gnu.org
Subject: bug#24829: 24.5; `easy-mmode-define-navigation': rename `define-...', per convention
Date: Sun, 30 Oct 2016 15:50:43 -0700 (PDT)

Macro `easy-mmode-define-navigation' apparently defines Emacs commands
(functions).  Per the Emacs Lisp coding conventions, its seems that the
macro should be renamed.

From (elisp `Coding Conventions':

  Constructs that define a function or variable should be macros, not
  functions, and their names should start with `define-'.  The macro
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  should receive the name to be defined as the first argument.  That
  will help various tools find the definition automatically.  Avoid
  constructing the names in the macro itself, since that would
  confuse these tools.


In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32'
This bug report was last modified 4 years and 287 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.